From patchwork Wed Mar 1 03:32:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neal Liu X-Patchwork-Id: 62746 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp3410853wrd; Tue, 28 Feb 2023 19:47:12 -0800 (PST) X-Google-Smtp-Source: AK7set/91mfdO+5M3vW3jrV5eKJzP9zILLl83uAEgRveuJldEzDO+M+MhTQu/FBy0xGc+nBP6yTS X-Received: by 2002:a17:90b:224a:b0:237:24a8:c5e2 with SMTP id hk10-20020a17090b224a00b0023724a8c5e2mr5686129pjb.40.1677642432369; Tue, 28 Feb 2023 19:47:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677642432; cv=none; d=google.com; s=arc-20160816; b=y0Lf0JHU4Kumcwh5Hcd62rJYUUxkJln1oxsX+IcE3gsJ15qj7vp0M+iOdH0PQJwiK5 8xutrH4dM4aVO/Xuogf9tveQKaHpyHR1gfFeXNAUgmWq3rcTtI/Mpdt1hk+3q25Ey/0I +S9w9lPVZ36jEQwZstLIQeGLz3edo7G5G9PBaLkdBOwX89Qpx+aEyCnb3PMOB4xfYjAe FjiD+n2GS8DB6uRxczxxlwdvu8x2+tPOJCy+zVNo1ohjY0mc3FBunV/GjR4WxezFlgdR 6FdpbGLiYnV1EvH41cGh5ic6t8swC1K6TMTC9Cl8vE0vsxnRW1I4t2NjppcojdmQ7ZeZ /1Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=veAsQrTdgSKEL0csbCH+yCxAWbwd0z9n2JfuQWVXE+M=; b=SrNyFMRreX/ZRb69PPTXluQ9jfYoO5pj7VhDDmlbEvbYInEk8VLkxPXNiGUuWgjU6I ZkuC6Af74hNG5hkD/zRpWSilaHV2sbHxh78h0iRHmLHxeEY7iFHEyMSFDivnkzikgCss zyLyZp6oPdK/rtzrA1G7f8QJu+IAq23yHIWcb8cnVHu0quG5Ss53ZTXhV+PCsGoSxSgZ PUY37XwBTIFhIYkRYty5yxjJm0aSeZL8kDEhhe7+gWYAplMoYfTvFaVmUQfAGvSQ60R1 RGPiiXWu8+cRWx0fiOlCo9Zwc5+P6OjAXYGkQW04i7OSbnf0Ii5VNuM3Hmh8YK6k8T3T SecQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fz1-20020a17090b024100b00233ac86782bsi11034302pjb.12.2023.02.28.19.46.59; Tue, 28 Feb 2023 19:47:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229908AbjCADei (ORCPT + 99 others); Tue, 28 Feb 2023 22:34:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjCADeh (ORCPT ); Tue, 28 Feb 2023 22:34:37 -0500 Received: from twspam01.aspeedtech.com (twspam01.aspeedtech.com [211.20.114.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A9A23C2F for ; Tue, 28 Feb 2023 19:34:32 -0800 (PST) Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 3213IphW072955; Wed, 1 Mar 2023 11:18:51 +0800 (GMT-8) (envelope-from neal_liu@aspeedtech.com) Received: from localhost.localdomain (192.168.10.10) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 1 Mar 2023 11:32:15 +0800 From: Neal Liu To: Joel Stanley , Andrew Jeffery , Neal Liu , Herbert Xu , "David S . Miller" CC: , , , , "kernel test robot" , Dan Carpenter Subject: [PATCH] crypto: aspeed: fix uninitialized symbol 'idx' warning Date: Wed, 1 Mar 2023 11:32:05 +0800 Message-ID: <20230301033205.2137450-1-neal_liu@aspeedtech.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [192.168.10.10] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 3213IphW072955 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS, T_SPF_HELO_TEMPERROR autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759135590837556881?= X-GMAIL-MSGID: =?utf-8?q?1759135590837556881?= 'idx' is not initialized if it's not EXP_MODE nor MOD_MODE. Use "else" instead to fix it. Signed-off-by: Neal Liu Reported-by: kernel test robot Reported-by: Dan Carpenter Link: https://lore.kernel.org/r/202302261052.CVFRyq6F-lkp@intel.com/ --- drivers/crypto/aspeed/aspeed-acry.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/aspeed/aspeed-acry.c b/drivers/crypto/aspeed/aspeed-acry.c index 1f77ebd73489..828dc3ae1b5f 100644 --- a/drivers/crypto/aspeed/aspeed-acry.c +++ b/drivers/crypto/aspeed/aspeed-acry.c @@ -289,7 +289,7 @@ static int aspeed_acry_rsa_ctx_copy(struct aspeed_acry_dev *acry_dev, void *buf, if (mode == ASPEED_RSA_EXP_MODE) idx = acry_dev->exp_dw_mapping[j - 1]; - else if (mode == ASPEED_RSA_MOD_MODE) + else /* mode == ASPEED_RSA_MOD_MODE */ idx = acry_dev->mod_dw_mapping[j - 1]; dw_buf[idx] = cpu_to_le32(data);