From patchwork Wed Mar 1 02:27:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 62724 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp3385137wrd; Tue, 28 Feb 2023 18:36:17 -0800 (PST) X-Google-Smtp-Source: AK7set+FIxicNjFFhWZlwNRyHGRFKa0QBBKolPsZS+0YTOOebHqrEAFYwORkbAEuvhLyrdIMxjyp X-Received: by 2002:a17:906:2348:b0:8e5:c06b:90e9 with SMTP id m8-20020a170906234800b008e5c06b90e9mr4721049eja.50.1677638176957; Tue, 28 Feb 2023 18:36:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677638176; cv=none; d=google.com; s=arc-20160816; b=KTt3w487s6ETVB3jES5Cf2bGgqWSBVh2PUERNWlzFNavcmDZOq0dsaKVU2Fc05ymmV u6CLX5uGZ5tqOIRuegoDqDFkix/GFBQgxeroQ2Q+aKoP7UpsNJlsboapEvMREs2ENqnA tfoQcsI42xx69suS50yUvN6ycPZII5k2+P9En5WP4HCav3G0FlKxuPhxsYEX4VOHCBBx oVClua+lQ6TDQ8aZphCpM1Azt1rhMKToNAHOZr/NNhN7BMLSL1On/7gq1/RgzrpDRMPk YMuk6RPRaGblx6qSSwDAI3fmta1JpgBu1+/Q3Ve1q/z1ZXYi3trgyYjw8uknez2pITut e34Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:mime-version:date :dkim-signature; bh=d/02ba9pKPs+xaeDNoqwdk3OeXtfhs3eb+vbTt5q+ds=; b=UbW9AcWuBmSrym78cQKwY/GMhzLhsG4ggZAWcOc51G70xAqmRij5OcYYBoLG45isqK CZCqFcDQYaZ+fIiVN/fKql5ENRhqhMkPIKaHnud07bs0zvXLfriQ9n6UVemovZd3MNj8 y3IuooOgvf2ArioSNuvuQ8MCmCYRJsdWhD9MznmFrAvRJKSwQsivQKLNV20HJZT4k1W7 3pR6LfnMFeIfXnU5gdNa2xULqSRy3eN9mBDZUPAo68rMiOerv/vSrZOhikgDJ6bBFXkj gkhh9v/kbRLgt8wydo9toYAQDyZfoHnbF5Vya0lTsKZYKr98fOl8v+Q6Nls4IGbZkPvP Kk7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=jwkVCM8M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m8-20020a1709060d8800b008b19eb2bcc8si15260788eji.600.2023.02.28.18.35.54; Tue, 28 Feb 2023 18:36:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=jwkVCM8M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229735AbjCAC11 (ORCPT + 99 others); Tue, 28 Feb 2023 21:27:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229617AbjCAC1Z (ORCPT ); Tue, 28 Feb 2023 21:27:25 -0500 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 026A5136DE for ; Tue, 28 Feb 2023 18:27:25 -0800 (PST) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-536bbaeceeaso251642447b3.11 for ; Tue, 28 Feb 2023 18:27:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1677637644; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=d/02ba9pKPs+xaeDNoqwdk3OeXtfhs3eb+vbTt5q+ds=; b=jwkVCM8M/VdQLhfCkuQxzR9SFY68aOcPkmEc06SJ6jbXq0SL8vhpoeNFFcc2FIMX4Z qOAOI7yp7551oLwvyh9mgMAkw383CXCX5b/h08MQxyDTWLFQM302VK4PCxZW4njJU5wA w8EcBp5F7o/S81X59PWPM2wdZuE0ddMRfvLTZfdeoGxlABs9nXf5/tfjdeYbhTyrLwWT e+FKJlhxrRgP+4+FF7t+gW+oCtxdSoeGJUiUlZqGApiO7FNDs2PJNRAhZDwX5gfdv5E5 1eq6ilJ6KGu4P83kvjayRhSH9oLzyJQNHlvbOeaMFbtv/Mp7aqikHM/ZQ07xCIiTbr5t l13g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677637644; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=d/02ba9pKPs+xaeDNoqwdk3OeXtfhs3eb+vbTt5q+ds=; b=mgDo75/zF6I62CW6ecIa9lGI1UZ45ifgAPCcBYYTBnB/efq0h1Qc8XVxVprFgnmqTO yVRmhTNqmknne7yRSWvi+pWb/gd8Jdy/mFLIS7YYgUjI3BQ69eex0wk8FnAJXciTwwg1 ShEz7EOhokRBDkErCmjh8LBqRne/SiznvYirBZ5XCQiTYFmg8Z/hkzystZP0z1Sbh6I1 2/d8kNQX/RtJmhJm6pXIl9jGWD8aAB8Y2hGHplHPNgyUrFxARgDnIdiUaCbPC7jTWfCA E9wcPmDXrn73c2JirAYwulkG8a9IuUNNNdR1a7HnU+Z+alAzOFEcYvW5qkxnLrZIdNUj xx7Q== X-Gm-Message-State: AO0yUKUH7SkxdD6hwUpU4dJy5DUsSP0laHZPJs4ODd78xXS4an5Wwlvx 2tCM4Ffws8MV9bj6pVO0qisu/OMfbCA= X-Received: from surenb-desktop.mtv.corp.google.com ([2620:15c:211:200:612b:820a:2225:ad82]) (user=surenb job=sendgmr) by 2002:a05:6902:50e:b0:967:f8b2:7a42 with SMTP id x14-20020a056902050e00b00967f8b27a42mr2156872ybs.7.1677637644274; Tue, 28 Feb 2023 18:27:24 -0800 (PST) Date: Tue, 28 Feb 2023 18:27:19 -0800 Mime-Version: 1.0 X-Mailer: git-send-email 2.39.2.722.g9855ee24e9-goog Message-ID: <20230301022720.1380780-1-surenb@google.com> Subject: [PATCH 1/2] mm/mmap: remove unnecessary vp->vma check in vma_prepare From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: sfr@canb.auug.org.au, error27@gmail.com, willy@infradead.org, david@redhat.com, Liam.Howlett@oracle.com, jgg@ziepe.ca, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, mathieu.desnoyers@efficios.com, pasha.tatashin@soleen.com, laurent.dufour@fr.ibm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, surenb@google.com, kernel test robot X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759131128978866291?= X-GMAIL-MSGID: =?utf-8?q?1759131128978866291?= vp->vma in vma_prepare() is always non-NULL, therefore checking it is not necessary. Remove the extra check. Fixes: e8f071350ea5 ("mm/mmap: write-lock VMAs in vma_prepare before modifying them") Reported-by: kernel test robot Reported-by: Dan Carpenter Link: https://lore.kernel.org/r/202302281802.J93Nma7q-lkp@intel.com/ Signed-off-by: Suren Baghdasaryan Reviewed-by: David Hildenbrand Reviewed-by: Liam R. Howlett --- Fix cleanly apply over mm-unstable, SHA in "Fixes" is from that tree. mm/mmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c index 0cd3714c2182..0759d53b470c 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -505,8 +505,7 @@ static inline void init_vma_prep(struct vma_prepare *vp, */ static inline void vma_prepare(struct vma_prepare *vp) { - if (vp->vma) - vma_start_write(vp->vma); + vma_start_write(vp->vma); if (vp->adj_next) vma_start_write(vp->adj_next); /* vp->insert is always a newly created VMA, no need for locking */ From patchwork Wed Mar 1 02:27:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 62723 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp3384769wrd; Tue, 28 Feb 2023 18:35:07 -0800 (PST) X-Google-Smtp-Source: AK7set/a43NvbC0ACweUrbwdCrh6z2crpYSEeF6cHy/xxqOg9s2TIsKuzDnxIEpAWNVSDWiHXukG X-Received: by 2002:aa7:dc0d:0:b0:4af:6a7e:9218 with SMTP id b13-20020aa7dc0d000000b004af6a7e9218mr5760940edu.42.1677638107297; Tue, 28 Feb 2023 18:35:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677638107; cv=none; d=google.com; s=arc-20160816; b=fTb9QPf3hk88NIrDSzGoHW4qysGO9MaZI0ed/IApRRGIJhrGv7ad63ikIea70GGLOC K4t9fl2ba+JeWMPfL1yIaH8k9NkBwZbw9hCyg4b1lAwHIq6pwntk89pbdh3w/3Ur2Hh8 L55D/GeKdSduNcTC7RDlwo23064ZWNl6NqtD1FP7Q7uibRr46Vu8vLZT5c4HwmwJwBcD mYu2issPvctXOEwC5TsUfKoZu+3HbRLbTN2761PA2ajA7SoO/p0TvxWfQTVEgLMsJrNR +FSiY2jsR4ybWM9v84yxUWvP757X4gL/7v6HpUcTPSOH3Zi3rGVnZ96BGOWPQKTuD+M/ Yh1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=7cn5FYVeC2KQFYRWBJMiQUgkU1g+DHIoWLNV16kMAX8=; b=Ot6ZxK80/FLnDSnSzP7Cls6BhajFdgAPHlRB6Lrm0DsAJCiocBMNWjjJVNJ9GLPNB8 g616aoxm8PRLHOvNnSuL4K4+29pviI6jqmhe/oNYKNCk0elA41RXwrywXlPapLwdzSbb G70QTfc/lTyxTP89mykFGAggTFzQdm10kYewCOoDZZ/fBBwI16Fp21KQ+gMjMm59gspm FQGNI8ER4lRVh5XeKYsPuN+zRMJbg+TsADbIGt3x6RH3IOmyNusiYqFfZ8ZMLCt19A3X UsTH7czzo/EDg2clsQcdpM6v5HeQQGmb9JWNwTt8uT2B++XUeY5wlFohVH7PbAUl+K1F PilQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=nEKJGBxV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y4-20020a056402134400b004ad7c4bc8b5si11647002edw.261.2023.02.28.18.34.44; Tue, 28 Feb 2023 18:35:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=nEKJGBxV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229763AbjCAC1a (ORCPT + 99 others); Tue, 28 Feb 2023 21:27:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229745AbjCAC11 (ORCPT ); Tue, 28 Feb 2023 21:27:27 -0500 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14407136DE for ; Tue, 28 Feb 2023 18:27:27 -0800 (PST) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-536a5a0b6e3so256328677b3.10 for ; Tue, 28 Feb 2023 18:27:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1677637646; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=7cn5FYVeC2KQFYRWBJMiQUgkU1g+DHIoWLNV16kMAX8=; b=nEKJGBxVMi4BEnUPRf0A+X+O4cmdoIfmLz4mW0W7FAAdyzE+55RofUSqDm1Oc8j5HW s1kTQu8Va0CaEqyTIW/ytdCVmiVSAcL55TeGUQBZ59DCB+JKZYO06jESJpBOq9zHC2Ve BFLqAqFjGXGEaw6a2XEiZp/v9rL6janNV4eXvoeLzGpw+GAUNeE9/AYpJAhViMLNUcMj M9FU382AfH+XW6iH4w1WuYFyzsFbmH3+tD0ZrvREQ3+QePPpECTKuQVBwosyAERKmI53 sgKsNHDtefpjWD8aYJb4eUnl3c/A4mbpNnImsVMVoqxw1yHBqUVX7C2Lb9lK+/YiXOny bAhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677637646; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7cn5FYVeC2KQFYRWBJMiQUgkU1g+DHIoWLNV16kMAX8=; b=t41RrGRcmA6e72HQjE/jNRBVfZF1DTNFELVJvYpfyPDJvTrycaSytinnCIfFF7TNoi dwiPlGe5ogSG4W/rLsKW1jpMN+6Lu3zGlKN1tq+rDI8TkmZYnOzy+Bo/NDmCUKnvSEpB 0d770JDvhTX/U1osjEiY+73Pk7vPG5YwmUpPYAYji/6evIFOIy6h54uhH8+NYH6FR+5P BJ8TrCjEPODDn6pfn9U02V+0vumOCsEZETYMjBBC11oZvD9xL4gsuzhDI6TR+jaby3i7 rCJwUJjaNR+l8mFkJWaQr1I3tqYnX7KOTzx+7bXw4Tv9ehyAnwpNCKF5lwqnz7MDIurl KeIw== X-Gm-Message-State: AO0yUKWPWgfSv6qwZEQpnQrx/TunjZoHdIUV26JcjRef/GD+XLTCiPPk XB7xaA/252AyLL6BHYKWiu2CxVNSZBg= X-Received: from surenb-desktop.mtv.corp.google.com ([2620:15c:211:200:612b:820a:2225:ad82]) (user=surenb job=sendgmr) by 2002:a05:6902:10d:b0:a4b:a813:46de with SMTP id o13-20020a056902010d00b00a4ba81346demr2167842ybh.4.1677637646292; Tue, 28 Feb 2023 18:27:26 -0800 (PST) Date: Tue, 28 Feb 2023 18:27:20 -0800 In-Reply-To: <20230301022720.1380780-1-surenb@google.com> Mime-Version: 1.0 References: <20230301022720.1380780-1-surenb@google.com> X-Mailer: git-send-email 2.39.2.722.g9855ee24e9-goog Message-ID: <20230301022720.1380780-2-surenb@google.com> Subject: [PATCH 2/2] mm: document FAULT_FLAG_VMA_LOCK flag From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: sfr@canb.auug.org.au, error27@gmail.com, willy@infradead.org, david@redhat.com, Liam.Howlett@oracle.com, jgg@ziepe.ca, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, mathieu.desnoyers@efficios.com, pasha.tatashin@soleen.com, laurent.dufour@fr.ibm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, surenb@google.com X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759131055918118728?= X-GMAIL-MSGID: =?utf-8?q?1759131055918118728?= FAULT_FLAG_VMA_LOCK flag was introduced without proper description. Fix this by documenting it. Fixes: 863be34fc093 ("mm: add FAULT_FLAG_VMA_LOCK flag") Reported-by: Stephen Rothwell Link: https://lore.kernel.org/all/20230301113648.7c279865@canb.auug.org.au/ Signed-off-by: Suren Baghdasaryan --- Fix cleanly apply over mm-unstable, SHA in "Fixes" is from that tree. include/linux/mm_types.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index 89bbf7d8a312..ef74ea892c5b 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -1064,6 +1064,7 @@ typedef struct { * mapped after the fault. * @FAULT_FLAG_ORIG_PTE_VALID: whether the fault has vmf->orig_pte cached. * We should only access orig_pte if this flag set. + * @FAULT_FLAG_VMA_LOCK: The fault is handled under VMA lock. * * About @FAULT_FLAG_ALLOW_RETRY and @FAULT_FLAG_TRIED: we can specify * whether we would allow page faults to retry by specifying these two