From patchwork Tue Feb 28 15:51:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 62542 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp3094881wrd; Tue, 28 Feb 2023 07:55:06 -0800 (PST) X-Google-Smtp-Source: AK7set8eJUP8TO+l4/Bq114zXJcCofOaAHzIv13TwjcBjAL8H2MgzY2SxUyvH/SpEfWd/UuC1gyu X-Received: by 2002:a50:ee81:0:b0:4aa:aaf6:e6be with SMTP id f1-20020a50ee81000000b004aaaaf6e6bemr3593283edr.7.1677599705767; Tue, 28 Feb 2023 07:55:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677599705; cv=none; d=google.com; s=arc-20160816; b=wY5c9ZldS1lOsRW8n70Q2k1K5dSPGvXHCqplK7IkH0AFRg9NzjnIh1nF/LMcDFhj5g ZnXCPVUPGfW22fguBZQYm6X/mrU3vUWY3Fo1MVB+qo9xakrBPLxIjQqfYv6UePTscac1 6FdhxdtnR9X9vMR84LsgHl7O+TVolHPLO/Vl8Ayz0FK1y1fNkrZ3WTKp6PIxYeP0pplz 10IIFd2o4XuS2Iayo+cRQh1oqzLP4VdGVAP3voDdZgprZFAvhT1l1X7OU+KTLTLs5em2 Y18s41s62Up+3qWZXcUmNGYZWrc282Vt+vItURwypIJMAKb+nlj2hRxGV+7tuoQiqHDc n1Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=wUCY23lI6ZJvR/D1w3pZEq+r1szcr1TztpwRWIRWSoQ=; b=Z6VT4plSNhzV/2/VibuVoCFp8HP9dKJ55pWFKzsWUhbqR2ezK/cybRoo/CClc7adpK qVtR90QFZaRWVOgM1yS/iQWUpjK6erP0/WNXBKtNX9UEOsDlLrF0BKQ/TTx3OqJFgL+S broccjpy/qM3yrbyqmR4OAgg899bE6VaYTyK4WOAh1wuxxAJkIESm6IYIlh1xLb0Lo15 cgILHLX2ScvFA98uo6ULqsQmncgqRSTJXcOUVnd406YYcdDOJfHomVKfCFllx6DCGMqL W2qgIxI365LKJ5C5QRqxdUyBOlmF9yhbr0eaPfrx0gBgDRt41kCTJb2dOoWXkYg9ADGj jp9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Z6mCyrlr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w10-20020a50fa8a000000b004ad155fcafbsi3261670edr.607.2023.02.28.07.54.43; Tue, 28 Feb 2023 07:55:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Z6mCyrlr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230178AbjB1Pvf (ORCPT + 99 others); Tue, 28 Feb 2023 10:51:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229881AbjB1Pvd (ORCPT ); Tue, 28 Feb 2023 10:51:33 -0500 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88D4231E35; Tue, 28 Feb 2023 07:51:32 -0800 (PST) Received: by mail-ed1-x535.google.com with SMTP id i34so41882549eda.7; Tue, 28 Feb 2023 07:51:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wUCY23lI6ZJvR/D1w3pZEq+r1szcr1TztpwRWIRWSoQ=; b=Z6mCyrlrP7F8GnsWHKAzm2VDvru9DuR70y50S672b+2tf42utVlWYAMTcdZLt9WXud /375YOW3sy1WhIXDwbFu/oamI5ub0Gwxn0RPFig7qzRm+eu5gFAqInUCc+ZqmxqBS2Dy IBZNVoeXtoZpqSlPuyEYGgx5O9RfwpCFyxMpmx4pYho6KGj9Y4CROqCaYkQKDXfJENq1 XeCD+kXP/3izj9acGl61Kai8elcAPWB49yjAVn6D6pPPKYoUAIbEAdXytWOdND4loVdR zpzHQsNgeVWYpXmLloU8xk4laIlZBO/2KpYPBek9axg7BozJVOgTu/FSFu1IjQPhTOl4 jDSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wUCY23lI6ZJvR/D1w3pZEq+r1szcr1TztpwRWIRWSoQ=; b=rhgmY6yPB3/DqSE+x6Oxi9QllaNwVCthz7iJj57bZiT1er54RWQA3s3zWyirfVJBm4 jaecL41r8cRyO6ymayF69B4bnbL9B7R7hE220HD8erV2lXTTA/BwztjzJBiXGdwpCXrK FlSOOJbX6kTay0qCEpvWZm7pa1Ti6vOUSUQH6huuTX8iGpGPgVWLkM3tMRt0OJrLggNI Gtm5/HAe6tXwMKZRmNPMYePdultbQQr+vv4JFc5Az0Sf8pammU1l2czsL5NMDitZxqzO rOjQhq5SNVScDFIQvX8dchIFYJAkGdwdR3mRKpB5jPaTcjU/PTbTN6FIBShdc41rAIIg 1doQ== X-Gm-Message-State: AO0yUKXwn8UlHdZNTOqfZvKUA4CubwjuY/7fmwk6jSauKqBOEy6ozSwX x5fSMe8mKPtnttVl4YejtoyDLsJ/BhU1PCYQ X-Received: by 2002:a05:6402:1a39:b0:4aa:b310:b695 with SMTP id be25-20020a0564021a3900b004aab310b695mr3573472edb.35.1677599490660; Tue, 28 Feb 2023 07:51:30 -0800 (PST) Received: from localhost.localdomain ([46.248.82.114]) by smtp.gmail.com with ESMTPSA id x16-20020a170906441000b008d09b900614sm4577153ejo.80.2023.02.28.07.51.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 07:51:30 -0800 (PST) From: Uros Bizjak To: rcu@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Uros Bizjak , "Paul E. McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes Subject: [PATCH] rcu: use try_cmpxchg in check_cpu_stall Date: Tue, 28 Feb 2023 16:51:21 +0100 Message-Id: <20230228155121.3416-1-ubizjak@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759090789039595586?= X-GMAIL-MSGID: =?utf-8?q?1759090789039595586?= Use try_cmpxchg instead of cmpxchg (*ptr, old, new) == old in check_cpu_stall. x86 CMPXCHG instruction returns success in ZF flag, so this change saves a compare after cmpxchg (and related move instruction in front of cmpxchg). No functional change intended. Cc: "Paul E. McKenney" Cc: Frederic Weisbecker Cc: Neeraj Upadhyay Cc: Josh Triplett Cc: Steven Rostedt Cc: Mathieu Desnoyers Cc: Lai Jiangshan Cc: Joel Fernandes Signed-off-by: Uros Bizjak Acked-by: Joel Fernandes (Google) --- kernel/rcu/tree_stall.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/rcu/tree_stall.h b/kernel/rcu/tree_stall.h index b10b8349bb2a..d81c88e66b42 100644 --- a/kernel/rcu/tree_stall.h +++ b/kernel/rcu/tree_stall.h @@ -760,7 +760,7 @@ static void check_cpu_stall(struct rcu_data *rdp) jn = jiffies + ULONG_MAX / 2; if (rcu_gp_in_progress() && (READ_ONCE(rnp->qsmask) & rdp->grpmask) && - cmpxchg(&rcu_state.jiffies_stall, js, jn) == js) { + try_cmpxchg(&rcu_state.jiffies_stall, &js, jn)) { /* * If a virtual machine is stopped by the host it can look to @@ -778,7 +778,7 @@ static void check_cpu_stall(struct rcu_data *rdp) } else if (rcu_gp_in_progress() && ULONG_CMP_GE(j, js + RCU_STALL_RAT_DELAY) && - cmpxchg(&rcu_state.jiffies_stall, js, jn) == js) { + try_cmpxchg(&rcu_state.jiffies_stall, &js, jn)) { /* * If a virtual machine is stopped by the host it can look to