From patchwork Tue Feb 28 13:55:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 62506 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp3031121wrd; Tue, 28 Feb 2023 06:04:35 -0800 (PST) X-Google-Smtp-Source: AK7set9ERyzsgLgBLgGAdKiE3mCeD9402bOrYnfWeGCujdIG20vcNfyWUnF5FOT01sDZHS4T2Ze2 X-Received: by 2002:a17:907:6e14:b0:8ea:5f7d:8fec with SMTP id sd20-20020a1709076e1400b008ea5f7d8fecmr3583365ejc.36.1677593075026; Tue, 28 Feb 2023 06:04:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677593075; cv=none; d=google.com; s=arc-20160816; b=NoumYmrlFUD2txTaWlN4U/hlhov5QF6eb/TWsQk45/6X1i50b+9RLRtwcn6w09qRIl r3/BWo8NR2PDJLRWR2A11ta8yn87CFe8kUxqT+vl0ZvDL9efiWJax+klc6zDn4DB/g2E RixIgZYEhtwCVLW4WcgmcK4uZ39Qjsa/BN6z8L774S71OdS0KYKNpKgIaVV+yzOV1Htv 992bYXdxW7QsWBzXdaTVEISxZGSitaYUAD8E7Je7yE2TF7O5viuGiy4A/PenL3TRWXkY b4L17Rv4m4EV9rh7Dq44vUSvfjmdsvDA2y+MleDaTWJJ0W9BaKfnz185ZgalMm+hhLu3 b4Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=O7+O1kKSy+uWznDTb7JHVKvwAgPzJFp/5DKHS/EQre4=; b=kik3+Ep+qbTyWCYNc3RkX5NKeTkt9o3N2o8tWJWvPa4qjK59w8SEz8p/zaE4rHMjOA subYJ0YEr3pJXXeX+0ooOJl7aCAssfT6l/6nFfY81AEqYUdu3AxNM68O1wSMSMtrtyOp jMYxeUhfTSxNRi8isU/UfDl65qespOGNfJ3V4ivZ4apWS/vIvWrgyLJnTGMp5SsWWzQT CEQmTR9gg9+YWVhhNkouJPjYVwmS2EByVP8lITYhH/HiK0E50IUqIo3BgCGxjHbhFq2U CD3X7R86xkNSQB1NnRDkAYbg1kzchx4WOOZRZXt4X7T2mwgl83Ju7N+lW7osULiaOtuu tgDw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e17-20020a170906045100b008b79a5e743esi11304534eja.253.2023.02.28.06.04.11; Tue, 28 Feb 2023 06:04:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229524AbjB1N4N (ORCPT + 99 others); Tue, 28 Feb 2023 08:56:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229730AbjB1N4M (ORCPT ); Tue, 28 Feb 2023 08:56:12 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 782CF303E0 for ; Tue, 28 Feb 2023 05:55:51 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pX0Ru-0007wr-FS; Tue, 28 Feb 2023 14:55:22 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pX0Rr-000sd5-Fv; Tue, 28 Feb 2023 14:55:19 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pX0Rq-0011dd-QM; Tue, 28 Feb 2023 14:55:18 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding , Munehisa Kamata , Jiancheng Xue , yuanjian , Rob Herring Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 1/4] pwm: hibvt: Explicitly set .polarity in .get_state() Date: Tue, 28 Feb 2023 14:55:05 +0100 Message-Id: <20230228135508.1798428-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230228135508.1798428-1-u.kleine-koenig@pengutronix.de> References: <20230228135508.1798428-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=851; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=wc4XckGFK16wdwJ/Xdl4epfiuvV/IHKkEC7JDlgUzKg=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBj/ges5DcD7InG+a9Dcii0vkRG0Z2rq8uudNNyL 1Dofr+8NjmJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCY/4HrAAKCRDB/BR4rcrs CTpaB/9LfzC8uQW9dLE0QEXLyQCUYsDAve9IntGqd6uLK6z8NZWmNYwkIkLnjwGQwqfIhpFtqp6 Xnc1NpZ0eQ5nAt2aPVu1lQRlXyI68NBtxE/xNf3sOpgrXpEU8CrGcSZ6BIiQ15g89hDuJAE/Bo1 vv76KL8LkxsVwcKgkTmBsKvhtNTZt+z0mC+6qCy+H9IIZZNfI0exVgaqF6OdjkEnJxz37AihCQf BJCrCJpn/98xLdjb08QXoRntq11gc4c7LU13hCJTPuQpkvQPqmqgS7FRLjjPp856CDHszepDKBp 7u17LXuJL6J6y2+sXxOnD3qxOrzjdnsblZ9FVgRlbt/iD0AQ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759083836220713336?= X-GMAIL-MSGID: =?utf-8?q?1759083836220713336?= The driver only both polarities. Complete the implementation of .get_state() by setting .polarity according to the configured hardware state. Fixes: d09f00810850 ("pwm: Add PWM driver for HiSilicon BVT SOCs") Signed-off-by: Uwe Kleine-König --- drivers/pwm/pwm-hibvt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pwm/pwm-hibvt.c b/drivers/pwm/pwm-hibvt.c index 12c05c155cab..1b9274c5ad87 100644 --- a/drivers/pwm/pwm-hibvt.c +++ b/drivers/pwm/pwm-hibvt.c @@ -146,6 +146,7 @@ static int hibvt_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, value = readl(base + PWM_CTRL_ADDR(pwm->hwpwm)); state->enabled = (PWM_ENABLE_MASK & value); + state->polarity = (PWM_POLARITY_MASK & value) ? PWM_POLARITY_INVERSED : PWM_POLARITY_NORMAL; return 0; } From patchwork Tue Feb 28 13:55:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 62504 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp3031028wrd; Tue, 28 Feb 2023 06:04:27 -0800 (PST) X-Google-Smtp-Source: AK7set9gXJ/WjulLF1mzwYHbo8ks1JxLVtCTLW1EIUns6JjKsVpXkFr9tDr/od1rH0Z8REKM+wYO X-Received: by 2002:a17:906:aac4:b0:8b2:d30:e721 with SMTP id kt4-20020a170906aac400b008b20d30e721mr2440729ejb.71.1677593067097; Tue, 28 Feb 2023 06:04:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677593067; cv=none; d=google.com; s=arc-20160816; b=f+Aw8/8HmXqbdGg74HghCQxkWCKnErI42HFQL/XjfnQamfV6IunBZ5F7j3/4O+ZFl0 j50KhMYwK/NM5l/83B6X/fAZ0POK9JxafFpM+loFu2O5HkQzqHKfXMoCUFyysPB6OtT2 pfnuDlnZieBYbJKz97qGx03H9X+wTsfMbBiPfDFfzPZDi+gqfigDNyKDaFrETIVXX9AB vcpHliDGgyP4loYLnVfAOcArxuYqwOOmxYNCa68Sja3zc0ptnJ+Os0hTnGFmuJ3xO/KO 45PHOdwJ0H3lb1zJaSN6aS/iDWz/T5YqnwWh0Mh2sSgKKglEjcehRHX3xzOrz0gHAPpP msng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Ufjb0v4UnoxULOv2ccC+TpLuvKf1/GUm5J1xrC1WJQM=; b=CZWr4Yab0q/hXnyAlrJ1qNtyb+Qg9ynTmtKVYbf+fCF05ICl3i9gbI/tWm+aPLDzqa G6D+jMLidSH8jSTyuAjae5QUbgoEFdNrQL7PGcNkqda2mRO4Mi+JmXp7x9n39iG9lDb+ 1wSYCXKiVjPI5OmaP/zLje5+PW/upzhsSCns5sDePif2o9Iu0899sFDHHTQB7t13nn6e vW+SL8uNYqP5uGEwWZC0gSAqWqmLf2ttcneQ4wDrRICerUNsGzonyaZ7LD+pD2fcbzJV JtFOL1957tLkxIdDvFiZgAsieK2ifNDqCggsbkMOB7Ldnqz+PtXJdLpLzhqaZ7L/SEj8 lS6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p6-20020a170906a00600b008b17e21e082si10810442ejy.295.2023.02.28.06.04.03; Tue, 28 Feb 2023 06:04:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229758AbjB1Nzb (ORCPT + 99 others); Tue, 28 Feb 2023 08:55:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229750AbjB1Nz2 (ORCPT ); Tue, 28 Feb 2023 08:55:28 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC5681EBEF for ; Tue, 28 Feb 2023 05:55:27 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pX0Rt-0007wv-33; Tue, 28 Feb 2023 14:55:21 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pX0Rr-000sdC-Si; Tue, 28 Feb 2023 14:55:19 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pX0Rr-0011dg-0Q; Tue, 28 Feb 2023 14:55:19 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding , Munehisa Kamata , Benson Leung Cc: Guenter Roeck , linux-pwm@vger.kernel.org, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 2/4] pwm: cros-ec: Explicitly set .polarity in .get_state() Date: Tue, 28 Feb 2023 14:55:06 +0100 Message-Id: <20230228135508.1798428-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230228135508.1798428-1-u.kleine-koenig@pengutronix.de> References: <20230228135508.1798428-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=749; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=IAtiCGV0wRa2U+/PppANZkZKRqaD1N3SRiIodPKqHTk=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBj/gevfhS7IyOpnmkoKmE420NdX4odBQ8eZG4d2 I2ybrXNvZCJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCY/4HrwAKCRDB/BR4rcrs Ceq2B/9uCvaS+h95L+nfKjNahQfxtSyvPKw84Bl5AdHl2eN8Dy3mvqKAj725tx3O8JoslREBw4/ k1yU9cCbtDN000837fApwnhAo5parWgJLsStdKIuE8ddcjtwTFLlku5s7gtUkPT/DxCAb7pE9Wz jsltzncD+SOAQAJi2mZqE1GYrVMBTqUDc5JtB1RW/Z0H4/jq00y1p4T9i8Xxhy4N8LpYeax+Xnu gYp9kfIyT/KWyGBhbndnN+QCxFC8kgs03aonHEF8uflNO3hVQwOAnRJFqN3tLWwBnvZpZJaKOEf nuL3FO6V8tuHZwwslunaK8Ex15qdmjfaNLhFqXxRhVXOpWF1 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759083828282564883?= X-GMAIL-MSGID: =?utf-8?q?1759083828282564883?= The driver only supports normal polarity. Complete the implementation of .get_state() by setting .polarity accordingly. Signed-off-by: Uwe Kleine-König Reviewed-by: Guenter Roeck --- drivers/pwm/pwm-cros-ec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pwm/pwm-cros-ec.c b/drivers/pwm/pwm-cros-ec.c index 86df6702cb83..ad18b0ebe3f1 100644 --- a/drivers/pwm/pwm-cros-ec.c +++ b/drivers/pwm/pwm-cros-ec.c @@ -198,6 +198,7 @@ static int cros_ec_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, state->enabled = (ret > 0); state->period = EC_PWM_MAX_DUTY; + state->polarity = PWM_POLARITY_NORMAL; /* * Note that "disabled" and "duty cycle == 0" are treated the same. If From patchwork Tue Feb 28 13:55:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 62505 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp3031047wrd; Tue, 28 Feb 2023 06:04:28 -0800 (PST) X-Google-Smtp-Source: AK7set8zJlOc5GGLJUmDg3q49oTtyBy6Zu067hVFZF017aR7fhZXGrV3JntdNUMh9FaLp+FCkS/x X-Received: by 2002:a17:906:6ad0:b0:7c9:6e0e:1427 with SMTP id q16-20020a1709066ad000b007c96e0e1427mr2426145ejs.6.1677593068708; Tue, 28 Feb 2023 06:04:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677593068; cv=none; d=google.com; s=arc-20160816; b=JzoAgB648klTgtWTyJYGgWGncbFE9ZzVruFkPn4ISF4PcRUez7wxv5LkpD+VJn4yOt Y44iAX4XDs7Z632VKvcmSbltdx3/bBmkwU1ZJgDZxYvyg5duHWfWaXX6JLCioGFDO5j1 LlvBVMU7BKDvBUyFypMr5gZvGI4nzctoj7S6NbNwZcRiL33hnc6rVoyvkhAuD2hEd4ku xQ5SoIgU7dBZRIQCvaZU/G8aP1qL5fS0HJU5haC3IP+/yvtl2dGsl0hl8jSwOUBxlvRV Cn73saOK20mG0CzmIcQWOvvBoDTXzWTw+2664TrkR1oVGf0t0vWcdXqv/074AUkoBUWe OkNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=MD1JkaNjiuMfQtfB3EJtmp0lEwTafG0tCM2GbcVNGY8=; b=T0VtcjmDDttRC6dK2usDe9vi4GhF4VyyzYph2ktnAuhnaWGjyzM0OycyzRPTsMG030 gjBRFPPBSPzuR7Wzr+ApFCbKzoAlMpt/gdnP15IjCbVQ14NxK353mupoBmEmUBNFfTm9 +tRlJBEDBRVcU5TZGfDm/4hlywahfL2kfxty6sVQ5RkAOMh49XLs1uvA7HURtsZdAgXh eHEk9Dx72XK2ey2Exy70IeNLBciopdGnssFM70uPGW5EwCpZqyabamRzatOAWRrYFGG8 wUd7r6vhtsUvcbf/fU5AyRq2KqK5HwZ3NOxuV4iU2KGzG94W9Xqffce+qfTShBYOGPMj 4pbQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sd25-20020a170906ce3900b008b3b05ca5e1si11036888ejb.375.2023.02.28.06.04.03; Tue, 28 Feb 2023 06:04:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229754AbjB1Nz0 (ORCPT + 99 others); Tue, 28 Feb 2023 08:55:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229739AbjB1NzZ (ORCPT ); Tue, 28 Feb 2023 08:55:25 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 930A91EBEF for ; Tue, 28 Feb 2023 05:55:24 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pX0Rs-0007wu-FG; Tue, 28 Feb 2023 14:55:20 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pX0Rr-000sd9-QY; Tue, 28 Feb 2023 14:55:19 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pX0Rr-0011dj-61; Tue, 28 Feb 2023 14:55:19 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding , Munehisa Kamata Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 3/4] pwm: iqs620a: Explicitly set .polarity in .get_state() Date: Tue, 28 Feb 2023 14:55:07 +0100 Message-Id: <20230228135508.1798428-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230228135508.1798428-1-u.kleine-koenig@pengutronix.de> References: <20230228135508.1798428-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=695; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=oFx9sWQeOcwK9tph3SLBT8A0PAe+uJ+yMPKcDB2SV6g=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBj/gezGzP7hFeDYYO3McBYrDAocsVr1s8ooAAwU 72jqr0StXGJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCY/4HswAKCRDB/BR4rcrs CTM8B/96zKiaRWSNjbH003KQRBpIIUk86CaI410ZsKGBCyV0v6djqh/onhyaXAYC+W4nqNVMXLz mxQ24yUJjuQ12Lp9ZjG0NwkuCXQtgQ9Ob1HeqgWwaojpVWV0y0hQPo3s0Pip3SdJAe26QmPsTX7 Thfbp3kCQ3QH7keDvzkuU9eceLmtH5RdHFjKHsHLjloTbMNfH2/Fj3AxsMF3ZnUkL5elLKX+5NB YV/mnpLa85ujstFIAT08S6efYP2TwSz/2OBwvLl48h3tRkO1RmwX3Ckk3ElqzJ9/YbqziRfYjsI lWAaKOx6GRUApZFTmhVMAgeb+M6sMDEvq5k0YU4YIfK4l1U5 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759083829772339521?= X-GMAIL-MSGID: =?utf-8?q?1759083829772339521?= The driver only supports normal polarity. Complete the implementation of .get_state() by setting .polarity accordingly. Signed-off-by: Uwe Kleine-König Reviewed-by: Jeff LaBundy --- drivers/pwm/pwm-iqs620a.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pwm/pwm-iqs620a.c b/drivers/pwm/pwm-iqs620a.c index 8362b4870c66..47b3141135f3 100644 --- a/drivers/pwm/pwm-iqs620a.c +++ b/drivers/pwm/pwm-iqs620a.c @@ -126,6 +126,7 @@ static int iqs620_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, mutex_unlock(&iqs620_pwm->lock); state->period = IQS620_PWM_PERIOD_NS; + state->polarity = PWM_POLARITY_NORMAL; return 0; } From patchwork Tue Feb 28 13:55:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 62503 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp3030707wrd; Tue, 28 Feb 2023 06:04:03 -0800 (PST) X-Google-Smtp-Source: AK7set91bIFJki2oa/wh8Wysz99RfEp5RHLSpiK0auEL1gC3b9DGHGsri5/swt3ZTsEbuHAR5Wq1 X-Received: by 2002:a05:6402:356:b0:4ac:c6ca:b1f8 with SMTP id r22-20020a056402035600b004acc6cab1f8mr2916514edw.12.1677593043172; Tue, 28 Feb 2023 06:04:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677593043; cv=none; d=google.com; s=arc-20160816; b=TJlSCLONpuwP/Qw6ECd5jm3IrJFqLTFPVZODTHrCkaqT0uHOGbdRPUDOchqYLwMuo+ B2GWRtVs0BU0RpSyyI6QdHa7B+/en+xSEwPdjTV5hB9NPhdGL+a8qnp9mkC/b8nJPXCV LLrtgnlYjky9jupV/Zyvl3CRePM6T6VFMk5kei9KKAbnYLx/dZfvAJbypHKz7Yx5MJUG Q4P01vW355lDj0/ujt+72j6+OSv40ZO25C29frm8mkpe6tlkmOd5+tSzps5aM/3L+wPQ IB2f6YPfVA9W2xO3HiFn3Dp0ZGtbfhy6YNcfc4PPpd05mNeg3p0fC9QURUNGFGDc8uHY LKcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=TU0IibZk81ON8uMC6969NrZx4EAjaeJxVnhw+jFgCgw=; b=MKy+bvoaCA84wjiXo8ghNXrnz3y4D3gSBllC7EyeVQgUqynvE8t+mgRK71UMTLR2Z2 uAiRzYxbd/unODjiLrD2DlwDUtPQ2vXVr9z0KRxYZPk/4c2Ap5KCTivtR76J/ymE+zOd Mf9VDb9bRVN1QwhjaR2fC2jVSpVS/v6YZ8u1WFpqtzAw4KTbdj9rBCGRSxmCM2U0H2e9 xDt1/WKEFDvOfaSK5RYnJvg0/EbUOX9r9NUqnGH/I4CT0HkwoEUQB/sSzCspTxVJFqr5 hYobgcjJQQvbHATPX/7CoK3teSNZDkaAnPpfJ0Z/w978PCzaujThCkHthAJMydFagINT 1JFQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hr37-20020a1709073fa500b008dd491949c6si3476372ejc.978.2023.02.28.06.03.38; Tue, 28 Feb 2023 06:04:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229771AbjB1Nzd (ORCPT + 99 others); Tue, 28 Feb 2023 08:55:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229761AbjB1Nza (ORCPT ); Tue, 28 Feb 2023 08:55:30 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF482305FE for ; Tue, 28 Feb 2023 05:55:28 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pX0Rt-0007wy-2Z; Tue, 28 Feb 2023 14:55:21 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pX0Rs-000sdF-0S; Tue, 28 Feb 2023 14:55:20 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pX0Rr-0011e4-CB; Tue, 28 Feb 2023 14:55:19 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding , Munehisa Kamata , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 4/4] pwm: sprd: Explicitly set .polarity in .get_state() Date: Tue, 28 Feb 2023 14:55:08 +0100 Message-Id: <20230228135508.1798428-5-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230228135508.1798428-1-u.kleine-koenig@pengutronix.de> References: <20230228135508.1798428-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=824; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=bmf2HoXP9Rt5LT3z0AtFgY3qIfAp4/hwx1OXH8EwlFw=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBj/ge2KHuAInQ+QDahQS2YY03DGST7KS6YuYIAG cCGk1az48GJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCY/4HtgAKCRDB/BR4rcrs CbNsB/9xAqs3WfLL+n74CI2B0P7vOauSZIUEMz7vuNJ1o8YDjSnmlkDtdJr4LA7olD3QWLXFyG2 QzZJSGsglYbR8rn87eemML3a8r3wiDlqeInSg4C1Ol5U9vDQLlOijd3c4BwWuKDDJCgzCt05Adi fVkCwABcaQteeTcFE3bwoLhFk14vTzmoGtp8Lb5teawf22xNNDd45/vAolptfbuFSv1s2qHKRP6 gT9zP4OIVm/x2QRC0/aH/tzfBI1zTQy6G55Az274UHAktxCPGvZmh3KM6KCC6ngEmfDXR99MF3w Q0DwLe7vriTk0Gly0sx2tEe9u84tUscrbYL3+Uh6Q88FCDR8 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759083802694712695?= X-GMAIL-MSGID: =?utf-8?q?1759083802694712695?= The driver only supports normal polarity. Complete the implementation of .get_state() by setting .polarity accordingly. Signed-off-by: Uwe Kleine-König --- drivers/pwm/pwm-sprd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pwm/pwm-sprd.c b/drivers/pwm/pwm-sprd.c index d866ce345f97..bde579a338c2 100644 --- a/drivers/pwm/pwm-sprd.c +++ b/drivers/pwm/pwm-sprd.c @@ -109,6 +109,7 @@ static int sprd_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, duty = val & SPRD_PWM_DUTY_MSK; tmp = (prescale + 1) * NSEC_PER_SEC * duty; state->duty_cycle = DIV_ROUND_CLOSEST_ULL(tmp, chn->clk_rate); + state->polarity = PWM_POLARITY_NORMAL; /* Disable PWM clocks if the PWM channel is not in enable state. */ if (!state->enabled)