From patchwork Tue Feb 28 00:52:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yang Li X-Patchwork-Id: 62221 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2734783wrd; Mon, 27 Feb 2023 17:01:06 -0800 (PST) X-Google-Smtp-Source: AK7set8vn05At522SCy/FGkloiCyFJkD0Zbu1oOazzSPq8g4Obse8p9bANyBEkYn/Q/Cm23aSX46 X-Received: by 2002:a62:1bd2:0:b0:5a9:cebc:90ee with SMTP id b201-20020a621bd2000000b005a9cebc90eemr775030pfb.15.1677546066673; Mon, 27 Feb 2023 17:01:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677546066; cv=none; d=google.com; s=arc-20160816; b=uhARMcoIa3pbvU/MrR4Gj111JiqlzSD5pwWIP43UWUwk5tZQAgrNCEpMaTNQQhjrfW JT88iGGWCTD6CA4WEoXhweZLaL0x+Zfjz9dyR9wzrj4WhczewZmdEog3CVRn55TKy32u 80ZPTSmP94gxaVECENi4jGuEhkDdQi8ij/x11YobrY25TYcZo4VCUSV73pVW4ecoUxZF KNoYgC/OllzMuNwlAG6DjFr9fVhpMe65a4TWd73u3r8HzR5mEw/JECDAIE/8d3nxHkwT kIZItQ3wo5HMdG3xiReeRUGoKHzGVm+1Eg5nwhOH32WZl0m1lRxdj1QDE2KlWfPT33L7 iE5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=a1yVgTBAKQq0QT4eZjjo9PpKI0Lr7mFd4QgqxcyfyjE=; b=S3o5JG/VBaO/5TyKLXnUY2XjaIMPdscC44Ru5XwTw6WnFGsMd+xS53A8mG9+1iI+/d nsvtX9nW3xF1Me4/kFZogwYzwQs6AE7ilg7oDXdIj4+TSx2qQRASXA0gKdXXGpD71ZNY 8hwKq5+s5NV1c+ZVoYYozIKvDbdCcUUMBAUSX8tk34bSp/U6xAsUMOFLORnzzkFFNMF3 gbZPjz5QRNTVj4c1vzeRnRzTsfhqhHFemmERk696o/8tDIr5b99DxV7ZRuRtTvN6NU3q tWxiq9+ugrXZ4EYJNoKi0FVYpwFGUyf7stW0F2AxIcCUC/ykgSA4jBc+cYS5b3xw4YKB xRdw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t19-20020a056a0021d300b005a8f197c6aasi9281528pfj.88.2023.02.27.17.00.52; Mon, 27 Feb 2023 17:01:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229671AbjB1Awk (ORCPT + 99 others); Mon, 27 Feb 2023 19:52:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229659AbjB1Awa (ORCPT ); Mon, 27 Feb 2023 19:52:30 -0500 Received: from out30-113.freemail.mail.aliyun.com (out30-113.freemail.mail.aliyun.com [115.124.30.113]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02AF126857; Mon, 27 Feb 2023 16:52:21 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R871e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0VcgbXXg_1677545538; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0VcgbXXg_1677545538) by smtp.aliyun-inc.com; Tue, 28 Feb 2023 08:52:19 +0800 From: Yang Li To: kuba@kernel.org Cc: davem@davemloft.net, ralf@linux-mips.org, edumazet@google.com, pabeni@redhat.com, linux-hams@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: [PATCH net-next] net: rose: Remove NULL check before dev_{put, hold} Date: Tue, 28 Feb 2023 08:52:17 +0800 Message-Id: <20230228005217.105058-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759034544285857506?= X-GMAIL-MSGID: =?utf-8?q?1759034544285857506?= The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there is no need to check before using dev_{put, hold}, remove it to silence the warning： ./net/rose/rose_route.c:619:2-10: WARNING: NULL check before dev_{put, hold} functions is not needed. Reported-by: Abaci Robot Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4239 Signed-off-by: Yang Li --- net/rose/rose_route.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/rose/rose_route.c b/net/rose/rose_route.c index fee772b4637c..58d0312c0119 100644 --- a/net/rose/rose_route.c +++ b/net/rose/rose_route.c @@ -615,8 +615,7 @@ struct net_device *rose_dev_first(void) if (first == NULL || strncmp(dev->name, first->name, 3) < 0) first = dev; } - if (first) - dev_hold(first); + dev_hold(first); rcu_read_unlock(); return first;