From patchwork Fri Feb 24 15:22:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Martin_Povi=C5=A1er?= X-Patchwork-Id: 61375 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp982309wrd; Fri, 24 Feb 2023 07:44:11 -0800 (PST) X-Google-Smtp-Source: AK7set9R7TT5yVy5a4PWp4WtOJ8ngfFWWa928YgnxxuWUZ4ArqfF7ZDuyrWrWAXEPFQhtzqEmjZy X-Received: by 2002:a17:902:b94c:b0:19c:a8e8:507d with SMTP id h12-20020a170902b94c00b0019ca8e8507dmr7863790pls.47.1677253450867; Fri, 24 Feb 2023 07:44:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677253450; cv=none; d=google.com; s=arc-20160816; b=cu1xNAqkNXpqn5KfyyYQqIlcruNNRDfFkAQpSWgb9tj+6YFG1eb/UW+LUQ764+57e6 qzHMZVE9cUCb+71ev9dBAaNlulFh2UucWxA/cmf+h+moCgr5vk7GEfakAd6zw4EG74HP 6QLM/MlZaVp9qfJs9sXGKnDpASvAUM5fV3vQnc9t+Zrg8j7Kt1fXvgJr1twnCExYjhoh KR8e9a7Zq6f4mQBJMSwkSSrGMIDv0EMiQHY4r/1bRivno6EYBpFyFM27lAzAMLlEFh/V GeRUh4KqIrIZTgeDCmmqWc4veYjL35K3NtwocLcQHGx0URZ6syY+XCBezJgMgnUN467X 5RkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:dkim-signature:from; bh=8I53wAm0Lhx1Y1CRpTsp/SrqowkIL26beK+I0BreeKg=; b=lggRG9YIDzm8VGRsXAHHhpMv9YLN4A/qCWA6o5Bw2f9Lq46QwBNR9mhsyD4owqPH7j KDwtBofMKWxkcZq4b0bY/xW37EcVIKuDGFZejHGMUq1MdwBV2lB3M+lgHmlyevG21x0e vxlAlr6aEIDhG0bVfTSOdeXevme+jCV91RoFpcUYd8AgtvYrep+ehBCVupWyxEgDBeuA 8Za3/wCds10EFuiHDs8bwfq0ewO+ABseZdWJqcFDKsWFeDHtq6RDEZrIw/sBgiphUna0 SrUw05B1hMDaEM26CG7xwOF2qTIwKc57TEyhPUnQZbJ5KlKiuk1HD41i9xCwEP5Q/ksx +XGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cutebit.org header.s=mail header.b=KzjvnnBt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cutebit.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q18-20020a170902bd9200b0019ad22c40c7si4685515pls.132.2023.02.24.07.43.58; Fri, 24 Feb 2023 07:44:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cutebit.org header.s=mail header.b=KzjvnnBt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cutebit.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230318AbjBXPWj (ORCPT + 99 others); Fri, 24 Feb 2023 10:22:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229748AbjBXPWh (ORCPT ); Fri, 24 Feb 2023 10:22:37 -0500 Received: from hutie.ust.cz (unknown [IPv6:2a03:3b40:fe:f0::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACEF66A9E6; Fri, 24 Feb 2023 07:22:30 -0800 (PST) From: =?utf-8?q?Martin_Povi=C5=A1er?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cutebit.org; s=mail; t=1677252145; bh=8I53wAm0Lhx1Y1CRpTsp/SrqowkIL26beK+I0BreeKg=; h=From:To:Cc:Subject:Date; b=KzjvnnBtPMLzkpne5ixV1R5vuvAuRq/riSQMn9JedY18pihL2mEdyY4AVhiv2dpX4 2jOIvqTVWjw8jMAAe4igDy0ErG5dXi8IdYScZWKLs1WURJu6IVVQGM4gAmerF6KtlL uzDbQyJTxoBgbh/cekLbEdEGeCEnorFmhJLgHseg= To: Hector Martin , Sven Peter , Vinod Koul Cc: Alyssa Rosenzweig , =?utf-8?q?Martin_Povi=C5=A1er?= , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] dmaengine: apple-admac: Handle 'global' interrupt flags Date: Fri, 24 Feb 2023 16:22:20 +0100 Message-Id: <20230224152222.26732-1-povik+lin@cutebit.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_FAIL,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758727714799147868?= X-GMAIL-MSGID: =?utf-8?q?1758727714799147868?= In addition to TX channel and RX channel interrupt flags there's another class of 'global' interrupt flags with unknown semantics. Those weren't being handled up to now, and they are the suspected cause of stuck IRQ states that have been sporadically occurring. Check the global flags and clear them if raised. Fixes: b127315d9a78 ("dmaengine: apple-admac: Add Apple ADMAC driver") Signed-off-by: Martin Povišer --- drivers/dma/apple-admac.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/dma/apple-admac.c b/drivers/dma/apple-admac.c index 90f28bda29c8..00cbfafe0ed9 100644 --- a/drivers/dma/apple-admac.c +++ b/drivers/dma/apple-admac.c @@ -75,6 +75,7 @@ #define REG_TX_INTSTATE(idx) (0x0030 + (idx) * 4) #define REG_RX_INTSTATE(idx) (0x0040 + (idx) * 4) +#define REG_GLOBAL_INTSTATE(idx) (0x0050 + (idx) * 4) #define REG_CHAN_INTSTATUS(ch, idx) (0x8010 + (ch) * 0x200 + (idx) * 4) #define REG_CHAN_INTMASK(ch, idx) (0x8020 + (ch) * 0x200 + (idx) * 4) @@ -672,13 +673,14 @@ static void admac_handle_chan_int(struct admac_data *ad, int no) static irqreturn_t admac_interrupt(int irq, void *devid) { struct admac_data *ad = devid; - u32 rx_intstate, tx_intstate; + u32 rx_intstate, tx_intstate, global_intstate; int i; rx_intstate = readl_relaxed(ad->base + REG_RX_INTSTATE(ad->irq_index)); tx_intstate = readl_relaxed(ad->base + REG_TX_INTSTATE(ad->irq_index)); + global_intstate = readl_relaxed(ad->base + REG_GLOBAL_INTSTATE(ad->irq_index)); - if (!tx_intstate && !rx_intstate) + if (!tx_intstate && !rx_intstate && !global_intstate) return IRQ_NONE; for (i = 0; i < ad->nchannels; i += 2) { @@ -693,6 +695,12 @@ static irqreturn_t admac_interrupt(int irq, void *devid) rx_intstate >>= 1; } + if (global_intstate) { + dev_warn(ad->dev, "clearing unknown global interrupt flag: %x\n", + global_intstate); + writel_relaxed(~(u32) 0, ad->base + REG_GLOBAL_INTSTATE(ad->irq_index)); + } + return IRQ_HANDLED; } From patchwork Fri Feb 24 15:22:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Martin_Povi=C5=A1er?= X-Patchwork-Id: 61373 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp978424wrd; Fri, 24 Feb 2023 07:36:25 -0800 (PST) X-Google-Smtp-Source: AK7set+GToYP/zlNKiJ9/W3owW3v58XMi4GDgsk2l3H75RMbcgXup76gkbjQjb5RtuUHzkUu0nNl X-Received: by 2002:a17:906:470a:b0:8b1:fc58:a4ad with SMTP id y10-20020a170906470a00b008b1fc58a4admr24149600ejq.11.1677252985155; Fri, 24 Feb 2023 07:36:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677252985; cv=none; d=google.com; s=arc-20160816; b=apjEDnx27qBfjULfpmGpjeHozEQtZnFuz/Na8eAzzTWDOYW8J3/b/OsvN6YGLnMGGa q1434Bh/0eVCT+8OsJs5piVo7w3P7G8pAeEOjjLXUtIHfXgheSXJes5pjNAMzs5XSVUT sWUa1hpfL0jV6T6GAlmVztqM+mEVsN8guhHZ4SDGfm7JxGG8AEqD8JzFCxSQwpkMi2Qe BUjxBau7YDkzL1nxod0YVaA7aKMwuo7dytfLbLvwLOz+rZ3fbyiMvmid/1GIWGZCqgZR KAogzkkL04Vd5wNlVOkDb+2IiQ04OYu5cFa6bH6PjCFexWY2bfpIm15MX6CUZF+sMhql S3zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:dkim-signature :from; bh=StaFikSjZpFQ+BUcIlQfwrxM+sCnU+rvBEoVvGQ2nmk=; b=Yfv0rnEbs/s4KHXHrqvIsbw5lC72NZxsWJjByJ3ry1sbVOvqEhGEi0g23rOFOK7qn1 3SsdZN4hXiz/o7jwCLB/r0CYQpvpJbf9MDy67mIjnCpfMx4VlnlKcYapDPPwhTVslJzP MZ5g/TTyvsgg3bPv8nMKaqB4+/rzC8eOQqB5j9YzNNTXvcl490HrpnjVVitPa/XkuXt7 ZtRNV9vgR9f+2lcWaw3OX8gxRgXjYt/hy/23CmlSlw3/mWOz6DCK4VU20fKX7EIoL3Eg qGCj2w2fRw0v0pJbVtYPGdCsuT6lH4h13oMi6Gx0DC7XEeMbX7RwTXTXQB8cpE76rpjY dmNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cutebit.org header.s=mail header.b=fOvbi5u7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cutebit.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mf24-20020a1709071a5800b008ccc0fd3d13si14615856ejc.348.2023.02.24.07.36.01; Fri, 24 Feb 2023 07:36:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cutebit.org header.s=mail header.b=fOvbi5u7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cutebit.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230354AbjBXPWr (ORCPT + 99 others); Fri, 24 Feb 2023 10:22:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230311AbjBXPWj (ORCPT ); Fri, 24 Feb 2023 10:22:39 -0500 Received: from hutie.ust.cz (unknown [IPv6:2a03:3b40:fe:f0::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81D676EB1A; Fri, 24 Feb 2023 07:22:31 -0800 (PST) From: =?utf-8?q?Martin_Povi=C5=A1er?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cutebit.org; s=mail; t=1677252145; bh=StaFikSjZpFQ+BUcIlQfwrxM+sCnU+rvBEoVvGQ2nmk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=fOvbi5u7TfZbdRb/5lxtFwcD+ebCgEW+egwfuLYdhfzxpB2grc3CsYFX5m3JosTZ3 5CP7I59IxQyKuSrYvD7i+g0nm3Z7Anzbz6LcVbPDatTuX7bCwQrAa765yoNtapNLkx VYNi76Ina7OQb60oYtDZ5wzW7ec+E3dPHKVJiV+4= To: Hector Martin , Sven Peter , Vinod Koul Cc: Alyssa Rosenzweig , =?utf-8?q?Martin_Povi=C5=A1er?= , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] dmaengine: apple-admac: Fix 'current_tx' not getting freed Date: Fri, 24 Feb 2023 16:22:21 +0100 Message-Id: <20230224152222.26732-2-povik+lin@cutebit.org> In-Reply-To: <20230224152222.26732-1-povik+lin@cutebit.org> References: <20230224152222.26732-1-povik+lin@cutebit.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_FAIL,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758727226099914756?= X-GMAIL-MSGID: =?utf-8?q?1758727226099914756?= In terminate_all we should queue up all submitted descriptors to be freed. We do that for the content of the 'issued' and 'submitted' lists, but the 'current_tx' descriptor falls through the cracks as it's removed from the 'issued' list once it gets assigned to be the current descriptor. Explicitly queue up freeing of the 'current_tx' descriptor to address a memory leak that is otherwise present. Fixes: b127315d9a78 ("dmaengine: apple-admac: Add Apple ADMAC driver") Signed-off-by: Martin Povišer --- drivers/dma/apple-admac.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/dma/apple-admac.c b/drivers/dma/apple-admac.c index 00cbfafe0ed9..497bb65b7d6d 100644 --- a/drivers/dma/apple-admac.c +++ b/drivers/dma/apple-admac.c @@ -512,7 +512,10 @@ static int admac_terminate_all(struct dma_chan *chan) admac_stop_chan(adchan); admac_reset_rings(adchan); - adchan->current_tx = NULL; + if (adchan->current_tx) { + list_add_tail(&adchan->current_tx->node, &adchan->to_free); + adchan->current_tx = NULL; + } /* * Descriptors can only be freed after the tasklet * has been killed (in admac_synchronize). From patchwork Fri Feb 24 15:22:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Martin_Povi=C5=A1er?= X-Patchwork-Id: 61374 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp981868wrd; Fri, 24 Feb 2023 07:43:14 -0800 (PST) X-Google-Smtp-Source: AK7set/QMSnbysFUAgHU10CpD0d+PZ/AsQdm1HOzzDVKLMz01DVtVXjlS/TDU3qaZBUvDW3KmtUc X-Received: by 2002:a17:90b:17cd:b0:232:fa13:4453 with SMTP id me13-20020a17090b17cd00b00232fa134453mr17787960pjb.13.1677253394610; Fri, 24 Feb 2023 07:43:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677253394; cv=none; d=google.com; s=arc-20160816; b=WkRKjt86LX1+B6u+uTQA59QbL2FbDOlxGgU57dyytbI8PfwEEtdI7rkf1Fr7AAY+9g xkg02drzxWGYTr7WQ4lwbQJ1BjTE2bGDp69OGlD3jjSCLbXswQY4c1td4Uj1FrSlrP2t sxnG2euv0JeVqzBqdBbRcfg+B06hm7Xun6/DhhLViBm2Sn5r2bZHWegnB5Xjex4oypjK xUUDvyTN1XuFwGyqwRfal8KbOmRTXwwGWy5Y0t2XZQfpAUtToRy2EQlqu58kLMo3u4us pnkWSONXAZ9IDrD1ZRBaeo8kk5NoYwBmt6OaDXyOt2j7AHLMjSdpJE+bZLdJP6xdl1Ka Pc4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:dkim-signature :from; bh=qcgclGCFYD+77b0HLKFa7/pKBARXaiNkZFUlsvgiV7U=; b=p4koe+ZMLfMo2CM5t7IXunxVMfK7DYi9u+iPZ/7fGZchRsec9jYSuEVgfxpha9eUuq YJ5KZs7zZzcBj4bgMZqV46+V9k+KZDFL0GoXDLbhKmE1JIJ9brUhdzWDR0U2s0Sb+tSY NJEzbaXbzyAw+Bk1GvqLedtw5RDjOP4AmkeS+7wKs+mgPdbjRkM4eQIGdCTG7J+wdgHu zACW4rBW8phadoYtQ9cgELzV4Uaf/E8wSnqjWneHUEKgpqFfhveZn1IM1Azw8XOmDaOR eKhAS3jK/3mvh4034R9fedJdLLJ2+Ntv39bSuTvhmy12pA5Aedr0mBoKhUY/2hq/NtP+ FF4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cutebit.org header.s=mail header.b=rPQdylos; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cutebit.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l1-20020a170903244100b001947ba0ac92si16051540pls.350.2023.02.24.07.43.01; Fri, 24 Feb 2023 07:43:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cutebit.org header.s=mail header.b=rPQdylos; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cutebit.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230007AbjBXPWg (ORCPT + 99 others); Fri, 24 Feb 2023 10:22:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229748AbjBXPWe (ORCPT ); Fri, 24 Feb 2023 10:22:34 -0500 Received: from hutie.ust.cz (unknown [IPv6:2a03:3b40:fe:f0::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42F876A9CD; Fri, 24 Feb 2023 07:22:28 -0800 (PST) From: =?utf-8?q?Martin_Povi=C5=A1er?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cutebit.org; s=mail; t=1677252146; bh=qcgclGCFYD+77b0HLKFa7/pKBARXaiNkZFUlsvgiV7U=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=rPQdylosAxrYCCO5c8/2Rz1rgF2eMzEo2nN+XzDHHHY4+Y/P8SWrZZ3ZkW96z5Hcb 7hYQRfRVs/LzFiwrE5hV2PlmdcgVImUYYTcN6kqBi+W5L2KFPLvVQuwqPe1AOsk3bW qLWLeQ+rLGrT5pbA3RNrIgOsxOwUY1GatwjsNLj8= To: Hector Martin , Sven Peter , Vinod Koul Cc: Alyssa Rosenzweig , =?utf-8?q?Martin_Povi=C5=A1er?= , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] dmaengine: apple-admac: Set src_addr_widths capability Date: Fri, 24 Feb 2023 16:22:22 +0100 Message-Id: <20230224152222.26732-3-povik+lin@cutebit.org> In-Reply-To: <20230224152222.26732-1-povik+lin@cutebit.org> References: <20230224152222.26732-1-povik+lin@cutebit.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_FAIL,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758727655584294513?= X-GMAIL-MSGID: =?utf-8?q?1758727655584294513?= Add missing setting of 'src_addr_widths', which is the same as for the other direction. Fixes: b127315d9a78 ("dmaengine: apple-admac: Add Apple ADMAC driver") Signed-off-by: Martin Povišer --- drivers/dma/apple-admac.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma/apple-admac.c b/drivers/dma/apple-admac.c index 497bb65b7d6d..4cf8da77bdd9 100644 --- a/drivers/dma/apple-admac.c +++ b/drivers/dma/apple-admac.c @@ -861,6 +861,9 @@ static int admac_probe(struct platform_device *pdev) dma->directions = BIT(DMA_MEM_TO_DEV) | BIT(DMA_DEV_TO_MEM); dma->residue_granularity = DMA_RESIDUE_GRANULARITY_BURST; + dma->src_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_1_BYTE) | + BIT(DMA_SLAVE_BUSWIDTH_2_BYTES) | + BIT(DMA_SLAVE_BUSWIDTH_4_BYTES); dma->dst_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_1_BYTE) | BIT(DMA_SLAVE_BUSWIDTH_2_BYTES) | BIT(DMA_SLAVE_BUSWIDTH_4_BYTES);