From patchwork Fri Feb 24 13:02:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 61302 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp891939wrd; Fri, 24 Feb 2023 05:02:38 -0800 (PST) X-Google-Smtp-Source: AK7set9SmAepcGGwEGwCDeSWOSBTOTkSrE4VTGxjqU19y5w3WL3mfk0coIvh2Ob/NfgdtSvw1dmX X-Received: by 2002:a17:907:8b89:b0:8b1:7891:19e8 with SMTP id tb9-20020a1709078b8900b008b1789119e8mr27891379ejc.44.1677243758896; Fri, 24 Feb 2023 05:02:38 -0800 (PST) Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id j16-20020aa7c410000000b004af6a815066si6003093edq.471.2023.02.24.05.02.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 05:02:38 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=I8gBailg; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AF32C3857007 for ; Fri, 24 Feb 2023 13:02:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AF32C3857007 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677243757; bh=VploRyHM3+5FAOdED/aruNTYnIe/6ApF+O7zMCsD+a0=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=I8gBailg81XdE+2/o99enCgzyr4KMdfDMvm8Z7jEq1xYzxKX0fJ8xq1qfvzGU213G aZ7tmMnS0hLvytsbz7rlOB2Gbs1nZLrcgY0ihjMJxtgwILCF8vS/kKLt2dizfXB9s1 DLmQGPgTDFjGG8SJbSzONqY7LCvv9A+NTXgFxu/8= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2089.outbound.protection.outlook.com [40.107.7.89]) by sourceware.org (Postfix) with ESMTPS id 6E35D385840F for ; Fri, 24 Feb 2023 13:02:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6E35D385840F ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SG0NCpvm7z3aezVGrtyExywjh8LIytRpcMGpGhaia8KITbaioTEhIdeA6DwwTBSUqpqXo0SLz6cmrRDjPzuNWOtF/sZX6xpt/xkRdi3Er7zyUuBRh3jqZKOA08Y6ysn5p5549PkkbA48OQim8fhJzZ6ye1fPU7TezLSUftMo7PxK2ibQhZmnDm/JjjjmlbkePo142+qvVMqFin8hEZrsPiQTLM15n5BB5luDULc9XznXXKRYEkoNp7L6zmfzXiCyxJd4CyfDtgZY2yUSY/0slodhGJrcsCv1KRXiL3DE0mK3qFZk9mk7CtxaVK1l6W5OHAqVISgIYv1C8TwPTMYMaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VploRyHM3+5FAOdED/aruNTYnIe/6ApF+O7zMCsD+a0=; b=bQOfmr/cD+7s0jU5MUr7EIERFrjLtZVYILBQmq4i3s3/XvJa13lDEBVxLEdJo1q481gaw/nXFnFSrvTNL6TzO/S++PDpmAIzEmtsTdBpxTTFxvlqF081TtQ9F9mIGcwtWeVl6QLiYTgQ2ZrEF2DOw8kGw+XtsphWeSEPVG7c7VTgKvFQS15gsOwHLiHBrRPzcPNtxQH14gKoox6r4Fmw3BbYOkDc+PjiJ3t6nAjfdTBR5URHJHcsm0e4l3uRnCfxmbOj+8h/T8PDe4WKNoifX+gFFGCCVN+Z0pyOmLdf7DgIizo5KfJsw3WnTi67nngwvA+qepf/RqdHoZqi76LzIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB7164.eurprd04.prod.outlook.com (2603:10a6:10:129::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 13:02:25 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.024; Fri, 24 Feb 2023 13:02:25 +0000 Message-ID: Date: Fri, 24 Feb 2023 14:02:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Binutils Subject: [PATCH] gas: default .debug section compression method adjustments X-ClientProxiedBy: FR3P281CA0003.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB7164:EE_ X-MS-Office365-Filtering-Correlation-Id: 12e9f863-78b2-4722-4367-08db16675fe3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w2VeGiBh2AHZNV9QWRdHXHkko5aAFw6wYnI5ap8FFnKM8hyYR0RlCMXJdpwt8QHlb4Pit46Ik3pkpqnOIBQAGrm6rMWrL0oe0nVOpgJz4G6cwOsZyoxZHTJfTjLa6eMRWui77hHArLdDw4uuIdhSo5DxMPrEtax4g95bGtAttwcD6zN31/ZlRSEjuXDHjrQe2lLikWSduc2Jv1oF7+xhfZTYrN3d7QfQ6zn8eLvL4IQ1MU/jtrZoT16esDEGuUsklx7aFrlYdYsPrBdFoUiZxUJU1+bDlyuJ4d0mvGhbhNT6DfplpZ+2ZRM15C74slOeUuFijx+s+ttI3AYqIwUaB/PajTsZWbG0BaEDbGSOm7CgKmWm33JtflOQfuqpeXZ00/U5M6hRrX5BxEqbWZNoTyvLw0oFrpMD61D80xDUSn8AvoU+HDCjnXN39EqdnlNKN8n23MjMwfNCI83FnPHcC1sB2eyVXu2m3XganX2KIc1C7CvWGvnbVHxTcF1le74gjmFQkTQ5ImwjQSs3gcHSkha53nQ3wfnh090k1irlVMaZXLX7Wq86jvk5AHR5WA8MAQvHMVeOQRxN8ieccl77KFv6EG0diGSToN6vKRgJzycFHnIJBGflP4WADLogQ9rapIWgXvY2nvDtcyto2GNE4GJph7o+DbEj3mAq93Nk4sC1L+U2/DP1rdzE3kXvHcZKPN6LEp8VzygimReiJfW3wbrZMNA1tI9WtvAsUZLUCADuYhiscV9kZ5TGZYdHYNAR X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(396003)(136003)(39860400002)(376002)(366004)(346002)(451199018)(31686004)(41300700001)(2616005)(6512007)(8676002)(6506007)(8936002)(6916009)(66946007)(66556008)(186003)(26005)(86362001)(31696002)(66476007)(5660300002)(316002)(36756003)(6486002)(6666004)(2906002)(478600001)(38100700002)(142923001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?n1yzTy/MfNeJ73/oOO3ZaiVKan/W?= =?utf-8?q?/3rQbLF7kOUal5Ljp88xRxYVvak7+oPqAqkatVwQ/tOtbxlIf7OdjM5Y1/oZg6Rm/?= =?utf-8?q?EUYV5vCb2YPu06RsdN38PDswpnfzecRiuBKQLGThKIYt7eT7M4sRJA6azmf/NgxsC?= =?utf-8?q?EVfpUuotDWtGKTpX3H6RAZU+UpvLqGuGIX50wFOMO2ojwahBtXtnRxJDqcI3IUO0F?= =?utf-8?q?sldYycUl5iMQRrgyo+O1Ccq5TkzU8vW98N3373t1qcPFSDsMDd8BLtnxFgcZEYQGT?= =?utf-8?q?QrGeR8jwmm+jn5zR2eZbN0HO5YCvoAH8iaK6IgahvMtMBjUW+8iOqmHiQBZ2qtt6u?= =?utf-8?q?MJy/Q569lrJyV1QuxdaS2r2EIYKnYTGq60ACitlEE+YZQlEtEG5L+VizhKZ1BaMXT?= =?utf-8?q?kQnjhk4Hufh6Bz8NsQw8W0cfJygu1NPAno9+g9cIZf1BR1CPI01hH+mgC1DBJ2Vjm?= =?utf-8?q?AEeGVuhstHWdiH8a8j43NhkHJ1/QV2NzoOSArfHDOwJj7Ibnt+H7ZqTS+te/iVXxO?= =?utf-8?q?nui0EqmQPsGuHvrdwxsE2TiIDxlFjiEdbK4BAj5cxPaz/rZ2Qt9Z2ZA1CYO4jK68u?= =?utf-8?q?d6kLnTvuYllsEbMCEG21EGgfv0EmyvcU77CAul4Mkd39iKfzaTKSIrd4BDM3PFaZ9?= =?utf-8?q?yc845o4+o4tIwlI4tvR/7DpSoN4xjrtIjO7bzFwuOi/xgSHrICNgVicJo+ZE7jU21?= =?utf-8?q?rk7ZZKxE20q7NnviMKbmTb4VPmpfZZ/4XPxyw/fYVpm/2wV40RSGyrcUe4GCaLlpi?= =?utf-8?q?gE20VwN5b4RGsLIL1e2dQLqvGwzZFuUez6KqBUtKgS5arCnAUCBn00bInEBZTquEU?= =?utf-8?q?ntauB0ODAhQZQJrwoxgEmqvQ21938e3b9FVBu6uZXxajPfcV96CKcsR++/FMDzzzU?= =?utf-8?q?8bRZb+ccsAygM5qdCbQj/Z2nAeee6ip5QZEqhuC9ZKjWXu/R9qcIlmTcDsredJkRN?= =?utf-8?q?/jYPPvVa7jrYJhkI8S3oknAHej/2UhcrgrDa/QE0oRSMTidK+xGmlrvAe7tyUyRbY?= =?utf-8?q?1jsTDLuHof6uEQbXIChIfOwlbMrE9Cn6i6YiTfUsiurcIP4oBR8oqqjfLlvmPKMaz?= =?utf-8?q?zeqvqziaZOTV3qfjXTS1DN9WeCh0q7kH6s0OUh9Vj5qxImIJHpCDC+vcLS9mYh99t?= =?utf-8?q?oQ2LPhAIOKL0nDQmDTBn1PsdzsIJ2/mihFQiF3UnsvjDrC8uC0gaKp7xG1MkSRAe1?= =?utf-8?q?xAsZNIUvud5yYnR4b0YFF7zmm0muyAukHwfF3QLF+6vhdqv2a3YcErYJnvrJJcJ3O?= =?utf-8?q?gEKm4Qgja2ao1yJHo0kLNnnGhHH9S6ZFxTVMLsYyCXWiFR4vMdMq8N32z4o/u25Gu?= =?utf-8?q?egSAh3UmWKy72S+FPQR0A5fpsT73oLDXy2GU79F5pzFEiA4XtbjakFK7G3mayzrPe?= =?utf-8?q?DymRiCS8vVCgvpLm4VLcTuJ5ZtVHzHzn+etGgi9KxLOJM4txwToJsp4mp1MdyTDzj?= =?utf-8?q?YW0q8Cgp/iRvCM1EL0dq0jjNuwQyolFeed76E5uFUy9dgLNTWuQZ2pHGv5yL7ajVx?= =?utf-8?q?neenhi9MZUNO?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12e9f863-78b2-4722-4367-08db16675fe3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 13:02:25.0479 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y8WnZob1vFYW17LiPUufX5yQBzT9PN1iUGoStHH6YmaLNscIPBZioSVKvglW8XTSeBo71uf+kC+FcmpR/As9Uw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7164 X-Spam-Status: No, score=-3028.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Beulich via Binutils From: Jan Beulich Reply-To: Jan Beulich Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758717551686333605?= X-GMAIL-MSGID: =?utf-8?q?1758717551686333605?= While commit b0c295e1b8d0 ("add --enable-default-compressed-debug- sections-algorithm configure option") adjusted flag_compress_debug's initializer, it didn't alter the default used when the command line option was specified with an (optional!) argument. This rendered help text inconsistent with actual behavior in certain configurations. As to help text - the default reported there clearly shouldn't be affected by a possible earlier --compress-debug-sections= option, so flag_compress_debug can't be used when emitting usage information. --- a/gas/as.c +++ b/gas/as.c @@ -228,6 +228,10 @@ print_version_id (void) #ifdef DEFAULT_FLAG_COMPRESS_DEBUG enum compressed_debug_section_type flag_compress_debug = DEFAULT_COMPRESSED_DEBUG_ALGORITHM; +#define DEFAULT_COMPRESSED_DEBUG_ALGORITHM_HELP \ + DEFAULT_COMPRESSED_DEBUG_ALGORITHM +#else +#define DEFAULT_COMPRESSED_DEBUG_ALGORITHM_HELP COMPRESS_DEBUG_NONE #endif static void @@ -256,7 +260,8 @@ Options:\n\ compress DWARF debug sections\n")), fprintf (stream, _("\ Default: %s\n"), - bfd_get_compression_algorithm_name (flag_compress_debug)); + bfd_get_compression_algorithm_name + (DEFAULT_COMPRESSED_DEBUG_ALGORITHM_HELP)); fprintf (stream, _("\ --nocompress-debug-sections\n\ @@ -764,7 +769,7 @@ This program has absolutely no warranty. #endif } else - flag_compress_debug = COMPRESS_DEBUG_GABI_ZLIB; + flag_compress_debug = DEFAULT_COMPRESSED_DEBUG_ALGORITHM; break; case OPTION_NOCOMPRESS_DEBUG: