From patchwork Fri Feb 24 11:38:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jerome Neanne X-Patchwork-Id: 61281 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp860782wrd; Fri, 24 Feb 2023 03:55:18 -0800 (PST) X-Google-Smtp-Source: AK7set8boLiNwFoWKWoqmQjORjhx0uWRa3ToID6czzoi4kznvrnP8TTpcpJh4KtFNDbjnphrklrd X-Received: by 2002:a17:902:e883:b0:19a:a810:542 with SMTP id w3-20020a170902e88300b0019aa8100542mr18097201plg.61.1677239718486; Fri, 24 Feb 2023 03:55:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677239718; cv=none; d=google.com; s=arc-20160816; b=zqvwCGiAYyH8b0dXAvkkPROs6vGpgTXRHo3qEwgcOLfClV35if16x4dfjKRW9o5Yks +Vl6QDDGtAbMJ6Va7t5IJnyoNOtCG04QDJZJ0TALuvdthQO3+KuqAw+WzTBXcFRDZDyv sm5fNaUIepjjGrsUM/8eByt7J4werdbuL9umHws5nskN27HkvvFTeybj+P4PYza1nug1 FKs4Lie75NtodngF0MITp/KkSVouQF726n1ZGADnk8hyQyOFpP6LPRFnsQLvgd0eeDia PjmQZIOoXrDY7dfiDg03dsPG7FmAdvUdKsvdukr3Yk5UQD3M/4IfPirj7MufSgBbXKVY 99Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1oEGDqtr1MO8ofjQLGEKjxybfElMWX+sJVJm1iOsVhc=; b=MjDek8xlXLe/HWG2udHn0v6JUrqRQqmF5sTrsGmlqr2yH2quShT4gx5qnWrihW3G5B tDd9w9LZwawPegYlWTuvOFe3vh8Gdk+pPfuDWhvzPwiGXdySSgRcNS9dWhh2Zmt2j42a Xd043PICyeO1hc6uu0Wy6HOmvetx0vfd7p2VvT3xoqZl5Kw18rBlI9I6cqjS4+5rUvwN FGA8w8+EhPV+PcTTkuehxFbCDWicb8sQCUIerJJz3x4kVm5bqF0UQQ3t+HaJae0+1JW1 OYRHcBG6HWNQIzoKp8dL/faBR47Bn7o4YmTJVNVJ966ubd9Ks5pump5hf4WDchdIe07Z k5uQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=XnVseKxM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kx13-20020a170902f94d00b0019cac96224bsi6470639plb.338.2023.02.24.03.55.05; Fri, 24 Feb 2023 03:55:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=XnVseKxM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229718AbjBXLiv (ORCPT + 99 others); Fri, 24 Feb 2023 06:38:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229635AbjBXLis (ORCPT ); Fri, 24 Feb 2023 06:38:48 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D6F33E634 for ; Fri, 24 Feb 2023 03:38:46 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id p26so11188587wmc.4 for ; Fri, 24 Feb 2023 03:38:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1oEGDqtr1MO8ofjQLGEKjxybfElMWX+sJVJm1iOsVhc=; b=XnVseKxMIZKqwZZxnldVaTj+3QHFKO/dm9tuWBB8qL1T0bb8VsGiO5XTPvGvJhmIRx yP4oSM8BLpcD4iyt/N+0FfasYFwS7qecvAbJqOMUfElG1v47xp5ojwMKhSTL0BG/fEE+ /RC8BEJf3EHGoACjjzQHqoZr7Vy4w1ISYhpoC0x9nHXqFkjxG8E8u4xPwrrpDbNO0UKl XLMYfpRUGCWK0rAYN12owXwk1zPuAcozXEy7C+X481kfho7JB291pWbtaQ9nQGnAabUq dmqnjC/H1Vq/5e2s3+03ZZZ+diq4YwgqqqHP5Urc1qLfE/nqAHeBIvDYl824ZMLgcX70 EePg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1oEGDqtr1MO8ofjQLGEKjxybfElMWX+sJVJm1iOsVhc=; b=f2G9MTkBazLjBFIwWDb9KqmPktDs9/B5+Bpnk1Uaqly3mwP0RyjF6XFeVGSzjnAJdE nb86m7xuaP5ISiqZOfOwQ8RyUqczeSg9xNVJJVyaq6pL9Qwseynsj6hYsQRPkYJFUZDv UhsbUG+Eqb+iK6pR7bmVBEl0d6GskcUuidJUTrbKPgHCooh88OHF2lsvw7Jsem3op5j2 sBrsaGeghfdRBHagOH8tikvRz6CuTuXV53acuIY9IRHHLmm+J954JQ33V7/qr59Syqg3 8soYGfJF0kqFaPZUosBAP8MEN6ihhjzRQX/ZdXyyuNZNJvbKNcfSTH4iYiVMAsq9XVXT pEHw== X-Gm-Message-State: AO0yUKW71HuAvXmdBagllNSccX1Ra8jyTsCAiOo1VeyB3HiqwuM+1gHM jIMLjJzTXREPTV2OgJjD8BzM4w== X-Received: by 2002:a05:600c:1652:b0:3e0:c75:7071 with SMTP id o18-20020a05600c165200b003e00c757071mr6880538wmn.5.1677238724927; Fri, 24 Feb 2023 03:38:44 -0800 (PST) Received: from jerome-BL.. (2a02-8440-5241-7427-e801-6f64-356d-2fd7.rev.sfr.net. [2a02:8440:5241:7427:e801:6f64:356d:2fd7]) by smtp.gmail.com with ESMTPSA id l11-20020adff48b000000b002c592535839sm12769679wro.17.2023.02.24.03.38.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 03:38:44 -0800 (PST) From: Jerome Neanne To: linus.walleij@linaro.org, brgl@bgdev.pl, tony@atomide.com, lee@kernel.org Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org, Jerome Neanne , Jonathan Cormier Subject: [PATCH 1/2] gpio: tps65219: add GPIO support for TPS65219 PMIC Date: Fri, 24 Feb 2023 12:38:36 +0100 Message-Id: <20230224113837.874264-2-jneanne@baylibre.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230224113837.874264-1-jneanne@baylibre.com> References: <20230224113837.874264-1-jneanne@baylibre.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758713314991644219?= X-GMAIL-MSGID: =?utf-8?q?1758713314991644219?= Add support for TPS65219 PMICs GPIO interface. 3 GPIO pins: - GPIO0 only is IO but input mode reserved for MULTI_DEVICE_ENABLE usage - GPIO1 and GPIO2 are Output only and referred as GPO1 and GPO2 in spec GPIO0 is statically configured as input or output prior to linux boot. it is used for MULTI_DEVICE_ENABLE function. This setting is statically configured by NVM. GPIO0 can't be used as a generic GPIO (specification Table 8-34). It's either a GPO when MULTI_DEVICE_EN=0 or a GPI when MULTI_DEVICE_EN=1. Link: https://www.ti.com/lit/ds/symlink/tps65219.pdf Signed-off-by: Jonathan Cormier Signed-off-by: Jerome Neanne --- MAINTAINERS | 1 + drivers/gpio/Kconfig | 13 +++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-tps65219.c | 167 +++++++++++++++++++++++++++++++++++ 4 files changed, 182 insertions(+) create mode 100644 drivers/gpio/gpio-tps65219.c diff --git a/MAINTAINERS b/MAINTAINERS index 468f39a37b33..76ed548cb926 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15330,6 +15330,7 @@ F: arch/arm/configs/omap2plus_defconfig F: arch/arm/mach-omap2/ F: arch/arm/plat-omap/ F: drivers/bus/ti-sysc.c +F: drivers/gpio/gpio-tps65219.c F: drivers/i2c/busses/i2c-omap.c F: drivers/irqchip/irq-omap-intc.c F: drivers/mfd/*omap*.c diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index ec7cfd4f52b1..a1ccc357e1ac 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -1385,6 +1385,19 @@ config GPIO_TPS65218 Select this option to enable GPIO driver for the TPS65218 chip family. +config GPIO_TPS65219 + tristate "TPS65219 GPIO" + depends on MFD_TPS65219 + help + Select this option to enable GPIO driver for the TPS65219 + chip family. + GPIO0 is statically configured as input or output prior to linux boot. + it is used for MULTI_DEVICE_ENABLE function. + This setting is statically configured by NVM. + GPIO0 can't be used as a generic GPIO. + It's either a GPO when MULTI_DEVICE_EN=0 + or a GPI when MULTI_DEVICE_EN=1. + config GPIO_TPS6586X bool "TPS6586X GPIO" depends on MFD_TPS6586X diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile index 010587025fc8..c0f570678db0 100644 --- a/drivers/gpio/Makefile +++ b/drivers/gpio/Makefile @@ -156,6 +156,7 @@ obj-$(CONFIG_GPIO_TN48M_CPLD) += gpio-tn48m.o obj-$(CONFIG_GPIO_TPIC2810) += gpio-tpic2810.o obj-$(CONFIG_GPIO_TPS65086) += gpio-tps65086.o obj-$(CONFIG_GPIO_TPS65218) += gpio-tps65218.o +obj-$(CONFIG_GPIO_TPS65219) += gpio-tps65219.o obj-$(CONFIG_GPIO_TPS6586X) += gpio-tps6586x.o obj-$(CONFIG_GPIO_TPS65910) += gpio-tps65910.o obj-$(CONFIG_GPIO_TPS65912) += gpio-tps65912.o diff --git a/drivers/gpio/gpio-tps65219.c b/drivers/gpio/gpio-tps65219.c new file mode 100644 index 000000000000..af8d3f54fc2f --- /dev/null +++ b/drivers/gpio/gpio-tps65219.c @@ -0,0 +1,167 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * GPIO driver for TI TPS65219 PMICs + * + * Copyright (C) 2022 Texas Instruments Incorporated - http://www.ti.com/ + */ + +#include +#include +#include +#include + +#include +#include + +#define TPS65219_GPIO0_DIR_MASK BIT(3) +#define TPS65219_GPIO0_OFFSET 2 +#define TPS65219_GPIO0_IDX 0 +#define TPS65219_GPIO_DIR_IN 1 +#define TPS65219_GPIO_DIR_OUT 0 + +struct tps65219_gpio { + struct gpio_chip gpio_chip; + struct tps65219 *tps; +}; + +static int tps65219_gpio_get_direction(struct gpio_chip *gc, unsigned int offset) +{ + struct tps65219_gpio *gpio = gpiochip_get_data(gc); + int ret, val; + + if (offset != TPS65219_GPIO0_IDX) + return GPIO_LINE_DIRECTION_OUT; + + ret = regmap_read(gpio->tps->regmap, TPS65219_REG_MFP_1_CONFIG, &val); + if (ret) + return ret; + + return !!(val & TPS65219_GPIO0_DIR_MASK); +} + +static int tps65219_gpio_get(struct gpio_chip *gc, unsigned int offset) +{ + struct tps65219_gpio *gpio = gpiochip_get_data(gc); + int ret, val; + + if (offset != TPS65219_GPIO0_IDX) { + dev_err(gpio->tps->dev, + "GPIO%d is output only, cannot get\n", + offset); + return -EOPNOTSUPP; + } + + ret = regmap_read(gpio->tps->regmap, TPS65219_REG_MFP_CTRL, &val); + if (ret) + return ret; + dev_warn(gpio->tps->dev, + "GPIO%d = %d, used for MULTI_DEVICE_ENABLE, not as standard GPIO\n", + offset, !!(val & BIT(TPS65219_MFP_GPIO_STATUS_MASK))); + + /* depends on NVM config return error if dir output else the GPIO0 status bit */ + if (tps65219_gpio_get_direction(gc, offset) == TPS65219_GPIO_DIR_OUT) + return -EOPNOTSUPP; + return !!(val & BIT(TPS65219_MFP_GPIO_STATUS_MASK)); +} + +static void tps65219_gpio_set(struct gpio_chip *gc, unsigned int offset, + int value) +{ + struct tps65219_gpio *gpio = gpiochip_get_data(gc); + + if (offset != TPS65219_GPIO0_IDX) + regmap_update_bits(gpio->tps->regmap, + TPS65219_REG_GENERAL_CONFIG, + BIT(offset - 1), value ? BIT(offset - 1) : 0); + else + regmap_update_bits(gpio->tps->regmap, + TPS65219_REG_GENERAL_CONFIG, + BIT(TPS65219_GPIO0_OFFSET), + value ? BIT(TPS65219_GPIO0_OFFSET) : 0); +} + +static int tps65219_gpio_change_direction(struct gpio_chip *gc, unsigned int offset, + unsigned int direction) +{ + struct tps65219_gpio *gpio = gpiochip_get_data(gc); + + /* Documentation is stating that GPIO0 direction must not be changed in Linux: + * Table 8-34. MFP_1_CONFIG(3): MULTI_DEVICE_ENABLE, + * Should only be changed in INITIALIZE state (prior to ON Request). + * Set statically by NVM, changing direction in application can cause a hang. + * Below can be used for test purpose only: + * ret = regmap_update_bits(gpio->tps->regmap, TPS65219_REG_MFP_1_CONFIG, + * TPS65219_GPIO0_DIR_MASK, direction); + */ + dev_err(gpio->tps->dev, + "GPIO%d direction set by NVM, change to %u failed, not allowed by specification\n", + offset, direction); + return -EOPNOTSUPP; +} + +static int tps65219_gpio_direction_input(struct gpio_chip *gc, unsigned int offset) +{ + struct tps65219_gpio *gpio = gpiochip_get_data(gc); + + if (offset != TPS65219_GPIO0_IDX) { + dev_err(gpio->tps->dev, + "GPIO%d is output only, cannot change to input\n", + offset); + return -EOPNOTSUPP; + } + if (tps65219_gpio_get_direction(gc, offset) == TPS65219_GPIO_DIR_IN) + return 0; + return tps65219_gpio_change_direction(gc, offset, TPS65219_GPIO_DIR_IN); +} + +static int tps65219_gpio_direction_output(struct gpio_chip *gc, unsigned int offset, + int value) +{ + tps65219_gpio_set(gc, offset, value); + if (offset != TPS65219_GPIO0_IDX) + return 0; + + if (tps65219_gpio_get_direction(gc, offset) == TPS65219_GPIO_DIR_OUT) + return 0; + return tps65219_gpio_change_direction(gc, offset, TPS65219_GPIO_DIR_OUT); +} + +static const struct gpio_chip tps65219_gpio_chip = { + .label = "tps65219-gpio", + .owner = THIS_MODULE, + .get_direction = tps65219_gpio_get_direction, + .direction_input = tps65219_gpio_direction_input, + .direction_output = tps65219_gpio_direction_output, + .get = tps65219_gpio_get, + .set = tps65219_gpio_set, + .base = -1, + .ngpio = 3, + .can_sleep = true, +}; + +static int tps65219_gpio_probe(struct platform_device *pdev) +{ + struct tps65219 *tps = dev_get_drvdata(pdev->dev.parent); + struct tps65219_gpio *gpio; + + gpio = devm_kzalloc(&pdev->dev, sizeof(*gpio), GFP_KERNEL); + if (!gpio) + return -ENOMEM; + + gpio->tps = tps; + gpio->gpio_chip = tps65219_gpio_chip; + gpio->gpio_chip.parent = tps->dev; + + return devm_gpiochip_add_data(&pdev->dev, &gpio->gpio_chip, gpio); +} + +static struct platform_driver tps65219_gpio_driver = { + .driver = {.name = "tps65219-gpio",}, + .probe = tps65219_gpio_probe, +}; +module_platform_driver(tps65219_gpio_driver); + +MODULE_ALIAS("platform:tps65219-gpio"); +MODULE_AUTHOR("Jonathan Cormier "); +MODULE_DESCRIPTION("TPS65219 GPIO driver"); +MODULE_LICENSE("GPL"); From patchwork Fri Feb 24 11:38:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jerome Neanne X-Patchwork-Id: 61284 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp867151wrd; Fri, 24 Feb 2023 04:07:45 -0800 (PST) X-Google-Smtp-Source: AK7set/MWvfP4atpE6SosJ1ZFiQZV5ibY73yRR49BOqIVSX8SepVEUHWDpbdQsUcVrZxED+7IX2h X-Received: by 2002:a05:6a21:3394:b0:bd:3a3:98cb with SMTP id yy20-20020a056a21339400b000bd03a398cbmr17326337pzb.1.1677240465107; Fri, 24 Feb 2023 04:07:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677240465; cv=none; d=google.com; s=arc-20160816; b=z8RVsu8CeCJYFPavszxEp5VKizQeSN8pgRLgBd26Y7eLBkMye1BmPYvX/hIq6qrA5f dngPfRI2Yig9yFZQQvXbRa7CKOGge+IQt7YxEpvrChWTL0MGtD7OekjCnD+utTmmVof0 FQTewoMRNl0cL2bna9femEXsEuWuOkLZ7y8T7Az9artFbOZ09Z66DqRrbi9gRVQxLzbG XDWYnTecu7KqfFMI+CjEV1wikyDouRh3vAzqCm07j01T4/rDD1EwguQ/akT8tNfG9oAZ /tK94+g3CU+FCc2YS5O5iaDZFPq9UMkIzumgEtuVYjrV4i4mJsNakcTXAmYZTN72dkQf R45A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vIyri+jpwJVpMIMhA1b9A/4ppRSy9kvCMb+aoYF2b5g=; b=HXbiYzBoCIvttUSavu8vkKzgjipMEs0weC54Efzn2PIpBDYmHtNTQc9g5mBNUKipyj l6vlz3hTnXMg5KhmDi+CGO+MrourBYY806ZrFq05EptEdhKbDB4c9UNQqaoP+saKcN8U O1nXs1pVUTRU+qAwjBZaGHDfQJ071HAJLi6DT7gkofRYQTUQDyNKO9WI0ew+ESrOAAg1 pVwi32NYRzXpwdJGQpdYz109mAcq0Z/1ma8dSOxCyrBwg8z8glLCFY0bnRrJTb/swtH3 HRO/NjquUQ2CPYM6dV+hMml+UvkcfGl5wxKXIkyqsd7GnmEvUZ3t+hH7MlkAFsfg9Y/L OhGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=oJaEWcdJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 201-20020a6307d2000000b00502f49f4a2csi4968262pgh.412.2023.02.24.04.07.31; Fri, 24 Feb 2023 04:07:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=oJaEWcdJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229728AbjBXLi7 (ORCPT + 99 others); Fri, 24 Feb 2023 06:38:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229660AbjBXLiv (ORCPT ); Fri, 24 Feb 2023 06:38:51 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9341B4E5C3 for ; Fri, 24 Feb 2023 03:38:48 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id h14so4933970wru.4 for ; Fri, 24 Feb 2023 03:38:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vIyri+jpwJVpMIMhA1b9A/4ppRSy9kvCMb+aoYF2b5g=; b=oJaEWcdJ75XrXsvikn4wguWJWYoT0aUHKKRBWrF6kVta1DbvAWNBusnvfasCdFYQDn 3vUKA+dXjGDs6NW67uARS/WIbtk04zqFdOwcm00259Hg4Xa4EtyqnONdmQEX//fBmttm /0azs3haKYLhkcyEoU2b3gAOIwHM5kX1t3gb5jqjyqp/GQj+HOONSWrvFzls0lY60UnY R78MGG3kAsoT2Hp/nwmeB+EQ70YOqL5mFUVd6uAGJ+unVqWveaV7Txl9BudmIkbZR2w4 ez9wU61H3gwZvMgpZsmX5eeS2A36+jU6dBpErf3qfwk2QxIbN/cNicjSc4RmjgvoOlGz fyCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vIyri+jpwJVpMIMhA1b9A/4ppRSy9kvCMb+aoYF2b5g=; b=8HnEuPUOF83LwxusXvx++KW9lQtyPf+nydZ0uVwS1cPAkCjddh0SY+v48orSV1Pxof E5vTVAWqsSDVw7wGh/SU4q/vRl8uD+e7mhLWb4Ncfhj02eGfh1NJNBG03JaPkpeXxkF3 0l41PR9EukQcFFrxEalXGkT5gs+vgxbD+4Qsd1tuhjZtJ+WXx2a0ItFaxPsdjjCuuxl3 3zrXgZWi8pqK5HulUsKS/qgyKe+jTjK1tUUsNVw9q2P5CJfcTcumIjxmPxqlM/YISSFs IDV5UFa3Of1zDMvr2QbGfJnkE2+fmsqxSJRQtUX2ZetFfcXPU7+zmwBtJg/AFXoHuCae Qn6w== X-Gm-Message-State: AO0yUKVyszPAjCVE/c6JIFxeEewDjt7ATvP05e5vsaxpewlR5XvjbdXQ ZaWjU6w4nPIY2WzR1K1lt2ne2wTYKiBoWAB2Qrc= X-Received: by 2002:adf:dccb:0:b0:2c7:691:18b4 with SMTP id x11-20020adfdccb000000b002c7069118b4mr10712190wrm.39.1677238727090; Fri, 24 Feb 2023 03:38:47 -0800 (PST) Received: from jerome-BL.. (2a02-8440-5241-7427-e801-6f64-356d-2fd7.rev.sfr.net. [2a02:8440:5241:7427:e801:6f64:356d:2fd7]) by smtp.gmail.com with ESMTPSA id l11-20020adff48b000000b002c592535839sm12769679wro.17.2023.02.24.03.38.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 03:38:46 -0800 (PST) From: Jerome Neanne To: linus.walleij@linaro.org, brgl@bgdev.pl, tony@atomide.com, lee@kernel.org Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org, Jerome Neanne , Jonathan Cormier Subject: [PATCH 2/2] mfd: tps65219: Add gpio cell instance Date: Fri, 24 Feb 2023 12:38:37 +0100 Message-Id: <20230224113837.874264-3-jneanne@baylibre.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230224113837.874264-1-jneanne@baylibre.com> References: <20230224113837.874264-1-jneanne@baylibre.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758714097801021346?= X-GMAIL-MSGID: =?utf-8?q?1758714097801021346?= tps65219 PMIC GPIOs are exposed in a standard way: gpiodetect gpiochip0 [tps65219-gpio] (3 lines) Signed-off-by: Jonathan Cormier Signed-off-by: Jerome Neanne --- drivers/mfd/tps65219.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/tps65219.c b/drivers/mfd/tps65219.c index c134f3f6e202..5ce62e480ff9 100644 --- a/drivers/mfd/tps65219.c +++ b/drivers/mfd/tps65219.c @@ -115,7 +115,7 @@ static const struct mfd_cell tps65219_cells[] = { .resources = tps65219_regulator_resources, .num_resources = ARRAY_SIZE(tps65219_regulator_resources), }, - { .name = "tps65219-gpios", }, + { .name = "tps65219-gpio", }, }; static const struct mfd_cell tps65219_pwrbutton_cell = { @@ -267,6 +267,11 @@ static int tps65219_probe(struct i2c_client *client) return ret; } + if (ret) { + dev_err(tps->dev, "Failed to add gpio: %d\n", ret); + return ret; + } + pwr_button = of_property_read_bool(tps->dev->of_node, "ti,power-button"); if (pwr_button) { ret = devm_mfd_add_devices(tps->dev, PLATFORM_DEVID_AUTO,