From patchwork Thu Feb 23 09:52:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhruva Gole X-Patchwork-Id: 60878 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp227718wrd; Thu, 23 Feb 2023 01:59:24 -0800 (PST) X-Google-Smtp-Source: AK7set8Xpv6rvQKKy9EhL8UklpsjbQQyH1magV1IUSNkT9rK5h3FEG1Rh7d13mfCVOH3/KH+vFKl X-Received: by 2002:a05:6402:268e:b0:4ac:373e:9d18 with SMTP id w14-20020a056402268e00b004ac373e9d18mr12073849edd.0.1677146364683; Thu, 23 Feb 2023 01:59:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677146364; cv=none; d=google.com; s=arc-20160816; b=zqwZQ3Y0VKCkjZhB1EGDPSFF2PekPjMuoXdYUQLxwqnR8amt8eoXTqoThPyIeq8hFn N/kYLnMkgkhyg5cqsl2gg+yg/oI5cMaOUJvF21Yyq8ymOqqrwea1RXIVyiXBurMdTMC/ SJI/8l+ECJgvpZUuvbea+n0NB4oI8rwEYub0hc0YJT9kJljzX4dZOcHxQzV8gl5bUClO fialMjK/Fx0FqAOYxSXrz5ZzElCPGY/QRumlSecmt4iH1FhUtSEST24zsKHN9VXUHT6M 0IfXrrOcQt5tHSNZ5xsr5Aq8LXjbijozV+vWWcDOWVE/4ynxDqFeN6ag7bIMfGRD5P8q SUqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=kN2RfnUUgzUkwI/ceg/z1+1sFH16ZWxamJeuThGZBG4=; b=K+xRCKmH1i2GboHzmXs1mcqQLOHUux78/uzTjSap69/Vll8bmb31U/nVTJkScq1y/g luRac05mYDfYiklPY9QMUUvO1F7ILzPo5F5mk6RxGLobDZVwE8g0mAx1+ZIlXRgMliGm M1LsYPq5utztTgQkUT60UPh7GdYa/cftDb1HCY1WEdPWfb7s0JiuCWRnXKULHTGu3HI0 7UeGq+KT80OZg6tFaoDBHzocUMiJJcTCUG4yRwS0dgJd3eFCeksuIMQf6x0IyoWEycn7 qwFpeqJFDLPh+vYk9TFgS/i/ZxeqxsQmirXukn2gZ5RFYg2JJhFwSAgA0hUIX99Z68zA k5Tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=RsGg7G6E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d18-20020a05640208d200b004acbb9ce157si4362174edz.237.2023.02.23.01.59.01; Thu, 23 Feb 2023 01:59:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=RsGg7G6E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234154AbjBWJww (ORCPT + 99 others); Thu, 23 Feb 2023 04:52:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234152AbjBWJwt (ORCPT ); Thu, 23 Feb 2023 04:52:49 -0500 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84B584ECEC; Thu, 23 Feb 2023 01:52:47 -0800 (PST) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 31N9qcBl077086; Thu, 23 Feb 2023 03:52:38 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1677145958; bh=kN2RfnUUgzUkwI/ceg/z1+1sFH16ZWxamJeuThGZBG4=; h=From:To:CC:Subject:Date; b=RsGg7G6EjFczahcvt4jv5U3I45u+EasuFuc3C8GNmf0XlwfQXpPkZvmOykWP3BusP Ox14gX4nz5GHeXl+dSwaKFEFawgxKfG4Hi2sEYYkHhDdom2uoGwOAjRdmiK7m9z8RT POB/p5cE4ItiZMZjb5E7j1N2dNy5VFExulWLCYlU= Received: from DFLE101.ent.ti.com (dfle101.ent.ti.com [10.64.6.22]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 31N9qcaJ007277 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 23 Feb 2023 03:52:38 -0600 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Thu, 23 Feb 2023 03:52:37 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Thu, 23 Feb 2023 03:52:37 -0600 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 31N9qarm120592; Thu, 23 Feb 2023 03:52:37 -0600 From: Dhruva Gole To: Mark Brown CC: Vignesh Raghavendra , Dhruva Gole , Pratyush Yadav , , Kunihiko Hayashi , , David Binderman , Subject: [PATCH] spi: spi-sn-f-ospi: fix duplicate flag while assigning to mode_bits Date: Thu, 23 Feb 2023 15:22:02 +0530 Message-ID: <20230223095202.924626-1-d-gole@ti.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758615426682669917?= X-GMAIL-MSGID: =?utf-8?q?1758615426682669917?= Replace the SPI_TX_OCTAL flag that appeared two time with SPI_RX_OCTAL in the chain of '|' operators while assigning to mode_bits Fixes: 1b74dd64c861 ("spi: Add Socionext F_OSPI SPI flash controller driver") Reported-by: David Binderman Link: https://lore.kernel.org/all/DB6P189MB0568F3BE9384315F5C8C1A3E9CA49@DB6P189MB0568.EURP189.PROD.OUTLOOK.COM/ Cc: stable@vger.kernel.org Signed-off-by: Dhruva Gole --- drivers/spi/spi-sn-f-ospi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-sn-f-ospi.c b/drivers/spi/spi-sn-f-ospi.c index 348c6e1edd38..333b22dfd8db 100644 --- a/drivers/spi/spi-sn-f-ospi.c +++ b/drivers/spi/spi-sn-f-ospi.c @@ -611,7 +611,7 @@ static int f_ospi_probe(struct platform_device *pdev) return -ENOMEM; ctlr->mode_bits = SPI_TX_DUAL | SPI_TX_QUAD | SPI_TX_OCTAL - | SPI_RX_DUAL | SPI_RX_QUAD | SPI_TX_OCTAL + | SPI_RX_DUAL | SPI_RX_QUAD | SPI_RX_OCTAL | SPI_MODE_0 | SPI_MODE_1 | SPI_LSB_FIRST; ctlr->mem_ops = &f_ospi_mem_ops; ctlr->bus_num = -1;