From patchwork Thu Feb 23 02:00:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kai-Heng Feng X-Patchwork-Id: 60756 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp64165wrd; Wed, 22 Feb 2023 18:10:31 -0800 (PST) X-Google-Smtp-Source: AK7set+jRz5w1ngQlS6FWoK4SAZUD99OeI4VljaOKwvX6IqVzyjVkmSZ6VlCJgksxWZgPzs/vrHT X-Received: by 2002:a17:902:ce87:b0:19b:e31:b329 with SMTP id f7-20020a170902ce8700b0019b0e31b329mr13628126plg.33.1677118231327; Wed, 22 Feb 2023 18:10:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677118231; cv=none; d=google.com; s=arc-20160816; b=o7WlX7xCdlC8zyx4cMRYvHB3XxBuuKfSFeBf7M1tdZSNOjmzgxN15HZrWDOQRkbv8t WSid7/fJbTuZIlngr/43DPyqzf/CcvzPnZXaAmE98ZvbegV9QMH+QCagavSMwaK6k759 nnQhfvdCtMVtOtQ/4IQHdncLSJdlhj7LYB3sFmiIH8iZaQg1NqucieixNWa4MiTw/tmb AdF5vjtgkziU2jES2HKEnvcx7oltentcdI18xWYOtdsFyXDu3CAzjPDcZu6tof0k3nMv pzY2CJGQE3ebjbaBpiq/64tzTOE0n+bWo2GltS9BVP9ENhFmhfjVGB7nWXMypgYjQUHN J0Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=U9a7rLpIP2hCUo6eMqKJBrvk9ya0IDzUiHVZwChKl1g=; b=w0tfrhrh5vTHkq1F4PJejkBXwzMZBne48rMiNBgykdCCS6A+n/r0ukxQ2xaDMI2NFv yMxcTUsMcrZWAqo7DERYbAzZ4U2nHGjkQPqgN5bkvw553rDoKFqWqe1gWi5GK/sawdCP C+xPj2+0yJFU++rUbKdccHbr4WI3kZAGbCZfrNLwuUhVda7UW2sTqQVdp8+qDbehadSU JbSzcoYgjHzssjsGUtBGxVr+979RX+un62f3h97MK8OUWhv++mIBAvUpG+Mne6Q6jwf5 /34OuwBI+Vbe+2NZFO3MlsY2huZLbQxB3sBx70hdqiONNMBC9YeghQdTkoP8A71+a9fQ 1XAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=k49S7U0N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h14-20020a170902680e00b0019b110d28c6si9461626plk.446.2023.02.22.18.10.18; Wed, 22 Feb 2023 18:10:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=k49S7U0N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232956AbjBWCCB (ORCPT + 99 others); Wed, 22 Feb 2023 21:02:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230435AbjBWCB4 (ORCPT ); Wed, 22 Feb 2023 21:01:56 -0500 Received: from smtp-relay-canonical-0.canonical.com (smtp-relay-canonical-0.canonical.com [185.125.188.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D7671CF77; Wed, 22 Feb 2023 18:01:51 -0800 (PST) Received: from localhost.localdomain (unknown [10.101.196.174]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id 51FD73F836; Thu, 23 Feb 2023 02:01:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1677117710; bh=U9a7rLpIP2hCUo6eMqKJBrvk9ya0IDzUiHVZwChKl1g=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=k49S7U0NgiJu83yL7x7GPeoyZuNTMSOO1TumMXe2/K3PmwWXsSpSAdunjhkPBgGF9 jn01djgQwF+0PPLRls3+8AzjYZ4QWIXYq7eNbAS5WWI9QIxKIQFV7WYSMrREGRevb/ xFGMSSkvyW3FOxpgzA8GrbD8larr/e2l4OOqB7G0YC0tqPE7ZdlEJn4xYlbO382ixt Fx4E2WjapqOMusvqlGCpuy5u4+XUsZqarAOuPQcvIKLutqKqFuomzIvjTD3SGuaIM5 fkCAO4nw4S4FUfxEAMd/ZNIOVhl9bjPEh7BnKyew7JVo+Wo395YnqTAGiHutcYbE77 f1GqF+0IZcN2w== From: Kai-Heng Feng To: jic23@kernel.org, lars@metafoo.de Cc: hdegoede@redhat.com, Kai-Heng Feng , Kevin Tsai , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4] iio: light: cm32181: Unregister second I2C client if present Date: Thu, 23 Feb 2023 10:00:59 +0800 Message-Id: <20230223020059.2013993-1-kai.heng.feng@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758585926335033117?= X-GMAIL-MSGID: =?utf-8?q?1758585926335033117?= If a second dummy client that talks to the actual I2C address was created in probe(), there should be a proper cleanup on driver and device removal to avoid leakage. So unregister the dummy client via another callback. Reviewed-by: Hans de Goede Suggested-by: Hans de Goede Fixes: c1e62062ff54 ("iio: light: cm32181: Handle CM3218 ACPI devices with 2 I2C resources") Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2152281 Signed-off-by: Kai-Heng Feng --- v4: - Remove logging kmalloc failures. v3: - Use devm_add_action_or_reset() in a correct place. - Wording. v2: - Use devm_add_action_or_reset() instead of remove() callback to avoid race. drivers/iio/light/cm32181.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c index b1674a5bfa368..d4a34a3bf00d9 100644 --- a/drivers/iio/light/cm32181.c +++ b/drivers/iio/light/cm32181.c @@ -429,6 +429,14 @@ static const struct iio_info cm32181_info = { .attrs = &cm32181_attribute_group, }; +static void cm32181_unregister_dummy_client(void *data) +{ + struct i2c_client *client = data; + + /* Unregister the dummy client */ + i2c_unregister_device(client); +} + static int cm32181_probe(struct i2c_client *client) { struct device *dev = &client->dev; @@ -460,6 +468,10 @@ static int cm32181_probe(struct i2c_client *client) client = i2c_acpi_new_device(dev, 1, &board_info); if (IS_ERR(client)) return PTR_ERR(client); + + ret = devm_add_action_or_reset(dev, cm32181_unregister_dummy_client, client); + if (ret) + return ret; } cm32181 = iio_priv(indio_dev);