From patchwork Thu Feb 23 01:41:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 60745 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp56770wrd; Wed, 22 Feb 2023 17:50:03 -0800 (PST) X-Google-Smtp-Source: AK7set+vtNA5TYOY1pxvUzcD+H3sDDV/BrP8EXG+hirOGgPVpRhS2ouXn8mHZ/tUWUlo3Qza/x8v X-Received: by 2002:a17:907:8a1c:b0:8e6:266c:d195 with SMTP id sc28-20020a1709078a1c00b008e6266cd195mr6895134ejc.38.1677117003336; Wed, 22 Feb 2023 17:50:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677117003; cv=none; d=google.com; s=arc-20160816; b=OArHOcp0pI4GvfrbLin/8VNW7S7jVm/8dTorpzNyf/3ZOQbgURTCKzkhDUotvOEjsi GbZNvQj7gFT3aLWALLVTXjctS/oMsqPYKrZgfnXdlubQ8rShLAiQRA/6vg4jYoEDixz4 VQD5YGUox1pZMlYURqr5zcRIpIac/toTx2tPa3EA/fBzEU33euQjSdnftxDISRBnfKmJ ukHe7hT+lrWSEaAj9d1YRQOn8aVt4iXuhDnfYfW2H3VQ2njhlfBHxwwwpH8OsGUe7aZm YrfSQDqeJPlEs0tIM+fUKFZ+6RvIEpZ9llaH+vSTWcp3dHuVl1rOfNP/wr/rFyAxyJta zSZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=4Y/vUgi+zlUePCC78E4DGLn2+CH9ssQFh6vEdznAP9w=; b=qdV8yBf4VrHYCh3XrE0UnoKThQXQE5S0aLKYRIwPcG2iSB58DCnbXx5RMOgoVENdNc rzap4PCQpyna01obWeFnACsNO7cQLNnnrvPpnEHG8LrmOQEiLpmxfXHEfL9EBOwLE53n aZsd/bvTiRgPPB+JU9M8UkDuBBHGZHSzNNcwcfzLIUHaH32HR2wPGiPkl1AX3F/di86/ 9oUlcHm00zL/EY+sdzCwC/cyTmBxc1Ni0bJgPTl1lwzXjeTjRinMrYfgTOvePv8vBj/c ZyZVdAhGO3RAxD7sh2hzrS56pVgnLNgU6m2mbGKFnPyqAjjY7Vh68NedlGrHv8rpGksO MX6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=LZPK0iLJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cp17-20020a17090793d100b008c5fe055449si14190692ejc.754.2023.02.22.17.49.41; Wed, 22 Feb 2023 17:50:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=LZPK0iLJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229611AbjBWBl5 (ORCPT + 99 others); Wed, 22 Feb 2023 20:41:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjBWBl4 (ORCPT ); Wed, 22 Feb 2023 20:41:56 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4B473BD87 for ; Wed, 22 Feb 2023 17:41:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=4Y/vUgi+zlUePCC78E4DGLn2+CH9ssQFh6vEdznAP9w=; b=LZPK0iLJzCjnUGWbq8qCOx/93y LjP0q1Pvaf5mPsdHgFYtqgrVhncPKPbprYF2m04fLaAjC+IJ7MRaedgo/awUyMcHVCQ+kjAtbN8a2 tr3T56MJikybyESRgRxDAOp/W+s+X0o2aRrYwn6f94VmWEQ1DPMGpRslDyQeDA+3dcnouvXOjRrGO Og91Oj5NpfUTq4NGJQCr+2CNllFw9YLWTQyWU644YtdxlhW2LjkCJ9hDURofNTIHwEohG+W6CFWOI EPf1U+ZZAZKMhFzpEQPPYgyaP0IEyFkF6xlpDR9180sPojTZRINoy1XENEgCWTu2RcESrFmo+ZyBV 6ugW3KMg==; Received: from [2601:1c2:980:9ec0::df2f] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pV0cK-00EgHt-Ln; Thu, 23 Feb 2023 01:41:52 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Benjamin Herrenschmidt , Paul Mackerras , Elimar Riesebieter , Michael Ellerman , linuxppc-dev@lists.ozlabs.org Subject: [PATCH] macintosh: via-pmu-led: ********************************* Date: Wed, 22 Feb 2023 17:41:51 -0800 Message-Id: <20230223014151.19270-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758584639316520033?= X-GMAIL-MSGID: =?utf-8?q?1758584639316520033?= LEDS_TRIGGER_DISK depends on ATA, so selecting LEDS_TRIGGER_DISK when ATA is not set/enabled causes a Kconfig warning: WARNING: unmet direct dependencies detected for LEDS_TRIGGER_DISK Depends on [n]: NEW_LEDS [=y] && LEDS_TRIGGERS [=y] && ATA [=n] Selected by [y]: - ADB_PMU_LED_DISK [=y] && MACINTOSH_DRIVERS [=y] && ADB_PMU_LED [=y] && LEDS_CLASS [=y] Fix this by making ADB_PMU_LED_DISK depend on ATA. Seen on both PPC32 and PPC64. Fixes: 0e865a80c135 ("macintosh: Remove dependency on IDE_GD_ATA if ADB_PMU_LED_DISK is selected") Signed-off-by: Randy Dunlap Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Elimar Riesebieter Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org --- drivers/macintosh/Kconfig | 1 + 1 file changed, 1 insertion(+) diff -- a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig --- a/drivers/macintosh/Kconfig +++ b/drivers/macintosh/Kconfig @@ -86,6 +86,7 @@ config ADB_PMU_LED config ADB_PMU_LED_DISK bool "Use front LED as DISK LED by default" + depends on ATA depends on ADB_PMU_LED depends on LEDS_CLASS select LEDS_TRIGGERS