From patchwork Thu Feb 23 01:42:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 60743 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp56196wrd; Wed, 22 Feb 2023 17:48:12 -0800 (PST) X-Google-Smtp-Source: AK7set/JKpXqFseAsUuHwblNml4QlBYsWezNoTUw5yLHU5hNfduu9BDBFBIBMuzB/dZXQpa2pNfA X-Received: by 2002:a17:906:ff45:b0:8b2:a42:5c3a with SMTP id zo5-20020a170906ff4500b008b20a425c3amr17451673ejb.70.1677116892187; Wed, 22 Feb 2023 17:48:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677116892; cv=none; d=google.com; s=arc-20160816; b=tvx+8oW7bZNgEsf4e/jPKaYG95OEXoR2/qxnbZPjfK6yo8YnF1U6thdXFjacybGn1H DMuUvwxN2cFb1HRZBs4HGlQNHAMOcBlH5Bu9dxu2xkZMHy3ue8f9HAe/g3ZN6oCW4e7d Z+IdDIbtjj1FroqZvxFwBxLYVoJBnMhoCPZ1l1TLYAYuaf1+VJEYUeh1It9h1+H4gpWQ Ny9dbSswdlsBs5u0WG0TjUOplrNWAthzhCKVvSoKlnrfPHkZJ1VdJwUu8KT48Z3hdRCj jRYX/k9eEuynhVwA3V6qy6zf7fGNqcpD5pbCyPT3T9qOXVb/rKFgTwb9shAMv1FHktDh U7aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=exZkU1nmxYgHYb5MmlRanTFni1d8EpMHC+AWVfIzNqg=; b=W+BFHt0LmNQbKqM16OqkH/Zs0r0+kPgHaypmJlkj6iZihKzdaC1F0U0JjR7W83MdD3 QR8IJifPBXvt1YSnBqqqE6wU0eHUIFKlDwg8wmh/7ogMBdGMQL4oceEYgdvGDLz02S/+ rl8tTo6yuyYb6pUWu6ikp8SurLQ11gqbcq5iQOJPeyTEqNSgtZnSkZUUL/IJ+yqGlw8b FpcOLFS6VG9fNePtIqx70PbHQa5dgc5JKsPT9sETYHyiKEGb1dJrB/IHvbKi/+YQYMl3 9Pd4Z4mULi75iw6IDySNFn3WEoppC/XlgTyyGImsMPNnOqCloW6AQU7apajByPYKj9uj MDdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=X+b06J0w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e8-20020a170906748800b008db13af5641si10075985ejl.261.2023.02.22.17.47.48; Wed, 22 Feb 2023 17:48:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=X+b06J0w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231214AbjBWBmx (ORCPT + 99 others); Wed, 22 Feb 2023 20:42:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232573AbjBWBmu (ORCPT ); Wed, 22 Feb 2023 20:42:50 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 736FA42BC6 for ; Wed, 22 Feb 2023 17:42:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=exZkU1nmxYgHYb5MmlRanTFni1d8EpMHC+AWVfIzNqg=; b=X+b06J0wQjj56Rv4JfRdtWJKHI V2RIN8Du1k7E4u/tpy4IevN50y4MFslnFqOQQuTinQNSoIcDMaMqHtKcCGeplfE/GO72LdO29q1yz /UtQJu5EOaGkfZyVeaaS6YGWSDxGGEqmFxsS3ZhPML/2hDkKrLpCC13q2QZ9eli01A4LuWHLgKMDQ XBSgSH+HqM0h/njL3TJEN8Wf5QRMjCSJVl+ZDXOS+0bfEgpHNWgsJr4ZSw74vp9bk2PfLOAzj+UJX kEliChkDrPklkR9JKM6D4o+GMxsL0mh/Sp33CdZHNr1NynhrzHpYUkcmNb/1gXMqvO6KejPF9M+OZ ghQtvIVA==; Received: from [2601:1c2:980:9ec0::df2f] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pV0d7-00EgSa-Vi; Thu, 23 Feb 2023 01:42:42 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Benjamin Herrenschmidt , Paul Mackerras , Elimar Riesebieter , Michael Ellerman , linuxppc-dev@lists.ozlabs.org Subject: [PATCH v2] macintosh: via-pmu-led: requires ATA to be set Date: Wed, 22 Feb 2023 17:42:41 -0800 Message-Id: <20230223014241.20878-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758584522376716680?= X-GMAIL-MSGID: =?utf-8?q?1758584522376716680?= LEDS_TRIGGER_DISK depends on ATA, so selecting LEDS_TRIGGER_DISK when ATA is not set/enabled causes a Kconfig warning: WARNING: unmet direct dependencies detected for LEDS_TRIGGER_DISK Depends on [n]: NEW_LEDS [=y] && LEDS_TRIGGERS [=y] && ATA [=n] Selected by [y]: - ADB_PMU_LED_DISK [=y] && MACINTOSH_DRIVERS [=y] && ADB_PMU_LED [=y] && LEDS_CLASS [=y] Fix this by making ADB_PMU_LED_DISK depend on ATA. Seen on both PPC32 and PPC64. Fixes: 0e865a80c135 ("macintosh: Remove dependency on IDE_GD_ATA if ADB_PMU_LED_DISK is selected") Signed-off-by: Randy Dunlap Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Elimar Riesebieter Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org --- v2: add a complete Subject: drivers/macintosh/Kconfig | 1 + 1 file changed, 1 insertion(+) diff -- a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig --- a/drivers/macintosh/Kconfig +++ b/drivers/macintosh/Kconfig @@ -86,6 +86,7 @@ config ADB_PMU_LED config ADB_PMU_LED_DISK bool "Use front LED as DISK LED by default" + depends on ATA depends on ADB_PMU_LED depends on LEDS_CLASS select LEDS_TRIGGERS