From patchwork Wed Feb 22 15:56:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 60591 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp664037wrd; Wed, 22 Feb 2023 08:13:01 -0800 (PST) X-Google-Smtp-Source: AK7set+V+mpkkH+cYhncqTj4tm028fsowyDE63/oPLof+NRtgqUNk07fReLJJpQW3JFssEDclWDP X-Received: by 2002:a50:ee1a:0:b0:4ad:7c6c:5386 with SMTP id g26-20020a50ee1a000000b004ad7c6c5386mr7626572eds.30.1677082381614; Wed, 22 Feb 2023 08:13:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677082381; cv=none; d=google.com; s=arc-20160816; b=Fr2tMjlqfUANSabA6Tqg9Yg/Stc/dcSoEXd78vc+46iI03rq6F/qM2j5Vx1LlciQRX 5rLLRjGng5kT+PtlzubZCG5kFPV+dRju7uOmfsGca+Fjc1csNMxEwNcfc+cSsw4MNSFZ ukP9K+HgN9cJ7ApJ3Ar4nOr7tQ/9QSf64WLhxHP7U9ZMgFGIJXV8ErS5HoEkIdA6CBze UYMqDSXsbGDxlRP+QGTsNZMH8m6LDDHfsw4TWFVk9Uuqu4Fl2jM7qqf9T96sFxflK0NM NpcPV6feyhXZLQYJRc/YBwnJTAiVD0Aau/egISYbv691duCF/1lhu6JrzSTPFJLNoAC5 pv7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=GScpUkVmR1trk5NKo/KgCoCbwLxTQg040xij2n32R0k=; b=CC1QmuD9HfskIYPJGKp3rRSxKFpFHrwyXORSwGTSamd+rkFb3bmJodByVbrJOltLKn 3nPJJye9UiZ8BvoCMASehOssqJT3Voyl9HHwYL72LDz1RZ7Y/H7qrLWTKIpPwn2HgzBl aReMZCZYQJQL0mw9CZjjPM2O1SKM0JLFfmBxg+xVUwQvapfUKwZhJe2IR/29mZ0lXtbV DYeF3NcwTe0xmaCX90CmnFkIcjSKDYAaxxTSMstAUwhJOLQo+mBUPdDlR8vHIpNDNIlh KTC0HWZnIkkAP+Qgyi4zvrxs4G+0IMAWAP3d/gsJ3PavtJCfvGDUq8m5Jm1P4BFBrSC1 AkKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HyhSGnir; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v20-20020aa7d654000000b004ab16936f7bsi8895243edr.405.2023.02.22.08.12.38; Wed, 22 Feb 2023 08:13:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HyhSGnir; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232252AbjBVP5q (ORCPT + 99 others); Wed, 22 Feb 2023 10:57:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231263AbjBVP5o (ORCPT ); Wed, 22 Feb 2023 10:57:44 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E000D3B87B for ; Wed, 22 Feb 2023 07:56:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677081418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=GScpUkVmR1trk5NKo/KgCoCbwLxTQg040xij2n32R0k=; b=HyhSGnircdImN9PIP7NHmo0XSpWLvwccFI+a9ucaSl5Jmx6Igibb60hruPwzgPDZoW6BEl fbtMjOOu9u8bRCRHktxN39QQPh2XEAO6D+Lz7jEjZ72697DtybcznfoKrPAgNOypt3BD4l xpvkpb6u6MU7lnnSpv80N+jZt5dSygE= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-240-DGTuPN3HPXGUyRLmYJeb_Q-1; Wed, 22 Feb 2023 10:56:57 -0500 X-MC-Unique: DGTuPN3HPXGUyRLmYJeb_Q-1 Received: by mail-qk1-f200.google.com with SMTP id m25-20020ae9e019000000b007421ddd945eso2693496qkk.6 for ; Wed, 22 Feb 2023 07:56:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GScpUkVmR1trk5NKo/KgCoCbwLxTQg040xij2n32R0k=; b=JzyIFBt2mVcSBDNUcvc3MLkc2gGFFDJxWoyNt0mu/ZOu4NESY0P8VoWAnO6jeOnba0 JdNi/fie/rfG1NbeQqofuQ0fOShmZz3yeUpMi59W5e3/j1+5rsUUiQ7armh6XOeKTEya HYkr3kpm85SaHbUU0p6yMo+IlSBmEPuEG7UCNXz07HOkomz7nGml4134WbWsJ0MvOMSS mOUUHEahMzCxpwXg7GIsICkhlF5p3A1WvBM79OkeQFRhYSgYDpG5Xc6We2ZQSNOM7dIk Eo5NWCYbBvNoDHCUXgsP+xLxHAgIshdKlbtMBe7fsAgOZfHmaHxi3gwLWPa2FAf6oShJ RuuA== X-Gm-Message-State: AO0yUKVR/zOYefgK0MCQeTiqRfK2e/dE3F9I3BEtawbpACgQn33706mp GBnenXQtlKyuAPqelIP7/t474l7BkBFC2J0AL4LpPfDlmcRT8ivqCoBKJYP2tP5E7XmRSkKxCKu cXHQ6xRUnknWoYxSBJa1kjaKpH54BPw== X-Received: by 2002:ad4:5aa7:0:b0:53c:9354:9721 with SMTP id u7-20020ad45aa7000000b0053c93549721mr17269885qvg.21.1677081416440; Wed, 22 Feb 2023 07:56:56 -0800 (PST) X-Received: by 2002:ad4:5aa7:0:b0:53c:9354:9721 with SMTP id u7-20020ad45aa7000000b0053c93549721mr17269856qvg.21.1677081416191; Wed, 22 Feb 2023 07:56:56 -0800 (PST) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id t78-20020a37aa51000000b006f9f3c0c63csm589967qke.32.2023.02.22.07.56.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:56:55 -0800 (PST) From: Tom Rix To: robdclark@gmail.com, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, sean@poorly.run, airlied@gmail.com, daniel@ffwll.ch, nathan@kernel.org, ndesaulniers@google.com, tzimmermann@suse.de, javierm@redhat.com Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Tom Rix Subject: [PATCH] drm/msm: return early when allocating fbdev fails Date: Wed, 22 Feb 2023 10:56:49 -0500 Message-Id: <20230222155649.2001467-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758548335242850998?= X-GMAIL-MSGID: =?utf-8?q?1758548335242850998?= building with clang and W=1 reports drivers/gpu/drm/msm/msm_fbdev.c:144:6: error: variable 'helper' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] if (!fbdev) ^~~~~~ helper is only initialized after fbdev succeeds, so is in a garbage state at the fail: label. There is nothing to unwinded if fbdev alloaction fails, return NULL. Fixes: 3fb1f62f80a1 ("drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini()") Signed-off-by: Tom Rix --- drivers/gpu/drm/msm/msm_fbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c index c804e5ba682a..c1356aff87da 100644 --- a/drivers/gpu/drm/msm/msm_fbdev.c +++ b/drivers/gpu/drm/msm/msm_fbdev.c @@ -142,7 +142,7 @@ struct drm_fb_helper *msm_fbdev_init(struct drm_device *dev) fbdev = kzalloc(sizeof(*fbdev), GFP_KERNEL); if (!fbdev) - goto fail; + return NULL; helper = &fbdev->base;