From patchwork Wed Feb 22 15:59:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kunihiko Hayashi X-Patchwork-Id: 60590 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp663975wrd; Wed, 22 Feb 2023 08:12:55 -0800 (PST) X-Google-Smtp-Source: AK7set+dJQvrFr7Hsh69mxpq1Hlyy5DYswWbE7uGv1kJsxagG5t8TYz7RHD/9zig58x61uTIWNbV X-Received: by 2002:a17:90b:4f8a:b0:233:bc78:b48f with SMTP id qe10-20020a17090b4f8a00b00233bc78b48fmr10604430pjb.3.1677082374950; Wed, 22 Feb 2023 08:12:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677082374; cv=none; d=google.com; s=arc-20160816; b=eiCL3YKAHpdUxb8mQKgHpikbtjycjXtDOXGdO/riMugPssr1MemVyPZT5qGLU+3kLs h8Ps+I9SJV2xwkIYRLr9qa5yTEi9WMnXp8J2j819PEqiClqVJOo0t/fhFvFrsDyIN0VV xWBcf4uegygjhUqia+Qh35KBXwA9DNCcZ/Rd0sR0+2IUD+2+LoEAedxEPh0OQ8QlTR41 EssPSaSnTWXkqf6cyKQwuTNvs8a04eId4+Uc0XOBqGtb2nY87R0OdaR5QFdyLsQAyZtr OIBNBXc/Pc+u8bfctm2tkbC1LIlQMyiQtVyzrBbeZICddBguV+RbawcSAlAh8qEsbmY0 TYaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=aMNjFpP4OOx9H2Fh/7ZZHgRhaZcENrZJ1HPLOR32bNk=; b=XvDDmcIZB5G7KBI0v3K3Gw/5+hDREUt3xGXlYeSss0lKGGIRFGZliEQHJzdRa20igj BMyfR0iZGrU3n9Y1y0IXLEZYWY0RHOwLcTVLpA/kz8C2eMXt8cMAHjPGZVqDnvpKQBEt 9Qinm7geiBq30M+iU8nj74IMctMcqU8GJe+hNuLWt6L5Gi75DwyW4A+NUi0KZARiAacb XklKqKGsVoaKet16IYSXGEFtXQ3qJK6cgWwnLSZtZZq+CCfFodXpHFmh90Dqn/cj5xTF T/Z2vVnBVkh1G7EAt3tum2SJpbt5+OwtFqvYvN0G/C+fm0/M1b55uWBXP05g1kQLfpVA g+Qw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h191-20020a6383c8000000b004fc23f82c7csi19934825pge.191.2023.02.22.08.12.41; Wed, 22 Feb 2023 08:12:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232070AbjBVP7V (ORCPT + 99 others); Wed, 22 Feb 2023 10:59:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230434AbjBVP7T (ORCPT ); Wed, 22 Feb 2023 10:59:19 -0500 Received: from mx.socionext.com (mx.socionext.com [202.248.49.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8A1FF21950; Wed, 22 Feb 2023 07:59:17 -0800 (PST) Received: from unknown (HELO iyokan2-ex.css.socionext.com) ([172.31.9.54]) by mx.socionext.com with ESMTP; 23 Feb 2023 00:59:16 +0900 Received: from mail.mfilter.local (mail-arc02.css.socionext.com [10.213.46.40]) by iyokan2-ex.css.socionext.com (Postfix) with ESMTP id C853A2058B4F; Thu, 23 Feb 2023 00:59:16 +0900 (JST) Received: from kinkan2.css.socionext.com ([172.31.9.51]) by m-FILTER with ESMTP; Thu, 23 Feb 2023 00:59:16 +0900 Received: from plum.e01.socionext.com (unknown [10.212.243.119]) by kinkan2.css.socionext.com (Postfix) with ESMTP id 03D6DC34A; Thu, 23 Feb 2023 00:59:16 +0900 (JST) From: Kunihiko Hayashi To: Damien Le Moal , Rob Herring , Krzysztof Kozlowski , Hans de Goede , Jens Axboe Cc: linux-ide@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Kunihiko Hayashi Subject: [PATCH v4] dt-bindings: ata: Add UniPhier controller binding Date: Thu, 23 Feb 2023 00:59:06 +0900 Message-Id: <20230222155906.19403-1-hayashi.kunihiko@socionext.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758328743600843626?= X-GMAIL-MSGID: =?utf-8?q?1758548328244863600?= Add UniPhier SATA controller compatible string to the platform binding. This controller needs three reset controls for Pro4 SoC, or two reset controls for PXs2 and PXs3 SoCs. Signed-off-by: Kunihiko Hayashi Reviewed-by: Krzysztof Kozlowski --- .../bindings/ata/ahci-platform.yaml | 49 +++++++++++++++++-- 1 file changed, 45 insertions(+), 4 deletions(-) Changes since v3: - Fix the position of resets and allOf properties - Add reset descriptions - Separate if conditions for two resets, three resets, and others Changes since v2: - Add compatible strings to select property - Add minItems and change maxItems for resets - Move condition schema under allOf property - Change resets to "required" for uniphier-*-ahci Changes since v1: - Restrict resets property changes with compatible strings - Fix maxItems from two to three diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.yaml b/Documentation/devicetree/bindings/ata/ahci-platform.yaml index 7dc2a2e8f598..358617115bb8 100644 --- a/Documentation/devicetree/bindings/ata/ahci-platform.yaml +++ b/Documentation/devicetree/bindings/ata/ahci-platform.yaml @@ -30,12 +30,12 @@ select: - marvell,armada-3700-ahci - marvell,armada-8k-ahci - marvell,berlin2q-ahci + - socionext,uniphier-pro4-ahci + - socionext,uniphier-pxs2-ahci + - socionext,uniphier-pxs3-ahci required: - compatible -allOf: - - $ref: "ahci-common.yaml#" - properties: compatible: oneOf: @@ -45,6 +45,9 @@ properties: - marvell,armada-8k-ahci - marvell,berlin2-ahci - marvell,berlin2q-ahci + - socionext,uniphier-pro4-ahci + - socionext,uniphier-pxs2-ahci + - socionext,uniphier-pxs3-ahci - const: generic-ahci - enum: - cavium,octeon-7130-ahci @@ -74,7 +77,8 @@ properties: maxItems: 1 resets: - maxItems: 1 + minItems: 1 + maxItems: 3 patternProperties: "^sata-port@[0-9a-f]+$": @@ -91,6 +95,43 @@ required: - reg - interrupts +allOf: + - $ref: ahci-common.yaml# + - if: + properties: + compatible: + contains: + const: socionext,uniphier-pro4-ahci + then: + properties: + resets: + items: + - description: reset line for the parent + - description: reset line for the glue logic + - description: reset line for the controller + required: + - resets + else: + if: + properties: + compatible: + contains: + enum: + - socionext,uniphier-pxs2-ahci + - socionext,uniphier-pxs3-ahci + then: + properties: + resets: + items: + - description: reset for the glue logic + - description: reset for the controller + required: + - resets + else: + properties: + resets: + maxItems: 1 + unevaluatedProperties: false examples: