From patchwork Wed Feb 22 02:29:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yang Li X-Patchwork-Id: 60305 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp346456wrd; Tue, 21 Feb 2023 18:42:54 -0800 (PST) X-Google-Smtp-Source: AK7set8rU9BlOGAeN8yLlJzsxDl/97nOrcZthdg3CPNW7ZT2++1KVmoDqoteGNPr/Z7vBDr4jJn+ X-Received: by 2002:a62:174a:0:b0:5a8:bd14:d6f1 with SMTP id 71-20020a62174a000000b005a8bd14d6f1mr7555791pfx.7.1677033774097; Tue, 21 Feb 2023 18:42:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677033774; cv=none; d=google.com; s=arc-20160816; b=PZHi7/SM5mbHF0X11iSS4TI3heQ0FZ4SWt3RSic6KiI29c6mZjm+JUCvU1n4xV0fMa P6xNRvoaDT+Uan/7UmN5M37yx9TaIS8zSjcxCLcAwGCSo+56mKqaXhLghevygVBkcZ+U FGNIZf7gOnnJ+OwH2lPliAsnAzdZYLUwiWwbokjdMr0MvVYN/Ym76nmr03YOTFbkPA82 LPMzW756/ykvk34dsUVfPqYDHeptM5La1sZzPtBT2oi7PDr3naLeHWBBucBtJYue3hre rA/l38DrAwD9129cpZIQ58aD+QSx97GYgd1dbNtMmhpPe1gQqRhybZPFHVdbQtUsnAZ6 3xlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=osdebyAKL72OerK1daT+ejk1J72EWsdB8PC+bToKFGs=; b=J319A0xR+3V+yWd1PHcOqylLgKyPD5MsqgGOdWT+6on1TgCaUBjLs38bJyiuSYlMm1 l7DhutjXfKT2I78K1npqku/kOlZdASYFmIanV9awJ8BRk30/wkuFN0BxpLEzlF7HvTjT RG13D/5cZN4kxwAlc3J08A5Ta3V+r0X55DwKNkUnQqTfEyusuUrDwH71S/TSddbRSMz1 uLXEGdfVUNHALJn6iX5nYjuOV2akmgEH+ymN8hfw3fwn9pFTNmieFNkJ4I202hjsvnwz J8Dlwi7KyFuihUTrdhs4n7kyDp7qs+0HltsadQyQQuEDXN47htqJvUUk9CD/pBp3/HWE UKTA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a9-20020a654189000000b004fac6261103si8818546pgq.843.2023.02.21.18.42.41; Tue, 21 Feb 2023 18:42:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230384AbjBVC3x (ORCPT + 99 others); Tue, 21 Feb 2023 21:29:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbjBVC3v (ORCPT ); Tue, 21 Feb 2023 21:29:51 -0500 Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AC332CC5A; Tue, 21 Feb 2023 18:29:49 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0VcEPLbg_1677032985; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0VcEPLbg_1677032985) by smtp.aliyun-inc.com; Wed, 22 Feb 2023 10:29:46 +0800 From: Yang Li To: kuba@kernel.org Cc: davem@davemloft.net, saeedm@nvidia.com, leon@kernel.org, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: [PATCH -next] net/mlx5: Remove NULL check before dev_{put, hold} Date: Wed, 22 Feb 2023 10:29:44 +0800 Message-Id: <20230222022944.48450-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758497366607446226?= X-GMAIL-MSGID: =?utf-8?q?1758497366607446226?= The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there is no need to check before using dev_{put, hold}, remove it to silence the warning： ./drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c:714:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed. Reported-by: Abaci Robot Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4174 Signed-off-by: Yang Li --- drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c index e24b46953542..8f7452dc00ee 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c @@ -710,8 +710,7 @@ void mlx5e_rep_tc_receive(struct mlx5_cqe64 *cqe, struct mlx5e_rq *rq, else napi_gro_receive(rq->cq.napi, skb); - if (tc_priv.fwd_dev) - dev_put(tc_priv.fwd_dev); + dev_put(tc_priv.fwd_dev); return;