From patchwork Tue Feb 21 15:37:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 60136 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp78142wrd; Tue, 21 Feb 2023 07:42:19 -0800 (PST) X-Google-Smtp-Source: AK7set+ec+dfOLQ91U0Eoa/VMnbleMgaT+hgylo8R8uIOAR2ZB7IJplsD364B5Qp4wxyhYr74mgW X-Received: by 2002:a17:90b:3504:b0:233:f09c:82c9 with SMTP id ls4-20020a17090b350400b00233f09c82c9mr7803894pjb.20.1676994139710; Tue, 21 Feb 2023 07:42:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676994139; cv=none; d=google.com; s=arc-20160816; b=ulVvND0hlMDhlY6DY+kcBioy92EiB1Fx/XtBvXr4rHq0frfr9xdam8GhK5zU9+NJBp d01KWBe7veEc5JtQmlfMexDnGWKESufJOYKd3BwL0CMjrZ5HTWZK2IGXk2x++lT2P3j0 11UKZu4TDcmzHHTdmoM7p2SPXItYxHGl3SQVR6d7Tceeqiofe91UqIH00fr3pthPHsWZ AvJgaeHVPP79aDGV6vtaIxz3Muh+roD/7gMMqaCJtrp7xbvVQgUFmio9K/z4OE1zWXEa XLEgc7ImZlerIoPiYoZ6LzK65EFn2B0UlmyKWxGmkjFGSCmXj0wBD8uxewNJk+Htdr8G 4g1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=U1/arpsFTNupPbknD64llFhKUm/wlNgsw1KbnSZuMME=; b=LV6gWuTSDjfg5+nPmSG65l+sVYOTUW1KZlw46Xwa6On3s3eXkWTMMY9E/8hPIm+VKy SeY6RksEB5MBfLEVdcfThWCzgcaCWv5IWrIw3ZTIdb3aU+b1cliNr8r6u9gFcv69kljN NY/FQuswdP9RfC0bxL7xP28jlFObjyH08aG93YMT9E/IM6bTu4F8hMyM/4EyVCMuOBIO RimSKLr43vUKXRzkg5hIf4R9oYsCwbBAzM1cvBB28pXyFoAWOKS3pyoivylufbD0d01J QfxIDSOkn+2b4gvGdNBaRuMp0XZE4quyVhSGUjYGY0BiFJgzMytPeRvkbWmp08oRRDH6 WtUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=IVEXs0YC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x13-20020a17090aca0d00b0022c2f9ab15esi3806032pjt.5.2023.02.21.07.42.06; Tue, 21 Feb 2023 07:42:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=IVEXs0YC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234226AbjBUPhv (ORCPT + 99 others); Tue, 21 Feb 2023 10:37:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233828AbjBUPhs (ORCPT ); Tue, 21 Feb 2023 10:37:48 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 436406A43; Tue, 21 Feb 2023 07:37:47 -0800 (PST) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id EA54066021CD; Tue, 21 Feb 2023 15:37:44 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676993865; bh=DZyb8vw6qbtsYIBlP4pzm++AodTcvCv6AvAETopyIuw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IVEXs0YCZUHyAapvJaL7aVXlMFv/vsVn5oMxuyZIvMl/T5zqxgfCYeHhYmO2zTn4P x4O/Ligz1ltjjWbtSD3MfYn5s31rg+XjE7bPD7MLuUfU9k8O13YchbjQq45jh21ZTa LztdlXygiNltijjIgzXHYdvOKIqU4J3+ZDe9zG5MHj6IG9T8YkD133VVKBabn3XU1l hyukQs3LB4LsL5x/o2e0YoZs7FZcnA8w0Pa3VvR0uv1jMx2E3viudreCGS26pvRoxw /JKxEK5nWPMf4Pz/k+y9uqFXsjOtNbmHoAA4cxN9SHYaLddrBDO9o6btnNztpvt/me CqXQtOjT+NW2Q== From: AngeloGioacchino Del Regno To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno Subject: [PATCH v2 01/10] dt-bindings: gpu: mali-bifrost: Add power-domain-names to base schema Date: Tue, 21 Feb 2023 16:37:31 +0100 Message-Id: <20230221153740.1620529-2-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230221153740.1620529-1-angelogioacchino.delregno@collabora.com> References: <20230221153740.1620529-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758455807133960349?= X-GMAIL-MSGID: =?utf-8?q?1758455807133960349?= From: Chen-Yu Tsai In commit a7a596cd3115 ("dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183"), "power-domain-names" was added to the mt8183-mali sub-schema, but was not added to the base mali-bifrost schema. Because validation happens for the base schema and any sub-schemas separately, this causes errors to be emitted when validating the MT8183 device trees. Add power-domain-names to the base schema to silence the error. Fixes: a7a596cd3115 ("dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183") Signed-off-by: Chen-Yu Tsai Signed-off-by: AngeloGioacchino Del Regno --- Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml index 78964c140b46..02699d389be1 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml @@ -65,6 +65,8 @@ properties: minItems: 1 maxItems: 3 + power-domain-names: true + resets: minItems: 1 maxItems: 3 @@ -166,6 +168,7 @@ allOf: properties: power-domains: maxItems: 1 + power-domain-names: false sram-supply: false - if: properties: From patchwork Tue Feb 21 15:37:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 60139 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp78592wrd; Tue, 21 Feb 2023 07:43:22 -0800 (PST) X-Google-Smtp-Source: AK7set8j6tK5OS2rPRSnsP9xdSQAFItvH1pQYtHcrgLG7ebBetfLNEcCReEndIqz+92VnA6WR1G3 X-Received: by 2002:aa7:9e1c:0:b0:5d2:1d72:3b31 with SMTP id y28-20020aa79e1c000000b005d21d723b31mr767769pfq.2.1676994202390; Tue, 21 Feb 2023 07:43:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676994202; cv=none; d=google.com; s=arc-20160816; b=KgtZ+aUSQ1y6NReoue5FoaWSIlQ02rZx6jAQ7LrhQU7qecxCl/k1rJ4J1u5f0ZWxCy XWZ3U3fXDfQFawizP+qRvuSno20xLHC9em9F23YAl/gpbhdq/s3o4O8BpFBE+hvfiuCy 2DkhuxUDlIjh0RW/FUVlpu8WQ6BOoHrrlK3wb+LZ5yb1xj4/5mxb4niYTmW1oePHGkQx 1JxiweMRTagNf9gZTNcx3ctC3DxO5bZw+ADoDw9C8ddDgEsRiI5BPmdZc8J+ZXIA7vju NEngQBsK+VJVJVbqojNc4fldcKF7lOmzak71T/I36Buk5XR2JZ5MfdCVkKFsZKsii+vz oa+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Ux2XCuCi78DmCxhmj2ukCazKOuQq87GMBp4lF8TlRzI=; b=VJFxn+JJz9btzrctRFyT3kHhONi83VZyphwnMsGLbqkr4bn8I3QQlRdTZ3G3R836oM e+Xfdizs8YQUnnJPmn+cgkLJsqiajNyrCoYf2TvETtLoX8Y49y+T7zab2nfPt39Xhw7G XUJ8y0PsJPlbcxYxPIMlk+z2sM1Vt2WwTgkz11L+GYJjx9gV5Gb25ZuQTbSLo/z4qVFo gnJ2fSZrup40WZpCJGpKPSb4KTh4M3cs3SBf4SZITyZXi+E8fpJvwa+m4pjKlok6Rv+6 Dob8E/lvRE3FaYAHrxCxGizkUOtGgOKzvkSRoBieosRQW0uGh9Lf73HsKn/OGpPL4amx tzbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=fruQtiaC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k78-20020a628451000000b005a8c6db7e78si16714063pfd.342.2023.02.21.07.43.09; Tue, 21 Feb 2023 07:43:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=fruQtiaC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234578AbjBUPhy (ORCPT + 99 others); Tue, 21 Feb 2023 10:37:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234527AbjBUPht (ORCPT ); Tue, 21 Feb 2023 10:37:49 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C36832A9B7; Tue, 21 Feb 2023 07:37:47 -0800 (PST) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id CDB4166021CE; Tue, 21 Feb 2023 15:37:45 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676993866; bh=dYSlQLXMyB6AD5hy1+lsca8EHSPk5mj7QuNmBK+ZBoM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fruQtiaCFMTjf65J3alfeo62CbcoagqQqYvW554EK9LoXS9Jq6sdepSifhbe9eSCT IAXo3KLtInJZRV1NQWbBeXKRWC0mWHT07qmVMNNv6WYiU4A7yrnesuAIc6oOhgmPM6 SbHmDPIjvKdhhEBGdJR3G35/PACkTxb/MnHm8twuGJhNia6fdirTD/65IEd3kcVju9 SxUTm+McN27gp5Z6FKgX9+DY+S6ra/n7qrN3gKTOZwWD9GNyTEObNyl/VRwK2VSDCy O7VDCYayuQXWe/ABLKOnd3dhnuiYB/IR4RsdrNAYvLgGNOxXPYN/P6PqpKBPVvlInt R6TyvdcMlrwzg== From: AngeloGioacchino Del Regno To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno Subject: [PATCH v2 02/10] dt-bindings: gpu: mali-bifrost: Split out MediaTek power-domains variation Date: Tue, 21 Feb 2023 16:37:32 +0100 Message-Id: <20230221153740.1620529-3-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230221153740.1620529-1-angelogioacchino.delregno@collabora.com> References: <20230221153740.1620529-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758455872480034998?= X-GMAIL-MSGID: =?utf-8?q?1758455872480034998?= In preparation for adding new bindings for new MediaTek SoCs, split out the power-domain-names and power-domainsvariation from the `else` in the current mediatek,mt8183-mali conditional. The sram-supply part is left in place to be disallowed for anything that is not compatible with "mediatek,mt8183-mali" as this regulator is MediaTek-specific and it is, and will ever be, used only for this specific string due to the addition of the mediatek-regulator-coupler driver. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Chen-Yu Tsai --- .../devicetree/bindings/gpu/arm,mali-bifrost.yaml | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml index 02699d389be1..ac174c17e25f 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml @@ -145,6 +145,18 @@ allOf: - power-domains - resets - reset-names + - if: + not: + properties: + compatible: + contains: + enum: + - mediatek,mt8183-mali + then: + properties: + power-domains: + maxItems: 1 + power-domain-names: false - if: properties: compatible: @@ -166,9 +178,6 @@ allOf: - power-domain-names else: properties: - power-domains: - maxItems: 1 - power-domain-names: false sram-supply: false - if: properties: From patchwork Tue Feb 21 15:37:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 60137 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp78380wrd; Tue, 21 Feb 2023 07:42:50 -0800 (PST) X-Google-Smtp-Source: AK7set8RJFKa0XlcFu3siamg4F6i1BsUbidKzFxB1VFXxX7NFyPb8nxwiKSjaSzhRXuNeRx3qv/c X-Received: by 2002:a17:90a:7645:b0:233:e305:f616 with SMTP id s5-20020a17090a764500b00233e305f616mr4542077pjl.15.1676994170298; Tue, 21 Feb 2023 07:42:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676994170; cv=none; d=google.com; s=arc-20160816; b=S0/uGLGuLSAiwtZXcO1AnVe7JW51fHfIsBbhrbejF8Ovkk3LPCkeKSe7Le9xE9NnH2 mdGe9WyFphE4UJZ4rYKHErB71pRoF5kI5VGqxYyxhaqEXXtKCmXqpQCcKdEdoR9wgUcx 9Zgl5qVBV7hHTVJv4YNgRISDsDY6p/rI4C3JRJd3a0cZrmSLY5u5+EWYb0HxWlH21xSP PyDSGarsFQJDTs2BOjdo8cKYWn9w2AKL6bNKbMQN/29mt8aXBDMLhj5x5qYTBlf0pI2n mZFC+5mul9jG2OvTh06tmGYQvrWJLBIUzGfizHyuxuYTRWtUUFKRgyezv5s79ePIBP2r LOJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9ywC0lpWIV9O+8/h0oC75OVWnYnh4CTXbd+m738N5ds=; b=LNXn0mhbOvP9GFdzN1cvMJeaOHs8jljmiupbpSW6DTdrSVqc7ZTQn83Q6u5UPKUN6b zGI95cGFkWOsKAOvZP970sbfmVoLSE9/DB/yeXKiMDFQig0HVaOPvxv3DD6f7t1fAgcc Mbm6Pw0C4AjWHj5KhVTkuExVaeTgopNSrfT/lB+EtT3ou+MMjVrSVqGbpZxiRkhUoj+k 6oHus1iXB1OZrftY/mKpeMTrwN9Gcc0V7gPKwsiLowr7+V5cJppFPrLctmge9xFFboKS ozkAD+pjBGcl/XUfSOQ8qY6jWK0So/LT3g9Rkx2OyWp87C7BG43ZzjD2+qeUPuccEBnu iumw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=iRERP9lH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z2-20020a17090a1fc200b00234e6cd59absi3777260pjz.117.2023.02.21.07.42.37; Tue, 21 Feb 2023 07:42:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=iRERP9lH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234557AbjBUPh6 (ORCPT + 99 others); Tue, 21 Feb 2023 10:37:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234532AbjBUPhu (ORCPT ); Tue, 21 Feb 2023 10:37:50 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A183010C5; Tue, 21 Feb 2023 07:37:48 -0800 (PST) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id B411566021D0; Tue, 21 Feb 2023 15:37:46 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676993867; bh=JLv1ypqmRwA4sZAh0v4tJj4CqhA/6gB3AMkCmc8wtN0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iRERP9lHxptyHbkUIZZpTJEqOpnNczybSXcyIV2hS8lxN1Xf3IbrOuPaPNYKST+ZN Fz5zFhdeoF6ZzKr8f0ZsVa5aoa63K7JcIZCAfSjclssml45FkFuiK/miXMO46sUTwv rZLajVOGcKKAZf7CR2I86/6OTqe74T2xWUg2wjULhETlbTdPH8WvNX97XqxLUjC7Jm Vpxx7rw5rxf6QFFGSrlVCQ6qP7PfNW6Qc/UY8qGR6hU+cdPyRUMtxqqWcWx5llNodm gKq02ZgAYkvQEL4I6wFUv6qC2CmQrzstTzSWYBRIGibzsZlJh1HORevo5JzmS4Lo4A iNwNkr5vSAYtg== From: AngeloGioacchino Del Regno To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno Subject: [PATCH v2 03/10] dt-bindings: gpu: mali-bifrost: Allow up to 5 power domains for MT8192 Date: Tue, 21 Feb 2023 16:37:33 +0100 Message-Id: <20230221153740.1620529-4-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230221153740.1620529-1-angelogioacchino.delregno@collabora.com> References: <20230221153740.1620529-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758455839146571216?= X-GMAIL-MSGID: =?utf-8?q?1758455839146571216?= MediaTek MT8192 (and similar) needs five power domains for the Mali GPU and no sram-supply: change the binding to allow so. Fixes: 5d82e74a97c2 ("dt-bindings: Add compatible for Mali Valhall (JM)") Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Rob Herring Reviewed-by: Chen-Yu Tsai --- .../bindings/gpu/arm,mali-bifrost.yaml | 22 ++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml index ac174c17e25f..65fe139ceb83 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml @@ -63,7 +63,7 @@ properties: power-domains: minItems: 1 - maxItems: 3 + maxItems: 5 power-domain-names: true @@ -152,6 +152,7 @@ allOf: contains: enum: - mediatek,mt8183-mali + - mediatek,mt8192-mali then: properties: power-domains: @@ -179,6 +180,25 @@ allOf: else: properties: sram-supply: false + - if: + properties: + compatible: + contains: + const: mediatek,mt8192-mali + then: + properties: + power-domains: + minItems: 5 + power-domain-names: + items: + - const: core0 + - const: core1 + - const: core2 + - const: core3 + - const: core4 + required: + - power-domains + - power-domain-names - if: properties: compatible: From patchwork Tue Feb 21 15:37:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 60138 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp78591wrd; Tue, 21 Feb 2023 07:43:22 -0800 (PST) X-Google-Smtp-Source: AK7set9YKrhC9kz5KyJl8FYz9KCZ2PvKnhhzSrvXOjf9B4z/ErruJVLCIkHrKK8j3+hYksqVHsoq X-Received: by 2002:a05:6a21:339b:b0:c1:2027:f4a2 with SMTP id yy27-20020a056a21339b00b000c12027f4a2mr14849212pzb.49.1676994202398; Tue, 21 Feb 2023 07:43:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676994202; cv=none; d=google.com; s=arc-20160816; b=1DNeMEJSr5zhuuLlU+duXP8INuX/GFo2LUbB0gxJXKMfUQcjcnsswYpx72itpCFYTo ilnDrX7LII2ILm0tnVZXStO1c/fg931UmqjXY26GSmyzYps2TmpJLgqrpayPez6ex2no 3phQOBVbLZwVf/arUCsQWz4lippkRaoyNs1po9pdwzaXDsKsqR2yop5KtZF2BLve6ncX lmGx+03P1QzJKKRCAJrUwwT/Ho6BUGhgUUMNAnMyDj52Z2Z+POGsyFWC9OP8THdClljO By/wN8cwoP+oKs0BvBds7hIbPsHBaK9fuNumYuzsH7n3Q+DSXDB6c2wouHreeho1UF3X LYyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HE1nmL/pK+99rwUcEZBSlqoNXqs5jByJDekHuPe79dk=; b=l5gCcQbkwdmZnZ+pLa0ykANIlhvF6gB//rU/6ygSQ9ZYd17crpgPM4d66VisM0klZm SSur2wBp181zjbqGFpVYwMWXNMcT6vCa5+SRu8pH6gnR/BU3PufHjleQjGcrFlyb7pel LXc4a/Bvj15LJ1dfzRwIqD7qW7A0iTZ6n4qXycKbpcZsxlRL1VrwnvZTpxDAhWJ3GQGy oEUcwX0xupYuqmu7QAavAak+1EBCZtdwMUobtp19DMv/WnKsqgDlyPkR6iEdz7TzA1+5 TE8/Simf1TlaVfXMak9+nlbJgnuq+igiE5aQHxgtnNxLOzOmr76C+p6nbis/1BhSv4TJ 2fQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=gfe+P9Sf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z26-20020aa79e5a000000b005a8b55f540bsi16758239pfq.268.2023.02.21.07.43.09; Tue, 21 Feb 2023 07:43:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=gfe+P9Sf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234651AbjBUPiA (ORCPT + 99 others); Tue, 21 Feb 2023 10:38:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234537AbjBUPhu (ORCPT ); Tue, 21 Feb 2023 10:37:50 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB1CA3A99; Tue, 21 Feb 2023 07:37:49 -0800 (PST) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 9794866021CF; Tue, 21 Feb 2023 15:37:47 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676993868; bh=jFlvEa9umviwW9HdtIpX7rwDDrEbdIW1Lu37fWHY6Jc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gfe+P9SfLlXPyMbQFKsRZfLfQUoASqM8Xd1PfVHy1vDH89/Xf6AtO0RuqccLgxEJe vAiI8yo1geE6uP7y2N9e4mQ9OBZYmPinmLEIfORujDQH6GxR1qKVxezCTDtMbvQ62Z PKLq5Sd1UWOsYFJ3jxuHmXScJpJ4u/0YFnrxpiYjZANmWVZO/1tum+4+0xJ+0O/PXt sMti7CxG9DjsQ79cTw2HMnmswEUxweNgezxPLfgS9aOodn8BYo+7/VI4u3jMqfE8uv PEfkxIyNThGnZKVsHiQ/TDEn2xUgxl1VIp+LsLovhFewfVcNexOoQvHaunFSl4Jh5Q 55qCAZ2ere6Sw== From: AngeloGioacchino Del Regno To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno Subject: [PATCH v2 04/10] dt-bindings: gpu: mali-bifrost: Add compatible for MT8195 SoC Date: Tue, 21 Feb 2023 16:37:34 +0100 Message-Id: <20230221153740.1620529-5-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230221153740.1620529-1-angelogioacchino.delregno@collabora.com> References: <20230221153740.1620529-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758455872738053805?= X-GMAIL-MSGID: =?utf-8?q?1758455872738053805?= The MediaTek MT8195 SoC has a Mali G57 MC5 (Valhall-JM) and has the same number of power domains and requirements as MT8192 in terms of bindings. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Rob Herring Reviewed-by: Chen-Yu Tsai --- Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml index 65fe139ceb83..4d9ab4702582 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml @@ -25,6 +25,11 @@ properties: - rockchip,px30-mali - rockchip,rk3568-mali - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable + - items: + - enum: + - mediatek,mt8195-mali + - const: mediatek,mt8192-mali + - const: arm,mali-valhall-jm # Mali Valhall GPU model/revision is fully discoverable - items: - enum: - mediatek,mt8192-mali From patchwork Tue Feb 21 15:37:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 60140 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp78602wrd; Tue, 21 Feb 2023 07:43:24 -0800 (PST) X-Google-Smtp-Source: AK7set9q8hLtjznpoH4SspyMrCA4UTr2SfkE1QiZMV5rqhDtQIgrE+TpclsQQI9wSeweqDNr1qSN X-Received: by 2002:a17:902:ce01:b0:19a:723b:433e with SMTP id k1-20020a170902ce0100b0019a723b433emr4746228plg.42.1676994203889; Tue, 21 Feb 2023 07:43:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676994203; cv=none; d=google.com; s=arc-20160816; b=DXcvl79s5a9SYZkGtyCHcD7zYOBuJjEyP07F5FfFDrcHqwpmVogA58Ewr7FRgJJwkl +EN+lhHWmbCTNPJprixswh0P1CNocFmGSi4h0A4fPfFoXWx0nreIy2Ely+mKqs71sNeV AnuylBJyfZ3XXCSm8ZixoV5z8jkz9MsZiA+Q/GqTmPlfauBmwMIEcz0uKsEy5FP4J4S4 vXDbo0VLtxMT3Ce48ZUFZVYBcIjDjnEIweHS/kYh3vTYFA4gzn3BydqZuWt5i6ksmcsc vhvcA16qe7b4lq+FWsw0pQZ1YKjFZsIgwV8otehbCtSinN4wd7mTYwtcGNOcA3y8nEJt //ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qbFCyiDnazR31Wpk8O7uCqJDZQcBF26z3rz3IXEylsw=; b=n1sgjqpK+L2kFYNwPgD4Ggyv6udVoEUVXSExJTLFamWxZ7u087cya11158j4rH7VqS ajyh/eAuDs12RioCLRYnCkyV3xL/VsaXaEGPpMzTUK3oP26ANuCLEQbd3ieBFOY1zHOX dl9yth7YBdy1RiVHRN83K+RKqVDPvaMB2m+3NZq7nBYkzZHdZCaLsVJ652o7S7ZKIJGI YH+0Z/Eqaaupix9hN6oGZWuNKOqS9+WSsHw47W6Qxd6/CanN0mlClfW+f5X7Ui7dhH2m 07D8WJT9Eig6oHzTM0QcEMf8+LMU54yHVI8KqGozXggkZ4Fkzn1ZLeSMztfBdmEs45xs 9w0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=QjILYONt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b25-20020a631b19000000b004fc298179b2si14517pgb.123.2023.02.21.07.43.11; Tue, 21 Feb 2023 07:43:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=QjILYONt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234216AbjBUPiE (ORCPT + 99 others); Tue, 21 Feb 2023 10:38:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234559AbjBUPhv (ORCPT ); Tue, 21 Feb 2023 10:37:51 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 581E065BF; Tue, 21 Feb 2023 07:37:50 -0800 (PST) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 7B21966021D1; Tue, 21 Feb 2023 15:37:48 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676993869; bh=laOGM5qspmdr3Jbg8tYgPNAcwC0TKu24Y1j4uxBmTgs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QjILYONtql0ehe3PptlOR7eKUZBQeJMTTtYY8w09XRxxCvmZ5OYdQLRzzzMtSAGby HsVOVWCd83+EDTFZF3doY2lB7PSEgLgZYw6qei1/ITB6eJeRtG2by53TaA2P5DdPXZ jRazpehci/kSx/ivYH9a4JAUwyZOOmyAqDJiYwUZWMQtslL6KVoPqUhczn4h1MZoGq Twg6GYpjzPuSO63ekaMKMQKyPl8kQz1XrLYnFSbJlypVckkERbCThJBEueEzSPLHlW JOzblsKjiyQXZ3l7dhy4efPviX5plwEkjHZ2HtU0kIu0ipOp+dUVHmPFtb7Did83w0 52JqyI6frluDA== From: AngeloGioacchino Del Regno To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno Subject: [PATCH v2 05/10] dt-bindings: gpu: mali-bifrost: Add new MT8183 compatible Date: Tue, 21 Feb 2023 16:37:35 +0100 Message-Id: <20230221153740.1620529-6-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230221153740.1620529-1-angelogioacchino.delregno@collabora.com> References: <20230221153740.1620529-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758455874286386953?= X-GMAIL-MSGID: =?utf-8?q?1758455874286386953?= Since new platform data was required in Panfrost for getting GPU DVFS finally working on MediaTek SoCs, add a new "mediatek,mt8183b-mali" compatible. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Rob Herring Reviewed-by: Chen-Yu Tsai --- .../bindings/gpu/arm,mali-bifrost.yaml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml index 4d9ab4702582..be18b161959b 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml @@ -19,6 +19,7 @@ properties: - enum: - amlogic,meson-g12a-mali - mediatek,mt8183-mali + - mediatek,mt8183b-mali - realtek,rtd1619-mali - renesas,r9a07g044-mali - renesas,r9a07g054-mali @@ -157,6 +158,7 @@ allOf: contains: enum: - mediatek,mt8183-mali + - mediatek,mt8183b-mali - mediatek,mt8192-mali then: properties: @@ -185,6 +187,23 @@ allOf: else: properties: sram-supply: false + - if: + properties: + compatible: + contains: + const: mediatek,mt8183b-mali + then: + properties: + power-domains: + minItems: 3 + power-domain-names: + items: + - const: core0 + - const: core1 + - const: core2 + required: + - power-domains + - power-domain-names - if: properties: compatible: From patchwork Tue Feb 21 15:37:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 60141 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp78856wrd; Tue, 21 Feb 2023 07:43:58 -0800 (PST) X-Google-Smtp-Source: AK7set9MbWR/NUokzW56F+iTzid/d2On4yOQQtATbxbZ2DNpGT99NFPO7C+XeZJf+v6Qlh1iKUew X-Received: by 2002:a17:903:228d:b0:19b:33c0:4097 with SMTP id b13-20020a170903228d00b0019b33c04097mr4923156plh.27.1676994237881; Tue, 21 Feb 2023 07:43:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676994237; cv=none; d=google.com; s=arc-20160816; b=JqOf0Z2zZMg5gTXH+gsKJlus4j7uwLWz1f9zrQns4gWqaEgmtcxzMUGO6YFelCngO1 6Z/I5VcgsNODgvGd/hl/H41+Q2up0fnBHUQkHDAz5QpSsep0vVXbsxRRmiNbfdWIwu2D ixnmsobQKGyvetgwZxQJwlpwZ1k4eOpFNu3/gVhiBoAzODX1IptlcpHKj78gNchGSGdf Mc1wUdQwbCGFVbQkrsfyQxBNN8aXZTxODV+Kof7Kwq53VjRT42Se00wb2ou+EwTjHnYG 5BDo5oJkbelKEGm4T7vhKe2ezHjnGmUUyWWy35dCfTN0ngFjaYdHO/dVQVaBx55fn0kA JPfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=x1F10CNA3aCGhAIsYkfbklvndjKZJhXm0DlJVEKE1IQ=; b=tO/kYSVBNG4tLI81BL3TqZadJnScdP9sHTl8RjYqbQn1HtGn3+Sijv2XYY6QKZPX4N a2ttEOCzjZTv+O1NymgB7Pz8FbhcN0B6eTeQY2LNYJvruYJKXyT5rz7Mm+7aIWMbftl7 ptaDr3ksnkqVb+ZQ3sV/9PSiAovi5QFQq1LkXE5VE3dveBSvWfQLygL8M3ZuHRtZa7RA 2M0CeMSOIsS28pvUxXsR3gusiIJ6/EAxvB0Kkb35lltDwNbSCORHlT1RTO7Y8ZbzEDod OIjE3JdwZnRwgWg/LSVNYQOj6bog80ATUeX934u2vT14PLtIMHb5i+wcSX83XTNAUbt1 rYGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=H+Othc8j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j17-20020a170902da9100b0019aa2f3e423si5035037plx.547.2023.02.21.07.43.44; Tue, 21 Feb 2023 07:43:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=H+Othc8j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234361AbjBUPiK (ORCPT + 99 others); Tue, 21 Feb 2023 10:38:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234613AbjBUPh4 (ORCPT ); Tue, 21 Feb 2023 10:37:56 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8006A1CAC7; Tue, 21 Feb 2023 07:37:51 -0800 (PST) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 61588660219C; Tue, 21 Feb 2023 15:37:49 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676993870; bh=XZzIf5WhWGCw6ZUak5aUno/dS29XlqQ4V6b5lAMNRT4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H+Othc8jly/UlZ/H/DYKYH2UsRajWJP5aw6CzokeJLVJtdEBoZthynoP83iLZjADP Vq9CEae9R1VtMisaalqSoYE0IvUcRUFRBQFBJVJEmhrhQ4eNWTJqeeuUWuH27UBNwU 4I/QgzW1qoOVHRfCrVXmB0IMd5+vOIZCCqVmeld4+LNPTjNAjqmQN/gmnIW31qcNgP iOvpAWaRT9jEATqXvjZ+/02fhU/Ik7SW9kk9FBy4Th2+SWqmXlK1wmk24yPDCSUXwo mHfIF1LJ3agbpB9T1IuXi8ESMSXkBjbiQodLq1XmhDr0mOYRyT/uA3UpA+X5ce42v5 yRgIO9n6bKObw== From: AngeloGioacchino Del Regno To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno Subject: [PATCH v2 06/10] dt-bindings: gpu: mali-bifrost: Add a compatible for MediaTek MT8186 Date: Tue, 21 Feb 2023 16:37:36 +0100 Message-Id: <20230221153740.1620529-7-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230221153740.1620529-1-angelogioacchino.delregno@collabora.com> References: <20230221153740.1620529-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758455909926775455?= X-GMAIL-MSGID: =?utf-8?q?1758455909926775455?= Get GPU support on MT8186 by adding its compatible. Signed-off-by: AngeloGioacchino Del Regno --- Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml index be18b161959b..43a841d4e94d 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml @@ -15,6 +15,11 @@ properties: compatible: oneOf: + - items: + - enum: + - mediatek,mt8186-mali + - const: mediatek,mt8183b-mali + - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable - items: - enum: - amlogic,meson-g12a-mali From patchwork Tue Feb 21 15:37:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 60143 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp78936wrd; Tue, 21 Feb 2023 07:44:07 -0800 (PST) X-Google-Smtp-Source: AK7set/Mrtk4OTusqApEYpmJWPTnuU5jTzuXe1C0QkWJKYEq9qVVtXWn+sT32i/dKTPwZ6HbPywV X-Received: by 2002:a05:6a20:7f94:b0:cb:8e4c:6e55 with SMTP id d20-20020a056a207f9400b000cb8e4c6e55mr2491494pzj.12.1676994247213; Tue, 21 Feb 2023 07:44:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676994247; cv=none; d=google.com; s=arc-20160816; b=0SG9nLJmray/V28icOlLKKcTKt6cSBIdf0IoS7NzlOSJO7Vcds9uHFKCix0Xw793iv d42A2fnChvydRedhDE9HngGPMTpi/fELHFMJlYalwdLPJUMmx8AhplkZvSsx3Dx6zJ3e 8oM2GhG+/D4OaomZoBPsEtvYu5rOY8tzUVLP5L6ZyCWDHEJriqPqPnSSzh4pzI6lxaln K7AdL2UlEfq9NlvzArE2FBnZPcBMjUpmxLBhFlSsriNeHahKzHSgZ290kRwEHnv55ZnO PiDOzJOI5VQBqk+r74hJa5zhC5Trip8DmPXIsJyyuta5yUJSBAMzYoMaMQAkeYpCFLsm E++g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Uu2ko/I2+FIAVizMpk+6MoW16wk0zrb3QEtaQNGzMgc=; b=SEkazJt6ZUrGdcfktUDbxmXrxWarZ9oGXv5bKt0BGHcY7Ezc+bInoIQXkmOVI3N/Jz P2Bw0ZbYh4HXCbLbX3Si6B+NzueVtgXxG2Kkk0tUASc4NXHCmVOlze3K+PU43rakWoDL XndiCWjRLT4ZcefP7pn9tacBI7EUdwuS+v43GDpKvO5lRGqwZBC3ZcDzLqtVkVRYk35f +o3D5scPmp5SP4S0YGwI+zjzOkOaO74dNSJDFk+QpJ8UJJ1tQFrb89/CtgwDbddyFfMz i5sHXjWokFFdRaYkQVaqlGf3QbUlTIvMk5NrnLY9xQG1p6k0Yr69rtT3vonUCK987nJ8 oCWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="U6/pIFVn"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 28-20020a63105c000000b00502e29be692si448465pgq.289.2023.02.21.07.43.41; Tue, 21 Feb 2023 07:44:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="U6/pIFVn"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234738AbjBUPiH (ORCPT + 99 others); Tue, 21 Feb 2023 10:38:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234596AbjBUPh4 (ORCPT ); Tue, 21 Feb 2023 10:37:56 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E0B622010; Tue, 21 Feb 2023 07:37:52 -0800 (PST) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 43EC366021D2; Tue, 21 Feb 2023 15:37:50 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676993871; bh=X9j7xcxPWqqju4SwMykvvaoqD5cIUMh5cTk3zCzxcjY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U6/pIFVnfCKS+MNTaAAmacRT0UTSPBum3hfbt9pRV5q7VFocDcyxcvGF7XrWAG/i1 sLaW/zi3XqfHtI4FiqAifMDCVres/490H6yCUfIFcSH+GkICdjw+mR5o3574fAIcFU ipUSyKZk2vlnvse4k9bNyVHGosdWvWU6wY8d3aC/hpBU6X2fXPj4kiWwfO5LjjWpPV cJI7OVZDogorBXjC7/exwBkjEQKrUCu9Pyijtn5u28Hxx9UMVcZ86KknTb+q/xiCIX WnqOcwvTj4cMnPRtc3pbcNeb3m53bItthzxujx02NyLDUkBRUdIVge7CtiwXy6O1if rs1iIJyaFne5Q== From: AngeloGioacchino Del Regno To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno Subject: [PATCH v2 07/10] drm/panfrost: Increase MAX_PM_DOMAINS to 5 Date: Tue, 21 Feb 2023 16:37:37 +0100 Message-Id: <20230221153740.1620529-8-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230221153740.1620529-1-angelogioacchino.delregno@collabora.com> References: <20230221153740.1620529-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758455919846735389?= X-GMAIL-MSGID: =?utf-8?q?1758455919846735389?= From: Alyssa Rosenzweig Increase the MAX_PM_DOMAINS constant from 3 to 5, to support the extra power domains required by the Mali-G57 on the MT8192. Signed-off-by: Alyssa Rosenzweig Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Steven Price Reviewed-by: Chen-Yu Tsai --- drivers/gpu/drm/panfrost/panfrost_device.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.h b/drivers/gpu/drm/panfrost/panfrost_device.h index d9ba68cffb77..b0126b9fbadc 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.h +++ b/drivers/gpu/drm/panfrost/panfrost_device.h @@ -23,7 +23,7 @@ struct panfrost_job; struct panfrost_perfcnt; #define NUM_JOB_SLOTS 3 -#define MAX_PM_DOMAINS 3 +#define MAX_PM_DOMAINS 5 struct panfrost_features { u16 id; From patchwork Tue Feb 21 15:37:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 60142 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp78881wrd; Tue, 21 Feb 2023 07:44:00 -0800 (PST) X-Google-Smtp-Source: AK7set8t6W4RCPm7n1P7BTFNwfD172lJx9/6u+rJlnbBdk5qs0XPpDg2l5Kj8+TWtHdgHw5SbfA5 X-Received: by 2002:a17:90b:3eca:b0:232:ce83:20a with SMTP id rm10-20020a17090b3eca00b00232ce83020amr7909841pjb.36.1676994240520; Tue, 21 Feb 2023 07:44:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676994240; cv=none; d=google.com; s=arc-20160816; b=UtU4PiU+Hj4/nA1uXlbP13d5UibXmntp/owlx0HQF8E+67gSKPIvaWD0bXjJ1wKO6C H3OuhBlCq6smbC8cu6IZPm2q3hFNV3N7xHMEOh9i9W7vLl0kB/LZh5LQjKjUeWcdk7e9 5R730vUIEdtHPnqZR2TexU9mYFO/u0r+h2xEBbU/XzEIplMKJZx9t1tqoZhlEwFDMjCe BNrTD7piIQ5MRxyTXpDj7JQHov6Kdcuqu8wRWKMmwXL3Akmh8FLowyYGKgADWE56tIk7 DVa5ehlKWmlEdH7Ye7G7/TogkuBu8oiG51sVaEOquhOgsCaTaXqFGrjTsGWvG3526wPW PUTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oRRbmSQ3Rq/4N4LJOPHJPIMC9cy1PqF0Em/E+4AfhBU=; b=mR73yCEFm6Y+bHBLtuMlLl5vbb2ja3kil7BGRdZqjQT94m93hGQ+zZGc7+SOm/EZdd CJgPVOrpo51BSKC/g0XX3yI3vxdwJGbPYCajuCdqsbDQF717TS+nTyDNMjSh/83/faz5 vYi5UPpBwGCa2KF00dirXZVX7OYuMwS5QtJmxNYWI+cUjBFGNNOSJ55Wb//MuQcjhhak m6tlRyF4b9bg0ugLDp0fYsuvjA/3SZVhn3YySngnX8Qky/t4OQFXsBGBPfMA+VkqmuAU hBx1Dv48CWNSIR+J5PbuhQORyxRyRfgzvTao2Y7KDiL6ZXrb+VNmmOgDPgeMLKGmz1jA zBsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=mzSAB68h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c4-20020a6566c4000000b00502d7941026si2909240pgw.442.2023.02.21.07.43.47; Tue, 21 Feb 2023 07:44:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=mzSAB68h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234613AbjBUPiN (ORCPT + 99 others); Tue, 21 Feb 2023 10:38:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234186AbjBUPh5 (ORCPT ); Tue, 21 Feb 2023 10:37:57 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 170E623103; Tue, 21 Feb 2023 07:37:53 -0800 (PST) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 29E9266021CF; Tue, 21 Feb 2023 15:37:51 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676993871; bh=HedQD3Ilc5pEnx8vhQO81s7TTNK+oqpJPvaglDZ6DvY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mzSAB68huZi2FWdjCmbPQLcRx/D12xji2dNq7yFIsN0pLXxptw/dMPR76n0abG8lz xcx+ldXx+RYzOJ0Z/EyrgyjHYxS4dTBHPe2puZUkPf/pqMKV8sRY1BqdI0UsmEnFg0 yzMHNEuaeXf5jQBw+Psxdkt5mOTiW3OzmMMjwCSCoDv9X+G8ZnMwlqAH994GT/GuCR dmmBdZCS+Sv+N6O0da+H4/DQgL+2F7TAHQL6yqMcObaqIG7Z2q5RBfSXyZSsn9DdWZ LVGdO2sQLN7DPcdiZnyMxP6vAvdeKXavJeqC495UgF84b0OOVHDvdQ88rKmu6hSnYm 9OL2oeVX36WjA== From: AngeloGioacchino Del Regno To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno Subject: [PATCH v2 08/10] drm/panfrost: Add the MT8192 GPU ID Date: Tue, 21 Feb 2023 16:37:38 +0100 Message-Id: <20230221153740.1620529-9-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230221153740.1620529-1-angelogioacchino.delregno@collabora.com> References: <20230221153740.1620529-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758455912210161020?= X-GMAIL-MSGID: =?utf-8?q?1758455912210161020?= From: Alyssa Rosenzweig MediaTek MT8192 has a Mali-G57 with a special GPU ID. Add its GPU ID, but treat it as otherwise identical to a standard Mali-G57. We do _not_ fix up the GPU ID here -- userspace needs to be aware of the special GPU ID, in case we find functional differences between MediaTek's implementation and the standard Mali-G57 down the line. Signed-off-by: Alyssa Rosenzweig Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Steven Price Reviewed-by: Chen-Yu Tsai --- drivers/gpu/drm/panfrost/panfrost_gpu.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c index 6452e4e900dd..d28b99732dde 100644 --- a/drivers/gpu/drm/panfrost/panfrost_gpu.c +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c @@ -204,6 +204,14 @@ static const struct panfrost_model gpu_models[] = { GPU_MODEL(g57, 0x9001, GPU_REV(g57, 0, 0)), + + /* MediaTek MT8192 has a Mali-G57 with a different GPU ID from the + * standard. Arm's driver does not appear to handle this model. + * ChromeOS has a hack downstream for it. Treat it as equivalent to + * standard Mali-G57 for now. + */ + GPU_MODEL(g57, 0x9003, + GPU_REV(g57, 0, 0)), }; static void panfrost_gpu_init_features(struct panfrost_device *pfdev) From patchwork Tue Feb 21 15:37:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 60144 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp79027wrd; Tue, 21 Feb 2023 07:44:22 -0800 (PST) X-Google-Smtp-Source: AK7set/BCeXrTU2vVwDRNV9/MdiAvidyPa59h8IUm85vw3Jxp7NwtkIbF6AIbgaBDELjSSwbjIpK X-Received: by 2002:a17:90b:1c10:b0:234:1621:3792 with SMTP id oc16-20020a17090b1c1000b0023416213792mr7031661pjb.4.1676994261983; Tue, 21 Feb 2023 07:44:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676994261; cv=none; d=google.com; s=arc-20160816; b=zhF9xHug4In+GN6TzGbAz2s9+RRcVStnYcR4tftOWhzO7lr/an0Cc4BZVCMIedRqcK +4mSkceb3eK8scs8TyNbu8jwfrL6rCyes4DDibemnE1qbRgdH9R8+J2xwkNjlAXC4t3n hZjafnODCXP4/dGc+HSCwLEuIsUP5YO2+hcDNtXtOliXbreyASdg5WV1GrqO5NsIrLq1 o25g0AE8UOidKm2b1TVpYVSVkU0DXHbpRkVHcN2dSe3Nguy1CdydS/VaQ41RFtNpCPVE PYlIRY8ddm1M19VGP0OVAqH/hDW4mwD0Ii17rjFVVcF6RfrsQrUbQ9BR4IvEuNV398/n /57A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/rRZquBeL2jOnSPHoHCrDfUkL4Y+iXOG/ZqD2+1dOXQ=; b=Fi/eufbuylNe+i63/30CJ+SifcU0FMwFTfMC0R/39IewPsuvGhy1Ohz4yvZ0PcM+Mr d3CzRaG1BHJG5WUHYUZlHAD78JuPCPU9Lwnb5UYQ7sCi+b5/NTEMLxLXpulzC3eHzVaW 9DPnvSsi5TsM5o9Ywr2UUcK/56LzaVeYec39gieP6tWK32ExmnNFoBohjY0hLrr5SYFi zCqHn1r8HrroBWvaN/FEv7C52lwPEv4N5772YZ9H46b72UHmwXQuaESKxi79QzLiKCUZ 9UTQoBI/WjAbeRAMjZT7brrLfIqKi03/RjZZaOMfKjzdB9A8YUYq7/QMorsnyK+VHy1H Eq2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=TrsF2Zyp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ch8-20020a17090af40800b00233bafad308si4103072pjb.150.2023.02.21.07.44.06; Tue, 21 Feb 2023 07:44:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=TrsF2Zyp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234683AbjBUPiQ (ORCPT + 99 others); Tue, 21 Feb 2023 10:38:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234703AbjBUPiC (ORCPT ); Tue, 21 Feb 2023 10:38:02 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79BD52BF1C; Tue, 21 Feb 2023 07:37:53 -0800 (PST) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 104D666021CD; Tue, 21 Feb 2023 15:37:52 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676993872; bh=XOBRNDDFJGfYsIgxMZ/xxG6T/bqER3TGwYBPNyV4tY8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TrsF2ZypFqBW/bFW+D9vITUwBlUQmc7X2dV7H+9+GCQRSLcrcgaqvgJKiXy6AY22m sLpSh/oNr3lXRepkMyKbiIhoWxkQvRPTYxrONI7RCCeEDo3XmMNflF3uAyrJHBJnc0 EJSCfPgDiThzY9s6UyUE2bI7E3nY433Mza3tMzLh66+eUeWJeK4jYG5pSKttwil/yI 4AtFcfZ3CuyH3O8cuC4Sb5kKJPZXwM7F72wZAQA6SMXxMvBLaDUSkskyajmC07z2b0 Rl39zya/RTIQUWR9z8qN/a0gihB4NnU1YSn7MiJ6yogg5GevScbfKrG+DLqx8W6SDC FSoHCoGOhTqXQ== From: AngeloGioacchino Del Regno To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno Subject: [PATCH v2 09/10] drm/panfrost: Add mediatek,mt8192-mali compatible Date: Tue, 21 Feb 2023 16:37:39 +0100 Message-Id: <20230221153740.1620529-10-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230221153740.1620529-1-angelogioacchino.delregno@collabora.com> References: <20230221153740.1620529-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758455935264618726?= X-GMAIL-MSGID: =?utf-8?q?1758455935264618726?= From: Alyssa Rosenzweig Required for Mali-G57 on the Mediatek MT8192 and MT8195, which uses even more power domains than the MT8183 before it. Signed-off-by: Alyssa Rosenzweig [Angelo: Removed unneeded "sram" supply, added mt8195 to commit description] Co-developed-by: AngeloGioacchino Del Regno Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Steven Price Reviewed-by: Chen-Yu Tsai --- drivers/gpu/drm/panfrost/panfrost_drv.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c index abb0dadd8f63..5d25e77e1037 100644 --- a/drivers/gpu/drm/panfrost/panfrost_drv.c +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c @@ -663,6 +663,16 @@ static const struct panfrost_compatible mediatek_mt8183_data = { .pm_domain_names = mediatek_mt8183_pm_domains, }; +static const char * const mediatek_mt8192_supplies[] = { "mali", NULL }; +static const char * const mediatek_mt8192_pm_domains[] = { "core0", "core1", "core2", + "core3", "core4" }; +static const struct panfrost_compatible mediatek_mt8192_data = { + .num_supplies = ARRAY_SIZE(mediatek_mt8192_supplies) - 1, + .supply_names = mediatek_mt8192_supplies, + .num_pm_domains = ARRAY_SIZE(mediatek_mt8192_pm_domains), + .pm_domain_names = mediatek_mt8192_pm_domains, +}; + static const struct of_device_id dt_match[] = { /* Set first to probe before the generic compatibles */ { .compatible = "amlogic,meson-gxm-mali", @@ -681,6 +691,7 @@ static const struct of_device_id dt_match[] = { { .compatible = "arm,mali-bifrost", .data = &default_data, }, { .compatible = "arm,mali-valhall-jm", .data = &default_data, }, { .compatible = "mediatek,mt8183-mali", .data = &mediatek_mt8183_data }, + { .compatible = "mediatek,mt8192-mali", .data = &mediatek_mt8192_data }, {} }; MODULE_DEVICE_TABLE(of, dt_match); From patchwork Tue Feb 21 15:37:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 60146 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp80009wrd; Tue, 21 Feb 2023 07:46:22 -0800 (PST) X-Google-Smtp-Source: AK7set+kQ1YTVtrEsMCjM9BQ91ZL/RG9XXw6O8UPgLAyPYNNUWJ9ClLNG8lQV4lMO8akjr2anpui X-Received: by 2002:a05:6a20:6910:b0:cb:ac6c:139d with SMTP id q16-20020a056a20691000b000cbac6c139dmr700208pzj.9.1676994382266; Tue, 21 Feb 2023 07:46:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676994382; cv=none; d=google.com; s=arc-20160816; b=EZmAIQtcahLmnmoVoXXxufz47NEYaU/gXEpA+j/6ecTVGobeHIDogBlBVhSoMi+D4n 5VAm80SPMXAj2giK28lh8zycyrlI+7tTxuU5zXOB41kyU9pNgfruEYxZ+oKfSWy9YQXz 1C1m3FSHsSauiJmh6gtyJNOMW1OO5+oFCLyo3xyRVnntG/1FS9/GPm8ZUiDm3UkJECQn pXqL+C5itsSBjP8RS2t1vsHQYwsJtfxTZhQMNPVNxKxiiZFWx5KsTiflmNShpaw5Q+NP cOLL8YnvwEe2aQAjKNi6DMvXIbZtUdk8JJXws+sOf0Bt/Ntdvw9LjHdTGF1yZZXG96ut UJWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=kJkPXXd0E1FJFKrycqmi608Pd6u8FQxFygP/oYqBqwk=; b=gF+rqWe7cd3zQB4nBWSUoxIqB2oVnbqG7Gv9YyL/L1V2D3gLx1T/3wwPKCEyr7bnv5 PDZSXPIEF2JbPpyvxaEuGXg6j7jcWimtU25b5tWD9fV8HJwfTaRw1Gr8MFXdck0mBdG3 ixpDwLB6W4+DcVUNe3ZJoiuJALfNMK9q5SB8QV+g8LzP3nnZtkxj2ZfhZdNb4KRcXybP yEEen/gYunCE7VNFja1V7bORo4mWJrV+LLU0bnp3sJOmD2gev1D0XknVZc+SfuDkjnne 1Li8Hre/acIdxKIQrxsgtaPGwMx/hUxlpfl7/Aj/QWRncnJQ90gwS8gqekZd+jeJG3p6 K29w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=UzrE+LbQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l185-20020a6388c2000000b00502d8244110si2530852pgd.638.2023.02.21.07.46.04; Tue, 21 Feb 2023 07:46:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=UzrE+LbQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233721AbjBUPiV (ORCPT + 99 others); Tue, 21 Feb 2023 10:38:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234606AbjBUPiD (ORCPT ); Tue, 21 Feb 2023 10:38:03 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07A2E2BF3A; Tue, 21 Feb 2023 07:37:54 -0800 (PST) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id E3C9666021D3; Tue, 21 Feb 2023 15:37:52 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676993873; bh=d98v4XkYuSdlaBMRVhy8ckf3WPpqfT9gFqNu9PlgtLo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UzrE+LbQ/q/0oEUfdmGWDjpM6NnJzjiNqoBtqiibNwJyOF6/8O7KN8y54F0CMgd9y stIgTD8qLHyWnvwds8ShWi8WDhOJdDF8LXMThS8yUsuTwO9XvQfQVafex2aLd3OczH WAmHckmNQJcvQhmyKFYTlguwycU553zByLkDfXZ+aSJiuhLiR77aKQk6pS/Lu1sesA W1xqD0lj0CWJIjhbpjlBN/1pxG8rP08/Rt78pgudRFgmG8PUOa7rQM6OcJbNnCOXs6 6BQAyJzAdFlIxXawaNBxgj800LlZwNc6FMLN0k2sGuxI5QKkBhGtGYygRhnIXmyG3R sN4UBYv7JHEfQ== From: AngeloGioacchino Del Regno To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno Subject: [PATCH v2 10/10] drm/panfrost: Add new compatible for Mali on the MT8183 SoC Date: Tue, 21 Feb 2023 16:37:40 +0100 Message-Id: <20230221153740.1620529-11-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230221153740.1620529-1-angelogioacchino.delregno@collabora.com> References: <20230221153740.1620529-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758456061067628745?= X-GMAIL-MSGID: =?utf-8?q?1758456061067628745?= The "mediatek,mt8183-mali" compatible uses platform data that calls for getting (and managing) two regulators ("mali" and "sram") but devfreq does not support this usecase, resulting in DVFS not working. Since a lot of MediaTek SoCs need to set the voltages for the GPU SRAM regulator in a specific relation to the GPU VCORE regulator, a MediaTek SoC specific driver was introduced to automatically satisfy, through coupling, these constraints: this means that there is at all no need to manage both regulators in panfrost but to otherwise just manage the main "mali" (-> gpu vcore) regulator instead. Keeping in mind that we cannot break the ABI, the most sensible route (avoiding hacks and uselessly overcomplicated code) to get a MT8183 node with one power supply was to add a new "mediatek,mt8183b-mali" compatible, which effectively deprecates the former. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Steven Price Reviewed-by: Chen-Yu Tsai --- drivers/gpu/drm/panfrost/panfrost_drv.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c index 5d25e77e1037..14cdeaeeb5c4 100644 --- a/drivers/gpu/drm/panfrost/panfrost_drv.c +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c @@ -654,6 +654,14 @@ static const struct panfrost_compatible amlogic_data = { .vendor_quirk = panfrost_gpu_amlogic_quirk, }; +/* + * The old data with two power supplies for MT8183 is here only to + * keep retro-compatibility with older devicetrees, as DVFS will + * not work with this one. + * + * On new devicetrees please use the _b variant with a single and + * coupled regulators instead. + */ static const char * const mediatek_mt8183_supplies[] = { "mali", "sram", NULL }; static const char * const mediatek_mt8183_pm_domains[] = { "core0", "core1", "core2" }; static const struct panfrost_compatible mediatek_mt8183_data = { @@ -663,6 +671,14 @@ static const struct panfrost_compatible mediatek_mt8183_data = { .pm_domain_names = mediatek_mt8183_pm_domains, }; +static const char * const mediatek_mt8183_b_supplies[] = { "mali", NULL }; +static const struct panfrost_compatible mediatek_mt8183_b_data = { + .num_supplies = ARRAY_SIZE(mediatek_mt8183_b_supplies) - 1, + .supply_names = mediatek_mt8183_b_supplies, + .num_pm_domains = ARRAY_SIZE(mediatek_mt8183_pm_domains), + .pm_domain_names = mediatek_mt8183_pm_domains, +}; + static const char * const mediatek_mt8192_supplies[] = { "mali", NULL }; static const char * const mediatek_mt8192_pm_domains[] = { "core0", "core1", "core2", "core3", "core4" }; @@ -691,6 +707,7 @@ static const struct of_device_id dt_match[] = { { .compatible = "arm,mali-bifrost", .data = &default_data, }, { .compatible = "arm,mali-valhall-jm", .data = &default_data, }, { .compatible = "mediatek,mt8183-mali", .data = &mediatek_mt8183_data }, + { .compatible = "mediatek,mt8183b-mali", .data = &mediatek_mt8183_b_data }, { .compatible = "mediatek,mt8192-mali", .data = &mediatek_mt8192_data }, {} };