From patchwork Tue Feb 21 10:50:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Marko X-Patchwork-Id: 59861 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1795456wrn; Tue, 21 Feb 2023 02:53:27 -0800 (PST) X-Google-Smtp-Source: AK7set/KpAKn/r0ObjG3+QjCZGWMGBRFYKaabVLvcMfyTa4ccERa8rDdutetz8yv6zKa7qg5cydQ X-Received: by 2002:a05:6402:5158:b0:4aa:a4f1:3edb with SMTP id n24-20020a056402515800b004aaa4f13edbmr3906484edd.29.1676976807683; Tue, 21 Feb 2023 02:53:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676976807; cv=none; d=google.com; s=arc-20160816; b=aR3cdVK+o42zgEEOmIzyZLXr2D3VTWrmJYwBvvp6qOFE6Gfim1Or0pxtgGpF0ztK8q RJwZiBOQpo4mxHKHGvr4wChR8qd0DRWe8KYHTzcyy02840OaSw/kpTtFmu8SlCq/1Z3J R8H3TJwTtGyxHoRBlnEfUS/RCd4RUgnC8d5dNMgvX2KcIM1h4jn62XiMnGAGj8Hl9tHl ey6MG4vRQD7hG4xs17PX0FtnxdHRvYYKeu2xwFIkfGCxMl9NnVQlZv8gJmsJjTIobtWF 3vj94xO5/ohxz7XDViHbvLBXp6om1XQr8pRiiF89QMYLQC6vaWgOattOaND/Ddhwo03R U78g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=pYjWLgQYUyf0rfB+O28fl3yoRQb/M04CEuNH5hkz1cs=; b=SyhuGi2dmBr+vNbFwsthjA4JylmlxUjxtuoTPchzRaLpXcASblDY5pFpP1WYjgFFtM n8Dc/oB5hrRAOI4bvvG6tuJtK44Qs1OZZAKx0zdiO4ZWPoRROH+LOJ1dvZmd9KL0zwF7 KB9ob70wwzIooD0laBeBJacDzuIQ77vSMAL9Ihia+nsLmhZ60tP9+T/8FnNJbr5glfPe Iu1+QfeGUL+OWht0KFtcRFzBIMmhMbhJRxWciMZcormpQBMpay3AP2AmQvT0FqnH5xRS Re9oidRkH0XIPFfiCyTOFoCyBT7wG1cUTsiiZA+Uu3668tX4Zl9jiSqsFz4gY7D+z0Xl BB3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sartura.hr header.s=sartura header.b=p2wzYBo3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=sartura.hr Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j15-20020aa7c0cf000000b004aab2fed3e7si18288874edp.275.2023.02.21.02.53.04; Tue, 21 Feb 2023 02:53:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sartura.hr header.s=sartura header.b=p2wzYBo3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=sartura.hr Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233812AbjBUKut (ORCPT + 99 others); Tue, 21 Feb 2023 05:50:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233825AbjBUKur (ORCPT ); Tue, 21 Feb 2023 05:50:47 -0500 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8348C21A25 for ; Tue, 21 Feb 2023 02:50:44 -0800 (PST) Received: by mail-ed1-x531.google.com with SMTP id h16so15530176edz.10 for ; Tue, 21 Feb 2023 02:50:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sartura.hr; s=sartura; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pYjWLgQYUyf0rfB+O28fl3yoRQb/M04CEuNH5hkz1cs=; b=p2wzYBo3W+HrqRwhYizv8ezrYEbXHvTHEGP4HDkZqnrL1td9lLY1poI37muWJ7sd3y Bd24g575XQwvAkILeyYn1CiV7LmkE+VFqxzYM8GiLqM3nPNvVOE2MTvW+j6Uf+petFQV /fL4aVnW6Awf9JyCMGMvLK/ckLO2+5LEFuVgo1wLs5cAY3yPZ+PoRu73RTIa/sfZJYxP vwZv0CpqP0copFJkNX++pG1KyBQarJ1StdWJlc+fh/vsDYKyjAhOSV/ZrQAPiQbQdXLQ v5eA2Qr9dqfCgE2gdryWm2viN/kqaT7cnzY9+2w7KioLjpVxTe90Et9jd6dIgH/ieg83 9hGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pYjWLgQYUyf0rfB+O28fl3yoRQb/M04CEuNH5hkz1cs=; b=rGUDbPn2J00tTtF03gnNxud8+CCVH/xmgUnzoSik6+6sx+bDzSvUFQvAPPfWdHYoPA JddRGm5QsfSu7YvJknTaUv9VCfKr+n9176l1Tgp6kxZrctxyy5J//JT1AlgaweNJxrLv IlDcp4NB/3MIp7VFDgV+4UHIpvDSF7fmOuipOyGowBMF3uEQD3KkxOBuas9jVcTGurJu lWqxwPSGHYIUSHlVZ3Lc1xfscsPwhXOoAsfyGImAwvd/4m6nY5nbMgmsVRQJmt10H+Lz MTYAL32smfmPbNF3NvB36fl6hfI6DJyfLjZBAfc4z5fQZ1BGldZl3h20ADnMxkTzNk4+ M/DQ== X-Gm-Message-State: AO0yUKWzvr6UZnoldca59gvCaD45ix1m/Xc9bvnRaCF2ERJA7FL7SbE7 phgwIOPVuBDHtoFeDdHHQZx6Zg== X-Received: by 2002:a17:907:e8d:b0:8b1:2e8f:d524 with SMTP id ho13-20020a1709070e8d00b008b12e8fd524mr19296846ejc.27.1676976642934; Tue, 21 Feb 2023 02:50:42 -0800 (PST) Received: from fedora.. (dh207-97-58.xnet.hr. [88.207.97.58]) by smtp.googlemail.com with ESMTPSA id bk26-20020a170906b0da00b0089d5aaf85besm6955802ejb.219.2023.02.21.02.50.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 02:50:42 -0800 (PST) From: Robert Marko To: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, lars.povlsen@microchip.com, Steen.Hegelund@microchip.com, daniel.machon@microchip.com, UNGLinuxDriver@microchip.com, arnd@arndb.de, alexandre.belloni@bootlin.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: luka.perkov@sartura.hr, Robert Marko Subject: [PATCH v2 1/3] arm64: dts: microchip: sparx5: do not use PSCI on reference boards Date: Tue, 21 Feb 2023 11:50:37 +0100 Message-Id: <20230221105039.316819-1-robert.marko@sartura.hr> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758437633175521319?= X-GMAIL-MSGID: =?utf-8?q?1758437633175521319?= PSCI is not implemented on SparX-5 at all, there is no ATF and U-boot that is shipped does not implement it as well. I have tried flashing the latest BSP 2022.12 U-boot which did not work. After contacting Microchip, they confirmed that there is no ATF for the SoC nor PSCI implementation which is unfortunate in 2023. So, disable PSCI as otherwise kernel crashes as soon as it tries probing PSCI with, and the crash is only visible if earlycon is used. Since PSCI is not implemented, switch core bringup to use spin-tables which are implemented in the vendor U-boot and actually work. Tested on PCB134 with eMMC (VSC5640EV). Fixes: 6694aee00a4b ("arm64: dts: sparx5: Add basic cpu support") Signed-off-by: Robert Marko Acked-by: Steen Hegelund --- Changes in v2: * As suggested by Arnd, disable PSCI only on reference boards --- arch/arm64/boot/dts/microchip/sparx5.dtsi | 2 +- arch/arm64/boot/dts/microchip/sparx5_pcb_common.dtsi | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi b/arch/arm64/boot/dts/microchip/sparx5.dtsi index 0367a00a269b3..5eae6e7fd248e 100644 --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi @@ -61,7 +61,7 @@ arm-pmu { interrupt-affinity = <&cpu0>, <&cpu1>; }; - psci { + psci: psci { compatible = "arm,psci-0.2"; method = "smc"; }; diff --git a/arch/arm64/boot/dts/microchip/sparx5_pcb_common.dtsi b/arch/arm64/boot/dts/microchip/sparx5_pcb_common.dtsi index 9d1a082de3e29..32bb76b3202a0 100644 --- a/arch/arm64/boot/dts/microchip/sparx5_pcb_common.dtsi +++ b/arch/arm64/boot/dts/microchip/sparx5_pcb_common.dtsi @@ -6,6 +6,18 @@ /dts-v1/; #include "sparx5.dtsi" +&psci { + status = "disabled"; +}; + +&cpu0 { + enable-method = "spin-table"; +}; + +&cpu1 { + enable-method = "spin-table"; +}; + &uart0 { status = "okay"; }; From patchwork Tue Feb 21 10:50:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Marko X-Patchwork-Id: 59862 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1795797wrn; Tue, 21 Feb 2023 02:54:47 -0800 (PST) X-Google-Smtp-Source: AK7set+49/oURCQHXWcIQrdVXDIhvT7HzANgGYN27P+T5+oxHOx3iCFhGeAxDxi8nBlp3HLUWnbR X-Received: by 2002:a50:ed16:0:b0:4ae:eb0f:4273 with SMTP id j22-20020a50ed16000000b004aeeb0f4273mr4434050eds.15.1676976887058; Tue, 21 Feb 2023 02:54:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676976887; cv=none; d=google.com; s=arc-20160816; b=RBvod3nodZwv9IoaxhAUPa8pCrg+Uvolblt+MgIOGGi3X1ddU3Idm4KDpqm/qajFfY z7LPtythvhAbREoZz6b0oZ44dGHBJa5TKUDiVL6vSuqDjkVzYs+mw5WTS43+mkSA+DZH fBBH/hPjBROEU5DB0F1ZgGTnuHXLNxhRAfYZyWKMP0Pdsedal/LTU1z7U0pvaCGN0MY+ MjgXrWzDSY/iz1U4yIbsMlZAJXfYzyTiSOm8igeL5CEy+HnFfr/b0hcLAxY/Sut/p6pP gqIIdywj9nXYVVq8fLDO0JJJpEk4X4h1yG51t14ceViYsCnrIWrxKcpWdq5zT7eukbOY wiiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ApMcsU4SYE3sBKMbTvqLq1Sm/IwL/ogI22P3eYaAobA=; b=xGI7Pp8P7SetwMj1xEkXXRa9FyuuOfc6o8S/asw6+wGq9YABXerVXDGfn2XBfl1Cgl J8NHOL+iFvkqwmIPshnyjFPQKwQacA6RkDXek3tNtEAJKV3w9cFwNmcyiV/ejS9bH2JQ DuzG7aYWlOwBAbLY3m1DnoMZnPDupLVZnEM+hT+O6wuc7sEqzpLOW+v6SRWWZQElM4vl KbNLuhP29jvqYiSiS05ocy1GMDM/M6fnXV3591s/ZWkCm+qDUxLrfIOwn4gICD0mX82X zm9Chk5U7YJMYgtyiiKlHpfX5jSk4hraqP577WyV3abtslMFf7Vpwrgogs/LJWHk9aoW +4QA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sartura.hr header.s=sartura header.b=nJjAKok+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=sartura.hr Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y20-20020a50e614000000b004acc68a3d5csi1965331edm.304.2023.02.21.02.54.23; Tue, 21 Feb 2023 02:54:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sartura.hr header.s=sartura header.b=nJjAKok+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=sartura.hr Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233836AbjBUKuv (ORCPT + 99 others); Tue, 21 Feb 2023 05:50:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233816AbjBUKus (ORCPT ); Tue, 21 Feb 2023 05:50:48 -0500 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9BAC25E16 for ; Tue, 21 Feb 2023 02:50:45 -0800 (PST) Received: by mail-ed1-x532.google.com with SMTP id cq23so15062628edb.1 for ; Tue, 21 Feb 2023 02:50:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sartura.hr; s=sartura; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ApMcsU4SYE3sBKMbTvqLq1Sm/IwL/ogI22P3eYaAobA=; b=nJjAKok+QWjwzqcccLIOmTbIbYB7wJCQ3D4e0bzfmx4InfttIlr0yypLruxx/+4TBN BAjbEUZrs9H2PfZWhEgfN5NWdPLdpGNMWpeS+FQEouQKqZEQOkdQTHOLjfocyJTQLae4 dHwsK+bTdn1ds5WVdfsuIpV31GXbgKBnmIRLe6l9eUBsS41hFJzc8zxwTXdSehlw/H1r WAKBKUd/1ur1Rvq/uZxgTH9qPFOCCXcXynLucOvaU92XYzNs+Y0yTzonOK5h6E87PH2j /mlN8FyMW25orWMqoP6XMJ4ri64t5ELg/8hkZkWwSQieKMyqD8etdJMNRC/7ipoL0IFk L2Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ApMcsU4SYE3sBKMbTvqLq1Sm/IwL/ogI22P3eYaAobA=; b=kvYINR3xQ9VHRChgWWDEaUlFz0e0DSCMDLyDidWDJARXq+c7todqfVKBfSTKRAFS0Q d8NL5zquF+AUqksFxnVZjpL/hzq5xxfq3IOg0I0eZHZE445N+gVrb5PFJe1nLbq8oCoz /PjS9vcHagooAXZTJE73Sw2iHmtmbfsyo6q4Bpe5KAMhL0EfJDb+SQSkMvkXSzKxYotl RMPGfeqBz6lmua09hbmfyyRr7c3wY/JVWM50XJJkfzk3ssL1t+XRUWKDklkeZq0gYith 5pkNopetCyjep6azdH+fIseuzfbuq7qY4TnkFT+UOGR+4tGXwedMHxP2fbHxrHD73ldy U5xg== X-Gm-Message-State: AO0yUKUQgRjL8b+wYLwOKW18PAY7Ckq1RTzT5okF1t5LdHGgLDcmBsg8 gLrrQySPYy/S9DXzXOrTbUqu9Q== X-Received: by 2002:a17:906:9750:b0:8b3:946d:51c8 with SMTP id o16-20020a170906975000b008b3946d51c8mr17519162ejy.29.1676976644132; Tue, 21 Feb 2023 02:50:44 -0800 (PST) Received: from fedora.. (dh207-97-58.xnet.hr. [88.207.97.58]) by smtp.googlemail.com with ESMTPSA id bk26-20020a170906b0da00b0089d5aaf85besm6955802ejb.219.2023.02.21.02.50.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 02:50:43 -0800 (PST) From: Robert Marko To: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, lars.povlsen@microchip.com, Steen.Hegelund@microchip.com, daniel.machon@microchip.com, UNGLinuxDriver@microchip.com, arnd@arndb.de, alexandre.belloni@bootlin.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: luka.perkov@sartura.hr, Robert Marko Subject: [PATCH v2 2/3] arm64: dts: microchip: sparx5: correct CPU address-cells Date: Tue, 21 Feb 2023 11:50:38 +0100 Message-Id: <20230221105039.316819-2-robert.marko@sartura.hr> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230221105039.316819-1-robert.marko@sartura.hr> References: <20230221105039.316819-1-robert.marko@sartura.hr> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758437716077423472?= X-GMAIL-MSGID: =?utf-8?q?1758437716077423472?= There is no reason for CPU node #address-cells to be set at 2, so lets change them to 1 and update the reg property accordingly. Signed-off-by: Robert Marko --- arch/arm64/boot/dts/microchip/sparx5.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi b/arch/arm64/boot/dts/microchip/sparx5.dtsi index 5eae6e7fd248e..a4fabacf5c2f7 100644 --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi @@ -24,7 +24,7 @@ chosen { }; cpus { - #address-cells = <2>; + #address-cells = <1>; #size-cells = <0>; cpu-map { cluster0 { @@ -39,14 +39,14 @@ core1 { cpu0: cpu@0 { compatible = "arm,cortex-a53"; device_type = "cpu"; - reg = <0x0 0x0>; + reg = <0x0>; enable-method = "psci"; next-level-cache = <&L2_0>; }; cpu1: cpu@1 { compatible = "arm,cortex-a53"; device_type = "cpu"; - reg = <0x0 0x1>; + reg = <0x1>; enable-method = "psci"; next-level-cache = <&L2_0>; }; From patchwork Tue Feb 21 10:50:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Marko X-Patchwork-Id: 59863 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1795992wrn; Tue, 21 Feb 2023 02:55:26 -0800 (PST) X-Google-Smtp-Source: AK7set+8ePy9R+s1nmbnClSL28pSsvzmvNU1EurbitN5YMAH5lLVrTg3idLmPTUrUfe1XgydJLGU X-Received: by 2002:aa7:d957:0:b0:4ac:c3c0:24d7 with SMTP id l23-20020aa7d957000000b004acc3c024d7mr4108484eds.42.1676976926164; Tue, 21 Feb 2023 02:55:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676976926; cv=none; d=google.com; s=arc-20160816; b=FSvYDXo2hGE7rXCiO16etLRIAh5CKkRfJYbcZOyz63Tur7ATQ3iiDnXmceCzwTAYEp jEFKcEIcFBngQ4M9PlXE8VNhdwrrEuzVuX8rmDrtIXYgLOBpEHedKd94eRbJqKxmIsSt TfChJXU6kgWTFmb0VM566+fiYKhXvOWWwYgWdzIgbGRUTHnAJI9gmHQpgBWGUHX/DAjH lKpaN9hz1I6vIF4vmxEOfNNuUUKrQ+WhbdNkU69EwuJxlnZ4XdLi9WPl6B7Ec+BSKrDU MF+6qSWgAU3kLQF+dkqsxDTFh0+XJkhgcZZCjQ5thYeqvNuP02dkUY4xl8XPhTgE2ZUv Qgyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0gk2DSmgvASQ5V9ePr4xMv7HQyGXDamFtmo/+7H0H7Q=; b=Jezu6NuUCv4QomWvkXI6eVCmi52IEs59Qng35mnnS2pnbvrmIuFTnnnxYlD/AymPcP ePZX+IlXWTDu4C22JYsb5XyQPQ1MwazKm4+Flc7D3WtRYUvKnGxMLfFIGNsQ3hzq3Ps7 eAf7GSkxjy4BcnPfDJ+8PNkG7pI3fK2tE2J4j/ourf69RX2Aofzj5AoHjJ+D6Ko+dBEB Uv+j4e6DvnvuAeVM2HuFDoyRUPqAUkfrxRbS65s//cb9RtbBvkE1CbwmTMHiyF6Fo5U3 +SygqCqNcWTNErX/KnAuwaQyyl3tg6+n7d+tFZsNiLuQMBALIwAV6GNN9DNmLRCGt1NT 9MlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sartura.hr header.s=sartura header.b="z6QrFp/K"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=sartura.hr Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v14-20020aa7d64e000000b004aaa4ffa6d2si18502292edr.627.2023.02.21.02.55.03; Tue, 21 Feb 2023 02:55:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sartura.hr header.s=sartura header.b="z6QrFp/K"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=sartura.hr Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233865AbjBUKuy (ORCPT + 99 others); Tue, 21 Feb 2023 05:50:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232686AbjBUKuu (ORCPT ); Tue, 21 Feb 2023 05:50:50 -0500 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 094EC25E1A for ; Tue, 21 Feb 2023 02:50:46 -0800 (PST) Received: by mail-ed1-x52a.google.com with SMTP id f13so14812683edz.6 for ; Tue, 21 Feb 2023 02:50:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sartura.hr; s=sartura; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0gk2DSmgvASQ5V9ePr4xMv7HQyGXDamFtmo/+7H0H7Q=; b=z6QrFp/Krt2zgU4roCx/tRFt9FnkDlEc8AOluIPbFpZzT/A/IB2zZiuh8MulzCnAgi Sd50gCC86ozaK7xkP1UFO3Wz0vOZxDo/RDTKjmmV52tUsiuXE6BasomSPjWwmNj6NVJc tPJajapj7D1Y3dPhQDI9SyPSgCLYvy01oSwgr4T3RlITMT2i76EEQMRwCruEsWzFPPDi afhbSbVjO7IzBMnWErmwWAgvcjkhLyPx4MMjD0MbUQ/e/8zv2tTKKQwQSfUH6xyr76Oz h+bnoIH5do3PEjNSm6vUX/Oce8OVjcG/Un0suI8PY2sFvSHfTVJ2aV81VECSNfBYMz8+ ze0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0gk2DSmgvASQ5V9ePr4xMv7HQyGXDamFtmo/+7H0H7Q=; b=c1laR/0viD5G+ANoVBoEg4b4+8GJEU0azGMAEZJQzsjSRu86oSAI164yZOHJy/8auf Nu6Yrf1OUqnF+70QaEZEJILw7khQel/bUrmovZ4TW2LDXON4edAGHlGUX4oXbwxMstTJ Hf5wCM4gIiUqTUV4YsmKdBx8WAEahkeoAWt08+1UBtfk8yez0y4/kEEXCv9BTprf6bY9 96s40MNaJrS8cVHZzD+xb+EXymEJWZihqgPD2eS2+HLHE6NZb4r6jMoIuDdR7fBkmhQR aGryp7edoTnCIiXynrluJYdZYsKSv3dTqZqAtC5+cyoMcjV//dHg0H/oTccsvJ1496hs ispw== X-Gm-Message-State: AO0yUKV8GSotX0j6sc+55ZDeeQAhxTIbIpxKMV8TuPFuW+ry0a8Ou2nf L9FhDJ/TdrDNYC0jmBplAC7Iqg== X-Received: by 2002:a17:906:ad82:b0:8af:40b0:3dd1 with SMTP id la2-20020a170906ad8200b008af40b03dd1mr11760401ejb.27.1676976645348; Tue, 21 Feb 2023 02:50:45 -0800 (PST) Received: from fedora.. (dh207-97-58.xnet.hr. [88.207.97.58]) by smtp.googlemail.com with ESMTPSA id bk26-20020a170906b0da00b0089d5aaf85besm6955802ejb.219.2023.02.21.02.50.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 02:50:44 -0800 (PST) From: Robert Marko To: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, lars.povlsen@microchip.com, Steen.Hegelund@microchip.com, daniel.machon@microchip.com, UNGLinuxDriver@microchip.com, arnd@arndb.de, alexandre.belloni@bootlin.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: luka.perkov@sartura.hr, Robert Marko Subject: [PATCH v2 3/3] arm64: dts: microchip: sparx5: add missing L1/L2 cache information Date: Tue, 21 Feb 2023 11:50:39 +0100 Message-Id: <20230221105039.316819-3-robert.marko@sartura.hr> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230221105039.316819-1-robert.marko@sartura.hr> References: <20230221105039.316819-1-robert.marko@sartura.hr> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758437757151389018?= X-GMAIL-MSGID: =?utf-8?q?1758437757151389018?= Currently, when booting on SparX-5 you will get the following error: [ 0.050132] Early cacheinfo failed, ret = -22 This is due to L2 cache node missing cache-level property to indicate its level, so populate it to let the kernel know its L2 cache. However, that alone is enough to get rid of the error, but then the following warnings appear: [ 0.050162] cacheinfo: Unable to detect cache hierarchy for CPU 0 [ 0.093256] cacheinfo: Unable to detect cache hierarchy for CPU 1 So, lets completely populate both the L1 and L2 cache info based off the SoC datasheet[1] and ARM A53 technical reference manual[2]. Now "lscpu -C" provides: NAME ONE-SIZE ALL-SIZE WAYS TYPE LEVEL SETS PHY-LINE COHERENCY-SIZE L1d 32K 64K 4 Data 1 128 64 L1i 32K 64K 2 Instruction 1 256 64 L2 256K 256K 16 Unified 2 256 64 Tested on PCB134 (eMMC). [1] https://ww1.microchip.com/downloads/aemDocuments/documents/UNG/ProductDocuments/DataSheets/SparX-5_Family_L2L3_Enterprise_25G_Ethernet_Switches_Datasheet_00003823D.pdf [2] https://developer.arm.com/documentation/ddi0500/j/Level-1-Memory-System/About-the-L1-memory-system?lang=en Fixes: 6694aee00a4b ("arm64: dts: sparx5: Add basic cpu support") Signed-off-by: Robert Marko --- arch/arm64/boot/dts/microchip/sparx5.dtsi | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi b/arch/arm64/boot/dts/microchip/sparx5.dtsi index a4fabacf5c2f7..950ba78bf73f3 100644 --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi @@ -41,6 +41,12 @@ cpu0: cpu@0 { device_type = "cpu"; reg = <0x0>; enable-method = "psci"; + d-cache-size = <0x8000>; + d-cache-line-size = <64>; + d-cache-sets = <128>; // 32KiB(size)/64(line-size)=512ways/4-way set + i-cache-size = <0x8000>; + i-cache-line-size = <64>; + i-cache-sets = <256>; // 32KiB(size)/64(line-size)=512ways/2-way set next-level-cache = <&L2_0>; }; cpu1: cpu@1 { @@ -48,10 +54,21 @@ cpu1: cpu@1 { device_type = "cpu"; reg = <0x1>; enable-method = "psci"; + d-cache-size = <0x8000>; + d-cache-line-size = <64>; + d-cache-sets = <128>; // 32KiB(size)/64(line-size)=512ways/4-way set + i-cache-size = <0x8000>; + i-cache-line-size = <64>; + i-cache-sets = <256>; // 32KiB(size)/64(line-size)=512ways/2-way set next-level-cache = <&L2_0>; }; L2_0: l2-cache0 { compatible = "cache"; + cache-unified; + cache-size = <0x40000>; + cache-line-size = <64>; + cache-sets = <256>; // 256KB(size)/64(line-size)=4096ways/16-way set + cache-level = <2>; }; };