From patchwork Tue Feb 21 07:32:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 59783 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1731749wrn; Mon, 20 Feb 2023 23:52:06 -0800 (PST) X-Google-Smtp-Source: AK7set+0ZuOpSDNBBndJI5IrlKa8Og0JJGS9eYKsD/fI6+R9L0ldgkrHWwW44uqUF0C5UNP0P0SM X-Received: by 2002:a17:907:5c6:b0:8af:3b78:315d with SMTP id wg6-20020a17090705c600b008af3b78315dmr15272392ejb.23.1676965926418; Mon, 20 Feb 2023 23:52:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676965926; cv=none; d=google.com; s=arc-20160816; b=qQpup5pRVeTk5hUpeyM6yXj5CiNNG//M/aiEGQOyCYhqTQ7rL3sGJnTWUjKDHqdx2X sv6A5YffBtqDiWFzn4blyo31aYoMuqQ8pHEpqOOWWb9WgZeP4LuSTJF5DvIGUCO2h146 /kE/SU/A0eJOf3kNz+3/wfmrS541/SOm6AqImUeZi6WtHNafPXyGtgONJWZbcP9NODxs 7i77l0UWUQgw2IejZZnDAxCSvL32axPOgsq9euS4/AJLzgwHO54lXwthcH4mCv2gPJna z2uWlCnR/DiZUZYBrnqCZzgyeq6Hdjdhsues17NGD/YOwQS1Uhh7F8DN+K+ntkEuCx1m 8krg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=sK/GFG6TYUaoyd+Hu4W1xz3mUYUg+OSib2U1QooR/hU=; b=h6ImvjqPLp6KxeItt6iCnl7BlHWboneCoZb+6S2XEWOjf+r5cMuQsj6Wa9VIC+6ov/ x8DgWMamNXJejrNvsdnULGCMpy/4cEcgHlpQzlgP82ppL18vuE7TOU7gg32aoepRS2no LMwUW5PxlZ+AK3xGsDzqDmoJYFij2zGGlJg/V6/qoUJdGIMHwnCKYs7469pVwtuHyLH9 bYXLZCWhSOft4dps8pMv+HDRQG2+lmR/3NGfu+cAme1M6QTfiJa2N2Kje3lz5E8oonbT FYzHO3w2oH72mE28XKxwsXYYtcV4eBrIbIS8SFebFUgOZfidrp0YQPLmd8Kj3O3JJ/G8 mD0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=pgpVmXPL; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id iy19-20020a170907819300b008c215db35a7si7808079ejc.37.2023.02.20.23.51.43; Mon, 20 Feb 2023 23:52:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=pgpVmXPL; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233643AbjBUHc5 (ORCPT + 99 others); Tue, 21 Feb 2023 02:32:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbjBUHcz (ORCPT ); Tue, 21 Feb 2023 02:32:55 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 630D2469D; Mon, 20 Feb 2023 23:32:54 -0800 (PST) Date: Tue, 21 Feb 2023 07:32:51 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1676964772; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sK/GFG6TYUaoyd+Hu4W1xz3mUYUg+OSib2U1QooR/hU=; b=pgpVmXPLBaBQMKI1dxvWTGgMUL5JDGJGErOJihDeN0RU6+b3/jAPpSMxRa8ZD6/yv0y/h6 yt7C/Y5A1ZMR1p3BzYErhsy5ohWSDyVATx7W6V0/oKKjxWTOvhQ6NELuWd7gRrdDb54y2O 2yFCxQgP173S40t57TVuNgTrqYUR0bc5cmgWvlouab5RUx6o+FxGMlCe+Jp7rmqAGrfyi+ WZYXPA8zCGHra5z5UstPuNgeuPJ1Q+1gS4iLFSpPuXHQw6v4hgrdJ8YhLFT/ZikvEqWq7q ivZMjDtET3oZEUkPqlPREO7AxsUv3+UiQiGy866lUmc5iDwQctKQLzl2wAP8Ew== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1676964772; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sK/GFG6TYUaoyd+Hu4W1xz3mUYUg+OSib2U1QooR/hU=; b=xl0ROWaldX359j0Ubv2eha0jFK6LXedn7duiUmuUnIQck/YDxzGrRbr1hn6IMybJvIQhqy XD4bNyd2kRkk8FBw== From: "tip-bot2 for Reinette Chatre" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: irq/urgent] PCI/MSI: Clarify usage of pci_msix_free_irq() Cc: Reinette Chatre , Thomas Gleixner , Kevin Tian , x86@kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org In-Reply-To: <87r0xsd8j4.ffs@tglx> References: <87r0xsd8j4.ffs@tglx> MIME-Version: 1.0 Message-ID: <167696477130.387.8165200996017804708.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758426223413405072?= X-GMAIL-MSGID: =?utf-8?q?1758426223413405072?= The following commit has been merged into the irq/urgent branch of tip: Commit-ID: e6cc6f175566dd21a3f6e384c24593b1c751dd74 Gitweb: https://git.kernel.org/tip/e6cc6f175566dd21a3f6e384c24593b1c751dd74 Author: Reinette Chatre AuthorDate: Tue, 14 Feb 2023 13:13:20 -08:00 Committer: Thomas Gleixner CommitterDate: Tue, 21 Feb 2023 08:25:14 +01:00 PCI/MSI: Clarify usage of pci_msix_free_irq() pci_msix_free_irq() is used to free an interrupt on a PCI/MSI-X interrupt domain. The API description specifies that the interrupt to be freed was allocated via pci_msix_alloc_irq_at(). This description limits the usage of pci_msix_free_irq() since pci_msix_free_irq() can also be used to free MSI-X interrupts allocated with, for example, pci_alloc_irq_vectors(). Remove the text stating that the interrupt to be freed had to be allocated with pci_msix_alloc_irq_at(). The needed struct msi_map need not be from pci_msix_alloc_irq_at() but can be created from scratch using pci_irq_vector() to obtain the Linux IRQ number. Highlight that pci_msix_free_irq() cannot be used to disable MSI-X to guide users that, for example, pci_free_irq_vectors() remains to be needed. Signed-off-by: Reinette Chatre Signed-off-by: Thomas Gleixner Reviewed-by: Kevin Tian Link: https://lore.kernel.org/lkml/87r0xsd8j4.ffs@tglx Link: https://lore.kernel.org/r/4c3e7a50d6e70f408812cd7ab199c6b4b326f9de.1676408572.git.reinette.chatre@intel.com --- drivers/pci/msi/api.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/msi/api.c b/drivers/pci/msi/api.c index b8009aa..be679aa 100644 --- a/drivers/pci/msi/api.c +++ b/drivers/pci/msi/api.c @@ -163,11 +163,11 @@ EXPORT_SYMBOL_GPL(pci_msix_alloc_irq_at); /** * pci_msix_free_irq - Free an interrupt on a PCI/MSIX interrupt domain - * which was allocated via pci_msix_alloc_irq_at() * * @dev: The PCI device to operate on * @map: A struct msi_map describing the interrupt to free - * as returned from the allocation function. + * + * Undo an interrupt vector allocation. Does not disable MSI-X. */ void pci_msix_free_irq(struct pci_dev *dev, struct msi_map map) {