From patchwork Mon Feb 20 05:45:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bumwoo Lee X-Patchwork-Id: 59259 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1154906wrn; Sun, 19 Feb 2023 22:16:45 -0800 (PST) X-Google-Smtp-Source: AK7set/F8QGdRHEG/u6EjXWddWDueiMm0mkisISS7rf+7qYkZKedAjjpF24q4C3PuIk51SIHyve7 X-Received: by 2002:a17:902:e547:b0:19a:a815:2876 with SMTP id n7-20020a170902e54700b0019aa8152876mr673122plf.62.1676873804738; Sun, 19 Feb 2023 22:16:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676873804; cv=none; d=google.com; s=arc-20160816; b=0FmWfwvTTjXmB8ZGLST5c790aE7/F1mI04QvRQwwnI9Y9LZ27TjaN1XEe4i2ygvr0L gTqDmI26xpG5RtU2qqKyc4IWIaB0pzcCcPnLkDA1SbCjt+D4pI1NszoumwoBOtpDr0Tn 86VUQdxdpIyfuCR9X7MqGYGSlB47Q/FUhdVqZjSonAZPndj69zTcCk+y/4ZufAL2072b 3DTdUqvnaBH8R/tApsuMRBVFpLXUtKglwoggGg6Ofp73YneZg0eymNQ6PbXPUNZo+h+9 YbplIKz6C/05xHzrSn/Vo73fAy7hj8sE6USPZaZhDJWUBOQXGLrbknY4Ru9NagcbJtfB B08g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:dlp-filter:cms-type :content-transfer-encoding:mime-version:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=TTV8W6gw3S+wohmFfLikBMFap7zij34yNhu2CdJ/iUI=; b=uWvGeHGdUdd/8MA+5cXit3z19TaqPNp/AXBuw7FvnwYdX8wPhX5o3DoBzg+3cY1+qJ VLnYd8YKR2poGDopd7vIbejnxfNL6U7+VWMNdX3xMnIkVHT+mBII/yhMDzg2MFjvPuMd JGxGpWbDFyrO/Wd7a4Sdovqr2pm0H7AIQwchQLiewdlKVNRJJCEKltc5FI28dmj4DT6a VgaQxG5l+UJkPPm9iQt+rop5fvKY7Z04D3y+ZSjOWPgUeoA6uu9rT6wjrhxvzPfhmqA7 QaWSd/TklSYlmM8xZz9JIAvkPSWt6XLpb+43+O/xx8QHwqaQMQc4jMtUJJqnTrPMVV3B W4tg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b="iO6x0/i2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u9-20020a1709026e0900b00186892f9f29si1146835plk.488.2023.02.19.22.16.32; Sun, 19 Feb 2023 22:16:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b="iO6x0/i2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230062AbjBTFpx (ORCPT + 99 others); Mon, 20 Feb 2023 00:45:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230050AbjBTFpv (ORCPT ); Mon, 20 Feb 2023 00:45:51 -0500 Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27697BDFA for ; Sun, 19 Feb 2023 21:45:49 -0800 (PST) Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20230220054546epoutp04c603bd23a143b6bbc94000aed2753c90~Fcia9BiUp0260502605epoutp04m for ; Mon, 20 Feb 2023 05:45:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20230220054546epoutp04c603bd23a143b6bbc94000aed2753c90~Fcia9BiUp0260502605epoutp04m DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1676871947; bh=TTV8W6gw3S+wohmFfLikBMFap7zij34yNhu2CdJ/iUI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iO6x0/i2RZgBnOb00qpwkhnmJs25DkKdtmY7UQsqM9rD8tTpeKBGwJ8bDWnXaD3gC RL7HVNrzeVHOsnJmeCD4CyvYAi4Riwp1vt7513PJXYaxEveHWhdxZ3rUyyTQ0h7kXs wrd41SVI9+NL6F1pfykSprzEx02L3a6A7WGmtDKw= Received: from epsnrtp3.localdomain (unknown [182.195.42.164]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20230220054546epcas1p30dee9ef5a8819d341351c0405e0fb67a~FciaqA3ml1540715407epcas1p3r; Mon, 20 Feb 2023 05:45:46 +0000 (GMT) Received: from epsmges1p3.samsung.com (unknown [182.195.36.224]) by epsnrtp3.localdomain (Postfix) with ESMTP id 4PKrxQ03Lkz4x9Q3; Mon, 20 Feb 2023 05:45:46 +0000 (GMT) Received: from epcas1p2.samsung.com ( [182.195.41.46]) by epsmges1p3.samsung.com (Symantec Messaging Gateway) with SMTP id 67.D9.52037.90903F36; Mon, 20 Feb 2023 14:45:45 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p3.samsung.com (KnoxPortal) with ESMTPA id 20230220054545epcas1p31abd5e19a4e4825c6f7a4be2139ddaed~FciZztUqi1540115401epcas1p37; Mon, 20 Feb 2023 05:45:45 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230220054545epsmtrp2db5862a4cbeadb1a66309914dc8ac8d8~FciZzDH-b0986209862epsmtrp2B; Mon, 20 Feb 2023 05:45:45 +0000 (GMT) X-AuditID: b6c32a37-d6eb8a800001cb45-19-63f309091d85 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 2F.77.17995.90903F36; Mon, 20 Feb 2023 14:45:45 +0900 (KST) Received: from VDBS1418.vd.sec.samsung.net (unknown [168.219.244.30]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20230220054545epsmtip177169cb1b9e420a7bc37b0dccce00975~FciZmS1gn2598325983epsmtip1o; Mon, 20 Feb 2023 05:45:45 +0000 (GMT) From: Bumwoo Lee To: MyungJoo Ham , Chanwoo Choi , linux-kernel@vger.kernel.org Cc: Bumwoo Lee Subject: [PATCH v2 1/4] extcon: Removed redundant null checking for class Date: Mon, 20 Feb 2023 14:45:10 +0900 Message-Id: <20230220054513.27385-2-bw365.lee@samsung.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230220054513.27385-1-bw365.lee@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHKsWRmVeSWpSXmKPExsWy7bCmni4n5+dkg99/LS1OrFnEZHH9y3NW i8u75rBZ3G5cwebA4tG3ZRWjx+dNcgFMUdk2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6 hpYW5koKeYm5qbZKLj4Bum6ZOUCLlBTKEnNKgUIBicXFSvp2NkX5pSWpChn5xSW2SqkFKTkF ZgV6xYm5xaV56Xp5qSVWhgYGRqZAhQnZGes+vWIq+MdZsf35K9YGxmkcXYycHBICJhIbLm9h 7GLk4hAS2MEocXzxNTYI5xOjxL6u00wQzmdGiZbd25hgWjqeLISq2sUosfbdCSjnF6PE5obb bCBVbAIaEnsuNgDZHBwiAoUSh/uzQcLMAmoSD1ZtZAexhQU8JW4/2cwIYrMIqEq8efaCFcTm FbCSOHXvPDPEMnmJ7n9/WEBsTgFriX/PF7FB1AhKnJz5hAViprxE89bZzCA3SAjsY5fYtucP VLOLxOP5S6GuFpZ4dXwLO4QtJfH53V42CDtdYuWVO1DxHInX99sZIWxjiXdv1zKD3M8soCmx fpc+RFhRYufvuYwQe/kk3n3tYQUpkRDglehoE4IoUZbofvACaqukxOKnd6AmekjM2NjNDgmq PkaJ3cePsU9gVJiF5J1ZSN6ZhbB5ASPzKkax1ILi3PTUYsMCY3gMJ+fnbmIEJzwt8x2M095+ 0DvEyMTBeIhRgoNZSYRX+tCHZCHelMTKqtSi/Pii0pzU4kOMpsDAnsgsJZqcD0y5eSXxhiaW BiZmRiYWxpbGZkrivOK2J5OFBNITS1KzU1MLUotg+pg4OKUamGQrHl2b+U506+oOp/fCxYd8 jK7oiE3q9f6/7MZCjn0rVPzObqiXs5i4TfDjo63hXV0bvhf+EbzqVMOs11rx5LHGsq3PG0/+ XWOR71F4btmDlIgrQVMm6H4JFbC7zuWlodzr8TVR+7r5n2c7nVatrHhoyzm1f1Hg3alRe9+k T1nTllmxKC1Z8p232DKZHmmORXaF+ovPuU7u2mO/q8RoxZSdDg0LA+4tKnDI21D06sbVTcy6 Hw5ZKL1p58nTvNQj+e6jX/OnjRpemxdLvTO93VTmfHK58a7dulPYz2hP/BXJVeSw/U7+a3Xv qTcU56ztujuPJT34tMMcPyMbzt+Fr+fN9Oz9ZbUpw6ns9sd15/4qsRRnJBpqMRcVJwIAnNv+ DQEEAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBLMWRmVeSWpSXmKPExsWy7bCSnC4n5+dkg1vL1S1OrFnEZHH9y3NW i8u75rBZ3G5cwebA4tG3ZRWjx+dNcgFMUVw2Kak5mWWpRfp2CVwZ6z69Yir4x1mx/fkr1gbG aRxdjJwcEgImEh1PFrJ1MXJxCAnsYJQ4uXsiC0RCUuLs8kfsXYwcQLawxOHDxRA1Pxglzl7Z D1bDJqAhsediAxuILSJQLHHhwGKwOLOAmsSDVRvZQWxhAU+J2082M4LYLAKqEm+evWAFsXkF rCRO3TvPDLFLXqL73x+wXk4Ba4l/zxeBzRQCqmmbPJkZol5Q4uTMJ1Dz5SWat85mnsAoMAtJ ahaS1AJGplWMkqkFxbnpucWGBUZ5qeV6xYm5xaV56XrJ+bmbGMGBqaW1g3HPqg96hxiZOBgP MUpwMCuJ8Eof+pAsxJuSWFmVWpQfX1Sak1p8iFGag0VJnPdC18l4IYH0xJLU7NTUgtQimCwT B6dUAxNHxOLzbsnT9ZjOfDyYeW3m5BBVa43tIgGbnEzz/RKNs06ZsJ/JPzfftujdo9gab701 K3yXlvet/le7afLEv0stNAxZz/zqKzjueDwnYl7KKr7uy2ejfPv03BY9TcoPMZ15M7f6lNW0 +/OuGWt+jZ1keeB14rynWXPl7kWI2y+wvHIiubSU01BVfbp3oWzmTVZl6ae7lgeyOWt8lmoW OL4v+Yfdz/UZ13W3Jzyc/KpbrcT0atmyz1Iyau+lv2h4nsy698VPRbX2Y9nEtQaOD9b9Tdpp /zph3bPr93sWHvRz+eu+9kFux9w1ctyvfMr1JxhOrA4LlFkh9dOr05F/P9uqDxfNz7QUtHpE KWf+f6jEUpyRaKjFXFScCACQ1KiYuwIAAA== X-CMS-MailID: 20230220054545epcas1p31abd5e19a4e4825c6f7a4be2139ddaed X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230220054545epcas1p31abd5e19a4e4825c6f7a4be2139ddaed References: <20230220054513.27385-1-bw365.lee@samsung.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758329626312188367?= X-GMAIL-MSGID: =?utf-8?q?1758329626312188367?= create_extcon_class() is already Null checking. Signed-off-by: Bumwoo Lee --- drivers/extcon/extcon.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index e1c71359b605..adcf01132f70 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1012,12 +1012,13 @@ ATTRIBUTE_GROUPS(extcon); static int create_extcon_class(void) { - if (!extcon_class) { - extcon_class = class_create(THIS_MODULE, "extcon"); - if (IS_ERR(extcon_class)) - return PTR_ERR(extcon_class); - extcon_class->dev_groups = extcon_groups; - } + if (extcon_class) + return 0; + + extcon_class = class_create(THIS_MODULE, "extcon"); + if (IS_ERR(extcon_class)) + return PTR_ERR(extcon_class); + extcon_class->dev_groups = extcon_groups; return 0; } @@ -1088,11 +1089,9 @@ int extcon_dev_register(struct extcon_dev *edev) int ret, index = 0; static atomic_t edev_no = ATOMIC_INIT(-1); - if (!extcon_class) { - ret = create_extcon_class(); - if (ret < 0) - return ret; - } + ret = create_extcon_class(); + if (ret < 0) + return ret; if (!edev || !edev->supported_cable) return -EINVAL; From patchwork Mon Feb 20 05:45:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bumwoo Lee X-Patchwork-Id: 59257 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1154462wrn; Sun, 19 Feb 2023 22:15:11 -0800 (PST) X-Google-Smtp-Source: AK7set8H2eeV4CImuAU5aEv6CdloTts8BsS0mFnxSNC7rRakli8IADbLCs8JQHZuMSM2kJJzi9qA X-Received: by 2002:aa7:955c:0:b0:593:91e4:99e2 with SMTP id w28-20020aa7955c000000b0059391e499e2mr1890255pfq.34.1676873710669; Sun, 19 Feb 2023 22:15:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676873710; cv=none; d=google.com; s=arc-20160816; b=q50EOcE7PSPxzyCQjGaEIultZXwZ3wCsOxt2sLW+/GgbOnbZ+jPiZUPU6JapXCIRL0 eHwEC4xvbTWnzKMMFv9exWkcBndp5HPgjle8VUdfw+4I/rk6xeq7wf7FF9v7vRT4VNfc +ti7K5PhaftyoJHWsdaLCxYkRj6Wq+Rvt38k0/PIzkiLLhUcM1o3VgqYeaYam+0B0MSE 7MFQHEDA6k9ixtRUnFMlr4nFLn2dNHF1phBygiy9++mk9/dsYOupJTqZdL+uJffCtOHy mry8ZJLmLmqY9P7NHl5BaINKPv07v07durqv0U1vujpyhgDxTuWRKohKZybEQ+eQ8mhS ZGRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:dlp-filter:cms-type :content-transfer-encoding:mime-version:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=15QEWNO/YBw7mVP+MxhNzSlTSz4ta3BdtNp9n1HdAJk=; b=vm5iuWL1gQKGGZE1EYbTUJ2EB2In7J3/YqTD2OxBi9DOHaT1FHP2Ke/lUeBS/6/OBG py4mazl6SS2PjwntcZ7LOgCjxYZFGOG9mvOhFB7qIrCpH/RRCKB2jDb+lSDkkGI7gPBV FiyF7rErQ/BvrK5pTOa8J0D3gjJ9XzvLZImAC5z9/1/moT+FtxmkBN65FfAR7GBcr5DI cj5ImAtL515xGeXwnmJWlGmltyuxkcVCvhzzGYhiaII85f5Z0eoMzPEl+Yufa775H/d0 7gpmD5Zk0QofKxW+OT5ATK+eG9WBJ9FqzctQQvSzuG3XJPDsxQae1tnPV5emCkUsKLg6 Kw8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=GYT1e+EF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z3-20020aa79583000000b0056e4c95266bsi13343282pfj.77.2023.02.19.22.14.57; Sun, 19 Feb 2023 22:15:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=GYT1e+EF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230085AbjBTFqI (ORCPT + 99 others); Mon, 20 Feb 2023 00:46:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230074AbjBTFpx (ORCPT ); Mon, 20 Feb 2023 00:45:53 -0500 Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 316ACD50B for ; Sun, 19 Feb 2023 21:45:51 -0800 (PST) Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20230220054547epoutp03a71e9c13552cace11a977d2132304065~Fciblhrh20689906899epoutp03Z for ; Mon, 20 Feb 2023 05:45:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20230220054547epoutp03a71e9c13552cace11a977d2132304065~Fciblhrh20689906899epoutp03Z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1676871947; bh=15QEWNO/YBw7mVP+MxhNzSlTSz4ta3BdtNp9n1HdAJk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GYT1e+EFvJoj9heuhExsaJ5z1ISzeVoyPoky3K/wcvrJbzAp3i/ryh09uAPEPIP7t mdudYHuqGcC9rhL8SfMgButAkWY4wtuOW21Kgd44ygXUMbxZKZsyCluySyyr690JPG PZvwpcPGjJhPlfj+dzrbx0oCBBbNQqYB9gE+uUEI= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20230220054547epcas1p3bbd0305c4f4844a56fdd838a4fd683f1~FcibFpyhr1540715407epcas1p3t; Mon, 20 Feb 2023 05:45:47 +0000 (GMT) Received: from epsmges1p4.samsung.com (unknown [182.195.36.222]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4PKrxQ09VSz4x9QB; Mon, 20 Feb 2023 05:45:46 +0000 (GMT) Received: from epcas1p2.samsung.com ( [182.195.41.46]) by epsmges1p4.samsung.com (Symantec Messaging Gateway) with SMTP id 15.A5.37890.90903F36; Mon, 20 Feb 2023 14:45:45 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p3.samsung.com (KnoxPortal) with ESMTPA id 20230220054545epcas1p34e5575ffdfd1dcef55bdee3c3563c925~FciZ0mNeM1540715407epcas1p3q; Mon, 20 Feb 2023 05:45:45 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230220054545epsmtrp273db62166c22ca59eee32c0ca130556a~FciZz7K3Z0972009720epsmtrp2i; Mon, 20 Feb 2023 05:45:45 +0000 (GMT) X-AuditID: b6c32a38-bbd3aa8000029402-14-63f30909823a Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 06.5A.05839.90903F36; Mon, 20 Feb 2023 14:45:45 +0900 (KST) Received: from VDBS1418.vd.sec.samsung.net (unknown [168.219.244.30]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20230220054545epsmtip106c71a61c85c67776e2da3f7d27f1905~FciZqv6Ut2598425984epsmtip1k; Mon, 20 Feb 2023 05:45:45 +0000 (GMT) From: Bumwoo Lee To: MyungJoo Ham , Chanwoo Choi , linux-kernel@vger.kernel.org Cc: Bumwoo Lee Subject: [PATCH v2 2/4] extcon: Added extcon_alloc_cables to simplify extcon register function Date: Mon, 20 Feb 2023 14:45:11 +0900 Message-Id: <20230220054513.27385-3-bw365.lee@samsung.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230220054513.27385-1-bw365.lee@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNKsWRmVeSWpSXmKPExsWy7bCmni4n5+dkg0uzrS1OrFnEZHH9y3NW i8u75rBZ3G5cwebA4tG3ZRWjx+dNcgFMUdk2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6 hpYW5koKeYm5qbZKLj4Bum6ZOUCLlBTKEnNKgUIBicXFSvp2NkX5pSWpChn5xSW2SqkFKTkF ZgV6xYm5xaV56Xp5qSVWhgYGRqZAhQnZGR8b5rEXHJKr2DZlAnsD4xGJLkZODgkBE4n3jQfY uhi5OIQEdjBKXFx4kwXC+cQocfLTBqjMN0aJ6ct72GFaPm37zAJiCwnsZZT48k8UougXo8Sm xWvAEmwCGhJ7LjYAdXNwiAgUShzuzwYJMwuoSTxYtRFsjrBAgsTcvgVsIDaLgKrEpZN3mUDK eQWsJPpWuEKskpfo/vcHbCKngLXEv+eLwMp5BQQlTs58wgIxUl6ieetsZpATJAT2sUu8OHGT CaLZReL6wrdQtrDEq+NboO6Xkvj8bi8bhJ0usfLKHah4jsTr++2MELaxxLu3a5lB7mEW0JRY v0sfIqwosfP3XEaIvXwS7772sIKUSAjwSnS0CUGUKEt0P3gBtVVSYvHTO1ATPSQmnTvBCgm1 PkaJG6fLJzAqzELyzSwk38xCWLyAkXkVo1hqQXFuemqxYYEJPHqT83M3MYJTnZbFDsa5bz/o HWJk4mA8xCjBwawkwit96EOyEG9KYmVValF+fFFpTmrxIUZTYFBPZJYSTc4HJtu8knhDE0sD EzMjEwtjS2MzJXFecduTyUIC6YklqdmpqQWpRTB9TBycUg1MpkVKthxn7zAs7nerMDNps+hb KiazhOPHVD4uo5X8czrc1seWLBBX+Smu9PKRO/ucygj5WcucOlKvlTT+0N/tVp6tOrXT6IQs T8yCIt3VMp9v3nfji954jYvf+JB3nFefz8PJ24o+7Tz2Xe6xNNP1q276m31sZW76Tzy5PtH+ we6PVvFBDU/XP7zYPEvG0pz9x7Sal+cz8iTPyGbUapd6n/JwfLv8kl3iu5Nbc6zvCgZJHbFi d+NosujYHh8Y6vZP2d6VT9VUeKbv0pVed+Y3nI+U/pG/7qq7U0P97tRzxxtZ5A/U+M87/+n0 k0SF77O8hY7GKs9eOj3l7tM9sv9rGQ89yDt16f61+j2xtQuUWIozEg21mIuKEwG0gBYU/gMA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOLMWRmVeSWpSXmKPExsWy7bCSnC4n5+dkgwX/NCxOrFnEZHH9y3NW i8u75rBZ3G5cwebA4tG3ZRWjx+dNcgFMUVw2Kak5mWWpRfp2CVwZHxvmsRcckqvYNmUCewPj EYkuRk4OCQETiU/bPrN0MXJxCAnsZpTYs6KFCSIhKXF2+SP2LkYOIFtY4vDhYoiaH4wSy3e8 ZAepYRPQkNhzsYENxBYRKJa4cGAxC4jNLKAm8WDVRrAaYYE4iS+bWllBbBYBVYlLJ+8ygczk FbCS6FvhCrFKXqL73x+wVk4Ba4l/zxeBjRQCKmmbPJkZxOYVEJQ4OfMJ1Hh5ieats5knMArM QpKahSS1gJFpFaNkakFxbnpusWGBYV5quV5xYm5xaV66XnJ+7iZGcFhqae5g3L7qg94hRiYO xkOMEhzMSiK80oc+JAvxpiRWVqUW5ccXleakFh9ilOZgURLnvdB1Ml5IID2xJDU7NbUgtQgm y8TBKdXAJLMqvqFw+oQ9l1iEZlUrb8suKP+4sHGDzK2C/9sPH8x/WLGG80/z/unbeO9wfX1+ 7QNn4PG9P5bN8wvR4mG73//vicmih+r2X1/JiGa8b5NQPJWx/LObMOMfo40/+Oc9+NrxyTgp iD0uuV57g27fd353y33B25t5V8V5ytpLzd1xsabScWL5bU9Z3SuZLdOlKr62L7EwWhlX07FB 5diUji2N39iELXcEHWjNuOSx993+qzYFcV0hf15rbtieWJKg1/tL8fnuHqGvGZpVlysvME7t /aNR7G/5YeXUJwJOsTZs4h/d3pW5XU53FeObIz7tGXvr4vo6r+DViWIasysmNyw2vc1V1v9v bZmeRZumEktxRqKhFnNRcSIA3v7DwLoCAAA= X-CMS-MailID: 20230220054545epcas1p34e5575ffdfd1dcef55bdee3c3563c925 X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230220054545epcas1p34e5575ffdfd1dcef55bdee3c3563c925 References: <20230220054513.27385-1-bw365.lee@samsung.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758329528167162283?= X-GMAIL-MSGID: =?utf-8?q?1758329528167162283?= The cable allocation part is functionalized from extcon_dev_register. Signed-off-by: Bumwoo Lee --- drivers/extcon/extcon.c | 104 +++++++++++++++++++++++----------------- 1 file changed, 59 insertions(+), 45 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index adcf01132f70..3c2f540785e8 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1070,6 +1070,61 @@ void extcon_dev_free(struct extcon_dev *edev) } EXPORT_SYMBOL_GPL(extcon_dev_free); +/** + * extcon_alloc_cables() - alloc the cables for extcon device + * @edev: extcon device which has cables + * + * Returns 0 if success or error number if fail. + */ +static int extcon_alloc_cables(struct extcon_dev *edev) +{ + int index; + char *str; + struct extcon_cable *cable; + + if (!edev->max_supported) + return 0; + + edev->cables = kcalloc(edev->max_supported, + sizeof(struct extcon_cable), + GFP_KERNEL); + if (!edev->cables) + return -ENOMEM; + + for (index = 0; index < edev->max_supported; index++) { + cable = &edev->cables[index]; + + str = kasprintf(GFP_KERNEL, "cable.%d", index); + if (!str) { + for (index--; index >= 0; index--) { + cable = &edev->cables[index]; + kfree(cable->attr_g.name); + } + return -ENOMEM; + } + + cable->edev = edev; + cable->cable_index = index; + cable->attrs[0] = &cable->attr_name.attr; + cable->attrs[1] = &cable->attr_state.attr; + cable->attrs[2] = NULL; + cable->attr_g.name = str; + cable->attr_g.attrs = cable->attrs; + + sysfs_attr_init(&cable->attr_name.attr); + cable->attr_name.attr.name = "name"; + cable->attr_name.attr.mode = 0444; + cable->attr_name.show = cable_name_show; + + sysfs_attr_init(&cable->attr_state.attr); + cable->attr_state.attr.name = "state"; + cable->attr_state.attr.mode = 0444; + cable->attr_state.show = cable_state_show; + } + + return 0; +} + /** * extcon_dev_register() - Register an new extcon device * @edev: the extcon device to be registered @@ -1117,50 +1172,9 @@ int extcon_dev_register(struct extcon_dev *edev) dev_set_name(&edev->dev, "extcon%lu", (unsigned long)atomic_inc_return(&edev_no)); - if (edev->max_supported) { - char *str; - struct extcon_cable *cable; - - edev->cables = kcalloc(edev->max_supported, - sizeof(struct extcon_cable), - GFP_KERNEL); - if (!edev->cables) { - ret = -ENOMEM; - goto err_sysfs_alloc; - } - for (index = 0; index < edev->max_supported; index++) { - cable = &edev->cables[index]; - - str = kasprintf(GFP_KERNEL, "cable.%d", index); - if (!str) { - for (index--; index >= 0; index--) { - cable = &edev->cables[index]; - kfree(cable->attr_g.name); - } - ret = -ENOMEM; - - goto err_alloc_cables; - } - - cable->edev = edev; - cable->cable_index = index; - cable->attrs[0] = &cable->attr_name.attr; - cable->attrs[1] = &cable->attr_state.attr; - cable->attrs[2] = NULL; - cable->attr_g.name = str; - cable->attr_g.attrs = cable->attrs; - - sysfs_attr_init(&cable->attr_name.attr); - cable->attr_name.attr.name = "name"; - cable->attr_name.attr.mode = 0444; - cable->attr_name.show = cable_name_show; - - sysfs_attr_init(&cable->attr_state.attr); - cable->attr_state.attr.name = "state"; - cable->attr_state.attr.mode = 0444; - cable->attr_state.show = cable_state_show; - } - } + ret = extcon_alloc_cables(edev); + if (ret) + goto err_alloc_cables; if (edev->max_supported && edev->mutually_exclusive) { char *name; @@ -1282,7 +1296,7 @@ int extcon_dev_register(struct extcon_dev *edev) err_alloc_cables: if (edev->max_supported) kfree(edev->cables); -err_sysfs_alloc: + return ret; } EXPORT_SYMBOL_GPL(extcon_dev_register); From patchwork Mon Feb 20 05:45:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bumwoo Lee X-Patchwork-Id: 59258 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1154759wrn; Sun, 19 Feb 2023 22:16:18 -0800 (PST) X-Google-Smtp-Source: AK7set81calpsjpBOBXNmp0l44J45RYUovG5x4xk9apWZOyitiTTcLxyoYyqUVLEveloof6EovsX X-Received: by 2002:a17:90b:3b87:b0:236:6e4f:bc1e with SMTP id pc7-20020a17090b3b8700b002366e4fbc1emr710052pjb.49.1676873777888; Sun, 19 Feb 2023 22:16:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676873777; cv=none; d=google.com; s=arc-20160816; b=AI3kxMSs2sNLampBsJD3uGXhFOOjr9Wf9/i+PLVyNu/e8ORIvgFG1QdtuQ49Y1lJCh RfJPeVnCp7T1qCL1AmqQtM/qrwSciXbEOA7dZxIVkxJ1t+z0OHeXGmXkUgg8Ig5kM1ZJ rwM7e7jQOqpXO080rVVf9M7PiJBndvuUmdlvDf3Fjiom4qTZzKf3WMVs+JkYHVFsUCWL 3rdGQyehomLbH0AWA+FlnyD5pObt12ATKtjF1dFiHDvrA6afuFQs8qhNqFMNBLti6GdZ mXydIJkn6I8K0hwvUtezlJ/CUOyNn26Fp/59UeCBGRlQM6GF3VSRsDrXM8ht7YHweCDj cGtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:dlp-filter:cms-type :content-transfer-encoding:mime-version:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=Lomkw3wOGq30Z8bGw0g7vY7CMRkAMEbVBey5jm8G6Ak=; b=DUb/DBIPB7pTThn+dJxBwSmg29dKt4/W0LGD/HRbFgpRkVNCPDLRPG/J2WxGKWefSI HN8g3b5PhnT9TW/1nRrp7EAarkRVc3ItZPmLp64a2AMf6x584ERIN6AA9vgWz2k1Z5NX 4AsiAASUGwdk2GGpeHaJuPA8BoRhE0KmO4C83yo1kT2qC8JUDqRn1aBv8sXbhP71/gUu 1ARLYejUZcgplsiQqDxaZ8dgXpgPnV0oN2mKRji/4m3BIlkR7au1aJ+IXynkGW8DpgVX ubEI0rEtuFBu4wb7bkaOR6w8wodvvq5SxRrQp1jMRXwOJEBad7usviNVxoUH8X/DstJ+ M66A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=IXxAMwvN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 65-20020a630044000000b004fbb1fa8e13si2961930pga.747.2023.02.19.22.16.05; Sun, 19 Feb 2023 22:16:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=IXxAMwvN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230059AbjBTFqF (ORCPT + 99 others); Mon, 20 Feb 2023 00:46:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230076AbjBTFpx (ORCPT ); Mon, 20 Feb 2023 00:45:53 -0500 Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39CCBDBC5 for ; Sun, 19 Feb 2023 21:45:51 -0800 (PST) Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20230220054547epoutp03c5937f86feaee31f31e7e78e112c7cae~Fcibrbr6V0620706207epoutp03v for ; Mon, 20 Feb 2023 05:45:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20230220054547epoutp03c5937f86feaee31f31e7e78e112c7cae~Fcibrbr6V0620706207epoutp03v DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1676871947; bh=Lomkw3wOGq30Z8bGw0g7vY7CMRkAMEbVBey5jm8G6Ak=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IXxAMwvNA4yN6Sl0+4FH4g98ZhhbR7qBm1Y6tcty637GyecRZlKWmTv8k22ZQfrOY qr/qN/Nj+IkrR92CZBlROcj8fBmHJATU4p3BqIy4hySTVnbo5qUBnQsvDq4qrTaKQ+ yRSUU6JQMa/Bo4s0+nGw6Fw8oqcWBYOwJyO33x0g= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p1.samsung.com (KnoxPortal) with ESMTP id 20230220054547epcas1p189575adc2ceea9b747fb1b5c1891de5f~FcibWe71Q2217522175epcas1p1_; Mon, 20 Feb 2023 05:45:47 +0000 (GMT) Received: from epsmges1p2.samsung.com (unknown [182.195.36.222]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4PKrxQ2Xqcz4x9Q9; Mon, 20 Feb 2023 05:45:46 +0000 (GMT) Received: from epcas1p1.samsung.com ( [182.195.41.45]) by epsmges1p2.samsung.com (Symantec Messaging Gateway) with SMTP id A8.F9.12562.A0903F36; Mon, 20 Feb 2023 14:45:46 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p3.samsung.com (KnoxPortal) with ESMTPA id 20230220054545epcas1p3ab4b1281f464c72a7b5ed8681a8b087f~FciZ1eVcr1540615406epcas1p3f; Mon, 20 Feb 2023 05:45:45 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230220054545epsmtrp2fc038af6876d068e3afaf5df7136443a~FciZ0GU780986209862epsmtrp2C; Mon, 20 Feb 2023 05:45:45 +0000 (GMT) X-AuditID: b6c32a36-bfdff70000023112-7f-63f3090a2bbc Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 16.5A.05839.90903F36; Mon, 20 Feb 2023 14:45:45 +0900 (KST) Received: from VDBS1418.vd.sec.samsung.net (unknown [168.219.244.30]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20230220054545epsmtip14c1317fc0a019a6d360c1b1b4dca9823~FciZsjDQ82594925949epsmtip1t; Mon, 20 Feb 2023 05:45:45 +0000 (GMT) From: Bumwoo Lee To: MyungJoo Ham , Chanwoo Choi , linux-kernel@vger.kernel.org Cc: Bumwoo Lee Subject: [PATCH v2 3/4] extcon: Added extcon_alloc_muex to simplify extcon register function Date: Mon, 20 Feb 2023 14:45:12 +0900 Message-Id: <20230220054513.27385-4-bw365.lee@samsung.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230220054513.27385-1-bw365.lee@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDKsWRmVeSWpSXmKPExsWy7bCmri4X5+dkgxvzBSxOrFnEZHH9y3NW i8u75rBZ3G5cwebA4tG3ZRWjx+dNcgFMUdk2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6 hpYW5koKeYm5qbZKLj4Bum6ZOUCLlBTKEnNKgUIBicXFSvp2NkX5pSWpChn5xSW2SqkFKTkF ZgV6xYm5xaV56Xp5qSVWhgYGRqZAhQnZGWcnvWAvmCpfMXf2UvYGxncSXYycHBICJhI/Hl9l 7WLk4hAS2MEo0b1wIhuE84lRYmnDTnYI5xujxJLHk9lgWvb/XAeV2Mso8ejDFWYI5xejxIIj 11hBqtgENCT2XGwA6uDgEBEolDjcnw0SZhZQk3iwaiM7iC0sECex4sFjFhCbRUBVYuPeR2Bx XgEriSctF5ghlslLdP/7A1bDKWAt8e/5IjaIGkGJkzOfsEDMlJdo3jobqn4Xu8SGD9EQtovE tf7b7BC2sMSr41ugbCmJz+/2Qj2TLrHyyh2oeI7E6/vtjBC2scS7t2uZQc5nFtCUWL9LHyKs KLHz91xGiLV8Eu++9rCClEgI8Ep0tAlBlChLdD94wQRhS0osfnoHaqKHxILuzWAXCwn0MUpM 6ZOcwKgwC8kzs5A8Mwth8QJG5lWMYqkFxbnpqcWGBUbw+E3Oz93ECE52WmY7GCe9/aB3iJGJ g/EQowQHs5IIr/ShD8lCvCmJlVWpRfnxRaU5qcWHGE2BQT2RWUo0OR+YbvNK4g1NLA1MzIxM LIwtjc2UxHnFbU8mCwmkJ5akZqemFqQWwfQxcXBKNTDFs8wuPn/W3HjiRUe7mntFGSIn/O/s 2KV/+Z7FSa1ak1NBjz8YPpwveYuxeU74K+VvvMunPQhpz9DLyz7MeENMeprcL/djBw+Izd/2 1/Nhgvp28TU5z4U/b22b4xq1tMYn2PFT+FWWuAc7MnRyjt3il+dPklohsF/z2OI+veU6BTsU haoXVYt18q73PVtaFrSxbPHBTsPLwh5LJrjsEFSVn6N3YVvZubrDy6PXN1+oSJ+gYVT3yC/N /0RYxup5F6s+GHcsmHquQNczQ08tnefv6i39a0zPlVnlVE6cOz+X6cKP5dtZf5c8PLxjJ4/V iguffcWFfuns3PMueyXLlFcnffeZ/O1f921hvFu+mnOpEktxRqKhFnNRcSIAod9d/f8DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBLMWRmVeSWpSXmKPExsWy7bCSnC4n5+dkg03PtSxOrFnEZHH9y3NW i8u75rBZ3G5cwebA4tG3ZRWjx+dNcgFMUVw2Kak5mWWpRfp2CVwZZye9YC+YKl8xd/ZS9gbG dxJdjJwcEgImEvt/rmPvYuTiEBLYzSix9N9KNoiEpMTZ5Y+AEhxAtrDE4cPFEDU/GCUaVzcz gtSwCWhI7LnYAFYvIlAsceHAYhYQm1lATeLBqo3sILawQIzEo+s/mEFsFgFViY17H4HFeQWs JJ60XGCG2CUv0f3vD1gvp4C1xL/ni8BmCgHVtE2ezAxRLyhxcuYTqPnyEs1bZzNPYBSYhSQ1 C0lqASPTKkbJ1ILi3PTcYsMCw7zUcr3ixNzi0rx0veT83E2M4MDU0tzBuH3VB71DjEwcjIcY JTiYlUR4pQ99SBbiTUmsrEotyo8vKs1JLT7EKM3BoiTOe6HrZLyQQHpiSWp2ampBahFMlomD U6qBKTtaekXw5M6QOz+bLuQG/6teffXEtLqqz13Liz8/dVGs5My93rBiZlz9wz3Jxg+tH7/7 0cUWHBhtbZmkv2/JnZaf07NWXhD443Ri6dppRZMVtM+IvMg8yqXqnRPKlvaDI3nXKrWPk2M+ xEd5hAcf4hJofnVoUeOy4inmEhP/fn7LGca8/oDg+oBq4Qt2K4OeHby4pqyd7Vht8dIrRWtK lSQ+rmSa5DpduJbzkrhIEfOxNIcK3d0twbpOxZGlj35+sTubpfko89QeljOT8uReccYHr5PL Fl3fsf+T/6nG892e7+022naeCZK5sj3zYqC4IE/Wrhc5h3yDIoxKG3/YbJSwCf2z+tCfwkyP 0wKnlViKMxINtZiLihMBSRFhDLsCAAA= X-CMS-MailID: 20230220054545epcas1p3ab4b1281f464c72a7b5ed8681a8b087f X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230220054545epcas1p3ab4b1281f464c72a7b5ed8681a8b087f References: <20230220054513.27385-1-bw365.lee@samsung.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758329598666429686?= X-GMAIL-MSGID: =?utf-8?q?1758329598666429686?= The mutual exclusive part is functionalized from extcon_dev_register. Signed-off-by: Bumwoo Lee --- drivers/extcon/extcon.c | 106 ++++++++++++++++++++++------------------ 1 file changed, 58 insertions(+), 48 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 3c2f540785e8..2aec34909843 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1125,6 +1125,60 @@ static int extcon_alloc_cables(struct extcon_dev *edev) return 0; } +/** + * extcon_alloc_muex() - alloc the mutual exclusive for extcon device + * @edev: extcon device + * + * Returns 0 if success or error number if fail. + */ +static int extcon_alloc_muex(struct extcon_dev *edev) +{ + char *name; + int index; + + if (!(edev->max_supported && edev->mutually_exclusive)) + return 0; + + /* Count the size of mutually_exclusive array */ + for (index = 0; edev->mutually_exclusive[index]; index++) + ; + + edev->attrs_muex = kcalloc(index + 1, + sizeof(struct attribute *), + GFP_KERNEL); + if (!edev->attrs_muex) + return -ENOMEM; + + edev->d_attrs_muex = kcalloc(index, + sizeof(struct device_attribute), + GFP_KERNEL); + if (!edev->d_attrs_muex) { + kfree(edev->attrs_muex); + return -ENOMEM; + } + + for (index = 0; edev->mutually_exclusive[index]; index++) { + name = kasprintf(GFP_KERNEL, "0x%x", + edev->mutually_exclusive[index]); + if (!name) { + for (index--; index >= 0; index--) + kfree(edev->d_attrs_muex[index].attr.name); + + kfree(edev->d_attrs_muex); + kfree(edev->attrs_muex); + return -ENOMEM; + } + sysfs_attr_init(&edev->d_attrs_muex[index].attr); + edev->d_attrs_muex[index].attr.name = name; + edev->d_attrs_muex[index].attr.mode = 0000; + edev->attrs_muex[index] = &edev->d_attrs_muex[index].attr; + } + edev->attr_g_muex.name = muex_name; + edev->attr_g_muex.attrs = edev->attrs_muex; + + return 0; +} + /** * extcon_dev_register() - Register an new extcon device * @edev: the extcon device to be registered @@ -1176,53 +1230,9 @@ int extcon_dev_register(struct extcon_dev *edev) if (ret) goto err_alloc_cables; - if (edev->max_supported && edev->mutually_exclusive) { - char *name; - - /* Count the size of mutually_exclusive array */ - for (index = 0; edev->mutually_exclusive[index]; index++) - ; - - edev->attrs_muex = kcalloc(index + 1, - sizeof(struct attribute *), - GFP_KERNEL); - if (!edev->attrs_muex) { - ret = -ENOMEM; - goto err_muex; - } - - edev->d_attrs_muex = kcalloc(index, - sizeof(struct device_attribute), - GFP_KERNEL); - if (!edev->d_attrs_muex) { - ret = -ENOMEM; - kfree(edev->attrs_muex); - goto err_muex; - } - - for (index = 0; edev->mutually_exclusive[index]; index++) { - name = kasprintf(GFP_KERNEL, "0x%x", - edev->mutually_exclusive[index]); - if (!name) { - for (index--; index >= 0; index--) { - kfree(edev->d_attrs_muex[index].attr. - name); - } - kfree(edev->d_attrs_muex); - kfree(edev->attrs_muex); - ret = -ENOMEM; - goto err_muex; - } - sysfs_attr_init(&edev->d_attrs_muex[index].attr); - edev->d_attrs_muex[index].attr.name = name; - edev->d_attrs_muex[index].attr.mode = 0000; - edev->attrs_muex[index] = &edev->d_attrs_muex[index] - .attr; - } - edev->attr_g_muex.name = muex_name; - edev->attr_g_muex.attrs = edev->attrs_muex; - - } + ret = extcon_alloc_muex(edev); + if (ret) + goto err_alloc_muex; if (edev->max_supported) { edev->extcon_dev_type.groups = @@ -1290,7 +1300,7 @@ int extcon_dev_register(struct extcon_dev *edev) kfree(edev->d_attrs_muex); kfree(edev->attrs_muex); } -err_muex: +err_alloc_muex: for (index = 0; index < edev->max_supported; index++) kfree(edev->cables[index].attr_g.name); err_alloc_cables: From patchwork Mon Feb 20 05:45:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bumwoo Lee X-Patchwork-Id: 59255 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1150468wrn; Sun, 19 Feb 2023 22:02:29 -0800 (PST) X-Google-Smtp-Source: AK7set+UEh28aO0VgLxinw4dwetllKAfILrDe5BWq5I63WDpBii+RgyAyT88lOyUTfEeVDK7WOiV X-Received: by 2002:a17:907:2cc5:b0:8ae:e724:ea15 with SMTP id hg5-20020a1709072cc500b008aee724ea15mr9201292ejc.76.1676872949285; Sun, 19 Feb 2023 22:02:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676872949; cv=none; d=google.com; s=arc-20160816; b=pMkhChQmaRDW+cSsxw5tnSz6iaa//KjGcszv3E9OBs7p6/xSy1hDJniXmHAGPCERhE cttIxX/Jrtnzos+WMLPIKh6ogAtVT2T13vsblvqoQKvIVy0PqhT2RDbtpUkoJzrk1BSL vg7Obs5kf4gdZnanvTD9gger4qmpwqzEX9I1QUPlSeXTQIBRO3HZS7XeQZcLzPTaIHuZ 6DkSzSUObbUmFmHMArFFrdJC4BtuKhZONfFfGAJ/HlfG1biqinbofn0z20+FWA8kxXxK netxC/MqLyOU0tltixXbtVxoBfRRaqrrvTbPR5l8bPOutx0F52upum/PGPofUM0yxC0r lG+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:dlp-filter:cms-type :content-transfer-encoding:mime-version:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=lNPksCGpheSqXVu55qAf+P0bJ2VIXVru95h9wl5NU28=; b=vERCYadiuUko5S/NdU48HEHrqTjz0ZB3UlNZI2tIw0TPtEqHfvucAaY4q/+5nBI4F9 ORf7/za5MGmN+qmeTpYKZWLgoce3YSCldJdUlFxWlV5wSqyP0ZvWAS9BUNdVdxfNt1jj eceXD0Lstt0LC7LZUSiHZl1WTigTMZLv8XjM7EEdWvGdIjOLOuwUDbfok1YC4GYiN8uA f6CQJucbwdJ/7MaVA4NtZKgaTUx0TAuYW3uyd5SJd9tr5hba7EJLXTcupDf4/ri9oDOT AVWY8pCL2C6auYO03JOEvpQFQpgs9jgqmdYYBa0UGM7T0122FxamV0/hceMoev+WSrQV yDBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=MCGdJnvh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b2-20020aa7c6c2000000b004ad02463b96si13928134eds.108.2023.02.19.22.02.02; Sun, 19 Feb 2023 22:02:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=MCGdJnvh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230084AbjBTFqA (ORCPT + 99 others); Mon, 20 Feb 2023 00:46:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230059AbjBTFpw (ORCPT ); Mon, 20 Feb 2023 00:45:52 -0500 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51496C14B for ; Sun, 19 Feb 2023 21:45:49 -0800 (PST) Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20230220054547epoutp01d93b85319fe64847ea5e8684bf2f103e~FcibU0Dt12911729117epoutp017 for ; Mon, 20 Feb 2023 05:45:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20230220054547epoutp01d93b85319fe64847ea5e8684bf2f103e~FcibU0Dt12911729117epoutp017 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1676871947; bh=lNPksCGpheSqXVu55qAf+P0bJ2VIXVru95h9wl5NU28=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MCGdJnvhJw9Gy/sXdwdojODrmr+cdjnC3/OP5NgNjg6FoH2CKSR3Bu8x+5G+SsLqg O754Oz2r04krCOjK06bslW27DaY3UrMhwhA48vRqOZeliLHLEoQeqmyxFDac6MdIBc F7G/o0XeBqlJO/CmgE0aRX/Rk4ovtkEyfNqvsc44= Received: from epsnrtp3.localdomain (unknown [182.195.42.164]) by epcas1p2.samsung.com (KnoxPortal) with ESMTP id 20230220054547epcas1p2695e6ad99af607f325f4aab6da708f2e~Fcia-VGsF1742417424epcas1p2o; Mon, 20 Feb 2023 05:45:47 +0000 (GMT) Received: from epsmges1p1.samsung.com (unknown [182.195.38.247]) by epsnrtp3.localdomain (Postfix) with ESMTP id 4PKrxQ2ghfz4x9Q7; Mon, 20 Feb 2023 05:45:46 +0000 (GMT) Received: from epcas1p1.samsung.com ( [182.195.41.45]) by epsmges1p1.samsung.com (Symantec Messaging Gateway) with SMTP id 00.DC.55531.A0903F36; Mon, 20 Feb 2023 14:45:46 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230220054545epcas1p1b26d2a04a170dab4517e09bd6cf09c3f~FciZ2oWJY1974419744epcas1p1L; Mon, 20 Feb 2023 05:45:45 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230220054545epsmtrp22e61a1b18f5835cd5d3740a68e40ec09~FciZ1_eoJ0972009720epsmtrp2j; Mon, 20 Feb 2023 05:45:45 +0000 (GMT) X-AuditID: b6c32a35-d9fff7000000d8eb-58-63f3090ab484 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 3F.77.17995.90903F36; Mon, 20 Feb 2023 14:45:45 +0900 (KST) Received: from VDBS1418.vd.sec.samsung.net (unknown [168.219.244.30]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20230220054545epsmtip114bcfb45fbc387c9de05bf0c7567a728~FciZuNwbS2561925619epsmtip13; Mon, 20 Feb 2023 05:45:45 +0000 (GMT) From: Bumwoo Lee To: MyungJoo Ham , Chanwoo Choi , linux-kernel@vger.kernel.org Cc: Bumwoo Lee Subject: [PATCH v2 4/4] extcon: Added extcon_alloc_groups to simplify extcon register function Date: Mon, 20 Feb 2023 14:45:13 +0900 Message-Id: <20230220054513.27385-5-bw365.lee@samsung.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230220054513.27385-1-bw365.lee@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNKsWRmVeSWpSXmKPExsWy7bCmri4X5+dkg8MPBC1OrFnEZHH9y3NW i8u75rBZ3G5cwebA4tG3ZRWjx+dNcgFMUdk2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6 hpYW5koKeYm5qbZKLj4Bum6ZOUCLlBTKEnNKgUIBicXFSvp2NkX5pSWpChn5xSW2SqkFKTkF ZgV6xYm5xaV56Xp5qSVWhgYGRqZAhQnZGU83X2Au6BGumPRhFXsD4zP+LkZODgkBE4nWk9OZ QGwhgR2MEtc/pncxcgHZnxglvi14wwqR+Mwo8edeLUzDuYaJ7BBFuxgl+pY+YoNwfjFKzNjU wgZSxSagIbHnYgOQzcEhIlAocbg/GyTMLKAm8WDVRnYQW1ggQeLsl39gm1kEVCW6j3awgNi8 AlYS/3ouM0Esk5fo/vcHLM4pYC3x7/kiNogaQYmTM5+wQMyUl2jeOpsZ5AYJgV3sEnfO/gDb KyHgIvH5UTTEHGGJV8e3sEPYUhKf3+1lg7DTJVZeuQMVz5F4fb+dEcI2lnj3di0zyBhmAU2J 9bv0IcKKEjt/z2WEWMsn8e5rDyvEJl6JjjYhiBJlie4HL6Cul5RY/PQO1EQPicZFE1ghIdXH KPG49zzLBEaFWUi+mYXkm1kImxcwMq9iFEstKM5NTy02LDCER29yfu4mRnCq0zLdwTjx7Qe9 Q4xMHIyHGCU4mJVEeKUPfUgW4k1JrKxKLcqPLyrNSS0+xGgKDOuJzFKiyfnAZJtXEm9oYmlg YmZkYmFsaWymJM4rbnsyWUggPbEkNTs1tSC1CKaPiYNTqoGpVvnES9eZFvqVD5+a5d9ce0SZ UzsjJrPy17TSsIIUN/3d/2QZjwhtqHhZE1/wbnLI2bV3Ki4V2XxSrpNXTM2fcM3wr2BEXviK 7iZjhean5Wt7Ujcuna5XJ/mmbJWk/aMrTwrXbz587/caj6w7K6o0a6aVc0Yk8i/+f3jrinfK K411+FQlM3tadzPlPOmdxs2h9GdmeGzz40WmodIMshZfZmVUvFwWVTIp9oGwg/JUzStJCnZ+ 9ZPcjT36lavntqgnLc/+zSe7J/Jp/rdp8SUXop8HzL0gtyVqSpbsr42PV3LaL59b8txQ7QiT kZ/nvUfHwnImljLX/ctXOXNts27lw/lCPfk98zK/afeFCyixFGckGmoxFxUnAgAfrUsm/gMA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBLMWRmVeSWpSXmKPExsWy7bCSnC4n5+dkg7YjOhYn1ixisrj+5Tmr xeVdc9gsbjeuYHNg8ejbsorR4/MmuQCmKC6blNSczLLUIn27BK6Mp5svMBf0CFdM+rCKvYHx GX8XIyeHhICJxLmGiexdjFwcQgI7GCV+LZ/KApGQlDi7/BFQggPIFpY4fLgYouYHo8Tk/ovs IDVsAhoSey42sIHYIgLFEhcOLAbrZRZQk3iwaiNYjbBAnMSztVuYQWwWAVWJ7qMdYDW8AlYS /3ouM0Hskpfo/vcHLM4pYC3x7/kisJlCQDVtkyczQ9QLSpyc+QRqvrxE89bZzBMYBWYhSc1C klrAyLSKUTK1oDg3PbfYsMAoL7Vcrzgxt7g0L10vOT93EyM4MLW0djDuWfVB7xAjEwfjIUYJ DmYlEV7pQx+ShXhTEiurUovy44tKc1KLDzFKc7AoifNe6DoZLySQnliSmp2aWpBaBJNl4uCU amDq5mLzPruh/k6gHottkKjZ0UnFJ9r1NF/w/jk/W2hv/q+pHvf7+cOtTshfiNlyr/BGupW/ iGfvgf8xE9o6DY6/Y2py1jN+U+nRkOzce13v7hrF6deST32fEuaWavdiN8d67odTI3mVOSq3 RD2YsyhALtqoq8nnj+9Wn5S3U1cfKbt4YG/JkRwXZelk6VPed5eskM69NH3B3J815T9bD1ss dlA+Lc1yy3p9d+IVrgo5/8/LYqftOz1HeNEKuQN/J7X5TY24oGwYc5PxQI2uwLXjLEeNRfj5 gyMiWDPuPX59SY955bwZ/2f1ufD4+LRJRb3ZZHPng8Pb2/sFvuiZW+Y61taeVX74yNtsRujL C1+UWIozEg21mIuKEwH+zzqCuwIAAA== X-CMS-MailID: 20230220054545epcas1p1b26d2a04a170dab4517e09bd6cf09c3f X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230220054545epcas1p1b26d2a04a170dab4517e09bd6cf09c3f References: <20230220054513.27385-1-bw365.lee@samsung.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758328730157204638?= X-GMAIL-MSGID: =?utf-8?q?1758328730157204638?= The alloc groups is functionalized from extcon_dev_register. Signed-off-by: Bumwoo Lee --- drivers/extcon/extcon.c | 58 +++++++++++++++++++++++++---------------- 1 file changed, 36 insertions(+), 22 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 2aec34909843..919d77539039 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1179,6 +1179,39 @@ static int extcon_alloc_muex(struct extcon_dev *edev) return 0; } +/** + * extcon_alloc_groups() - alloc the groups for extcon device + * @edev: extcon device + * + * Returns 0 if success or error number if fail. + */ +static int extcon_alloc_groups(struct extcon_dev *edev) +{ + int index; + + if (!edev->max_supported) + return 0; + + edev->extcon_dev_type.groups = kcalloc(edev->max_supported + 2, + sizeof(struct attribute_group *), + GFP_KERNEL); + if (!edev->extcon_dev_type.groups) + return -ENOMEM; + + edev->extcon_dev_type.name = dev_name(&edev->dev); + edev->extcon_dev_type.release = dummy_sysfs_dev_release; + + for (index = 0; index < edev->max_supported; index++) + edev->extcon_dev_type.groups[index] = &edev->cables[index].attr_g; + + if (edev->mutually_exclusive) + edev->extcon_dev_type.groups[index] = &edev->attr_g_muex; + + edev->dev.type = &edev->extcon_dev_type; + + return 0; +} + /** * extcon_dev_register() - Register an new extcon device * @edev: the extcon device to be registered @@ -1234,28 +1267,9 @@ int extcon_dev_register(struct extcon_dev *edev) if (ret) goto err_alloc_muex; - if (edev->max_supported) { - edev->extcon_dev_type.groups = - kcalloc(edev->max_supported + 2, - sizeof(struct attribute_group *), - GFP_KERNEL); - if (!edev->extcon_dev_type.groups) { - ret = -ENOMEM; - goto err_alloc_groups; - } - - edev->extcon_dev_type.name = dev_name(&edev->dev); - edev->extcon_dev_type.release = dummy_sysfs_dev_release; - - for (index = 0; index < edev->max_supported; index++) - edev->extcon_dev_type.groups[index] = - &edev->cables[index].attr_g; - if (edev->mutually_exclusive) - edev->extcon_dev_type.groups[index] = - &edev->attr_g_muex; - - edev->dev.type = &edev->extcon_dev_type; - } + ret = extcon_alloc_groups(edev); + if (ret) + goto err_alloc_groups; spin_lock_init(&edev->lock); if (edev->max_supported) {