From patchwork Fri Feb 17 08:46:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bumwoo Lee X-Patchwork-Id: 58426 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp775261wrn; Fri, 17 Feb 2023 00:53:03 -0800 (PST) X-Google-Smtp-Source: AK7set9WJLFyPAX7Cs6dWtbhB6wEHI0jujYl09CSR3Sq2oH4xSHzUC9+vb1wZ43GebPXe0oCF0z8 X-Received: by 2002:aa7:c2c9:0:b0:4ac:bf55:7d61 with SMTP id m9-20020aa7c2c9000000b004acbf557d61mr7857337edp.9.1676623982878; Fri, 17 Feb 2023 00:53:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676623982; cv=none; d=google.com; s=arc-20160816; b=c8Nifc5CrEe6+mBPtwXntSKgmqwntqvOQJ/knyRLabo5UBVeZL+h7zsoNnEcgGbg6J SooVmC/odPiur4JCi0Qj5aiAeAVbk0q/QmFEBeKIZ3gnxBzX/TVFRccdZtzZOJl0M7T/ x5ufHW8PLzN1AzAD2T3/Lx0yWAw3u4ILe7FIAKY1fygx/L3n4V/LXOFhjsvcpV+9/kXN kgrk0rdqnKqdqYvWiWPdbjtoyHPq0tBP+TMk3jmR9Xvcp3JnHjen5TvIgDGrcY8ONImE xoofmE5pIQd6Lr0R1gwH/NTO7qIuz3SH3KAXjhfQl9PGEKYPHesn6M4NI+HmH5Stv3To UpDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:dlp-filter:cms-type :content-transfer-encoding:mime-version:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=D4c96abBnqAEnbKACGW2gCIF8B2km59E2gdY/W+0IM8=; b=fDfLQSo+M4zlt1koJDDSXZId6WL5FXnB9ESOtNEC59niAGmBKEmBYLQ+mg2buAF1Xi JOVNKhB1fthBNOARfXV+yPtk5puXr8Gj8mYvu0GMYbAIB6Q8B7W7cgXOG3T81nl6W7H+ /PI3w7pQlXYqiCpC8SK3adho/Jx03BxUZqn2unazByNW0pYdWmumOmX1oXWuOWAhDtCb GLjBgbtvtfmBVzstdvaW/npeV4vfYr/DejHfMQTkLgLQecsTsOmMjPpmGi7sLjMfvzhE WewxfeaXspdzva04b4K6wIAbsx+ZS6BATxG4uiGL9cnzwAO2SVRxB8jr99dtYgs3xZwE 4CZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b="Yd/TCprU"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k7-20020a05640212c700b004acc1b383e3si5150381edx.427.2023.02.17.00.52.40; Fri, 17 Feb 2023 00:53:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b="Yd/TCprU"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229869AbjBQIsL (ORCPT + 99 others); Fri, 17 Feb 2023 03:48:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229863AbjBQIsJ (ORCPT ); Fri, 17 Feb 2023 03:48:09 -0500 Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 238003251D for ; Fri, 17 Feb 2023 00:48:06 -0800 (PST) Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20230217084804epoutp033ea714901e8c32b97571f5dea603f23d~EkFuqZ6ZH1811718117epoutp03V for ; Fri, 17 Feb 2023 08:48:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20230217084804epoutp033ea714901e8c32b97571f5dea603f23d~EkFuqZ6ZH1811718117epoutp03V DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1676623684; bh=D4c96abBnqAEnbKACGW2gCIF8B2km59E2gdY/W+0IM8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Yd/TCprUr4zbgP0+SsAjbD2hSQYZlxf+7x5DFnqIhXfGm/w0eDXtVy2NlGrAyarMt cqUHZB54u2B5ILdO5ZGg5uJJ0FWqX0XvtZkEsUSsVNq3bpwWrxmi10tRgp3T/B/Aq8 mkyGEa6zoN/nfd+u0VtDrf2A8fexeAk0+3MzoelM= Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas1p2.samsung.com (KnoxPortal) with ESMTP id 20230217084804epcas1p2f27e10c4f6d45d0f6f2f49b31208c512~EkFub3YAu0793207932epcas1p2v; Fri, 17 Feb 2023 08:48:04 +0000 (GMT) Received: from epsmges1p5.samsung.com (unknown [182.195.38.242]) by epsnrtp1.localdomain (Postfix) with ESMTP id 4PJ5775QGBz4x9Q1; Fri, 17 Feb 2023 08:48:03 +0000 (GMT) Received: from epcas1p2.samsung.com ( [182.195.41.46]) by epsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id D1.26.54823.34F3FE36; Fri, 17 Feb 2023 17:48:03 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230217084803epcas1p12b708d8119263cef2233d652062ba3d1~EkFtjoQ6V1479114791epcas1p1G; Fri, 17 Feb 2023 08:48:03 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230217084803epsmtrp225e9da445e547008dc7f8469ecce56f1~EkFti7BwD3026830268epsmtrp2Q; Fri, 17 Feb 2023 08:48:03 +0000 (GMT) X-AuditID: b6c32a39-d01fc7000000d627-9e-63ef3f43183a Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id D1.55.05839.34F3FE36; Fri, 17 Feb 2023 17:48:03 +0900 (KST) Received: from VDBS1418.vd.sec.samsung.net (unknown [168.219.244.30]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230217084803epsmtip298a82d811f33b1349c1ecb38fdd5af92~EkFtXa-S-2511925119epsmtip2N; Fri, 17 Feb 2023 08:48:03 +0000 (GMT) From: Bumwoo Lee To: MyungJoo Ham , Chanwoo Choi , linux-kernel@vger.kernel.org Cc: Bumwoo Lee Subject: [PATCH 1/4] extcon: remove redundant null checking for class Date: Fri, 17 Feb 2023 17:46:10 +0900 Message-Id: <20230217084613.25359-2-bw365.lee@samsung.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230217084613.25359-1-bw365.lee@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLKsWRmVeSWpSXmKPExsWy7bCmnq6z/ftkg28TtC1OrFnEZHH9y3NW i8u75rBZ3G5cwebA4tG3ZRWjx+dNcgFMUdk2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6 hpYW5koKeYm5qbZKLj4Bum6ZOUCLlBTKEnNKgUIBicXFSvp2NkX5pSWpChn5xSW2SqkFKTkF ZgV6xYm5xaV56Xp5qSVWhgYGRqZAhQnZGU3959kL/nFWzJzfydTAOI2ji5GTQ0LARGL5qy62 LkYuDiGBHYwSD/5OZ4ZwPjFKLL84HSrzjVFi7qupzDAtN3peM0Ek9jJKbPo3AarqF6PEmo7H jCBVbAIaEnsuNgAlODhEBAolDvdng4SZBdQkHqzayA5iCwu4Stzc/QVsKIuAqsTntYdYQWxe ASuJA1MfskIsk5fo/veHBcTmFLCW+Lv3JlSNoMTJmU9YIGbKSzRvnQ12toTAPnaJMyt2skA0 u0gsuzCLCcIWlnh1fAs7hC0l8fndXjYIO11i5ZU7UPEcidf32xkhbGOJd2/XMoPczyygKbF+ lz5EWFFi5++5jBB7+STefe1hBSmREOCV6GgTgihRluh+8AJqq6TE4qd3oCZ6SEy8/BAsLiTQ xyix6qLKBEaFWUi+mYXkm1kIixcwMq9iFEstKM5NTy02LDCFR3Byfu4mRnC607LcwTj97Qe9 Q4xMHIyHGCU4mJVEeDfdfJMsxJuSWFmVWpQfX1Sak1p8iNEUGNYTmaVEk/OBCTevJN7QxNLA xMzIxMLY0thMSZxX3PZkspBAemJJanZqakFqEUwfEwenVAOT4R2fTOtr0bXPHz/n+D7lt9y/ zKUMjRwqrz0PGR3VvfRtntp/7dUR1eWGSU8FHPsm7PnxMHl+XfPdG26VSqnnjv84eNpgoUm3 oFBUzapaTrfrEv/afH31XLoLi345pV/36vqhzqz27nOEkleV9BWNqAjzLQ1Gd6UKmxVV+n+d i8iJ2F924g8DQ1qu0ZPbwQtC+5aGLPQK5mp9vXZ/ue2RjSerXczeGW8IVNSyfPxp+5+LLWa7 DPI+Gpg92MS559vcvAOTfl+/d/WTzp0fhzKl10p9sv10JHPqZKZTRoUTzl1MrpZj4XUszOPN V/pY/NpLVdN50vPO+JoKm5gPB3bL/RD/6mNTJbPlQ5hdX7sSS3FGoqEWc1FxIgCQyxNkAAQA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOLMWRmVeSWpSXmKPExsWy7bCSvK6z/ftkg2/NEhYn1ixisrj+5Tmr xeVdc9gsbjeuYHNg8ejbsorR4/MmuQCmKC6blNSczLLUIn27BK6Mpv7z7AX/OCtmzu9kamCc xtHFyMkhIWAicaPnNVMXIxeHkMBuRolve26xQSQkJc4uf8TexcgBZAtLHD5cDFHzg1Fi9YKD LCA1bAIaEnsuNoDViwgUS1w4sBgsziygJvFg1UZ2EFtYwFXi5u4vzCA2i4CqxOe1h1hBbF4B K4kDUx+yQuySl+j+9wesl1PAWuLv3pusIHuFgGpOT+KGKBeUODnzCdR4eYnmrbOZJzAKzEKS moUktYCRaRWjZGpBcW56brFhgWFearlecWJucWleul5yfu4mRnBYamnuYNy+6oPeIUYmDsZD jBIczEoivJtuvkkW4k1JrKxKLcqPLyrNSS0+xCjNwaIkznuh62S8kEB6YklqdmpqQWoRTJaJ g1OqgYkhKOHshqgTz953sF9dNHdWgOj8iPSW73KTb9k3RgZNDtf88W+JveXlbxE10SbX6i9w Jayt6Y57siN80qcS/WrrA8unPM/8b37+x709Zyy/BpzYzBOnntFdmqU22bxx/xKl2cn33k0v mDVhwfanKzYfb2Xy6mR+nf9065qfVd8Xn746tVbNY4r/lQze6WmXVpa16j9yyk7edf/TXrHZ XYeqzs8/2SbzrWjbijo5XaH7YUtPqxwUbGU+/WXXvge/rX2OzZyj847tyAH7HqGdF0zOBDu5 2oqJ3og32d1Uui1xRsXaA6avV93f49TWs2fCsnSF8ralYpfN1skqHfpZni216HgAy4ojauZP 1fLvaHIJKbEUZyQaajEXFScCAKTnGLq6AgAA X-CMS-MailID: 20230217084803epcas1p12b708d8119263cef2233d652062ba3d1 X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230217084803epcas1p12b708d8119263cef2233d652062ba3d1 References: <20230217084613.25359-1-bw365.lee@samsung.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758067669259609395?= X-GMAIL-MSGID: =?utf-8?q?1758067669259609395?= Create_extcon_class() is already Null checking. Signed-off-by: Bumwoo Lee --- drivers/extcon/extcon.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index e1c71359b605..adcf01132f70 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1012,12 +1012,13 @@ ATTRIBUTE_GROUPS(extcon); static int create_extcon_class(void) { - if (!extcon_class) { - extcon_class = class_create(THIS_MODULE, "extcon"); - if (IS_ERR(extcon_class)) - return PTR_ERR(extcon_class); - extcon_class->dev_groups = extcon_groups; - } + if (extcon_class) + return 0; + + extcon_class = class_create(THIS_MODULE, "extcon"); + if (IS_ERR(extcon_class)) + return PTR_ERR(extcon_class); + extcon_class->dev_groups = extcon_groups; return 0; } @@ -1088,11 +1089,9 @@ int extcon_dev_register(struct extcon_dev *edev) int ret, index = 0; static atomic_t edev_no = ATOMIC_INIT(-1); - if (!extcon_class) { - ret = create_extcon_class(); - if (ret < 0) - return ret; - } + ret = create_extcon_class(); + if (ret < 0) + return ret; if (!edev || !edev->supported_cable) return -EINVAL; From patchwork Fri Feb 17 08:46:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bumwoo Lee X-Patchwork-Id: 58425 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp774961wrn; Fri, 17 Feb 2023 00:52:10 -0800 (PST) X-Google-Smtp-Source: AK7set99SoTt5xZNxpH44KihYhuXEU/1h/6aO8AipkeO+QuaURYEFyP2z5nB3KPR5NzhssLpySrT X-Received: by 2002:a17:906:94d8:b0:878:481c:c49b with SMTP id d24-20020a17090694d800b00878481cc49bmr8469136ejy.1.1676623930106; Fri, 17 Feb 2023 00:52:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676623930; cv=none; d=google.com; s=arc-20160816; b=A2hq8LyL5zbzmw47ZGccRqsXBdw0j4++1Ovm/lTfzbr/yU/H5zr1s9M53u55b64+bH syLJ7lx/iBPE8MG3GeDWDk6JhQpiDSqagAoqx8pspEdneipkAWgpZNCQyv5JK8vpArBg TC9rPnIm9+uGwAl1sFPko0OmX3kIoYbffExll769+zSDTZ0AX6CKqk5TFXkF92eiRwdi iQQb2TQT/Lf+3BM9+3572JHV5RS+RLXrmDha2Grhe1LkHY1hGIqAlJzfBc7IHO7kloRo rQKMqo69W1/fyMl0eQwPNpUw5Lpohw6mexQ5sj4MtEtkWvk4kwP/x0UoT8Tl0e+kfVGr eRGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:dlp-filter:cms-type :content-transfer-encoding:mime-version:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=VWFXNTIw9nK2J03yx4ldB4NgMy/4kPQyO7bFGTxkKQ4=; b=gQpzFZ/uRaZgNydfBnHJWtZ+2QnWnK0fz4K4mBPSawMy2+waX3BqRMJFy9T6zvxuKb Lm1xiQ9TFurcPAeZIVif+MDojVa9DU5gIhG38fzOJO2ywKebsIyHGTDcj6Ih39i+nfVv m55dUJkDhPWuPMtQOeRAmr0LYBSnmY67PO8XM5TrbCJ4TkvYRA7BU0pYspaCYeFQlOFU T5CaDmzmXqKOFUpAHKgTiBqDUDgrmTb82Gy1lnYhB/ncYzynZf56CpfGXLXSbOKAeDd0 9Ofrr8mjgjhJh7q2PbShyW6Yjk9uMxXedzgpJA3YC5pnF7QuJgnyV+eZCCg6uncwLwEJ jGYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=R6E8dDks; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kb3-20020a170907924300b008869f495216si4471121ejb.843.2023.02.17.00.51.47; Fri, 17 Feb 2023 00:52:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=R6E8dDks; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229524AbjBQIsV (ORCPT + 99 others); Fri, 17 Feb 2023 03:48:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229822AbjBQIsK (ORCPT ); Fri, 17 Feb 2023 03:48:10 -0500 Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BC7434022 for ; Fri, 17 Feb 2023 00:48:06 -0800 (PST) Received: from epcas1p1.samsung.com (unknown [182.195.41.45]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20230217084804epoutp0380bc4c25d913b1703b77e21e4b1f2d57~EkFu8RlvC1849418494epoutp03D for ; Fri, 17 Feb 2023 08:48:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20230217084804epoutp0380bc4c25d913b1703b77e21e4b1f2d57~EkFu8RlvC1849418494epoutp03D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1676623685; bh=VWFXNTIw9nK2J03yx4ldB4NgMy/4kPQyO7bFGTxkKQ4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R6E8dDkstBxi1DJYDFTtolXmrkaEsc/Ghw4mrn5LOkkcI0KB9HFnNXMrwHeEExvu5 Oz4nJmMotDBuQD4Nx4p/Hmqdg+m+yYIk2hLZcAWXw1+JsnJwjfH9tv9swUvlrs7R0g TChqSfWapUUm6LDaYLTxrng7toCrLMYGReSPRpbI= Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20230217084804epcas1p3794f56a4da6fafe70a45faa7dbfec7cd~EkFurI5Yw1965819658epcas1p3K; Fri, 17 Feb 2023 08:48:04 +0000 (GMT) Received: from epsmges1p5.samsung.com (unknown [182.195.36.224]) by epsnrtp1.localdomain (Postfix) with ESMTP id 4PJ5775R9Tz4x9Q3; Fri, 17 Feb 2023 08:48:03 +0000 (GMT) Received: from epcas1p2.samsung.com ( [182.195.41.46]) by epsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id F1.26.54823.34F3FE36; Fri, 17 Feb 2023 17:48:03 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p2.samsung.com (KnoxPortal) with ESMTPA id 20230217084803epcas1p29ef858c842b18de89f1b034acb26086a~EkFtkI0z60793207932epcas1p2n; Fri, 17 Feb 2023 08:48:03 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20230217084803epsmtrp12ec72081f370337f74c9e2fce3da3506~EkFtjYfy21579015790epsmtrp1h; Fri, 17 Feb 2023 08:48:03 +0000 (GMT) X-AuditID: b6c32a39-a97ff7000000d627-9f-63ef3f43cea8 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 39.92.17995.34F3FE36; Fri, 17 Feb 2023 17:48:03 +0900 (KST) Received: from VDBS1418.vd.sec.samsung.net (unknown [168.219.244.30]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230217084803epsmtip21745654c993e2f869c8abd4518f6ed98~EkFtbLcz52512425124epsmtip2H; Fri, 17 Feb 2023 08:48:03 +0000 (GMT) From: Bumwoo Lee To: MyungJoo Ham , Chanwoo Choi , linux-kernel@vger.kernel.org Cc: Bumwoo Lee Subject: [PATCH 2/4] extcon: added extcon_alloc_cables to simplify extcon register function Date: Fri, 17 Feb 2023 17:46:11 +0900 Message-Id: <20230217084613.25359-3-bw365.lee@samsung.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230217084613.25359-1-bw365.lee@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDKsWRmVeSWpSXmKPExsWy7bCmnq6z/ftkg0WTdSxOrFnEZHH9y3NW i8u75rBZ3G5cwebA4tG3ZRWjx+dNcgFMUdk2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6 hpYW5koKeYm5qbZKLj4Bum6ZOUCLlBTKEnNKgUIBicXFSvp2NkX5pSWpChn5xSW2SqkFKTkF ZgV6xYm5xaV56Xp5qSVWhgYGRqZAhQnZGbOm72Uq2CJXcf7QIcYGxt0SXYycHBICJhIL7u1n 72Lk4hAS2MEocfPrckYI5xOjxNz+X8wQzmdGiVln5rPCtGxb/A6qahejxP1fN6CcX4wSGy/9 ZgapYhPQkNhzsYGti5GDQ0SgUOJwfzZImFlATeLBqo3sILawQKzEmlcLWEBsFgFVicnv3oIt 4BWwkpi6bQ8jxDJ5ie5/f8BqOAWsJf7uvQlVIyhxcuYTFoiZ8hLNW2czQ9TvY5eYeFQWZK2E gIvEkUUZEGFhiVfHt7BD2FISL/vboOx0iZVX7kDZORKv77dDrTWWePd2LTPIGGYBTYn1u/Qh wooSO3/PZYTYyifx7msPK8QmXomONiGIEmWJ7gcvmCBsSYnFT+9ATfSQ2PlvExskoPoYJe40 7GObwKgwC8kzs5A8Mwth8wJG5lWMYqkFxbnpqcWGBabw+E3Oz93ECE52WpY7GKe//aB3iJGJ g/EQowQHs5II76abb5KFeFMSK6tSi/Lji0pzUosPMZoCg3ois5Rocj4w3eaVxBuaWBqYmBmZ WBhbGpspifOK255MFhJITyxJzU5NLUgtgulj4uCUamBqkma5pxt+dUNhtqP/rmtRTzXZG3s0 khU+S+2rLtnfyTZj/6XeZbefVYbc2lY39y7njUXLNcrdVPkmFdeYVZuyLpFzCmuabKyWuXCB 15LsU2uzO0uSFgTI9nkZ2vwQctz4Z1X6zBMPVmyLm5G3Qn1d3SnJ/5+D9NZILhcRZ9NrVzGv 7F0app+enDCtbe754pALKyPXdk38X/gh+NezJ39CrP+dDLBfuuXTrll/ozZKn+89ataYc1vj QmcB57v9Ritnr1nNtOTRGi0+x4nSr1anC9v1yezZdPZyVXr87aWRL5M07aY8E7xkvejNrplP 2tOCnsmo1C4VU8tx9Jvj1PNl1pHP/7aXLHzhxvl3Xf1EJZbijERDLeai4kQAuTx0Rf8DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOLMWRmVeSWpSXmKPExsWy7bCSvK6z/ftkg1M7JS1OrFnEZHH9y3NW i8u75rBZ3G5cwebA4tG3ZRWjx+dNcgFMUVw2Kak5mWWpRfp2CVwZs6bvZSrYIldx/tAhxgbG 3RJdjJwcEgImEtsWv2PsYuTiEBLYwShxddliJoiEpMTZ5Y/Yuxg5gGxhicOHiyFqfjBKHJjz lBWkhk1AQ2LPxQY2EFtEoFjiwoHFLCA2s4CaxINVG9lBbGGBaIlH3cfB4iwCqhKT370F6+UV sJKYum0PI8QueYnuf3/AajgFrCX+7r3JCrJXCKjm9CRuiHJBiZMzn0CNl5do3jqbeQKjwCwk qVlIUgsYmVYxSqYWFOem5xYbFhjlpZbrFSfmFpfmpesl5+duYgSHpZbWDsY9qz7oHWJk4mA8 xCjBwawkwrvp5ptkId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rwXuk7GCwmkJ5akZqemFqQWwWSZ ODilGphSHs3IPrnoTsbcmeWM20WlTQJXLzmc+vBxuGNW67OtyfP3/P5het1YWORHEvf0lDqO XS8YlnfnxbdPq9iRtCmmI4L7399DrPVXnv5ac7dyRU6HBb+aiu59HWl3ex+za/mSu67uY2GO 6zhTf5Gtf/7SSwcKlPI92kyOmV7clR825ckH9WBFg01zXm82NJg6aU+4idFk7TdlsSlyabce 830932WXbDdve72GPL9214qdLw63Km7JaH12+5iH5cM7FytXlD6tZb54SmnOe5bYOaZL+KNd kybveHh+mvydDK/H5gFiy7bu3+vII9bIKt3uoS/McOTA9s6ikA8vi0VvvGVdWRoUuIvrpe25 ijvM+ZFKLMUZiYZazEXFiQChrkaGugIAAA== X-CMS-MailID: 20230217084803epcas1p29ef858c842b18de89f1b034acb26086a X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230217084803epcas1p29ef858c842b18de89f1b034acb26086a References: <20230217084613.25359-1-bw365.lee@samsung.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758067614029630604?= X-GMAIL-MSGID: =?utf-8?q?1758067614029630604?= The cable allocation part is functionalized from extcon_dev_register. Signed-off-by: Bumwoo Lee --- drivers/extcon/extcon.c | 103 ++++++++++++++++++++++------------------ 1 file changed, 58 insertions(+), 45 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index adcf01132f70..28058a1d2745 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1070,6 +1070,61 @@ void extcon_dev_free(struct extcon_dev *edev) } EXPORT_SYMBOL_GPL(extcon_dev_free); +/** + * extcon_alloc_cables() - alloc the cables for extcon device + * @edev: extcon device which has cables + * + * Returns 0 if success or error number if fail. + */ +static int extcon_alloc_cables(struct extcon_dev *edev) +{ + int index; + char *str; + struct extcon_cable *cable; + + if (!edev->max_supported) + return 0; + + edev->cables = kcalloc(edev->max_supported, + sizeof(struct extcon_cable), + GFP_KERNEL); + if (!edev->cables) + return -ENOMEM; + + for (index = 0; index < edev->max_supported; index++) { + cable = &edev->cables[index]; + + str = kasprintf(GFP_KERNEL, "cable.%d", index); + if (!str) { + for (index--; index >= 0; index--) { + cable = &edev->cables[index]; + kfree(cable->attr_g.name); + } + return -ENOMEM; + } + + cable->edev = edev; + cable->cable_index = index; + cable->attrs[0] = &cable->attr_name.attr; + cable->attrs[1] = &cable->attr_state.attr; + cable->attrs[2] = NULL; + cable->attr_g.name = str; + cable->attr_g.attrs = cable->attrs; + + sysfs_attr_init(&cable->attr_name.attr); + cable->attr_name.attr.name = "name"; + cable->attr_name.attr.mode = 0444; + cable->attr_name.show = cable_name_show; + + sysfs_attr_init(&cable->attr_state.attr); + cable->attr_state.attr.name = "state"; + cable->attr_state.attr.mode = 0444; + cable->attr_state.show = cable_state_show; + } + + return 0; +} + /** * extcon_dev_register() - Register an new extcon device * @edev: the extcon device to be registered @@ -1117,50 +1172,8 @@ int extcon_dev_register(struct extcon_dev *edev) dev_set_name(&edev->dev, "extcon%lu", (unsigned long)atomic_inc_return(&edev_no)); - if (edev->max_supported) { - char *str; - struct extcon_cable *cable; - - edev->cables = kcalloc(edev->max_supported, - sizeof(struct extcon_cable), - GFP_KERNEL); - if (!edev->cables) { - ret = -ENOMEM; - goto err_sysfs_alloc; - } - for (index = 0; index < edev->max_supported; index++) { - cable = &edev->cables[index]; - - str = kasprintf(GFP_KERNEL, "cable.%d", index); - if (!str) { - for (index--; index >= 0; index--) { - cable = &edev->cables[index]; - kfree(cable->attr_g.name); - } - ret = -ENOMEM; - - goto err_alloc_cables; - } - - cable->edev = edev; - cable->cable_index = index; - cable->attrs[0] = &cable->attr_name.attr; - cable->attrs[1] = &cable->attr_state.attr; - cable->attrs[2] = NULL; - cable->attr_g.name = str; - cable->attr_g.attrs = cable->attrs; - - sysfs_attr_init(&cable->attr_name.attr); - cable->attr_name.attr.name = "name"; - cable->attr_name.attr.mode = 0444; - cable->attr_name.show = cable_name_show; - - sysfs_attr_init(&cable->attr_state.attr); - cable->attr_state.attr.name = "state"; - cable->attr_state.attr.mode = 0444; - cable->attr_state.show = cable_state_show; - } - } + if (extcon_alloc_cables(edev)) + goto err_alloc_cables; if (edev->max_supported && edev->mutually_exclusive) { char *name; @@ -1282,7 +1295,7 @@ int extcon_dev_register(struct extcon_dev *edev) err_alloc_cables: if (edev->max_supported) kfree(edev->cables); -err_sysfs_alloc: + return ret; } EXPORT_SYMBOL_GPL(extcon_dev_register); From patchwork Fri Feb 17 08:46:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bumwoo Lee X-Patchwork-Id: 58424 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp774936wrn; Fri, 17 Feb 2023 00:52:03 -0800 (PST) X-Google-Smtp-Source: AK7set9QFjG40V3UuPPWYJQOdt8omrOjRjXsGxI8Z0r9hvqVqivcg9s6jLFTB6k/yYzfekrkceAN X-Received: by 2002:a17:906:3903:b0:8b1:3824:1f58 with SMTP id f3-20020a170906390300b008b138241f58mr8982639eje.21.1676623923767; Fri, 17 Feb 2023 00:52:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676623923; cv=none; d=google.com; s=arc-20160816; b=n6v8Vqku6PjJTgUxCUGdI8I4M+9lQ4TPxarhpmjGYnmMVeCrjUQYyLRl60Pu6EF+UD zt6x+CtVs/zbOqnkYwSU6RkNJ5gFY6xuFBLrAaXYBbpwPwwBlkGdGVc6Pat38ImSMSPF 7FisX5C+AHYvklZ2PTs465KVitS733Z7vksfazAk1QzI5ctk4hmsSeqhrTssbT8LL6u1 XkLF7urPwwo8tMBZwtsfTtW3S/mU2729lrx8OXMkk/AQI4FHuH0OMezkBhYsHjTeFJi8 ERwiK1bRE4SmSowMAH0RUrHebXTrd6myFqbrAVj5Ko8PQDzF2b3wHy+GctmGbTNY9qeL DE9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:dlp-filter:cms-type :content-transfer-encoding:mime-version:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=3Q1QvMlS4mEXN1/iWE6lHKK6DzCnawz/nukzULRBOh0=; b=CKWxDTVjNZ71FrWpQLMKVp6/0PBLVqFiRgSWSpGtTEvhaDO+52KpTAHXrtiNDBFxDO rdRrTJwZbM4ovQeePtUxMBflwGyS+7CDtDi6RNpT05LOBFqKKfHa4NTCwHNn4BWcm7UO T3wOkY5Qldp7cf4qHxCOr3SY+g0iyjgRbfBvXQRd4/aobP3k0RJyinyzt0+oA0pq6vE2 aJ3+dzWzEQp6Y8Rk2+NjdQCe7jC0FOnrUMZGjYdsdqJ/LZVfZbxYa0A972dhWEnMqXg6 nmRkw7tvl8upeD16Itbgw6R2WXs4fha1sdwCzY9fD2yW7EcQROnYT914SuNqouf3xxFE PBdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=YbNr+m0H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r14-20020a056402034e00b004ad0993e54esi4064658edw.487.2023.02.17.00.51.40; Fri, 17 Feb 2023 00:52:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=YbNr+m0H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229924AbjBQIsS (ORCPT + 99 others); Fri, 17 Feb 2023 03:48:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229666AbjBQIsK (ORCPT ); Fri, 17 Feb 2023 03:48:10 -0500 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F19B35247 for ; Fri, 17 Feb 2023 00:48:07 -0800 (PST) Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20230217084805epoutp01d4cd46d855a2b070a5ab86beda1e3533~EkFvL6EWG1426814268epoutp01V for ; Fri, 17 Feb 2023 08:48:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20230217084805epoutp01d4cd46d855a2b070a5ab86beda1e3533~EkFvL6EWG1426814268epoutp01V DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1676623685; bh=3Q1QvMlS4mEXN1/iWE6lHKK6DzCnawz/nukzULRBOh0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YbNr+m0HUdCtwG5HEHC+wEUoLrBw+xT+jWxFkYyQImW/DJGE1S22wUwI9ZBOEfGAM 9JcYFtHgdBskkDC/dKJsiWzU7LT6PN7oTYSmt7a6xlwTtdlKihlOVaOzkccbif+Zr+ /WMMBiKZPRaQc6+SILYeVKysqRq3ZQqKxyjTpIvY= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas1p1.samsung.com (KnoxPortal) with ESMTP id 20230217084804epcas1p1d11976b5290b777901c541215133b61e~EkFu0zdaO1582215822epcas1p1-; Fri, 17 Feb 2023 08:48:04 +0000 (GMT) Received: from epsmges1p3.samsung.com (unknown [182.195.38.247]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4PJ577647pz4x9Pt; Fri, 17 Feb 2023 08:48:03 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p3.samsung.com (Symantec Messaging Gateway) with SMTP id 1C.F0.52037.34F3FE36; Fri, 17 Feb 2023 17:48:03 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p2.samsung.com (KnoxPortal) with ESMTPA id 20230217084803epcas1p2d5e3ca2fbadd5fde7f58a8ae1940d53f~EkFtkUy0s0318103181epcas1p26; Fri, 17 Feb 2023 08:48:03 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230217084803epsmtrp238a22aa69251596d7e8ffebd937a97f5~EkFtjl-cH3026830268epsmtrp2R; Fri, 17 Feb 2023 08:48:03 +0000 (GMT) X-AuditID: b6c32a37-7cbfd7000001cb45-fb-63ef3f4396c2 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 49.92.17995.34F3FE36; Fri, 17 Feb 2023 17:48:03 +0900 (KST) Received: from VDBS1418.vd.sec.samsung.net (unknown [168.219.244.30]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230217084803epsmtip29cd3511e9e6eff58b3aac830d7bbecd8~EkFtc2UfE2511925119epsmtip2O; Fri, 17 Feb 2023 08:48:03 +0000 (GMT) From: Bumwoo Lee To: MyungJoo Ham , Chanwoo Choi , linux-kernel@vger.kernel.org Cc: Bumwoo Lee Subject: [PATCH 3/4] extcon: added extcon_alloc_muex to simplify extcon register function Date: Fri, 17 Feb 2023 17:46:12 +0900 Message-Id: <20230217084613.25359-4-bw365.lee@samsung.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230217084613.25359-1-bw365.lee@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLKsWRmVeSWpSXmKPExsWy7bCmga6z/ftkg1c3DS1OrFnEZHH9y3NW i8u75rBZ3G5cwebA4tG3ZRWjx+dNcgFMUdk2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6 hpYW5koKeYm5qbZKLj4Bum6ZOUCLlBTKEnNKgUIBicXFSvp2NkX5pSWpChn5xSW2SqkFKTkF ZgV6xYm5xaV56Xp5qSVWhgYGRqZAhQnZGctfvGIvmCtfcfVbC3sD42+JLkZODgkBE4lzbxax djFycQgJ7GCUuLlgNwuE84lR4sbqeUwQzmdGiTuT9jHBtLQsfwKV2MUo8W7pBWYI5xejxILv r1hAqtgENCT2XGxg62Lk4BARKJQ43J8NEmYWUJN4sGojO4gtLBAt8ef/QjYQm0VAVWL15nNg C3gFrCQe9Gxjg1gmL9H97w/YSE4Ba4m/e2+yQtQISpyc+YQFYqa8RPPW2WA3SAjsY5fo/rWC BWSvhICLxJLPGhBzhCVeHd/CDmFLSXx+txdqfrrEyit3oOI5Eq/vtzNC2MYS796uZQYZwyyg KbF+lz5EWFFi5++5jBBr+STefe1hhdjEK9HRJgRRoizR/eAFNKgkJRY/vQM10UNi9s3n0GDr Y5Q4eXAW0wRGhVlIvpmF5JtZCJsXMDKvYhRLLSjOTU8tNiwwhkdwcn7uJkZwutMy38E47e0H vUOMTByMhxglOJiVRHg33XyTLMSbklhZlVqUH19UmpNafIjRFBjWE5mlRJPzgQk3ryTe0MTS wMTMyMTC2NLYTEmcV9z2ZLKQQHpiSWp2ampBahFMHxMHp1QDU+2yr6s2T1sef2tnydeWyxY7 Hr3f/MOTxVCuVjS3YbFcYcgSLXG50r7f6aUlhbpOS7cY2btO4vghmhtkWvdLpKVZtr5LNbDH 40PLjYVC2z4utHi/b07RyZSNz9dWzn3FUzHnwZVyp6RbFilCzDcnH5RdkDzNTlXu9jKj3eas pQeNFH7uVKgNS+bW8dfepii3YtZK02t1AWt8PYprzga8qK3m/fjyaAL/ematHL2oCzf3f0me zh690N5qTcorXqWjq9Rdp72wCDH7ePTCKkVLhuN9smtuapm80+fIWX9XUNQxwiyF488VU9kz vD+1uhmkV+4r/S/FeObwfRPDeEOr/EPi4q+jnr/4w8avVlWrxFKckWioxVxUnAgAzuriPwAE AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGLMWRmVeSWpSXmKPExsWy7bCSvK6z/ftkg293pCxOrFnEZHH9y3NW i8u75rBZ3G5cwebA4tG3ZRWjx+dNcgFMUVw2Kak5mWWpRfp2CVwZy1+8Yi+YK19x9VsLewPj b4kuRk4OCQETiZblT5i6GLk4hAR2MEpcWTqRDSIhKXF2+SP2LkYOIFtY4vDhYpCwkMAPRomX D+VBbDYBDYk9FxvAykUEiiUuHFjMAmIzC6hJPFi1kR3EFhaIlPjw/TVYDYuAqsTqzeeYQGxe ASuJBz3boFbJS3T/+wPWyylgLfF3701WkLVCQDWnJ3FDlAtKnJz5BGq8vETz1tnMExgFZiFJ zUKSWsDItIpRMrWgODc9t9iwwCgvtVyvODG3uDQvXS85P3cTIzgotbR2MO5Z9UHvECMTB+Mh RgkOZiUR3k033yQL8aYkVlalFuXHF5XmpBYfYpTmYFES573QdTJeSCA9sSQ1OzW1ILUIJsvE wSnVwBT+SsEkK7OLabK13QZGD32zi83z327a9DdEemP0TIU3ifyF++dv/JK34WrX2jZhNc6/ MlUhWy8sPq8oJC367PAy1njJzZniqx/Vbavp+NP94Yinosbe+6HfLux02aP9xHLd5suXHwQs l7CW3G8wIbQ82/RY+5YfrTN2szZe+SHra24Q3r77Y8NOk8VlLpOZL202Xrn8/ZqFu7pCaj/8 VnX4URvJk9vpcOdeC9dpUfkef63jEX/0Hzypj95ifyCSLcOUK7HqTg23SYpsUoeMy+0JcnZ8 97I5ptUveCcx+zHvhjffVgjrVCUI5F15z7piwvxWdqtVfk+k+IQZVzmdXPcoLH8SbyTnwkl1 jzlWZyuxFGckGmoxFxUnAgCEneDDuQIAAA== X-CMS-MailID: 20230217084803epcas1p2d5e3ca2fbadd5fde7f58a8ae1940d53f X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230217084803epcas1p2d5e3ca2fbadd5fde7f58a8ae1940d53f References: <20230217084613.25359-1-bw365.lee@samsung.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758067607880976165?= X-GMAIL-MSGID: =?utf-8?q?1758067607880976165?= The mutual exclusive part is functionalized from extcon_dev_register. Signed-off-by: Bumwoo Lee --- drivers/extcon/extcon.c | 105 ++++++++++++++++++++++------------------ 1 file changed, 57 insertions(+), 48 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 28058a1d2745..93cab4fe178e 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1125,6 +1125,60 @@ static int extcon_alloc_cables(struct extcon_dev *edev) return 0; } +/** + * extcon_alloc_muex() - alloc the mutual exclusive for extcon device + * @edev: extcon device + * + * Returns 0 if success or error number if fail. + */ +static int extcon_alloc_muex(struct extcon_dev *edev) +{ + char *name; + int index; + + if (!(edev->max_supported && edev->mutually_exclusive)) + return 0; + + /* Count the size of mutually_exclusive array */ + for (index = 0; edev->mutually_exclusive[index]; index++) + ; + + edev->attrs_muex = kcalloc(index + 1, + sizeof(struct attribute *), + GFP_KERNEL); + if (!edev->attrs_muex) + return -ENOMEM; + + edev->d_attrs_muex = kcalloc(index, + sizeof(struct device_attribute), + GFP_KERNEL); + if (!edev->d_attrs_muex) { + kfree(edev->attrs_muex); + return -ENOMEM; + } + + for (index = 0; edev->mutually_exclusive[index]; index++) { + name = kasprintf(GFP_KERNEL, "0x%x", + edev->mutually_exclusive[index]); + if (!name) { + for (index--; index >= 0; index--) + kfree(edev->d_attrs_muex[index].attr.name); + + kfree(edev->d_attrs_muex); + kfree(edev->attrs_muex); + return -ENOMEM; + } + sysfs_attr_init(&edev->d_attrs_muex[index].attr); + edev->d_attrs_muex[index].attr.name = name; + edev->d_attrs_muex[index].attr.mode = 0000; + edev->attrs_muex[index] = &edev->d_attrs_muex[index].attr; + } + edev->attr_g_muex.name = muex_name; + edev->attr_g_muex.attrs = edev->attrs_muex; + + return 0; +} + /** * extcon_dev_register() - Register an new extcon device * @edev: the extcon device to be registered @@ -1175,53 +1229,8 @@ int extcon_dev_register(struct extcon_dev *edev) if (extcon_alloc_cables(edev)) goto err_alloc_cables; - if (edev->max_supported && edev->mutually_exclusive) { - char *name; - - /* Count the size of mutually_exclusive array */ - for (index = 0; edev->mutually_exclusive[index]; index++) - ; - - edev->attrs_muex = kcalloc(index + 1, - sizeof(struct attribute *), - GFP_KERNEL); - if (!edev->attrs_muex) { - ret = -ENOMEM; - goto err_muex; - } - - edev->d_attrs_muex = kcalloc(index, - sizeof(struct device_attribute), - GFP_KERNEL); - if (!edev->d_attrs_muex) { - ret = -ENOMEM; - kfree(edev->attrs_muex); - goto err_muex; - } - - for (index = 0; edev->mutually_exclusive[index]; index++) { - name = kasprintf(GFP_KERNEL, "0x%x", - edev->mutually_exclusive[index]); - if (!name) { - for (index--; index >= 0; index--) { - kfree(edev->d_attrs_muex[index].attr. - name); - } - kfree(edev->d_attrs_muex); - kfree(edev->attrs_muex); - ret = -ENOMEM; - goto err_muex; - } - sysfs_attr_init(&edev->d_attrs_muex[index].attr); - edev->d_attrs_muex[index].attr.name = name; - edev->d_attrs_muex[index].attr.mode = 0000; - edev->attrs_muex[index] = &edev->d_attrs_muex[index] - .attr; - } - edev->attr_g_muex.name = muex_name; - edev->attr_g_muex.attrs = edev->attrs_muex; - - } + if (extcon_alloc_muex(edev)) + goto err_alloc_muex; if (edev->max_supported) { edev->extcon_dev_type.groups = @@ -1289,7 +1298,7 @@ int extcon_dev_register(struct extcon_dev *edev) kfree(edev->d_attrs_muex); kfree(edev->attrs_muex); } -err_muex: +err_alloc_muex: for (index = 0; index < edev->max_supported; index++) kfree(edev->cables[index].attr_g.name); err_alloc_cables: From patchwork Fri Feb 17 08:46:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bumwoo Lee X-Patchwork-Id: 58427 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp775306wrn; Fri, 17 Feb 2023 00:53:09 -0800 (PST) X-Google-Smtp-Source: AK7set99J8pk2AIF4IVvBmQ4d1dKlmGxJ6WHJEJs0n4duuzbPkBfynN3+whKOW45wMuenBquCTGq X-Received: by 2002:a17:907:7628:b0:8b1:7daf:6285 with SMTP id jy8-20020a170907762800b008b17daf6285mr2284175ejc.35.1676623989566; Fri, 17 Feb 2023 00:53:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676623989; cv=none; d=google.com; s=arc-20160816; b=d1Zqm5COMf7x8Of2F8yx9NKPvET5FVT89+ClSiZO1if4QnT2TMFYbKFpFeMXtl7fJB 2khejaRFltDurD/eQ1N/RU8gVvJEGO6mVOZpTujv1K/21msgnYW4MU6oT/zIUXW1l+7g GIIiegNoTkq7ZpUIgPOVSb+jcJlwUN85+G+hl99XHU4KFCfQZaxRCja2huflIkvSQllm LUfWD2Rc5K6EDuMPgYAUyrXdmuFvdTiSJZnmcITGBT7YGyECzD9+Mm0AZoS/mI+YsXF3 rFeWmHVRe9XCri9M/Xtuw/y/s+t4335op8X+pVJHGf92auS/M8RUL5vwRTGthzWpt3Ds bMcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:dlp-filter:cms-type :content-transfer-encoding:mime-version:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=mkN+m3nU5kJKUPNLUDoUi3aY8MfrFcT8Rpq3baj3b5M=; b=SfwoAEe3mYjgm2ztDCQ4OnwEviMzIUfUBM0OBoZsltjNLKgOs2FoLTGMbJsYc1AVTv 2iY7/DRXmECz36uRbnRNhZTnPxxZ01K5qSzvyX5kVQavf7Yoy88KYwEaDuYhd6NSVLsR W4/U0f6nt4QwpjLWuVN+H/10q9/GsLK+2iy991x/RgUtAN23XNiZZCPTM/LdHpORXWfR 9Ry26WnRRHXn/1/1XN/rW/c/CM80ouHSVs2NNK8lq+KrDW0Bgb4clincAON5kpOLoVZr L30PY9TaFdouD87A3VD69S8WOHm1vczO2Q1E8wslnE88HyIf2S+pt2d7p9lBMEEc5X5/ 6FgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=Rlq2ohw3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id eq22-20020a170907291600b0088a6700e203si3693878ejc.128.2023.02.17.00.52.46; Fri, 17 Feb 2023 00:53:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=Rlq2ohw3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229907AbjBQIsO (ORCPT + 99 others); Fri, 17 Feb 2023 03:48:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229883AbjBQIsK (ORCPT ); Fri, 17 Feb 2023 03:48:10 -0500 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FD6F3645A for ; Fri, 17 Feb 2023 00:48:07 -0800 (PST) Received: from epcas1p3.samsung.com (unknown [182.195.41.47]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20230217084804epoutp01c55767a351b657f083eef004a2f704d8~EkFuvrQvF1217012170epoutp01R for ; Fri, 17 Feb 2023 08:48:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20230217084804epoutp01c55767a351b657f083eef004a2f704d8~EkFuvrQvF1217012170epoutp01R DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1676623684; bh=mkN+m3nU5kJKUPNLUDoUi3aY8MfrFcT8Rpq3baj3b5M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Rlq2ohw3HYy6e3zqJiYaJTMCJnMubkIPipMsgnjtST/m2UBcLJcgh5FhkxDNOR4XH qfGAQMhdWqJN1/EwO6bBTDO0rbqSgv7nkOKFq1wl6RbqfL7VnPYYo612WQLf+sl7z7 GIKI7JY62GJdvMERVHG1f8P+KIJ4I+52uDKlRojc= Received: from epsnrtp3.localdomain (unknown [182.195.42.164]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20230217084804epcas1p35bd433c9b33050b31085765ec47c1c34~EkFueAYGR1965219652epcas1p3K; Fri, 17 Feb 2023 08:48:04 +0000 (GMT) Received: from epsmges1p3.samsung.com (unknown [182.195.38.240]) by epsnrtp3.localdomain (Postfix) with ESMTP id 4PJ57763ZLz4x9Pt; Fri, 17 Feb 2023 08:48:03 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p3.samsung.com (Symantec Messaging Gateway) with SMTP id 0C.F0.52037.34F3FE36; Fri, 17 Feb 2023 17:48:03 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230217084803epcas1p17f034701f5bf98ef2650f2ec27cd2d35~EkFtmXUAC1582215822epcas1p18; Fri, 17 Feb 2023 08:48:03 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230217084803epsmtrp2ba027930c5e6c13326996a894e4d329e~EkFtlr3h13026830268epsmtrp2S; Fri, 17 Feb 2023 08:48:03 +0000 (GMT) X-AuditID: b6c32a37-55fff7000001cb45-fa-63ef3f43500f Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id F1.55.05839.34F3FE36; Fri, 17 Feb 2023 17:48:03 +0900 (KST) Received: from VDBS1418.vd.sec.samsung.net (unknown [168.219.244.30]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230217084803epsmtip204b9046a4a576329fe051bba405dd69a~EkFteSOSl2114021140epsmtip2U; Fri, 17 Feb 2023 08:48:03 +0000 (GMT) From: Bumwoo Lee To: MyungJoo Ham , Chanwoo Choi , linux-kernel@vger.kernel.org Cc: Bumwoo Lee Subject: [PATCH 4/4] extcon: added extcon_alloc_groups to simplify extcon register function Date: Fri, 17 Feb 2023 17:46:13 +0900 Message-Id: <20230217084613.25359-5-bw365.lee@samsung.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230217084613.25359-1-bw365.lee@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNKsWRmVeSWpSXmKPExsWy7bCmga6z/ftkgzMXDS1OrFnEZHH9y3NW i8u75rBZ3G5cwebA4tG3ZRWjx+dNcgFMUdk2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6 hpYW5koKeYm5qbZKLj4Bum6ZOUCLlBTKEnNKgUIBicXFSvp2NkX5pSWpChn5xSW2SqkFKTkF ZgV6xYm5xaV56Xp5qSVWhgYGRqZAhQnZGXffbWMtmCRccfz7VuYGxo/8XYwcHBICJhLPdmp0 MXJxCAnsYJSYfmQBI4TziVHiTccbJgjnG6PEgQ17mbsYOcE6fq66xw6R2AvUMuUEG4Tzi1Hi 4JObYFVsAhoSey42sIHsEBEolDjcnw0SZhZQk3iwaiM7iC0sECuxauF3sBIWAVWJifP5QMK8 AlYS37onsUPskpfo/veHBcTmFLCW+Lv3JitEjaDEyZlPWCBGyks0b53NDHKChMA2don21t1s EM0uEpMOP2CEsIUlXh3fAjVUSuLzu71QNekSK6/cgYrnSLy+3w5Vbyzx7u1aZpDbmAU0Jdbv 0ocIK0rs/D2XEWIvn8S7rz2skFDklehoE4IoUZbofvCCCcKWlFj89A7URA+J2Y9awE4WEuhj lOi+UjKBUWEWkm9mIflmFsLiBYzMqxjFUguKc9NTiw0LjOHRm5yfu4kRnOq0zHcwTnv7Qe8Q IxMH4yFGCQ5mJRHeTTffJAvxpiRWVqUW5ccXleakFh9iNAUG9URmKdHkfGCyzSuJNzSxNDAx MzKxMLY0NlMS5xW3PZksJJCeWJKanZpakFoE08fEwSnVwBS9z/r6tXu2fdU19c7JbLyHtyas nrl/SejblSus5I46HwrVObPu42R7/u6rNjGG9k8F+BPMeh61/Zo1JW+Z0ooGz+qmPcKm97xL 5wXqHPz47/6MebXH74WGXf+wO2yfplvH8tMlr87vak05eL7O4n38wxmLRHjCZrX/DL4X6nc1 V2Z1dbcdt97uVbtz3x3bd3fTsvcOL07enHyGTSotsqQzckXMCrH2+xJ39bZNtkhZ/vnI+6LU R6fqUgPt5T5EbfFJadsV/Fx98jVVZ0PelHpPS7UorvdTJhgvrnyuHvP2o906nugMjcVz3W4F ec7dn8Ey4Yfb6dTdyXm3tvrNPDPtuMZT97/fq2TeJ8jb356hxFKckWioxVxUnAgAQHh5N/4D AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCLMWRmVeSWpSXmKPExsWy7bCSvK6z/ftkg8alMhYn1ixisrj+5Tmr xeVdc9gsbjeuYHNg8ejbsorR4/MmuQCmKC6blNSczLLUIn27BK6Mu++2sRZMEq44/n0rcwPj R/4uRk4OCQETiZ+r7rGD2EICuxkl3n9nh4hLSpxd/gjI5gCyhSUOHy7uYuQCKvnBKHGz8xoT SA2bgIbEnosNbCC2iECxxIUDi1lAbGYBNYkHqzaC9QoLREs83CwCYrIIqEpMnM8HUsErYCXx rXsS1CZ5ie5/f8A6OQWsJf7uvckKUi4EVHN6EjdEuaDEyZlPoIbLSzRvnc08gVFgFpLULCSp BYxMqxglUwuKc9Nziw0LDPNSy/WKE3OLS/PS9ZLzczcxggNSS3MH4/ZVH/QOMTJxMB5ilOBg VhLh3XTzTbIQb0piZVVqUX58UWlOavEhRmkOFiVx3gtdJ+OFBNITS1KzU1MLUotgskwcnFIN TGL8vGpWP+fYHUjJnq6V92N5x+8WsZebXQ7Wn9oaWB7yjcfpgWVFeGMHl1pxVbeNiNwx87uM vfUmOeWT5dwVVs2w+fur70+5zsLpCywulD9MsPf1Kfub/XbR2ooJn4XNF075ktHc1CXwJDf4 XtsB9QrW+w5HzxSujDNgahZK01nV/mZ3huLnnAenNGZyHPq3sKo5pvjd3SV1u1nlshg6uZ+I nW96vzXnxL+N0+Sj/kn+4b4bkKognPR6x9L/bNOvfDgsavf3280NAT+89rvNcbmwU0prz/ec kgm2D95eOWXtz8bauVJ22oNXiT92rpltfIjL/wq//FPvF6HvlQo3FPduUbBv+bj6ZP2OstW/ UpVYijMSDbWYi4oTAZce6du3AgAA X-CMS-MailID: 20230217084803epcas1p17f034701f5bf98ef2650f2ec27cd2d35 X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230217084803epcas1p17f034701f5bf98ef2650f2ec27cd2d35 References: <20230217084613.25359-1-bw365.lee@samsung.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758067676631042093?= X-GMAIL-MSGID: =?utf-8?q?1758067676631042093?= The alloc groups is functionalized from extcon_dev_register. Signed-off-by: Bumwoo Lee --- drivers/extcon/extcon.c | 57 +++++++++++++++++++++++++---------------- 1 file changed, 35 insertions(+), 22 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 93cab4fe178e..9336d0d7589a 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1179,6 +1179,39 @@ static int extcon_alloc_muex(struct extcon_dev *edev) return 0; } +/** + * extcon_alloc_groups() - alloc the groups for extcon device + * @edev: extcon device + * + * Returns 0 if success or error number if fail. + */ +static int extcon_alloc_groups(struct extcon_dev *edev) +{ + int index; + + if (!edev->max_supported) + return 0; + + edev->extcon_dev_type.groups = kcalloc(edev->max_supported + 2, + sizeof(struct attribute_group *), + GFP_KERNEL); + if (!edev->extcon_dev_type.groups) + return -ENOMEM; + + edev->extcon_dev_type.name = dev_name(&edev->dev); + edev->extcon_dev_type.release = dummy_sysfs_dev_release; + + for (index = 0; index < edev->max_supported; index++) + edev->extcon_dev_type.groups[index] = &edev->cables[index].attr_g; + + if (edev->mutually_exclusive) + edev->extcon_dev_type.groups[index] = &edev->attr_g_muex; + + edev->dev.type = &edev->extcon_dev_type; + + return 0; +} + /** * extcon_dev_register() - Register an new extcon device * @edev: the extcon device to be registered @@ -1232,28 +1265,8 @@ int extcon_dev_register(struct extcon_dev *edev) if (extcon_alloc_muex(edev)) goto err_alloc_muex; - if (edev->max_supported) { - edev->extcon_dev_type.groups = - kcalloc(edev->max_supported + 2, - sizeof(struct attribute_group *), - GFP_KERNEL); - if (!edev->extcon_dev_type.groups) { - ret = -ENOMEM; - goto err_alloc_groups; - } - - edev->extcon_dev_type.name = dev_name(&edev->dev); - edev->extcon_dev_type.release = dummy_sysfs_dev_release; - - for (index = 0; index < edev->max_supported; index++) - edev->extcon_dev_type.groups[index] = - &edev->cables[index].attr_g; - if (edev->mutually_exclusive) - edev->extcon_dev_type.groups[index] = - &edev->attr_g_muex; - - edev->dev.type = &edev->extcon_dev_type; - } + if (extcon_alloc_groups(edev)) + goto err_alloc_groups; spin_lock_init(&edev->lock); if (edev->max_supported) {