From patchwork Fri Feb 17 08:33:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kathiravan Thirumoorthy X-Patchwork-Id: 58414 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp770394wrn; Fri, 17 Feb 2023 00:37:01 -0800 (PST) X-Google-Smtp-Source: AK7set+eFkhxLwgaIAIDr/n4Olm9OBc0QAd8XFwIxl25kNf+2v87SbOvkti2RSOt+VQw5s8O0gLd X-Received: by 2002:a17:902:c412:b0:19a:98c9:8cea with SMTP id k18-20020a170902c41200b0019a98c98ceamr58734plk.39.1676623020917; Fri, 17 Feb 2023 00:37:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676623020; cv=none; d=google.com; s=arc-20160816; b=GP17tA08F/SC1+gakOHMDrAL4xl3kxlMVSxnMY4PYOJnbAepOCRnJp+TKj7GYcHDRo x3NMB2kRv7Viff4YUvJoofgTqtmHyXL1xdg0unbFSlwp/oZqCa36ONoPfGUObqki2DTZ BQRYkAPdNXQYcqTO935zlkJbqD33TqiYIeEpVELJYq6aiXapV3cKGATfQHklAxlZg4aH VEJigzBGtc995APi5IrA/80ETDlvfGSSlM5I7SEumhgfEVBP25W1cuiwXId4SRnUJPn7 bMUr5A3aMSn0+TVbuvxNvUwQa6cArgE3uPXrWRB8v6Hw3AiMM1dR38bgCznA9RFFnW7o jwgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=xa9XZiBikd9wXQPbluBvwWQN/1ODQw+TlYDNvBgoWu0=; b=oswoGXjYyMmvJHmzgtRoWJGB4viV0cMAjQBKp876nCBQeShWpf4gmKE6oEVE04yFgR QRMquYSyh0962crGnpZV12P5u8zjmQg7sjeSnePTjGANOJd2si+GSA2SLnb7g29C5baT Tj9hutXi7UlYhj04gr1VwDdOddqBwO/DIW53GjaLW7HvcbHKPZ8MchSgSAtCteCd+eAB gQ45AtMqaodjBkiolf0Bv/QorTjtffbOs5NtXTjxFDxWLHL0zNrBFUfOONjbLfhuuaW9 1rgOKyV8DbZKRWaefma6L8MKjvr+InQmzKQA8uOs1eTKJGYeC/PFm1mFb0ocn13+rI/V e1Og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="HT3zw/nH"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u1-20020a170902e5c100b00198e1b0680csi4636908plf.578.2023.02.17.00.36.49; Fri, 17 Feb 2023 00:37:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="HT3zw/nH"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229787AbjBQIdn (ORCPT + 99 others); Fri, 17 Feb 2023 03:33:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbjBQIdm (ORCPT ); Fri, 17 Feb 2023 03:33:42 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BC895FBEA; Fri, 17 Feb 2023 00:33:37 -0800 (PST) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31H7Jg4v010504; Fri, 17 Feb 2023 08:33:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=xa9XZiBikd9wXQPbluBvwWQN/1ODQw+TlYDNvBgoWu0=; b=HT3zw/nHTcHgeBhAAwwiwdqsAHzCa78ZJZF/Xm8M1ofnlc4fiyKLggZgHR1Fqra9Z9/I aOSwdrwGeonZFpqLmy0OQznCxCVyVahv/7Pr+gtDjXrOvJtLhRvxcTGwQmg9AhAk05ED Yj842Ghf3EMgc7QSK2GG7RXBcFufy4Nn8cvaiLo/spxlT3PuYF9vBL5sR50YzbjPaO73 K9R9aNhlrXOOUd9CsN4cnLDrE5c+gqI+kZVlF+FAc2p4To/toFpoELHG1UJSUfBHwozF 0je3tQxyxUDIOL2A1IZoqwRyT/VnF3OoR8nu1y2mqdUGzgkV6STN6XLaVIwswVttJoKS tA== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3nt53br5eu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Feb 2023 08:33:33 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 31H8XWse012488 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Feb 2023 08:33:32 GMT Received: from kathirav-linux.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Fri, 17 Feb 2023 00:33:27 -0800 From: Kathiravan T To: , , , , , , , , , , , CC: , , Kathiravan T Subject: [PATCH V3 1/5] clk: qcom: apss-ipq-pll: refactor the driver to accommodate different PLL types Date: Fri, 17 Feb 2023 14:03:04 +0530 Message-ID: <20230217083308.12017-2-quic_kathirav@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230217083308.12017-1-quic_kathirav@quicinc.com> References: <20230217083308.12017-1-quic_kathirav@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: DCSrJVLpnVTY_hCcJrH4F79AYBsAl7yO X-Proofpoint-GUID: DCSrJVLpnVTY_hCcJrH4F79AYBsAl7yO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-17_04,2023-02-16_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 suspectscore=0 adultscore=0 impostorscore=0 priorityscore=1501 phishscore=0 mlxlogscore=999 spamscore=0 clxscore=1015 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302170076 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758066660835582866?= X-GMAIL-MSGID: =?utf-8?q?1758066660835582866?= APSS PLL found on the IPQ8074 and IPQ6018 are of type Huayra PLL. But, IPQ5332 APSS PLL is of type Stromer Plus. To accommodate both these PLLs, refactor the driver to take the clk_alpha_pll, alpha_pll_config via driver data. Reviewed-by: Konrad Dybcio Signed-off-by: Kathiravan T --- Changes in V3: - Pick up R-b tag Changes in V2: - Added a comment to describe why different offsets are required for PLL drivers/clk/qcom/apss-ipq-pll.c | 60 ++++++++++++++++++++++----------- 1 file changed, 41 insertions(+), 19 deletions(-) diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c index a5aea27eb867..4f2a147e9fb2 100644 --- a/drivers/clk/qcom/apss-ipq-pll.c +++ b/drivers/clk/qcom/apss-ipq-pll.c @@ -8,20 +8,27 @@ #include "clk-alpha-pll.h" -static const u8 ipq_pll_offsets[] = { - [PLL_OFF_L_VAL] = 0x08, - [PLL_OFF_ALPHA_VAL] = 0x10, - [PLL_OFF_USER_CTL] = 0x18, - [PLL_OFF_CONFIG_CTL] = 0x20, - [PLL_OFF_CONFIG_CTL_U] = 0x24, - [PLL_OFF_STATUS] = 0x28, - [PLL_OFF_TEST_CTL] = 0x30, - [PLL_OFF_TEST_CTL_U] = 0x34, +/* + * Even though APSS PLL type is of existing one (like Huayra), its offsets + * are different from the one mentioned in the clk-alpha-pll.c, since the + * PLL is specific to APSS, so lets the define the same. + */ +static const u8 ipq_pll_offsets[][PLL_OFF_MAX_REGS] = { + [CLK_ALPHA_PLL_TYPE_HUAYRA] = { + [PLL_OFF_L_VAL] = 0x08, + [PLL_OFF_ALPHA_VAL] = 0x10, + [PLL_OFF_USER_CTL] = 0x18, + [PLL_OFF_CONFIG_CTL] = 0x20, + [PLL_OFF_CONFIG_CTL_U] = 0x24, + [PLL_OFF_STATUS] = 0x28, + [PLL_OFF_TEST_CTL] = 0x30, + [PLL_OFF_TEST_CTL_U] = 0x34, + }, }; -static struct clk_alpha_pll ipq_pll = { +static struct clk_alpha_pll ipq_pll_huayra = { .offset = 0x0, - .regs = ipq_pll_offsets, + .regs = ipq_pll_offsets[CLK_ALPHA_PLL_TYPE_HUAYRA], .flags = SUPPORTS_DYNAMIC_UPDATE, .clkr = { .enable_reg = 0x0, @@ -61,6 +68,21 @@ static const struct alpha_pll_config ipq8074_pll_config = { .test_ctl_hi_val = 0x4000, }; +struct apss_pll_data { + struct clk_alpha_pll *pll; + const struct alpha_pll_config *pll_config; +}; + +static struct apss_pll_data ipq8074_pll_data = { + .pll = &ipq_pll_huayra, + .pll_config = &ipq8074_pll_config, +}; + +static struct apss_pll_data ipq6018_pll_data = { + .pll = &ipq_pll_huayra, + .pll_config = &ipq6018_pll_config, +}; + static const struct regmap_config ipq_pll_regmap_config = { .reg_bits = 32, .reg_stride = 4, @@ -71,7 +93,7 @@ static const struct regmap_config ipq_pll_regmap_config = { static int apss_ipq_pll_probe(struct platform_device *pdev) { - const struct alpha_pll_config *ipq_pll_config; + const struct apss_pll_data *data; struct device *dev = &pdev->dev; struct regmap *regmap; void __iomem *base; @@ -85,23 +107,23 @@ static int apss_ipq_pll_probe(struct platform_device *pdev) if (IS_ERR(regmap)) return PTR_ERR(regmap); - ipq_pll_config = of_device_get_match_data(&pdev->dev); - if (!ipq_pll_config) + data = of_device_get_match_data(&pdev->dev); + if (!data) return -ENODEV; - clk_alpha_pll_configure(&ipq_pll, regmap, ipq_pll_config); + clk_alpha_pll_configure(data->pll, regmap, data->pll_config); - ret = devm_clk_register_regmap(dev, &ipq_pll.clkr); + ret = devm_clk_register_regmap(dev, &data->pll->clkr); if (ret) return ret; return devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, - &ipq_pll.clkr.hw); + &data->pll->clkr.hw); } static const struct of_device_id apss_ipq_pll_match_table[] = { - { .compatible = "qcom,ipq6018-a53pll", .data = &ipq6018_pll_config }, - { .compatible = "qcom,ipq8074-a53pll", .data = &ipq8074_pll_config }, + { .compatible = "qcom,ipq6018-a53pll", .data = &ipq6018_pll_data }, + { .compatible = "qcom,ipq8074-a53pll", .data = &ipq8074_pll_data }, { } }; MODULE_DEVICE_TABLE(of, apss_ipq_pll_match_table); From patchwork Fri Feb 17 08:33:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kathiravan Thirumoorthy X-Patchwork-Id: 58415 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp770421wrn; Fri, 17 Feb 2023 00:37:05 -0800 (PST) X-Google-Smtp-Source: AK7set8PVh6kndeAcUcn+1wmTIlmPMBD/Lrljp1WmdYXki/s3nWO6CY+bVE9v1rtjnhvBY4Duy89 X-Received: by 2002:a17:90b:4acc:b0:233:a6b7:3770 with SMTP id mh12-20020a17090b4acc00b00233a6b73770mr10133872pjb.14.1676623024809; Fri, 17 Feb 2023 00:37:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676623024; cv=none; d=google.com; s=arc-20160816; b=dgEabSj4a7NgtzLGU6eaC68EA2Ia5BAsHMAyoeIab7AsTlgpbxrHBzNfZ/KjXFEs+z ghTOnSy/bvR8SnT//4L/4b1Z01DcId/OiAeX+g8C5VZotsTfqv42nFNTzqhWq9va4YTk r1K9/y/cIcn0mkXEJSVJBMjac6wbBDwvezjdGZb5QhxPL89hZJXAsVEXRBga1CcH+4mD +ECWTnUCjNgxOutBavNRdIz8qN5tTvPkzlAtNYbfGxXYxydiL6JgNCW8vbUph6UjV9hq SyVtdGViwrKb2qWI1XHRvHRsE2MiorgwXJIQf3Rg0F+YzeeyDEPeysabdgpylECLW6nG P6aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=bNYBAOHRKNJwDzPX2CiFLqutSWmz6EAH+5Pn33Qxgu0=; b=sfF66ciiOfsIq6yiTuEz3PRY2XqTXH38peFQ1cD8cYrwrdQO0CXiOOOI/WIjPJmrV3 S5xA/W6e+h5o4OB1ES6mxvDt4rD5iYIL17yhFHAS1yd3QLSArtcOCHLaCVgOz5Cd9ntH LFmmvZLdTJ26w2Hco7ZswtHOucPiDg3KhvqVx7C6fbgHKR42jcPzWgLKCo/BrNUonfxU Ha9toxbIE3MWoy0xgMyMK2fjt3DY1Ja4q1FLXJkxo+iGFoh25cjqC9310ZoVpRQFyRvd VJ6doKmkwQK32cr7QV+r9YHkgunYdZT8n+Ycr66CUPw8sPLwMhel6JgbmbwWwGx0zV6y zS0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=ZhxC+Zpy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t186-20020a6381c3000000b004fbc925dd52si3969017pgd.271.2023.02.17.00.36.52; Fri, 17 Feb 2023 00:37:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=ZhxC+Zpy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229892AbjBQIdt (ORCPT + 99 others); Fri, 17 Feb 2023 03:33:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229883AbjBQIdp (ORCPT ); Fri, 17 Feb 2023 03:33:45 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78AE45F269; Fri, 17 Feb 2023 00:33:41 -0800 (PST) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31H6nkMr000664; Fri, 17 Feb 2023 08:33:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=bNYBAOHRKNJwDzPX2CiFLqutSWmz6EAH+5Pn33Qxgu0=; b=ZhxC+Zpy+2Nj43q1VYxEGvGLj7elOB+4NDLcBZjrT9UfANGgRN1GAzBKWp18ew17vzQT I89AOc+HKGKSOaDtdESTRgmVtJofkeGmaR+10UUavR3uQN4czAYg8cX586J7xf213j5W gAjZIhAIh8gE6hp6LBYOH+hlWBkPAqHiutv5g+jwcpb+ruUCSN8MaNUu7DCjsUTd13oN 6eABHSWlrqpp3ekanDP/x7ncQBrJ1/MusbKkj2X7rdQtoB5e94/xWOVQBzX83iBBxcaD J6Mv3q8VQhrUUMXlnB53SZAPjkOsJMVYAgTomMqVgSLWuws4jEQe0APYKwUSXOiDfu5S fQ== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3nsft5uj1g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Feb 2023 08:33:37 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 31H8XatZ015832 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Feb 2023 08:33:36 GMT Received: from kathirav-linux.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Fri, 17 Feb 2023 00:33:32 -0800 From: Kathiravan T To: , , , , , , , , , , , CC: , , Kathiravan T Subject: [PATCH V3 2/5] dt-bindings: clock: qcom,a53pll: add IPQ5332 compatible Date: Fri, 17 Feb 2023 14:03:05 +0530 Message-ID: <20230217083308.12017-3-quic_kathirav@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230217083308.12017-1-quic_kathirav@quicinc.com> References: <20230217083308.12017-1-quic_kathirav@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: WkglyfN3xf6L8q74kc2y9z5jqP8epP4r X-Proofpoint-GUID: WkglyfN3xf6L8q74kc2y9z5jqP8epP4r X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-17_04,2023-02-16_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 bulkscore=0 spamscore=0 phishscore=0 impostorscore=0 mlxlogscore=971 clxscore=1015 adultscore=0 lowpriorityscore=0 mlxscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302170076 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758066665043815956?= X-GMAIL-MSGID: =?utf-8?q?1758066665043815956?= Add IPQ5332 compatible to A53 PLL bindings. Acked-by: Krzysztof Kozlowski Signed-off-by: Kathiravan T --- Changes in V3: - No change Changes in V2: - Pick up the tags Documentation/devicetree/bindings/clock/qcom,a53pll.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml index 525ebaa93c85..3b6169f30154 100644 --- a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml @@ -16,6 +16,7 @@ description: properties: compatible: enum: + - qcom,ipq5332-a53pll - qcom,ipq6018-a53pll - qcom,ipq8074-a53pll - qcom,msm8916-a53pll From patchwork Fri Feb 17 08:33:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kathiravan Thirumoorthy X-Patchwork-Id: 58416 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp770527wrn; Fri, 17 Feb 2023 00:37:25 -0800 (PST) X-Google-Smtp-Source: AK7set8uoGyTksGk99ew4+g76r7vwib4GmsdgMFAqfsWRkBecg0H7d8Mc21GXJNuz1dG9+pg+fer X-Received: by 2002:a05:6a20:4299:b0:c7:4c1a:3e49 with SMTP id o25-20020a056a20429900b000c74c1a3e49mr4160473pzj.35.1676623045063; Fri, 17 Feb 2023 00:37:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676623045; cv=none; d=google.com; s=arc-20160816; b=vd6y8ybJMOpVRFlrWtMbfQMEbZ+j+fpftb0VRA5OvYHDYjb75REbJOFc27mNRSaBFW Q3BtiYyow3Sv91Pw4SpqbAOX+iCIv/psXT84SFZ8aYB9MufBp5mraf2qnK0Cl6nSXkPM 5cfLfkPFiFRiZQtPC3FZqcU2NMx8uubC9P7HUBPebm1k9j6bRJ41vIWdekBEIXSGRXc6 wc+Wecqdd7tvQSbu7Edo/nB4D+OnsvpA0VgP95Bk9+NUH2WVodfMcAohUH8HLk5RXZgw Xn45yx6ftdlotMM/dLBX5RLlMuS7Z8xXXIXrPeYbDlbl82WafpnL0K608+qhAFPSWZMe fZ+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=brhz50fJcwcoUXAHiAulWT6InrLg/7Z2AY3zOrX2Vxc=; b=GMEP7lQgPRt7NkG5D1xZiF2DyWakgitjr8Qkl783I+Ekg/iWkUtrsYL91JC+wQ3zho 3KfkOBXGJRA9bboU0CWzLeldOdlqiUV9OJqeXEpmIDBROLYAwRam67rp4zIoCKqe1oLN JVZKroA2C0/h0a9t3IB1XjvQXRjtcBlNLE4AYYgSzw0stSZUbQNwYwhXo/ol66pvuiNe 4mV1T5g9/tpZMySj4AFYOSJD5EoY9if4PmFATuIdwwbyLzXWCf+EGG9EKlMUUhlAZ2SW 8mv1trtaoC1Xyr5oxsj5pv3YPRr4oDCd4wgjs3EE3fMnm108cYDr+UGdqRu4YfgrxTD0 Uwpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=nxetScIw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s144-20020a632c96000000b004fbffa7d04dsi3886287pgs.863.2023.02.17.00.37.12; Fri, 17 Feb 2023 00:37:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=nxetScIw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229663AbjBQIdz (ORCPT + 99 others); Fri, 17 Feb 2023 03:33:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229889AbjBQIdv (ORCPT ); Fri, 17 Feb 2023 03:33:51 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2C7D5FBFE; Fri, 17 Feb 2023 00:33:46 -0800 (PST) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31H7JM6S010198; Fri, 17 Feb 2023 08:33:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=brhz50fJcwcoUXAHiAulWT6InrLg/7Z2AY3zOrX2Vxc=; b=nxetScIwd5ewVWlCcYwU1YLEbzVgC2PWqUapGKCfMnmqZ5223joK1JHFVKuDnw6Zu2JX gZHOLf0P53f8CNrflfk+CdXJNRTYhg+nBJIwVTXx/gbRrzxJcBLntumcoN2IVbV1zFY+ g04UXh1o4105rFE82yPktme2n2b1v38qziMr1f5Z/azbW5aLzg5ATGNfJcIyi4IfCerD 1GdLMfjL6z1Bh6q2+ns4z2N3gKnym7pcKMV6YnvXSAIo+r0nTFYZX/ZDqN0+DsjfHbAf p9gfUF6Z7kjoWV0A8LzrLGRW/AtZ202LjutplJr75dc4zt7PxbfEY9RKdl+DVsgIz15u Mg== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3nt53br5f6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Feb 2023 08:33:42 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 31H8XfJB015865 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Feb 2023 08:33:41 GMT Received: from kathirav-linux.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Fri, 17 Feb 2023 00:33:36 -0800 From: Kathiravan T To: , , , , , , , , , , , CC: , , Kathiravan T Subject: [PATCH V3 3/5] clk: qcom: apss-ipq-pll: add support for IPQ5332 Date: Fri, 17 Feb 2023 14:03:06 +0530 Message-ID: <20230217083308.12017-4-quic_kathirav@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230217083308.12017-1-quic_kathirav@quicinc.com> References: <20230217083308.12017-1-quic_kathirav@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: _7E_8h42Tfb7LrUvSZYo2lJaoTYzXo-y X-Proofpoint-GUID: _7E_8h42Tfb7LrUvSZYo2lJaoTYzXo-y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-17_04,2023-02-16_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 suspectscore=0 adultscore=0 impostorscore=0 priorityscore=1501 phishscore=0 mlxlogscore=999 spamscore=0 clxscore=1015 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302170076 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758066685806224142?= X-GMAIL-MSGID: =?utf-8?q?1758066685806224142?= IPQ5332 APSS PLL is of type Stromer Plus. Add support for the same. To configure the stromer plus PLL separate API (clock_stromer_pll_configure) to be used. To achieve this, introduce the new member pll_type in device data structure and call the appropriate function based on this. Reviewed-by: Konrad Dybcio Signed-off-by: Kathiravan T --- Changes in V3: - Pick up R-b tag Changes in V2: - No changes drivers/clk/qcom/apss-ipq-pll.c | 58 ++++++++++++++++++++++++++++++++- 1 file changed, 57 insertions(+), 1 deletion(-) diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c index 4f2a147e9fb2..cf4f0d340cbf 100644 --- a/drivers/clk/qcom/apss-ipq-pll.c +++ b/drivers/clk/qcom/apss-ipq-pll.c @@ -24,6 +24,17 @@ static const u8 ipq_pll_offsets[][PLL_OFF_MAX_REGS] = { [PLL_OFF_TEST_CTL] = 0x30, [PLL_OFF_TEST_CTL_U] = 0x34, }, + [CLK_ALPHA_PLL_TYPE_STROMER_PLUS] = { + [PLL_OFF_L_VAL] = 0x08, + [PLL_OFF_ALPHA_VAL] = 0x10, + [PLL_OFF_ALPHA_VAL_U] = 0x14, + [PLL_OFF_USER_CTL] = 0x18, + [PLL_OFF_USER_CTL_U] = 0x1c, + [PLL_OFF_CONFIG_CTL] = 0x20, + [PLL_OFF_STATUS] = 0x28, + [PLL_OFF_TEST_CTL] = 0x30, + [PLL_OFF_TEST_CTL_U] = 0x34, + }, }; static struct clk_alpha_pll ipq_pll_huayra = { @@ -44,6 +55,38 @@ static struct clk_alpha_pll ipq_pll_huayra = { }, }; +static struct clk_alpha_pll ipq_pll_stromer_plus = { + .offset = 0x0, + .regs = ipq_pll_offsets[CLK_ALPHA_PLL_TYPE_STROMER_PLUS], + .flags = SUPPORTS_DYNAMIC_UPDATE, + .clkr = { + .enable_reg = 0x0, + .enable_mask = BIT(0), + .hw.init = &(struct clk_init_data){ + .name = "a53pll", + .parent_data = &(const struct clk_parent_data) { + .fw_name = "xo", + }, + .num_parents = 1, + .ops = &clk_alpha_pll_stromer_ops, + }, + }, +}; + +static const struct alpha_pll_config ipq5332_pll_config = { + .l = 0x3e, + .config_ctl_val = 0x4001075b, + .config_ctl_hi_val = 0x304, + .main_output_mask = BIT(0), + .aux_output_mask = BIT(1), + .early_output_mask = BIT(3), + .alpha_en_mask = BIT(24), + .status_val = 0x3, + .status_mask = GENMASK(10, 8), + .lock_det = BIT(2), + .test_ctl_hi_val = 0x00400003, +}; + static const struct alpha_pll_config ipq6018_pll_config = { .l = 0x37, .config_ctl_val = 0x240d4828, @@ -69,16 +112,25 @@ static const struct alpha_pll_config ipq8074_pll_config = { }; struct apss_pll_data { + int pll_type; struct clk_alpha_pll *pll; const struct alpha_pll_config *pll_config; }; +static struct apss_pll_data ipq5332_pll_data = { + .pll_type = CLK_ALPHA_PLL_TYPE_STROMER_PLUS, + .pll = &ipq_pll_stromer_plus, + .pll_config = &ipq5332_pll_config, +}; + static struct apss_pll_data ipq8074_pll_data = { + .pll_type = CLK_ALPHA_PLL_TYPE_HUAYRA, .pll = &ipq_pll_huayra, .pll_config = &ipq8074_pll_config, }; static struct apss_pll_data ipq6018_pll_data = { + .pll_type = CLK_ALPHA_PLL_TYPE_HUAYRA, .pll = &ipq_pll_huayra, .pll_config = &ipq6018_pll_config, }; @@ -111,7 +163,10 @@ static int apss_ipq_pll_probe(struct platform_device *pdev) if (!data) return -ENODEV; - clk_alpha_pll_configure(data->pll, regmap, data->pll_config); + if (data->pll_type == CLK_ALPHA_PLL_TYPE_HUAYRA) + clk_alpha_pll_configure(data->pll, regmap, data->pll_config); + else if (data->pll_type == CLK_ALPHA_PLL_TYPE_STROMER_PLUS) + clk_stromer_pll_configure(data->pll, regmap, data->pll_config); ret = devm_clk_register_regmap(dev, &data->pll->clkr); if (ret) @@ -122,6 +177,7 @@ static int apss_ipq_pll_probe(struct platform_device *pdev) } static const struct of_device_id apss_ipq_pll_match_table[] = { + { .compatible = "qcom,ipq5332-a53pll", .data = &ipq5332_pll_data }, { .compatible = "qcom,ipq6018-a53pll", .data = &ipq6018_pll_data }, { .compatible = "qcom,ipq8074-a53pll", .data = &ipq8074_pll_data }, { } From patchwork Fri Feb 17 08:33:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kathiravan Thirumoorthy X-Patchwork-Id: 58417 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp770553wrn; Fri, 17 Feb 2023 00:37:30 -0800 (PST) X-Google-Smtp-Source: AK7set/SvA5zdBDc5NsZnuZjuH5uZtOCwxluQ9rgKbL/5SraHfrDrAPb6mWZoDytK1PXYzN5OBn1 X-Received: by 2002:a05:6a20:3ca6:b0:bc:50a6:5944 with SMTP id b38-20020a056a203ca600b000bc50a65944mr10901864pzj.38.1676623050652; Fri, 17 Feb 2023 00:37:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676623050; cv=none; d=google.com; s=arc-20160816; b=r2KU2hVSSx08kmc/m9gD6R5j2XaDGodUiDK/acAFEaOVdEICv58MMq7EtWeNBQw/ng kPld5perxTBm0LD3SzjsugGhIW5sb6g84owf27V5QaaCPw32Wu5A/nxNSSIgbAzJ/pGz PLeihcRJUXbvgTmHzTtT8uFPsPZ8Zl+FHn4bSH/5KXf8I1eXlMZoFK7rI7D7hKdlD+yg Qdxwni3qmrLvezRmpkFJ9zPK8zrcpBjN6RLOXNwNfaXW1Rqf+efF8GkeYh/qn4nLyqbx /P/LxEpKxjkWLrDH4DcGep/H2aw1/Cx6wjvFbrCB6imotLYoX3ZBYlANgLHUL+AXEUcE PW+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=dhVqyWRblQnWDpLPMMouwmbGElAdHlf0juTflJFrGS4=; b=lURVVNQFjnitRx9naFocon5E8F7s3W9N6/9jwviIa86kaHjFL89RiZ7ipdKCu4Z/dq 70jWYZZZjKZQHjlikVQDVCwx2WnzO5UuCc+TVs8y0dcwS6Lo6NbwCvg/74rqfSR0tdGg 4PXDV0ESnvbfl5BBfijUXqZXcTkByzG1IAeHTbZzK7KoxPFPkfbbfBY0Xve3gV6/yC/C xfDU9vTKpMMBiskNsVO+ChRnw+JjE1RycKvwHkSRK/SQeJAR0BRKxvLf/Y7vQvAyCtgK oKRCh6UP07zYC0CTep78sYLsgsNFJag5AGyfnaZlqDOr6lZXUuhKDdtHSwTxluSIlgsH ONlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=TgbRswtc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q15-20020a63e94f000000b004b377960752si4726031pgj.353.2023.02.17.00.37.18; Fri, 17 Feb 2023 00:37:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=TgbRswtc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229802AbjBQIeH (ORCPT + 99 others); Fri, 17 Feb 2023 03:34:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229897AbjBQIeE (ORCPT ); Fri, 17 Feb 2023 03:34:04 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 754F5604C0; Fri, 17 Feb 2023 00:33:51 -0800 (PST) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31H5rGEB029046; Fri, 17 Feb 2023 08:33:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=dhVqyWRblQnWDpLPMMouwmbGElAdHlf0juTflJFrGS4=; b=TgbRswtcIGRL6VNiVbqbCW2ThSNNznep+wEnjbpqRdCZdLsZ8aBYzizqrNipHAOx6zTW lbMot7I+SQScBrri78zKl6P2enkgy4jN/JjEtJHRBQMqFyzzFzMJSBcXs4/zOyADuH9m m2G/X9GMlu5WGSgJk6RmbVa+HWcxNXN56MIldFrppQt56HGGL386QSMewBdYuB03SNNo dh+q+y0s7JoV+WAtN3+ieXARn+7atY6tujeBDUzGZNw7GdgqpTaZYrm6rm2P4hMbTYEB HgNe5EFVBnnhbqJmsgOy1B6POdA7KzKfCvFSSA9lPB3GCe8q6ONlu/829gkE3t/ecsWA +A== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3nswjph94p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Feb 2023 08:33:47 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 31H8XkwT016001 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Feb 2023 08:33:46 GMT Received: from kathirav-linux.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Fri, 17 Feb 2023 00:33:41 -0800 From: Kathiravan T To: , , , , , , , , , , , CC: , , Kathiravan T Subject: [PATCH V3 4/5] dt-bindings: mailbox: qcom: add compatible for the IPQ5332 SoC Date: Fri, 17 Feb 2023 14:03:07 +0530 Message-ID: <20230217083308.12017-5-quic_kathirav@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230217083308.12017-1-quic_kathirav@quicinc.com> References: <20230217083308.12017-1-quic_kathirav@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: ktpuDPxwdhxhh3_heqrJ_7gPfcMHU-Xo X-Proofpoint-ORIG-GUID: ktpuDPxwdhxhh3_heqrJ_7gPfcMHU-Xo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-17_04,2023-02-16_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 adultscore=0 malwarescore=0 suspectscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 spamscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302170076 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758066691582270988?= X-GMAIL-MSGID: =?utf-8?q?1758066691582270988?= Add the mailbox compatible for the IPQ5332 SoC. Since the IPQ5332 mailbox is compatible with the IPQ6018, lets create the fallback to ipq6018 compatible, so that we don't bloat the of_device_id table in the driver. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Kathiravan T --- Changes in V3: - Pick up R-b tag Changes in V2: - As suggested by Krzysztof, modified the binding to use the fallback mechanism so that we don't keep adding the compatibles with the same driver data in mailbox driver .../mailbox/qcom,apcs-kpss-global.yaml | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml index 56b386b688b3..71195c0cadf9 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -16,6 +16,10 @@ maintainers: properties: compatible: oneOf: + - items: + - enum: + - qcom,ipq5332-apcs-apps-global + - const: qcom,ipq6018-apcs-apps-global - items: - enum: - qcom,ipq6018-apcs-apps-global @@ -110,9 +114,10 @@ allOf: - if: properties: compatible: - enum: - - qcom,ipq6018-apcs-apps-global - - qcom,ipq8074-apcs-apps-global + contains: + enum: + - qcom,ipq6018-apcs-apps-global + - qcom,ipq8074-apcs-apps-global then: properties: clocks: @@ -126,9 +131,10 @@ allOf: - if: properties: compatible: - enum: - - qcom,ipq6018-apcs-apps-global - - qcom,ipq8074-apcs-apps-global + contains: + enum: + - qcom,ipq6018-apcs-apps-global + - qcom,ipq8074-apcs-apps-global then: properties: '#clock-cells': From patchwork Fri Feb 17 08:33:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kathiravan Thirumoorthy X-Patchwork-Id: 58421 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp770860wrn; Fri, 17 Feb 2023 00:38:23 -0800 (PST) X-Google-Smtp-Source: AK7set+GQfvEIH5kpRsPIOsud2/zrPbT69wwHxXvk5mCxuf4w0DytMSWMP9agro7JXteownrhIl0 X-Received: by 2002:a17:903:41ce:b0:19c:1455:d588 with SMTP id u14-20020a17090341ce00b0019c1455d588mr1442754ple.0.1676623103237; Fri, 17 Feb 2023 00:38:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676623103; cv=none; d=google.com; s=arc-20160816; b=RV47cZrnezmGMu9cACqloM2KqA4v2YWHi3UXYn7V4s+likyXInl86fKcGpsh0f9Udz 3PkLdR9JvPV4UizHh0k6ityoDtKxLXEQLmWg+fPPkhWK0v0jc8jybzVWjQohuODsKSWY NMdy+WA284QvrTH8JZCQ12l2S/nA8/jbixIcU9Ow1rtQUtVuYF9XRiXOnUwqVL2L1V5W 3bYjMl21mhtcsW3pv1pA/Hh+TrqF71o5E0P5/E71d9wZ+Dyg9vAwEeEC5DgefXeb5Q+f tBv/OKCW+9P/jJuiNO1gPymDsOeNG+UcJaMjx1fagvD+vgmu/urOqYhnlPrMw2uaziDy UCTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=7NzHuwpLfAHoeS4MDg46Por/cx6TUNRnZkEsBcJGs4Y=; b=sjbRaBuApCf3xrUVGZGTISiHbRbj7bnG8L9skACTOs0qLZaQk7J3u4Ty+y2aSta8CP h736+xXpnbcMq4JoA7KaNWPLICn4hO18BEjw5ZN7m9a/zrEuIUHeeF281SwvVWGjjK+1 FRoKdwB9DRA7pKhI0m8jBqlZcr2mu50i1W+YaGB/hIN9rVjmQLsLmgg1LV0tmMc83gc0 Y7KX+iQO+GS3VjT6f+VthkQ1TMRs0x08WJ+suCwG1jeyF1ScW+mvdqCTo26IlcWb6iBu P2/E34ix7dttW3HUtm9x0hEkp8XtEISo08b3hoCGxv4FhGSzG6UNhjnhZA2Hx0FVjvhT ww/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=LXGwcxJo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ks8-20020a170903084800b001933989d4f8si3627660plb.344.2023.02.17.00.38.10; Fri, 17 Feb 2023 00:38:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=LXGwcxJo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229478AbjBQIeQ (ORCPT + 99 others); Fri, 17 Feb 2023 03:34:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229752AbjBQIeO (ORCPT ); Fri, 17 Feb 2023 03:34:14 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46D1A5FBC8; Fri, 17 Feb 2023 00:33:56 -0800 (PST) Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31H6oJRT019483; Fri, 17 Feb 2023 08:33:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=7NzHuwpLfAHoeS4MDg46Por/cx6TUNRnZkEsBcJGs4Y=; b=LXGwcxJoCqD1p5YdwzNxSv5XYxZpPwiT0zO5YbYZlfi01BgoWtymno/xaA7+x3FA51W3 fIrXbRDAYLiMqKhAtInmJLu9PfgcYo7wA3Yn/LhevbL+3/ulpWywp7/JugvsiyR4jlmI F0ZOU86dVwtg6P42ol1vYJIBLGTVZQTzMsP6HdmNydmXAa54tMp4vtq0jpd0hqKmO37/ /+KcrTExTC8RtAE21Sert3fwYmYPu+nZvWv97lFNKwNotwr+Falocwse/6FLpNbSW0b9 XvlDmHh5u5dgrRyzR/ei8cwY486xMotY8YjyNPx8PRqpXdo5bfI9xSPyVAqbWYbjqDmO dg== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3nshe5k8kt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Feb 2023 08:33:52 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 31H8XprE012565 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Feb 2023 08:33:51 GMT Received: from kathirav-linux.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Fri, 17 Feb 2023 00:33:46 -0800 From: Kathiravan T To: , , , , , , , , , , , CC: , , Kathiravan T Subject: [PATCH V3 5/5] arm64: dts: qcom: ipq5332: enable the CPUFreq support Date: Fri, 17 Feb 2023 14:03:08 +0530 Message-ID: <20230217083308.12017-6-quic_kathirav@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230217083308.12017-1-quic_kathirav@quicinc.com> References: <20230217083308.12017-1-quic_kathirav@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: _c5teQD24S1ItNHlzX_7wyyt2WNLF2P5 X-Proofpoint-ORIG-GUID: _c5teQD24S1ItNHlzX_7wyyt2WNLF2P5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-17_04,2023-02-16_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 phishscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 impostorscore=0 mlxlogscore=935 spamscore=0 mlxscore=0 lowpriorityscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302170076 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758066747291780283?= X-GMAIL-MSGID: =?utf-8?q?1758066747291780283?= Add the APCS, A53 PLL, cpu-opp-table nodes to bump the CPU frequency above 800MHz. Signed-off-by: Kathiravan T --- Changes in V3: - Sort the opp-table-cpu node Changes in V2: - No changes arch/arm64/boot/dts/qcom/ipq5332.dtsi | 37 +++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi index a2ed54264d5c..4bf8c01721d6 100644 --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi @@ -5,6 +5,7 @@ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved. */ +#include #include #include @@ -35,6 +36,8 @@ reg = <0x0>; enable-method = "psci"; next-level-cache = <&L2_0>; + clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>; + operating-points-v2 = <&cpu_opp_table>; }; CPU1: cpu@1 { @@ -43,6 +46,8 @@ reg = <0x1>; enable-method = "psci"; next-level-cache = <&L2_0>; + clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>; + operating-points-v2 = <&cpu_opp_table>; }; CPU2: cpu@2 { @@ -51,6 +56,8 @@ reg = <0x2>; enable-method = "psci"; next-level-cache = <&L2_0>; + clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>; + operating-points-v2 = <&cpu_opp_table>; }; CPU3: cpu@3 { @@ -59,6 +66,8 @@ reg = <0x3>; enable-method = "psci"; next-level-cache = <&L2_0>; + clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>; + operating-points-v2 = <&cpu_opp_table>; }; L2_0: l2-cache { @@ -79,6 +88,16 @@ reg = <0x0 0x40000000 0x0 0x0>; }; + cpu_opp_table: opp-table-cpu { + compatible = "operating-points-v2"; + opp-shared; + + opp-1488000000 { + opp-hz = /bits/ 64 <1488000000>; + clock-latency-ns = <200000>; + }; + }; + pmu { compatible = "arm,cortex-a53-pmu"; interrupts = ; @@ -194,6 +213,24 @@ }; }; + apcs_glb: mailbox@b111000 { + compatible = "qcom,ipq5332-apcs-apps-global", + "qcom,ipq6018-apcs-apps-global"; + reg = <0x0b111000 0x1000>; + #clock-cells = <1>; + clocks = <&a53pll>, <&xo_board>; + clock-names = "pll", "xo"; + #mbox-cells = <1>; + }; + + a53pll: clock@b116000 { + compatible = "qcom,ipq5332-a53pll"; + reg = <0x0b116000 0x40>; + #clock-cells = <0>; + clocks = <&xo_board>; + clock-names = "xo"; + }; + timer@b120000 { compatible = "arm,armv7-timer-mem"; reg = <0x0b120000 0x1000>;