From patchwork Thu Feb 16 22:31:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aidan MacDonald X-Patchwork-Id: 58272 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp564427wrn; Thu, 16 Feb 2023 14:36:35 -0800 (PST) X-Google-Smtp-Source: AK7set+eiDAV3XsOSkDz9q0TlKMIlACV7ColzlIhKocL3DoPXbjzKm8UABw3T+9khM4eksv6o0rG X-Received: by 2002:a05:6a20:1e62:b0:c7:6c6f:7722 with SMTP id cy34-20020a056a201e6200b000c76c6f7722mr605604pzb.7.1676586995652; Thu, 16 Feb 2023 14:36:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676586995; cv=none; d=google.com; s=arc-20160816; b=IqMcxVDj/B8smBVOSzJf0OWF2LjP0Y3oEB0YGYIgixwgfkM3glg2VcvV8gDhDBLV7h mFXYdEnmC3rIEogMJ9/ylqe5MudoyY6O8v6P2KNdUGAB6HCUqTp/rinMJG3D2fVzvU7e WkoiX2sGKFk8K8h1jOZudv1Q9X0dMIl2ZbWY+8G4sjTHdjim4H04RzHGtgr6Lmr9f+o8 WKe9yHij9RRPnieccfowvhUzDIbM9rs53r34Q82ceQyRS52ZM8GGQ/nSL3WhVFUCkWIj 6X1ZZ3MwooSE+pvyYaq1DEmE/q9pn5F7GAFGB7jt14XlsT7x8UIsXL2hQYobw3Q74Jpy MhRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=f5vXNR+H0c80bTIPdRkMX1RbvYvrD4ce9/JGf1xe3NU=; b=at2JVlDM7Vm9HqBR7acNN6M9c8aFcRWZa9N/42nt1CitaJujhAMgDhhiy5hTNt4tQU 4zXTmJp3Aa16lsgdU+nep0DIn9P0h44T7L4EMEeJjkQ6WlRi9SPBK+ipRRD//MpyNqvq JSZaa5oFrOF8VPOEECt6dsbPrkjGZNA6dLMOuukZFOLHMyGnT8cP3HMt8F4UHyZX5y7s cntE8ql8BbZTTrVlQlPMXQAiaaD/NTVzezbEYdQk1Acp92DVGiI9vNOVlUyUlnLvV2b7 3Xos6CMh42LjSUUzOj1nCUStF6la+pZzqBs3XSxl+nz83nlr54kUMJUORs1xCLgip1gL YBKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=k61SMX1K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v185-20020a6389c2000000b0049b37046fbcsi2872559pgd.391.2023.02.16.14.36.22; Thu, 16 Feb 2023 14:36:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=k61SMX1K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229854AbjBPWcZ (ORCPT + 99 others); Thu, 16 Feb 2023 17:32:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbjBPWcX (ORCPT ); Thu, 16 Feb 2023 17:32:23 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 651AA4C3FA for ; Thu, 16 Feb 2023 14:32:12 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id m20-20020a05600c3b1400b003e1e754657aso5417202wms.2 for ; Thu, 16 Feb 2023 14:32:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=f5vXNR+H0c80bTIPdRkMX1RbvYvrD4ce9/JGf1xe3NU=; b=k61SMX1KONa9iIwehIQCaziylg3pU9/0NrlOH9Hn+OQjDN6wbgXkM9RHYX+r7+lAuu jzbuPTNK3M1N0Mfo+tF9uRANQzUn0/Xrg/ZLfBvQSxV8+UYN8Gp00TGUCcohgzIF0vSC K0c790y0PII1LJ+rOuYrg5NSkGlyCJ0I9lhbnkKV1dYzsNi2T11orf7ZW9Wjkgh0+axh QMTI99YrfV/oYznnM1UnHvo6ERVyd088YMzgY6DMRxt5dKbz+m4feKuOjcsNMRM08GBN ys0kI7EP/NtksrCM1J/xa8vzp7W8qdToxAKrqfm41cFFbQO2tSpnksTHYIX7OFuaFSyB qzSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f5vXNR+H0c80bTIPdRkMX1RbvYvrD4ce9/JGf1xe3NU=; b=vNkG3Ei7PLCyyU+YEGMcLuzTaYTgqEl0lbA8y1khj72/x38lZdzvMAtoo/me+s85k2 NDuP/WzbnTFMDrbt7hQYCVn60UthGybbKTZHaNqEA0/YPoMCH1zoCJ4xguY0Vk7D4E3M YVB/dHonMJT59bHVlpPlj4EXvVt6ZjBsnlZOvSgUu35giM9Mi47pnKkBfOj/s2HWCxrl YbtSU5b1XqrORezI1nyQb4sIIrJdVdi54L/HjbmBz86vCseFbPiKRWrM2xm/sQwwJOGo AEeIawNSZ849VYRp7fcbCNkALFSBLmpsspxlRfql61nrQqSfivmnsSPEGC2nLfrSi/F2 nv5A== X-Gm-Message-State: AO0yUKXa4xlXbRcpC4AHpRhDAJiZqBJQI+lJCHbCJMfJ6LSSN2ex6VDz 0VRPs4QpQ2uQXZV8PvAYk/JHXh78mnE= X-Received: by 2002:a05:600c:816:b0:3dc:5390:6499 with SMTP id k22-20020a05600c081600b003dc53906499mr6517227wmp.1.1676586730839; Thu, 16 Feb 2023 14:32:10 -0800 (PST) Received: from localhost (94.197.187.145.threembb.co.uk. [94.197.187.145]) by smtp.gmail.com with ESMTPSA id bg30-20020a05600c3c9e00b003db012d49b7sm14516056wmb.2.2023.02.16.14.32.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 14:32:10 -0800 (PST) From: Aidan MacDonald To: broonie@kernel.org Cc: gregkh@linuxfoundation.org, rafael@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 1/2] regmap-irq: Remove unused type_invert flag Date: Thu, 16 Feb 2023 22:31:59 +0000 Message-Id: <20230216223200.150679-1-aidanmacdonald.0x0@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758028885125989426?= X-GMAIL-MSGID: =?utf-8?q?1758028885125989426?= type_invert is deprecated and no longer used; it can now be removed. Signed-off-by: Aidan MacDonald --- drivers/base/regmap/regmap-irq.c | 11 ++--------- include/linux/regmap.h | 3 --- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c index a8f185430a07..e3092f522107 100644 --- a/drivers/base/regmap/regmap-irq.c +++ b/drivers/base/regmap/regmap-irq.c @@ -189,12 +189,8 @@ static void regmap_irq_sync_unlock(struct irq_data *data) if (!d->type_buf_def[i]) continue; reg = d->get_irq_reg(d, d->chip->type_base, i); - if (d->chip->type_invert) - ret = regmap_update_bits(d->map, reg, - d->type_buf_def[i], ~d->type_buf[i]); - else - ret = regmap_update_bits(d->map, reg, - d->type_buf_def[i], d->type_buf[i]); + ret = regmap_update_bits(d->map, reg, + d->type_buf_def[i], d->type_buf[i]); if (ret != 0) dev_err(d->map->dev, "Failed to sync type in %x\n", reg); @@ -1028,9 +1024,6 @@ int regmap_add_irq_chip_fwnode(struct fwnode_handle *fwnode, ret = regmap_read(map, reg, &d->type_buf_def[i]); - if (d->chip->type_invert) - d->type_buf_def[i] = ~d->type_buf_def[i]; - if (ret) { dev_err(map->dev, "Failed to get type defaults at 0x%x: %d\n", reg, ret); diff --git a/include/linux/regmap.h b/include/linux/regmap.h index a3bc695bcca0..2114679729ce 100644 --- a/include/linux/regmap.h +++ b/include/linux/regmap.h @@ -1547,8 +1547,6 @@ struct regmap_irq_chip_data; * @ack_invert: Inverted ack register: cleared bits for ack. * @clear_ack: Use this to set 1 and 0 or vice-versa to clear interrupts. * @wake_invert: Inverted wake register: cleared bits are wake enabled. - * @type_invert: Invert the type flags. Deprecated, use config registers - * instead. * @type_in_mask: Use the mask registers for controlling irq type. Use this if * the hardware provides separate bits for rising/falling edge * or low/high level interrupts and they should be combined into @@ -1625,7 +1623,6 @@ struct regmap_irq_chip { unsigned int clear_ack:1; unsigned int wake_invert:1; unsigned int runtime_pm:1; - unsigned int type_invert:1; unsigned int type_in_mask:1; unsigned int clear_on_unmask:1; unsigned int not_fixed_stride:1; From patchwork Thu Feb 16 22:32:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aidan MacDonald X-Patchwork-Id: 58273 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp564809wrn; Thu, 16 Feb 2023 14:37:35 -0800 (PST) X-Google-Smtp-Source: AK7set/qksa3d5b9OGP327ZfEv+CHWpNy4P/QthjHZUCnJmCvQHklRGJBNv0eGs+6FHFY6eVRSeD X-Received: by 2002:a05:6402:328:b0:4aa:a4e9:fa28 with SMTP id q8-20020a056402032800b004aaa4e9fa28mr7053021edw.34.1676587055743; Thu, 16 Feb 2023 14:37:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676587055; cv=none; d=google.com; s=arc-20160816; b=C2Vr8ucxXSLjkzfGkXLQ46t+YuUMXWyF3jyC/0YazcooqmxnQ63yRGMGux2MJTGefd satTxuDBKwFCKRx4+Cst46/gWqi0SXK2CrTVeejQ7P5Cn1N5xlCbESoQ29/LmdhmD1v6 0NYHLAQ9hz7vMXEzZ6k7iD6+WejYnnzjqwZIbJSZdmmLrHjq5j3vhAAT3IkhyQAgRk9L EOee9vCdFzMAjYAGwr/cHye7D7pf1DEoOZzbfhNti6TWCEQMlhmBReW9UUMAMQ47pfve vYkx0hMrhxHvyaebYe8cuyM5pBHpQfLtBgMid7hiRMA/qyY7xcAXPhm8b3xYpVDVeZlC OGow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=GvzIXeBwNjkQ9IcRgD+ojwStnjrbesfxRf+gfVkqoyc=; b=OOeBjzRypHjSadjsKSZcabDSos08MWX7MnjEqIeRsH2iMmWcmEE4pzIB9pzSlt6TAu NkBLI0otI1GjVU8kIntPwNUewj0UeRZd39OAYi/f85rQTAK+F9TNPutO7qKfOs+Jpd5r d321+llHRuv4koq/DHwO+EwmwdyrywJ4e59mu0XPmegl4EPPZDholqxQRmbWzwoVzLDC 6vp44pUcdjvqVTfFb5iBtpLX9ZFr3Fx8AP7Kd6BeVINDuipEetG7J6vIBcAWEYsDJxdN /f+GgT5OBj1E5TSSQ0HxWjFcvkZ5gNa46JFpb6mbMPt6V2nhLlWbphXNNcveCILaLOmk lajw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=VYSoiJSa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n8-20020a05640206c800b004accac1c5d1si3004174edy.566.2023.02.16.14.36.56; Thu, 16 Feb 2023 14:37:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=VYSoiJSa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230092AbjBPWc2 (ORCPT + 99 others); Thu, 16 Feb 2023 17:32:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbjBPWcX (ORCPT ); Thu, 16 Feb 2023 17:32:23 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 897F748E1B for ; Thu, 16 Feb 2023 14:32:13 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id r25so236732wrr.5 for ; Thu, 16 Feb 2023 14:32:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GvzIXeBwNjkQ9IcRgD+ojwStnjrbesfxRf+gfVkqoyc=; b=VYSoiJSayRXtEYIfR8Hy8SoP+yEE+4aPstU32fxzv5Uv2KYLidAt0mnkgq9qRjhFQH N+qYUmdwHlx+cytXSNZOXd+1lhJMUx/5geurMPuUXks4mg2wVSntprJhdqMe/AQhge68 I3EImvVp+OZO5QFx0cMQuV7OSMZs2EkxYRJNNJJu9WSIc9Dtve/SCyEQN0vScAJ13EPV LVQ/8Vcnwvu2PrK5N6twcb83zE14eUX9LKpqtwEOoRYLozYJ05+Xu3UvogLMhy/k4cNu VILMMrlcZcnM321b/XzFiShTZlteeHKs0K/4Gve3/xwlAWNt6CwfJDDCkZt18GQTJ8/C kbXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GvzIXeBwNjkQ9IcRgD+ojwStnjrbesfxRf+gfVkqoyc=; b=0alU1GKdhZEDN/ELnPG2drz90GWWy34jkxw/jejYfzSzY5iFjBrafIrZnyfiRcqGvr +/V9EGNke25V8I64DJE8aHurXlNeB6YduWojXIFenGy7Yl3QJOu4F2TaVoCoAr+WWibi f1MJ88ylMD3VkaDjH9oZ6nJWEEgkkuAGfgR+VqEhFpCxPtW33fSfukAuf2qiga5x25FK 9yLtWGeEVVMzboEuTH3nz2wOYqm5hIyxM7DB9Hdl5sQT6e1kBrxS1NZvFe1P+SSxAU7P dm4FckgvrYRTlOyB98n+YG3udVSEYWxGPNHssi1cXmFoNX6EMI6AH4hlbJ5AfZZfbl0r xTVA== X-Gm-Message-State: AO0yUKVUNrOSZrVdn9uGsGvmLTAJXjbUkNnCBFLluLfh7c6HUN+Oxz9Z aN/RCAAnU57UeuSrjltPIXsvyiMhrzI= X-Received: by 2002:a5d:5502:0:b0:2c3:db4f:f336 with SMTP id b2-20020a5d5502000000b002c3db4ff336mr5456407wrv.39.1676586731996; Thu, 16 Feb 2023 14:32:11 -0800 (PST) Received: from localhost (94.197.187.145.threembb.co.uk. [94.197.187.145]) by smtp.gmail.com with ESMTPSA id k8-20020a5d4288000000b002c559843748sm2600774wrq.10.2023.02.16.14.32.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 14:32:11 -0800 (PST) From: Aidan MacDonald To: broonie@kernel.org Cc: gregkh@linuxfoundation.org, rafael@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 2/2] regmap-irq: Remove unused mask_invert flag Date: Thu, 16 Feb 2023 22:32:00 +0000 Message-Id: <20230216223200.150679-2-aidanmacdonald.0x0@gmail.com> In-Reply-To: <20230216223200.150679-1-aidanmacdonald.0x0@gmail.com> References: <20230216223200.150679-1-aidanmacdonald.0x0@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758028948961746855?= X-GMAIL-MSGID: =?utf-8?q?1758028948961746855?= mask_invert is deprecated and no longer used; it can now be removed. Signed-off-by: Aidan MacDonald --- drivers/base/regmap/regmap-irq.c | 14 -------------- include/linux/regmap.h | 4 ---- 2 files changed, 18 deletions(-) diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c index e3092f522107..8c903b8c9714 100644 --- a/drivers/base/regmap/regmap-irq.c +++ b/drivers/base/regmap/regmap-irq.c @@ -878,20 +878,6 @@ int regmap_add_irq_chip_fwnode(struct fwnode_handle *fwnode, */ dev_warn(map->dev, "mask_base and unmask_base are inverted, please fix it"); - /* Might as well warn about mask_invert while we're at it... */ - if (chip->mask_invert) - dev_warn(map->dev, "mask_invert=true ignored"); - - d->mask_base = chip->unmask_base; - d->unmask_base = chip->mask_base; - } else if (chip->mask_invert) { - /* - * Swap the roles of mask_base and unmask_base if the bits are - * inverted. This is deprecated, drivers should use unmask_base - * directly. - */ - dev_warn(map->dev, "mask_invert=true is deprecated; please switch to unmask_base"); - d->mask_base = chip->unmask_base; d->unmask_base = chip->mask_base; } else { diff --git a/include/linux/regmap.h b/include/linux/regmap.h index 2114679729ce..4b9ec1eb5235 100644 --- a/include/linux/regmap.h +++ b/include/linux/regmap.h @@ -1532,9 +1532,6 @@ struct regmap_irq_chip_data; * @config_base: Base address for IRQ type config regs. If null unsupported. * @irq_reg_stride: Stride to use for chips where registers are not contiguous. * @init_ack_masked: Ack all masked interrupts once during initalization. - * @mask_invert: Inverted mask register: cleared bits are masked out. - * Deprecated; prefer describing an inverted mask register as - * an unmask register. * @mask_unmask_non_inverted: Controls mask bit inversion for chips that set * both @mask_base and @unmask_base. If false, mask and unmask bits are * inverted (which is deprecated behavior); if true, bits will not be @@ -1616,7 +1613,6 @@ struct regmap_irq_chip { const unsigned int *config_base; unsigned int irq_reg_stride; unsigned int init_ack_masked:1; - unsigned int mask_invert:1; unsigned int mask_unmask_non_inverted:1; unsigned int use_ack:1; unsigned int ack_invert:1;