From patchwork Thu Feb 16 22:00:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 58259 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp550097wrn; Thu, 16 Feb 2023 14:00:43 -0800 (PST) X-Google-Smtp-Source: AK7set8eucAKJhRLPd64DGq/GTJKJ6vAtf2YupkWWuFi1WAGLGJxXHU2+bW99i04BB29+GiZPzB6 X-Received: by 2002:a17:906:115a:b0:8b1:7fe8:1c38 with SMTP id i26-20020a170906115a00b008b17fe81c38mr758910eja.43.1676584843426; Thu, 16 Feb 2023 14:00:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676584843; cv=none; d=google.com; s=arc-20160816; b=ONfDtpoE7Jvepln5kBRY2jQp/lKTYTmrFg9IIfc4sIPN10akjzaouFzGTw4ykxOB96 Lm0x/KDtkI+bi+UHqZXIdsrUdltpelS6ivkpZr4Ehg5H5me1GSHrQmGCXETtFB9eyxXC zGv1V4VeO6N6Wr3OPE+XMzaeSuVsB58tCqLCEbd1HlEM8BAvivVKqseOSk3WXCP0cxLo 6l9BHHe+IK4AZ0fm/dvm82gAjVfoXiseTMyC2WxdaPE+mkYpGBDPlTRnHLbeiV9wWz50 gqoiXoRrJpTl18DTj5PDJWz6zJLSxNbR+Ri+V0MrF/YQpw+/+EphIKxSHDjBSMFgSPYc omRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=Cke/HonRH3WZfcLmQoVn6z4Ldaw0hHOnQK74EOa1lwM=; b=LjwEUJFvIfbVXYeWYIL6vu2uDTbwusCnSbtFz+4Nm6sitVm31mHu6azmsa9GCNlHDL OfDIo4q+T518dAfD37zRkjY70TYcpr7FFtsn7es4aZCv2FfQQd+B2LeQr48Wl5OmzFAG az3EgOwDL6S6PrOiXW1g6XD+IDBHPBWG99n6KSMGNWRbvNWCv33ZJ01/Dnl1IdRsDjhL jK+ZYB4nYJvDC7pyhR0J4XOWSTfL0/e3CMMwNbxCgTcILArsYlLDJGFnCUE3HLCiTff4 Xf4AktJSem7F8PgEPpk3Rrm/yHIow9TJaQXQq9Br5g+JY5v1dasN5ydyLcbT3raF/jBe 1fAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=rwAKwtNe; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id az14-20020a170907904e00b008b152114137si2907828ejc.884.2023.02.16.14.00.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 14:00:43 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=rwAKwtNe; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3DE973857B93 for ; Thu, 16 Feb 2023 22:00:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3DE973857B93 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1676584842; bh=Cke/HonRH3WZfcLmQoVn6z4Ldaw0hHOnQK74EOa1lwM=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=rwAKwtNeAIyGeThvfkD5inn3sBm4MT9o6vxBbO7PPDPQY5840m6u3NLpWKBfW18oy DXj6G+MkLm8BUlkIIju+bexta4SR6CwR+zpIjvXQXZ0t/GNmx1b2JWtZOJ5dUEz5BQ lSw2vIbdb8a8c+fhW8znWJphe5HJyY69wcASHJnI= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id 303C93858D33 for ; Thu, 16 Feb 2023 22:00:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 303C93858D33 Received: by mail-pl1-x634.google.com with SMTP id v23so3607391plo.1 for ; Thu, 16 Feb 2023 14:00:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Cke/HonRH3WZfcLmQoVn6z4Ldaw0hHOnQK74EOa1lwM=; b=K7AX/UITh+4pZY6Kt2OzZQth2PWdLUtHxu7CKhn4XCj6EBjSLEGrmw4TUcHa7brfHc gjRfp9sunO+plMKrQS5VYuzQkYuMoQRBPxMEcw0Ov7DNu0TgOw2Wa/TAAq2XjRp3tC/H 8LAj0BHohskRxnvnxQOABrpyHG03WmFm82TXaWs4q6FXzHFOXl9RJVlCFgNyOhKGt4ms gcIqItJlXsiuqG6qt/FA2vTQUts20cJzHIxeKnV2/y+lwM2oyuQqt34EDa7jJbvMHQIK tlDlIXb9Tdkci6ckbcFSxaGNDZv0YcEHPbw3nylVphcXbL929Q0g4CqVTMltuOLJ0Mrh bwIg== X-Gm-Message-State: AO0yUKWtFbzg7mQHVvaUhGUlEk8UoJWVgpTUwAXVubA7g6pJ2lCHhqiZ DMxDEAWST2kUtvWKrmHlt7UOY5YroAQ= X-Received: by 2002:a17:902:d489:b0:19a:b033:2bb0 with SMTP id c9-20020a170902d48900b0019ab0332bb0mr9539454plg.46.1676584831842; Thu, 16 Feb 2023 14:00:31 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:e39e:7b87:db68:a9f9]) by smtp.gmail.com with ESMTPSA id j4-20020a170902c08400b00189743ed3b6sm1797057pld.64.2023.02.16.14.00.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 14:00:31 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 277181140C4B; Fri, 17 Feb 2023 08:30:29 +1030 (ACDT) Date: Fri, 17 Feb 2023 08:30:29 +1030 To: binutils@sourceware.org Subject: PR30046, power cmpi leads to unknown architecture Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3034.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758026628829172800?= X-GMAIL-MSGID: =?utf-8?q?1758026628829172800?= PowerPC ELF always uses bfd_arch_powerpc, so we shouldn't allow the gas -mpwr, -mpwr2 or -mpwrx options to choose bfd_arch_rs6000. Given the possible values of ppc_cpu, I think the as_fatal at the end of ppc_arch will never be reached, so it can be deleted and the code simplified a little. PR 30046 * config/tc-ppc.c (ppc_arch): Return bfd_arch_powerpc for ELF. Delete dead code. diff --git a/gas/config/tc-ppc.c b/gas/config/tc-ppc.c index 9450fa74de1..a3af5f5e276 100644 --- a/gas/config/tc-ppc.c +++ b/gas/config/tc-ppc.c @@ -1496,9 +1496,11 @@ ppc_set_cpu (void) enum bfd_architecture ppc_arch (void) { - const char *default_cpu = TARGET_CPU; ppc_set_cpu (); +#ifdef OBJ_ELF + return bfd_arch_powerpc; +#else if ((ppc_cpu & PPC_OPCODE_PPC) != 0) return bfd_arch_powerpc; if ((ppc_cpu & PPC_OPCODE_VLE) != 0) @@ -1507,14 +1509,12 @@ ppc_arch (void) return bfd_arch_rs6000; if ((ppc_cpu & (PPC_OPCODE_COMMON | PPC_OPCODE_ANY)) != 0) { - if (strcmp (default_cpu, "rs6000") == 0) - return bfd_arch_rs6000; - else if (startswith (default_cpu, "powerpc")) + const char *default_cpu = TARGET_CPU; + if (startswith (default_cpu, "powerpc")) return bfd_arch_powerpc; } - - as_fatal (_("neither Power nor PowerPC opcodes were selected.")); - return bfd_arch_unknown; + return bfd_arch_rs6000; +#endif } unsigned long