From patchwork Wed Feb 15 17:04:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 57638 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp313767wrn; Wed, 15 Feb 2023 09:18:00 -0800 (PST) X-Google-Smtp-Source: AK7set8zHS4RfRfLnLAqbDFR4UX+dl2r6WLDFbXkeo0mChgjx5p99+Q45JSz5QRnLp2BAiAzhjGq X-Received: by 2002:a17:902:c949:b0:19a:9691:196d with SMTP id i9-20020a170902c94900b0019a9691196dmr3701298pla.29.1676481480391; Wed, 15 Feb 2023 09:18:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676481480; cv=none; d=google.com; s=arc-20160816; b=bupgDWH85KNhY7+G83Te6tkH+h1gva39Txi/itDogO8eQV5vrga7dXG64Jn5uVBJD5 EYLs3JKvNjbzhpu5jOMYjDpRHMIiCx8/p0zeibA2rjVxZd3phhtw0lg0WZc9gpmVN6RF fl4aE+icjxxXAqYnWbp4QkSeaAapxrhJ11Hy+tIIXcYmgiHc5I+0ySrvVMYQ9nu8WXeV bd34kgHKqVgs1MPmtz9ZWA/lCZoItkjK1McKFBee6UmuN5U8LlQKsBuasdKyZrXcxWDy SS7DSgeXOTAaFG5IJt43T6mIAnMbTTwyycVNEdHiYB9LhhCG7mHjE8Iw2U0LasdmgHtt RY6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=5yOu1c57tzGtjqYOCkwFmm0OF/zLpO04fVMqZFHFO3c=; b=qHZxRfewDK+vgc04kaWYxkkdAwDvVDXlC0711RmPkjrV1q+7sRFwiBXyDDODs4qBCm zJblOJz6iAYZwlXuKJ9EhSYoBrB9hE47XOabJNIa3P2mrd2RfGmSZXXsDzhW4LUc3uwa 80eUpb9ZfLgASDdvcSrW3hW52LcIVayfjpQGd/5XTP03sOUBW83mziqKDWY+4LZn9rX5 LSaq788huzebOHxVet9Z0PgaXxuaaLQf4auxjqA10knz8BuVCVSC4pqJXtNpM5EVvmpV qZgIsyk8uxHNKxL4446AU8yWyVeGdibQ0MjEWEhda7Yc/9Un1LqMRnEjW5Dy0G8SPyw0 xZhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Wr3rTZrg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k8-20020a170902c40800b0019a8119053esi1112212plk.327.2023.02.15.09.17.44; Wed, 15 Feb 2023 09:18:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Wr3rTZrg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229991AbjBORFc (ORCPT + 99 others); Wed, 15 Feb 2023 12:05:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229949AbjBORFa (ORCPT ); Wed, 15 Feb 2023 12:05:30 -0500 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43BF23669D; Wed, 15 Feb 2023 09:05:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676480721; x=1708016721; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=EkzFT1Nke/B9I8aR5SnJ8afv1Mh9pNWCQQ/xa3G/7d0=; b=Wr3rTZrgtWAfhc8fKQGgLyULBK9/YwycvUcEcVr2JL9ONLxdBHpoKgWe USUlaEhtjpyw4u0J4OpmvVaiUBulH/C1OxB1RleNn7aPWhJo0pYy5xANk hBx3ProW6Xg/FzReNWh+9X0zzBPP+QE+jgDOQfNlDw0/9TSqF6RkbRha7 UIAJS86O7l0saapAAxrAgKFheAjrAxbYHIZOwCdOo/mS2uTqo0LEUXyRL W4oNGjTxShP8ZmMfmNb7U1/cq4hclNdcw/RYFSsRh3kihkjNbZjlhesja rVhRhgI/++TgAdJ1812pD6vhNZyithFr+GgvkKYTDcimDIiLga3YicWG/ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10622"; a="393886453" X-IronPort-AV: E=Sophos;i="5.97,300,1669104000"; d="scan'208";a="393886453" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2023 09:03:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10622"; a="647262367" X-IronPort-AV: E=Sophos;i="5.97,300,1669104000"; d="scan'208";a="647262367" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga006.jf.intel.com with ESMTP; 15 Feb 2023 09:03:27 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 2070B1A6; Wed, 15 Feb 2023 19:04:07 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Pavel Machek , Lee Jones Subject: [PATCH v1 1/2] leds: lp8860: Remove unused of_gpio,h Date: Wed, 15 Feb 2023 19:04:02 +0200 Message-Id: <20230215170403.84449-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757918245017633011?= X-GMAIL-MSGID: =?utf-8?q?1757918245017633011?= of_gpio.h provides a single function, which is not used in this driver. Remove unused header. Signed-off-by: Andy Shevchenko --- drivers/leds/leds-lp8860.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/leds/leds-lp8860.c b/drivers/leds/leds-lp8860.c index b66ed5ac1aa5..666f4d38214f 100644 --- a/drivers/leds/leds-lp8860.c +++ b/drivers/leds/leds-lp8860.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include From patchwork Wed Feb 15 17:04:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 57636 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp306319wrn; Wed, 15 Feb 2023 09:05:53 -0800 (PST) X-Google-Smtp-Source: AK7set9q6lICF+UZgKqfkFvwqF2Bwts0U7+AIpKCa0fGmiNsEwCDWrHcEC5YfOUY3DDU309efZYq X-Received: by 2002:a17:902:ecd2:b0:19a:73f7:6762 with SMTP id a18-20020a170902ecd200b0019a73f76762mr2961594plh.52.1676480753648; Wed, 15 Feb 2023 09:05:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676480753; cv=none; d=google.com; s=arc-20160816; b=qLcx/Aa1/XrQ6ZCh4h2akFkGCRda8CAtMLc+8h1dwQHBFWYlfIRi1kui224kdK7nGQ dRxlC9vG2fqc0v3mZ49Ijw+4/GMg72u6uCl7M7seK/ePJwrYCQhuuIcHM5AibsueluEO qiZMWoXhdWKq7Xc9IPCtsvt7UUIYqje/xjRrjtjFC++axZwrtUWmqfbHuhRYsriN6dNv +o4Le8PFTBPwua1SxxTj5nIGynlffz+pzTh1bbxiBVmPcP1hVkbNZ7/jyhfJSRtMb04C 1waYD1HZ89h+WjMY6oL5Y3DM6FGVYOMpdC2oZwK1AkGoaR8udaxwCJmG6RjdNPj3OyWW dw5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=e5/9NZuM1+ACC4ocvEZWmMQwq9UXDJyPG7+0qWFYQBw=; b=sEYdFali5YPzjZISpMCCy3hhzelee4MWc36HG4qzTZXWzBv030rPdnTD3OpjBUEgi+ jIZtceiWBFUP3fZ5bLNzmpLVlvVJSXxFaEZjKuDNbQbuInAtTdQWGaWxBzjhMYyA6cyB qISRy/Nh1hp5yl+q9VJvkLhAtduVW3jSi6kqSSC5qGsoNlPER4xfWC8CQjyPZ2Jc8oq1 rovZZ/YN6V5aleVGWTPGAhpxEvvy4dUOSp4w8XQlv5dUXLcBaDkO42SxRN/UcxZQr0S1 ojuWSrqgPesGfrGMmqhW4TXDlOVNpqTJTWt2OmPFYt3G8UtZ0k92hmdduWoZZhecwSj8 7cUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=EJvr2QE4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q16-20020a170902dad000b00194c90ca330si19862698plx.335.2023.02.15.09.05.40; Wed, 15 Feb 2023 09:05:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=EJvr2QE4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229992AbjBORFJ (ORCPT + 99 others); Wed, 15 Feb 2023 12:05:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230005AbjBORFG (ORCPT ); Wed, 15 Feb 2023 12:05:06 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7569859DA; Wed, 15 Feb 2023 09:05:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676480705; x=1708016705; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=rOimDod//OCrW4INcjgAv6xJyq0ZxmoU28TD++6SzWw=; b=EJvr2QE4SDnC0NgYijXHTzKlzyKbs/SfTsWrEFoKNWrk137d4vBImKOl d0sc/Ak0HqmfV/IdAJF/C2lT6yr96Ky4Wj65ERvjIoW8cwzLu75AGPsNq WQEEWeXafpr6K+4f7/peYKTTIjI5JCjCdu8DEX8JU//Th1j+6DSiCcV7W DfoH+c7EXoQnNV0S//jh1fGNIKk1mTScbtQ4JhXmxGo74XIAMZeLtKKBD riwvLllsHsOh+ZJKR8TXqUBBVubiVC/khXGbMpMB0YN6CXZkk4V25HOgr Y8SaOdd2jra6NaOHPTkFFB2UqIZ9W6XklPhn7B1gjDKWEPVcfVflGF91c Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10622"; a="311847975" X-IronPort-AV: E=Sophos;i="5.97,300,1669104000"; d="scan'208";a="311847975" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2023 09:03:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10622"; a="812539731" X-IronPort-AV: E=Sophos;i="5.97,300,1669104000"; d="scan'208";a="812539731" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 15 Feb 2023 09:03:27 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id AFAC91C5; Wed, 15 Feb 2023 19:04:07 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Pavel Machek , Lee Jones Subject: [PATCH v1 2/2] leds: lp8860: Remove duplicate NULL checks Date: Wed, 15 Feb 2023 19:04:03 +0200 Message-Id: <20230215170403.84449-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230215170403.84449-1-andriy.shevchenko@linux.intel.com> References: <20230215170403.84449-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757917482745315580?= X-GMAIL-MSGID: =?utf-8?q?1757917482745315580?= gpiod_*() API check already for the NULL, no need to repeat that in the driver. Signed-off-by: Andy Shevchenko --- drivers/leds/leds-lp8860.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/leds/leds-lp8860.c b/drivers/leds/leds-lp8860.c index 666f4d38214f..221b386443bc 100644 --- a/drivers/leds/leds-lp8860.c +++ b/drivers/leds/leds-lp8860.c @@ -249,8 +249,7 @@ static int lp8860_init(struct lp8860_led *led) } } - if (led->enable_gpio) - gpiod_direction_output(led->enable_gpio, 1); + gpiod_direction_output(led->enable_gpio, 1); ret = lp8860_fault_check(led); if (ret) @@ -293,8 +292,7 @@ static int lp8860_init(struct lp8860_led *led) out: if (ret) - if (led->enable_gpio) - gpiod_direction_output(led->enable_gpio, 0); + gpiod_direction_output(led->enable_gpio, 0); if (led->regulator) { ret = regulator_disable(led->regulator); @@ -448,8 +446,7 @@ static void lp8860_remove(struct i2c_client *client) struct lp8860_led *led = i2c_get_clientdata(client); int ret; - if (led->enable_gpio) - gpiod_direction_output(led->enable_gpio, 0); + gpiod_direction_output(led->enable_gpio, 0); if (led->regulator) { ret = regulator_disable(led->regulator);