From patchwork Wed Feb 15 01:14:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Li X-Patchwork-Id: 57319 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3299065wrn; Tue, 14 Feb 2023 17:21:47 -0800 (PST) X-Google-Smtp-Source: AK7set/8LSIffvPBKKwzStZpNfoyX6LqkZPT0LfRnW2Woz2+Xx/sLcw9n9Xzyi4sgPptxjTk+Qik X-Received: by 2002:a62:18d2:0:b0:5a8:b1b9:8306 with SMTP id 201-20020a6218d2000000b005a8b1b98306mr127854pfy.26.1676424107352; Tue, 14 Feb 2023 17:21:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676424107; cv=none; d=google.com; s=arc-20160816; b=luAgk1+eBXDrv5EW6hG/8rBv3b7aQsRWhyxBoPQBBXZQ53To1Bm0YrPGWJ8IudDz0+ qgRCRBuPkj5oZ/VJ9rK5VeMmBXCNL3Auo6swWOH+9jONfeEaXYJvKhtVxuM2vrKvXUhs qhVYfapHWNThb8vXX30MM69dp8PkjO0myZkcIyqT8OqTOZwUM/bUuOHHsofIgpYSqTHw 4SGuHORfgMTvMSQoq7V53JMt+pvbeWCGF3HAplfm5OdiFG8piFSQdQsmHVe+TXR3Arz0 nMXjlNY0g4RMluTimqc7dw56/cfpKxg/zXRLgczyprFrxk50S+pHF/KcU2+p+YFxhB+H lTaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=H5eGAnWlhK0Lgo5p/2Vgi8vreufDIZg1JOc3Xy0R6sM=; b=kWm1DaFhj0gLf6NDxDJHQhvRyrRIeMbs308+KBrUTIzHBFS/Y5TpD0mPbYqOx1dAX0 Kumyq22y0hFP6ZTT9I0KMTpsKzKbEjwJ7GzIVXHUIdE7SBsR1G4NSXp9i0//UzSDuTIS DLtkpbenguS4AA4500vfJoWY9EkOz0H3uIh+CZLDfEfsZAn7YGSFUHlW/ZOiObbiMZTj mIGS4IAX6xgVrH44ej/uIS04ibGHnOQ+08+EccIwSQKffeh8uD4BRsDSWS34n4FeMZUh ZLbRLHEXDhFyXnezTf6FXlpqjxOTw6yuJaU/rjLY8liCZFF0Yavj3L3agKF/DCiQwui4 KwmQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x6-20020a623106000000b0058bb0834688si9603140pfx.157.2023.02.14.17.21.34; Tue, 14 Feb 2023 17:21:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233263AbjBOBP5 (ORCPT + 99 others); Tue, 14 Feb 2023 20:15:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233278AbjBOBPx (ORCPT ); Tue, 14 Feb 2023 20:15:53 -0500 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 521A6F763; Tue, 14 Feb 2023 17:15:20 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R921e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0VbhhwbR_1676423695; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0VbhhwbR_1676423695) by smtp.aliyun-inc.com; Wed, 15 Feb 2023 09:14:56 +0800 From: Yang Li To: kuba@kernel.org Cc: davem@davemloft.net, kvalo@kernel.org, edumazet@google.com, pabeni@redhat.com, ath12k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: [PATCH -next] wifi: ath12k: dp_mon: Fix unsigned comparison with less than zero Date: Wed, 15 Feb 2023 09:14:53 +0800 Message-Id: <20230215011453.73466-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757858084726129635?= X-GMAIL-MSGID: =?utf-8?q?1757858084726129635?= The return value from the call to idr_alloc() is int. However, the return value is being assigned to an unsigned int variable 'buf_id', so making 'buf_id' an int. Eliminate the following warning: ./drivers/net/wireless/ath/ath12k/dp_mon.c:1300:15-21: WARNING: Unsigned expression compared with zero: buf_id < 0 Reported-by: Abaci Robot Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4060 Signed-off-by: Yang Li --- drivers/net/wireless/ath/ath12k/dp_mon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath12k/dp_mon.c b/drivers/net/wireless/ath/ath12k/dp_mon.c index a214797c96a2..8b3f0769dd58 100644 --- a/drivers/net/wireless/ath/ath12k/dp_mon.c +++ b/drivers/net/wireless/ath/ath12k/dp_mon.c @@ -1268,7 +1268,8 @@ int ath12k_dp_mon_buf_replenish(struct ath12k_base *ab, struct sk_buff *skb; struct hal_srng *srng; dma_addr_t paddr; - u32 cookie, buf_id; + u32 cookie; + int buf_id; srng = &ab->hal.srng_list[buf_ring->refill_buf_ring.ring_id]; spin_lock_bh(&srng->lock);