From patchwork Tue Feb 14 14:41:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 57061 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3019820wrn; Tue, 14 Feb 2023 06:54:22 -0800 (PST) X-Google-Smtp-Source: AK7set/tIJ/H9ZpMBancWaRDqETXTlEcnGoAEvj7KjJ3jmPyQuPdCpjXwkIVRyE0ndik0KcAPnTi X-Received: by 2002:a05:6a20:1453:b0:c0:c938:8c31 with SMTP id a19-20020a056a20145300b000c0c9388c31mr2555971pzi.14.1676386461950; Tue, 14 Feb 2023 06:54:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676386461; cv=none; d=google.com; s=arc-20160816; b=hGTOgcXAeZT4Qaa3XSZB6ppR4ZB+S0LFFkuFN0ag+iLVgP3AcvVEM3+DbQYqamfJnU lXXD/YzsZ88OlzFdxXgMLS3VCMdSSrzaqPFq/E/JBLlzVfriTw8bbwEogh02b9d25XXV KjHyqAL91oRE34QbfLEbSHuwJsaWAx4wJ9pGz9PUF/rmi7j7T0PH+iipOwFkukhYjMZr Io2gE1xyItFiBhzEF5EvnuV1IoC/I4KRNZ24b/mwxx3BWbzaszNor/en7dMncEbOyLuv g6tA48llWCD6k/kzu26iu7D+0s+91MTIOuKBfakGjf01BMr4eyZHzv6LutdX7UHSgxl8 Yzjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=DGcDso1CCEc5Nc0HhtN4IZhLX6GV6RM4LTYXIf/7Xjo=; b=f3nLF9Zt3LnRvuLmh+wWdDTbqQv+r3HFV84fmUKZudmGhSGf5PGwrap9dB4qqcqMAk 9CjjlmvDF1gfQpAbcnxFgE6UiYYFpsOAvcIoY9nES5ZDdtsBKG5RpYVyr9VIw3/1poVp rMHBw3fwet4PG8UBjCLLBl+fNnfI/chMr+gGBN9ul4t3hswRr4ISlrj1oUOnEyI3eyRG O7TumvtlArFRcE486EpL/5Gki6jnTHQL9jwLuLCEI52NQCsGslaf4QO4DuMTfIbVFq5q 4ngZg0tX/quzbK2bRNN8q7zTyWwnSBkwfofL4obgRD1Of4PmdSB7Q29Eb7Yc8ILQem/Q j+oQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=v+fbA+4J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s9-20020a63b409000000b004e0d688fb83si12913014pgf.824.2023.02.14.06.54.08; Tue, 14 Feb 2023 06:54:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=v+fbA+4J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233142AbjBNOlZ (ORCPT + 99 others); Tue, 14 Feb 2023 09:41:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232803AbjBNOlY (ORCPT ); Tue, 14 Feb 2023 09:41:24 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD17222782 for ; Tue, 14 Feb 2023 06:41:23 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 78F62B81D57 for ; Tue, 14 Feb 2023 14:41:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F5D7C433D2; Tue, 14 Feb 2023 14:41:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1676385681; bh=lbbg43PStKyBji25cugZl7z2Wo+JqNKTmI03zrJYDYo=; h=From:To:Cc:Subject:Date:From; b=v+fbA+4JWP8YhvkxgOhYdNWHqEe0KLqbNIaixMIK+kYyIvcUBVtrzp6UYUU1xjch5 +ydGZSeXdUH+qY9Vj7Kxoks/PvnmmlLfQyg1rpWtuStVMnJbMcc+spT3KSIrPkvVII SNvdGF1CSVEEh9UVG4FzLhxeQ+sfUBjalbMtQpEA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" Subject: [PATCH] driver core: class: move EXPORT_SYMBOL_GPL() lines to the correct place Date: Tue, 14 Feb 2023 15:41:17 +0100 Message-Id: <20230214144117.158956-1-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2459; i=gregkh@linuxfoundation.org; h=from:subject; bh=lbbg43PStKyBji25cugZl7z2Wo+JqNKTmI03zrJYDYo=; b=owGbwMvMwCRo6H6F97bub03G02pJDMmv53bfLloTd0vgqdmB59k3A3WmXNO5vHDt2SkLtyRG3OnX jE292hHLwiDIxCArpsjyZRvP0f0VhxS9DG1Pw8xhZQIZwsDFKQATuWPKsGB35vqbqSvaNmmvluHWuD dj3S+2w1cZ5jvdVbG+HmWx51sDD9fG1uqH/K8yQwE= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757818493145883367?= X-GMAIL-MSGID: =?utf-8?q?1757818610561099133?= For some reason, the drivers/base/class.c file still had the "old style" of exports, at the end of the file. Move the exports to the proper location, right after the function, to be correct. Cc: "Rafael J. Wysocki" Signed-off-by: Greg Kroah-Hartman Reviewed-by: Rafael J. Wysocki --- drivers/base/class.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/base/class.c b/drivers/base/class.c index 89d4528fcc1a..2373b3e210d8 100644 --- a/drivers/base/class.c +++ b/drivers/base/class.c @@ -99,6 +99,7 @@ int class_create_file_ns(struct class *cls, const struct class_attribute *attr, error = -EINVAL; return error; } +EXPORT_SYMBOL_GPL(class_create_file_ns); void class_remove_file_ns(struct class *cls, const struct class_attribute *attr, const void *ns) @@ -106,6 +107,7 @@ void class_remove_file_ns(struct class *cls, const struct class_attribute *attr, if (cls) sysfs_remove_file_ns(&cls->p->subsys.kobj, &attr->attr, ns); } +EXPORT_SYMBOL_GPL(class_remove_file_ns); static struct class *class_get(struct class *cls) { @@ -213,6 +215,7 @@ void class_unregister(struct class *cls) class_remove_groups(cls, cls->class_groups); kset_unregister(&cls->p->subsys); } +EXPORT_SYMBOL_GPL(class_unregister); static void class_create_release(struct class *cls) { @@ -276,6 +279,7 @@ void class_destroy(struct class *cls) class_unregister(cls); } +EXPORT_SYMBOL_GPL(class_destroy); /** * class_dev_iter_init - initialize class device iterator @@ -460,6 +464,7 @@ int class_interface_register(struct class_interface *class_intf) return 0; } +EXPORT_SYMBOL_GPL(class_interface_register); void class_interface_unregister(struct class_interface *class_intf) { @@ -482,6 +487,7 @@ void class_interface_unregister(struct class_interface *class_intf) class_put(parent); } +EXPORT_SYMBOL_GPL(class_interface_unregister); ssize_t show_class_attr_string(struct class *class, struct class_attribute *attr, char *buf) @@ -588,11 +594,3 @@ int __init classes_init(void) return -ENOMEM; return 0; } - -EXPORT_SYMBOL_GPL(class_create_file_ns); -EXPORT_SYMBOL_GPL(class_remove_file_ns); -EXPORT_SYMBOL_GPL(class_unregister); -EXPORT_SYMBOL_GPL(class_destroy); - -EXPORT_SYMBOL_GPL(class_interface_register); -EXPORT_SYMBOL_GPL(class_interface_unregister);