From patchwork Tue Feb 14 00:57:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 56603 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2682714wrn; Mon, 13 Feb 2023 17:14:05 -0800 (PST) X-Google-Smtp-Source: AK7set81aSk0M4ogqu0BmJ4WvVwX4NaF56RHH6iYs6nkvTY2OGaBCNLq3gOIqNRegb5Hj3LnxkZu X-Received: by 2002:a17:90b:1c06:b0:232:db7b:5698 with SMTP id oc6-20020a17090b1c0600b00232db7b5698mr567325pjb.15.1676337245582; Mon, 13 Feb 2023 17:14:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676337245; cv=none; d=google.com; s=arc-20160816; b=aFZFm+gPQCFLW+S4TeR+yQ0rWLe9NUl8a91oDNHZryoGGESh/UiOmc96p6VuJKZbUr mBsTfq6ppnCpO9UHMMm3ySr4vJz3X8snqaBaS3J4lmzuTprgq7tYOnucrW6sszixs7zS cDEcRXdZs70hvpebcrOUz86Zd3+vEr4sjik434I3cHeEaqQTdgRUx1MlXC/MlK7U+cUx Xtp5RvC2g/LAEmVJZ2iBzQodJezLHyaJscaHRhOTihY4/J+OZhOblafhHepD7Lu1TBcJ v9pArejHnYz/vKSVL7dWsKT7gqWP32xbd8cVH8tJzcw7OlpQcIK6Lvm11ckIKSooKJri JVDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=jhxllVnbI2AwFWPN2tKYS/gPDBTeZyTnINmF5vnAF9s=; b=VXetJelda/MaGnFWj7LekTj3AMPuf7ublR9WJExxDXsAWYywKpyI0ZbaVhtubN9Uvv Wt8Blvr8v+Y4Hq89DX3gMrR7zqUXhpl1iwC38m6H+2mtuIv5TiqaereFTDrp23wB+b1w /XXJ8ckURrDZ4TE+IbRIc3ydFssbXmX0wW4n0tptJ3AMlt39hEEFhmGKtBPz7UvP1bTR x5LZI05IR7YH8cD+bzEOC9RWrR2Yu/s/OUtNhNnGAcbvsAjACXxGmH9f9qo0HA2wSrdX vRSCv0WLR3LBj5yUvnZuQM7kJFp1lnMqN0aADKB9uEqviCYubadsckGZvAI++88YxMjk zj4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=jiksO25M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i2-20020a636d02000000b004fb878e0fbbsi7142875pgc.639.2023.02.13.17.13.52; Mon, 13 Feb 2023 17:14:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=jiksO25M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230098AbjBNBAf (ORCPT + 99 others); Mon, 13 Feb 2023 20:00:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229539AbjBNBAd (ORCPT ); Mon, 13 Feb 2023 20:00:33 -0500 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E77614226 for ; Mon, 13 Feb 2023 17:00:32 -0800 (PST) Received: by mail-pf1-x430.google.com with SMTP id n2so9159713pfo.3 for ; Mon, 13 Feb 2023 17:00:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jhxllVnbI2AwFWPN2tKYS/gPDBTeZyTnINmF5vnAF9s=; b=jiksO25M1xbJMh+TgDf925qz1OI33yVXPFpT+lYue4N/aK/2EjPChZIbJ4iopZfMH9 qL3CQlp3Q9OGs9elRk+awGd4bmSX4oldimJ+cw6T7pzAirT+A7PkIorWfcbglVMNxmcY x/zEMdVvjkjXDnoH1Sfjv0OboADk5n9MAOyyI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jhxllVnbI2AwFWPN2tKYS/gPDBTeZyTnINmF5vnAF9s=; b=7P2dlBAXmCkY6zoAHzWcNf/+VSEwOleHab418uxI7nbx2n3hzgBdwHNSLGVgLPzX7U QfOkg11Qmc5hvTYoMvJJNaWCHpe1uq7ft1zf82Q18mK6xDT5CurrOPlTROhsurxXNf6t h7q/rc/ZE4DFY5TI1qlCjG9X6gdPINjYuoTHP68Y/k7pOWP1/0l9dw9X7TC3JBOYWu3N xnVPNJKWIe5xT+/mswlnyNTSEvfLbno+3E0chplSLuNQqO9Yuw/pf5bDSWA3xwMB4Mip nM2G3CPaDtoJq3Y5dwYabEKC3sN6jGq/g3H02q7RDz37Crvei7iMeQ5H+4BCzxwH3YYj S+8g== X-Gm-Message-State: AO0yUKXnvFYkVMppjiX7MzJfn110iyeZsxy7cdE947m96Lqm2fq+d7i5 k4iO7yn4IwL9JA51DnfvMFQUuA== X-Received: by 2002:a62:17d2:0:b0:5a8:49c8:8533 with SMTP id 201-20020a6217d2000000b005a849c88533mr397121pfx.8.1676336432029; Mon, 13 Feb 2023 17:00:32 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:af55:a232:a032:95ff]) by smtp.gmail.com with ESMTPSA id e22-20020aa78256000000b00592626fe48csm8482914pfn.122.2023.02.13.17.00.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 17:00:31 -0800 (PST) From: Douglas Anderson To: Bjorn Andersson Cc: amstan@chromium.org, swboyd@chromium.org, mka@chromium.org, Douglas Anderson , Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , Rob Clark , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] arm64: dts: qcom: sc7180: Fix trogdor qspi pull direction Date: Mon, 13 Feb 2023 16:57:51 -0800 Message-Id: <20230213165743.1.I6f03f86546e6ce9abb1d24fd9ece663c3a5b950c@changeid> X-Mailer: git-send-email 2.39.1.581.gbfd45094c4-goog MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757767003241539021?= X-GMAIL-MSGID: =?utf-8?q?1757767003241539021?= Though it shouldn't matter very much, we've decided that it's slightly better to park the qspi lines for trogdor with an internal pulldown instead of an internal pullup. There was a footnote that Cr50 (which connects to these lines too) may have pulldowns configured on one of the data lines and we don't want to have fighting pulls. This also means that if the pulls somehow get left powered in S3 (which I'm uncertain about) that they won't be pulling up lines on an unpowered SPI part. Originally the pullup was picked because SPI transfers are active low and thus the high state is somewhat more "idle", but that really isn't that important because the chip select won't be asserted when the bus is idle. The chip select has a nice external pullup on it that's powered by the same power rail as the SPI flash. This shouldn't have any functionality impact w/ reading/writing the SPI since the lines are always push-pull when SPI transfers are actually taking place. Fixes: 7ec3e67307f8 ("arm64: dts: qcom: sc7180-trogdor: add initial trogdor and lazor dt") Signed-off-by: Douglas Anderson --- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index 423630c4d02c..de40abcd18db 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -1054,7 +1054,7 @@ &qspi_clk { &qspi_data01 { /* High-Z when no transfers; nice to park the lines */ - bias-pull-up; + bias-pull-down; }; &qup_i2c2_default { From patchwork Tue Feb 14 00:57:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 56602 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2681892wrn; Mon, 13 Feb 2023 17:12:05 -0800 (PST) X-Google-Smtp-Source: AK7set+1b7tneX0VuJprNgi9bnmlUqTHeBuJCL4WkeAIIhosMUsMAYOO80WNmfSwGpFhL9y+cUYb X-Received: by 2002:a17:903:41c3:b0:19a:723a:832f with SMTP id u3-20020a17090341c300b0019a723a832fmr14635648ple.7.1676337125346; Mon, 13 Feb 2023 17:12:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676337125; cv=none; d=google.com; s=arc-20160816; b=q4agdyeeWgJQOF3QHPS/kpMnWDR2+B5hQIxVY8WO58ULzZvT3DooMncSQJfzQoldtJ v+Ggailzy5hUPfxVc2cQ9uuC60D5Oxn1tYUTElp7CoMuiH3dtJme0kk5fh/2B7vcuZ1R JZcNweNLTXWrf6MkmK/qVhLgH2nBx4tBiEtQo0NR8U6XLhFzINeSEpDHTxMFW/+Cy6PV N2VHRZdcfflqJFGMtuXIpL801rHJFkO1QLXt/w/dmoLA3zplUAjArhygOGCpqsXS5bKV Cgb5K2yWAhIMK9ReNy2Vtaiy8yzITtzwMbKkg8v/Q9pMGapKunN5RbsG8/fvLMK2pZmq skZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=yWn9i0V4jviqXHKN2YdmFTxHcOb6y0FVwkDe3mDFK6M=; b=tE3QR3UHJD2Kvqo7RG/T07ysLVZsOY3wmtsFd9uL1hc6mcB7wWHNwXfBUexppzzxEd 756DTOeaSlAdbuTbTcdv2me/deX7uznf9a+OGza/4/+YdJlngznsYyyykLAM/kSEugsh bRYbiP6dWrox7BWywVfCi3iMNtG9rbqMbIYI9ZcLLeYgxabGk2i5RiJfwQE62Qr9eia2 Sq9gQH5lLaKqZu8MpKxFMBektKSxjyza+AaOCG8fNnl0SOZedEutTyFC+sHTLTgu7cSA DMg/jmZRq0YRRPwXskVSMDfd7qsCqwQCIKm/+WPAVEsT9+uOivy+ri8Og0r+e1bFe8H7 ISdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=m2PnzqgH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i16-20020a17090332d000b0019ab354d8cdsi1364273plr.337.2023.02.13.17.11.50; Mon, 13 Feb 2023 17:12:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=m2PnzqgH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230127AbjBNBAj (ORCPT + 99 others); Mon, 13 Feb 2023 20:00:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229645AbjBNBAf (ORCPT ); Mon, 13 Feb 2023 20:00:35 -0500 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BB7E14E98 for ; Mon, 13 Feb 2023 17:00:34 -0800 (PST) Received: by mail-pj1-x1031.google.com with SMTP id rm7-20020a17090b3ec700b0022c05558d22so13931952pjb.5 for ; Mon, 13 Feb 2023 17:00:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yWn9i0V4jviqXHKN2YdmFTxHcOb6y0FVwkDe3mDFK6M=; b=m2PnzqgHnJBv2JUn7LigKLSx5KiB21zizYojzPjYtfYTjuDQbwVm8EDB5jrOT7JzjX 66WOjXVgDf+EqBHClQN82HQlJNLxhk5k9mlv4q91tKTu6Y7d0XyKNbK1Pdj/Ssd/PAyX Wk8rQdW0XBTMFaa9EhwneE0mk/s57vTR8VZO0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yWn9i0V4jviqXHKN2YdmFTxHcOb6y0FVwkDe3mDFK6M=; b=IJ58eotjE6GpWqWachFscso3prw0YUAXcjI2WPeLMt27O5DWSZgSizaBtro/QjdRMb B8aOMUjk3sg6I6WkJJanyCgorUQs8+poPwl8EGVpxsul69zAVuQDwKz2tv0Koo5WTu0L Ft38Ojh0HA+S5N0hZ90jdt7OBKHV1tH5VjNp4fbH9cmDTo8a1kZmvcbTCmA6ikytf2EH yUViODUt1JkDy4BtE/37iVrocpPsiGvGY1T/NH3g5itXjQ37y2UkkgyGAHwvJORxsFGs WRq8x3VZic/VTOfNTPDdr9iuvBM8mxREV2xDrwZQQWdZVP9z2JG5bMT47+m+3yZZ1QzC l51w== X-Gm-Message-State: AO0yUKVYJqGYMZhAMKaOczsmWzEC7HJRfbvs9fkxMG8farBTD9y6+L3W BgWH3wHXkqpXdRo2oU3R+qSc/w== X-Received: by 2002:a05:6a20:1453:b0:c0:c938:8c31 with SMTP id a19-20020a056a20145300b000c0c9388c31mr146109pzi.14.1676336433546; Mon, 13 Feb 2023 17:00:33 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:af55:a232:a032:95ff]) by smtp.gmail.com with ESMTPSA id e22-20020aa78256000000b00592626fe48csm8482914pfn.122.2023.02.13.17.00.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 17:00:33 -0800 (PST) From: Douglas Anderson To: Bjorn Andersson Cc: amstan@chromium.org, swboyd@chromium.org, mka@chromium.org, Douglas Anderson , Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] arm64: dts: qcom: sc7280: Fix herobrine qspi pull direction Date: Mon, 13 Feb 2023 16:57:52 -0800 Message-Id: <20230213165743.2.I06f9e461a85fcd5d6fb1e977aa253f6523096b6f@changeid> X-Mailer: git-send-email 2.39.1.581.gbfd45094c4-goog In-Reply-To: <20230213165743.1.I6f03f86546e6ce9abb1d24fd9ece663c3a5b950c@changeid> References: <20230213165743.1.I6f03f86546e6ce9abb1d24fd9ece663c3a5b950c@changeid> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757766877471829932?= X-GMAIL-MSGID: =?utf-8?q?1757766877471829932?= Though it shouldn't matter very much, we've decided that it's slightly better to park the qspi lines for herobrine with an internal pulldown instead of an internal pullup. There is an external pulldown on one of the data lines on the board and we don't want to have fighting pulls. This also means that if the pulls somehow get left powered in S3 (which I'm uncertain about) that they won't be pulling up lines on an unpowered SPI part. Originally the pullup was picked because SPI transfers are active low and thus the high state is somewhat more "idle", but that really isn't that important because the chip select won't be asserted when the bus is idle. The chip select has a nice external pullup on it that's powered by the same power rail as the SPI flash. This shouldn't have any functionality impact w/ reading/writing the SPI since the lines are always push-pull when SPI transfers are actually taking place. Fixes: 116f7cc43d28 ("arm64: dts: qcom: sc7280: Add herobrine-r1") Signed-off-by: Douglas Anderson --- arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi index b6137816f2f3..7d787b12c10f 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi @@ -703,7 +703,7 @@ &qspi_clk { &qspi_data01 { /* High-Z when no transfers; nice to park the lines */ - bias-pull-up; + bias-pull-down; drive-strength = <8>; };