From patchwork Mon Feb 13 04:15:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 56017 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2166201wrn; Sun, 12 Feb 2023 20:16:36 -0800 (PST) X-Google-Smtp-Source: AK7set+5sG12dsrwdPgCpeGQbAvDsB+oERblZP+lbbuJ5JGZRYhSAs3+/5mzEqD0izVqQQxKrErt X-Received: by 2002:a05:6a20:42a1:b0:b6:157c:d72b with SMTP id o33-20020a056a2042a100b000b6157cd72bmr29355106pzj.33.1676261795702; Sun, 12 Feb 2023 20:16:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676261795; cv=none; d=google.com; s=arc-20160816; b=H2NeU+3i7dQUkvkPQD7TIZ9BnD1pzAIXNomcFQK4avaHB2++0Omsk5yuTQb5O07Mu2 lAOMACnlgrYgEC7e8sn+NpWqLfwhkMa+pXkGXttOS7IcCklV4gevMovz17LIyhUNutkO 9eZKgHYhbeqry9xSOh7zJwTVkm30l3X97yeHAf+/A+a2+SitbGCki0ZJ1WnZzZmU7apD xfRXwtHrM1nEHv3mXoWURyyxan/3NPaM1nnz4z01Q+XBzhu6cbCU/ciSveIjTdGgKWBa e1Hxj8cObUhR5LxSPPf6VOyhYeIpTvaHId74UYoTB5rSwX1TLGLoYC8ZwhJUuc6qyOxj i6jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=KP+QUTQLUK2eLfgHq5KRvNPggllLGVnWdOEMxnpKkT0=; b=wmNE4dVhU9bZPOfw/D4XDLcRJrfBaWsEozbtPM9HrH+OLIzKuvDH0EL67RWvudQUMs E8a7s98qTkYIRuMB+2fugwA/7DQmAH0ZAeX0FeEgJkbn01EgYVwNBxXRdOAVDftqso4v 2xhsxsirQw36jXFN4viLo1BalevwvXBkow1MhjCeFev7EerbOmNA5Xy/AbEYxkrGqSfn SAkraZYzdipIidU3yIxZbonnKea/ZJ0b6FMogPE133kNpQ5bbwBHLgZbxFPhGJL+ZeWu EmEC2AXAmrmEDBQqw6AbYrFeiW30/117qR69sFHg3GHs1ENRbpkMdwqFRN/hm4NCjh5d YHhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=cAOtQYru; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n7-20020a637207000000b004dab94e3f03si10773850pgc.758.2023.02.12.20.16.20; Sun, 12 Feb 2023 20:16:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=cAOtQYru; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229670AbjBMEPs (ORCPT + 99 others); Sun, 12 Feb 2023 23:15:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbjBMEPq (ORCPT ); Sun, 12 Feb 2023 23:15:46 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEAEBCA2F for ; Sun, 12 Feb 2023 20:15:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=KP+QUTQLUK2eLfgHq5KRvNPggllLGVnWdOEMxnpKkT0=; b=cAOtQYru6OXsUMRBFJy+DckahO 44CgxcULv8NnYNsA+AZAPfSqrt3F2nv7INKfutwhVAJh3363RQIgqeTbtJ5lJhx86bC8s33Uymac3 y40xl8TwQTFjL2GCWnzrHiZgSFTWciXhoMjURFivyjmwTwz3CPzeSH24CKL5ildUox+xl2I6E2fne GIk6FBdMXV/3Qq0Aj/AthbBXZONaIX/IJ+cqxgufAaBhaKfBRW9CaPqImEPttO/6yuCzs+cmrzdre tzxnRP7Ie7QYIyiBPahk0eKz+vWZKjoPax7qRdzszQZxJuLMGc0RcCADt9MqWsXWDOGSBZhfsztUx FrNYgaqA==; Received: from [2601:1c2:980:9ec0::df2f] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRQFf-00D56G-Jq; Mon, 13 Feb 2023 04:15:39 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Arnd Bergmann , MyungJoo Ham , Chanwoo Choi , Donggeun Kim , Marc Zyngier , Philipp Zabel , Peter Rosin , Greg Kroah-Hartman Subject: [PATCH 1/3] extcon: max8997: select IRQ_DOMAIN instead of depending on it Date: Sun, 12 Feb 2023 20:15:33 -0800 Message-Id: <20230213041535.12083-2-rdunlap@infradead.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230213041535.12083-1-rdunlap@infradead.org> References: <20230213041535.12083-1-rdunlap@infradead.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757687888480913760?= X-GMAIL-MSGID: =?utf-8?q?1757687888480913760?= IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Relying on it being set for a dependency is risky. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change EXTCON_MAX8997's use of "depends on" for IRQ_DOMAIN to "select". Fixes: dca1a71e4108 ("extcon: Add support irq domain for MAX8997 muic") Signed-off-by: Randy Dunlap Cc: Arnd Bergmann Cc: MyungJoo Ham Cc: Chanwoo Choi Cc: Donggeun Kim Cc: Marc Zyngier Cc: Philipp Zabel Cc: Peter Rosin Cc: Greg Kroah-Hartman --- I have a similar patch (should be a series) for REGMAP. drivers/extcon/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -- a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig --- a/drivers/extcon/Kconfig +++ b/drivers/extcon/Kconfig @@ -115,7 +115,8 @@ config EXTCON_MAX77843 config EXTCON_MAX8997 tristate "Maxim MAX8997 EXTCON Support" - depends on MFD_MAX8997 && IRQ_DOMAIN + depends on MFD_MAX8997 + select IRQ_DOMAIN help If you say yes here you get support for the MUIC device of Maxim MAX8997 PMIC. The MAX8997 MUIC is a USB port accessory From patchwork Mon Feb 13 04:15:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 56019 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2166298wrn; Sun, 12 Feb 2023 20:16:58 -0800 (PST) X-Google-Smtp-Source: AK7set8YIXl+SMP7hNa3HBqJeP+20c5fWkBRT/e9JWS7qLykdblSmrZZRwzxqess3EXwUMW2fEqc X-Received: by 2002:a17:907:a64b:b0:8af:3382:e578 with SMTP id vu11-20020a170907a64b00b008af3382e578mr15699951ejc.4.1676261818490; Sun, 12 Feb 2023 20:16:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676261818; cv=none; d=google.com; s=arc-20160816; b=sU66BlK2JpX0hQmC3fbXEZG7xtUqPlfKD396ivx/u5Q4sbe71Q46XAMMKW9vfXHymZ QA0etgHys9X8xdrftM0EytwBCGDaMbthdcwgKKr2JWFI1D95tYkZFGJrVcljWuqe9CHv 74U/Pr6bkc+fYe3diGCXpOW1dg0BEZQNAlWlE8VWfU8RIzIJRCn1c6pa+kwE8no0qHFn LEnVZlsMMUSV/9Fd2wHWirDKK6X43gBNYXHw/y+KacK7iWUpe0Kjc39UMcirSlxbP6Ox FAmxeXvv1sox7nkgtqvXsTD27ZX3fn9Vkc0vlu2V6GxmA2NSJJLq7bxd+kPGtkaEo4Jw iPJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7EM0k4yf3TlWpm0n08kPMpGLehSGSAexr0X/ND2utsk=; b=m2mgfEBtQwYRPaAwbqWwvXaJyA4/DZM9/6cZxPyj6ywsJ3ce+XDXCFK3KDx/HVEjok dWt0I3yM5uf0IersBT0NexnkPLnyrpOrv0+fqn1/s3SeB7z6yv3dBfcp8SprHUJteCdT 3mCAUiRabsF36C2iNB3FkB4AX/qkz0hZHMQnvU+Wy/2yTxodiTLcvbzJluH9pTssxOTw 9jmzAKRZTI4BhQPJMzWdmpRicXclJ14a/lXSPRvE3fBuX39sZB3H4QbEN6eGBi/0cZAy YwqwgWG8eBs6z28YDoQno5JVbmKdsJrJKN1+EWSZCQG45PX7GZY5VLsY31bDcidqyqOC n5zg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=en4qp0vW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 19-20020a17090602d300b008795db50bdcsi14069201ejk.934.2023.02.12.20.16.35; Sun, 12 Feb 2023 20:16:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=en4qp0vW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229604AbjBMEPx (ORCPT + 99 others); Sun, 12 Feb 2023 23:15:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229581AbjBMEPq (ORCPT ); Sun, 12 Feb 2023 23:15:46 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7C8BE396 for ; Sun, 12 Feb 2023 20:15:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=7EM0k4yf3TlWpm0n08kPMpGLehSGSAexr0X/ND2utsk=; b=en4qp0vWpgwjNqCR4CxWOb5O7G m5x0DwxA7IbG+ddJ/QOh/85G88XNLlR9Cb/RtIK1YxZuCRRBmnrQtvsGD9vc+fWi7xBC573DGBt6I BiUwLHQ/Dx/Y0wFBwOo+FQH5HD+q51PFy71EgWqddTqm7zHfY8Pk4biBDm4LVuHq+pxZSYE0jUpvB L1Rhfk3Z4v8YQ2q5qH7p/gbRn4ws3BV56G5mGd9eH8phgTi0rioI9hNAnDKvsr7NmgGlQyZ1i2dRf hoPwjpt3KJ+iO+13Ij6VUwtORq4vLxgfLOSAvWs0TXtznk65QDW4Gv7+P0vzURUqELBs7Dnt5VdZd nmqgFyDw==; Received: from [2601:1c2:980:9ec0::df2f] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRQFg-00D56G-7N; Mon, 13 Feb 2023 04:15:40 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Geert Uytterhoeven , Rob Herring , Marc Zyngier , Arnd Bergmann , Philipp Zabel , Peter Rosin Subject: [PATCH 2/3] of: OF_IRQ: select IRQ_DOMAIN instead of depending on it Date: Sun, 12 Feb 2023 20:15:34 -0800 Message-Id: <20230213041535.12083-3-rdunlap@infradead.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230213041535.12083-1-rdunlap@infradead.org> References: <20230213041535.12083-1-rdunlap@infradead.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757687912935185449?= X-GMAIL-MSGID: =?utf-8?q?1757687912935185449?= IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Relying on it being set for a dependency is risky. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change OF_IRQ's use of "depends on" to "select". This patch reduces one Kconfig circular dependency in drivers/mux/Kconfig when MUX_MMIO attempts to select REGMAP, which that driver needs (but does not completely resolve that issue). [1] [1] https://lore.kernel.org/lkml/20230210115625.GA30942@pengutronix.de/ Fixes: 63c60e3a6dc3 ("of: OF_IRQ should depend on IRQ_DOMAIN") Signed-off-by: Randy Dunlap Cc: Geert Uytterhoeven Cc: Rob Herring Cc: Marc Zyngier Cc: Arnd Bergmann Cc: Philipp Zabel Cc: Peter Rosin --- I have a similar patch (should be a series) for REGMAP. drivers/of/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -- a/drivers/of/Kconfig b/drivers/of/Kconfig --- a/drivers/of/Kconfig +++ b/drivers/of/Kconfig @@ -68,7 +68,8 @@ config OF_ADDRESS config OF_IRQ def_bool y - depends on !SPARC && IRQ_DOMAIN + depends on !SPARC + select IRQ_DOMAIN config OF_RESERVED_MEM def_bool OF_EARLY_FLATTREE From patchwork Mon Feb 13 04:15:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 56018 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2166200wrn; Sun, 12 Feb 2023 20:16:35 -0800 (PST) X-Google-Smtp-Source: AK7set/IeCmrHnBaVu9sMX6l32iZaWol7rchlsK4sr649KfYvyEKzKkJNo1+gdiBTzsxc14n6OUh X-Received: by 2002:a17:90b:164a:b0:233:feb4:895f with SMTP id il10-20020a17090b164a00b00233feb4895fmr1740049pjb.44.1676261795706; Sun, 12 Feb 2023 20:16:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676261795; cv=none; d=google.com; s=arc-20160816; b=i4tRFfQueHqCroghZToL0y1rXHXFKTeaiOnoX2RFxK3iIzxASgj6fsg0KwyjsGl0++ xu4SKnbDXnwmb0ZgQ/lokItNzCOiRPXqoPFXfof0JdQl2kx5rhH6pqawL+RYLOJGf077 pSvTX/NFjIRTOotJ3I1xrTQiX4wS9OhMEQncPtBTLfjwjgieGqXyIznVQaiXYilgqUdS KKhqb+FkFl90bkxsS8rHBgAwshlKtoBcEVkjhPNpdf/03aQItkP2Kk5V2fYZoWy8TkWN XFEMqEDwGYUKL8BiU5np1QAeokczSWokyqyJAkxWb1ptfk3ccFRB0xO7atDlQR5v29Uo 6myA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=b2TQAFC9pQ+rFyre5LGzTHnEk3iqoypnovZvNJTJtgQ=; b=pj/GKjd1Jb05MzdIavGZIxn4PitfuRMnYUrWnjNF0k0G3luEPJhbbgHSedvKVoeRUv 1xeh+Nfz6yv/DqR/6zmIx8ufDvOG/4jxO4AB38EyUXqWcVTG0rzd2TzVyQyao10QCW29 5z36CMZLuGOwMaYalx5dgASPT0mn1GV2P1RwGfrfFdEDTSc3lULobCKLJ0efiDSyvzSR +8pZ4DSnxXBSu+NPs5ojjJpAztBqmRhrQDUeQrLc8BWa2UUGWXUWJO2xyVMHwUfMbFko YlYAPlH920L/GKXwpfVzOCPs2D3Awdqv5pW/2hlnmJbbSkzEdjDnza60mj0RFv3q5teH TudQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=tt2oG+eQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t18-20020a17090ad15200b00226ddf6b7ddsi10126109pjw.181.2023.02.12.20.16.21; Sun, 12 Feb 2023 20:16:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=tt2oG+eQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229552AbjBMEPu (ORCPT + 99 others); Sun, 12 Feb 2023 23:15:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229589AbjBMEPq (ORCPT ); Sun, 12 Feb 2023 23:15:46 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 182B8E398; Sun, 12 Feb 2023 20:15:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=b2TQAFC9pQ+rFyre5LGzTHnEk3iqoypnovZvNJTJtgQ=; b=tt2oG+eQWgWsZl+xyvKM8MNAxj VxZJMIDE6T3wn23KcFzBD2dZVlX3BTABLB+4WrBlgaRzb3rdD0dpboH8TYGeHiU2lhtkx0SY/WCcj VhcGdaq6k7QC+QmoafepvH76tngi5sLd4M6iRNNfvtbh+M4hWKo2F0oiYBxHhCmZpoP96sDZckkqe 4rCFVUvZxuSw6zPA3AawRwJAmUfXZGtOjvS+FeTbxlsP+G62MvLGcSAOz7CP+XxzONhy4JAMFoBRR jvA6VS63YbZlktpuhP/73IAV4Q+eSz38jmc2cOuzML+Nsu040MaMbXOdEQpag8pVY5K81qU/j/v2E fW58fEIA==; Received: from [2601:1c2:980:9ec0::df2f] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRQFh-00D56G-7X; Mon, 13 Feb 2023 04:15:41 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Arnd Bergmann , Eddie Huang , Sean Wang , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org, Marc Zyngier , Philipp Zabel , Peter Rosin Subject: [PATCH 3/3] rtc: mt6397: select IRQ_DOMAIN instead of depending on it Date: Sun, 12 Feb 2023 20:15:35 -0800 Message-Id: <20230213041535.12083-4-rdunlap@infradead.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230213041535.12083-1-rdunlap@infradead.org> References: <20230213041535.12083-1-rdunlap@infradead.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757687888574849967?= X-GMAIL-MSGID: =?utf-8?q?1757687888574849967?= IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Relying on it being set for a dependency is risky. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change the use of "depends on" for IRQ_DOMAIN to "select" for RTC_DRV_MT6397. Fixes: 04d3ba70a3c9 ("rtc: mt6397: add IRQ domain dependency") Signed-off-by: Randy Dunlap Cc: Arnd Bergmann Cc: Eddie Huang Cc: Sean Wang Cc: Matthias Brugger Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Cc: Alessandro Zummo Cc: Alexandre Belloni Cc: linux-rtc@vger.kernel.org Cc: Marc Zyngier Cc: Philipp Zabel Cc: Peter Rosin Reviewed-by: AngeloGioacchino Del Regno --- I have a similar patch (should be a series) for REGMAP. drivers/rtc/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -- a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -1814,7 +1814,8 @@ config RTC_DRV_MT2712 config RTC_DRV_MT6397 tristate "MediaTek PMIC based RTC" - depends on MFD_MT6397 || (COMPILE_TEST && IRQ_DOMAIN) + depends on MFD_MT6397 || COMPILE_TEST + select IRQ_DOMAIN help This selects the MediaTek(R) RTC driver. RTC is part of MediaTek MT6397 PMIC. You should enable MT6397 PMIC MFD before select