From patchwork Fri Feb 10 04:48:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 55213 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp755485wrn; Thu, 9 Feb 2023 20:51:27 -0800 (PST) X-Google-Smtp-Source: AK7set86sw2BwnEWTMYVYnjZaecg7hl7OiVMOdK9Rf6ZIxx0hGIl8tq6nQz4KnmY7qdR+jt/Fh9w X-Received: by 2002:a17:906:36d9:b0:878:7921:9a94 with SMTP id b25-20020a17090636d900b0087879219a94mr13233942ejc.16.1676004687529; Thu, 09 Feb 2023 20:51:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676004687; cv=none; d=google.com; s=arc-20160816; b=wgckRlFhZQiWHNP3s1YyoQdPD40VcfZOqSpbRegXU3S4CCZNWRgMvmRAA34bb3kxbd CGt6yMJbfh0SISu/8OBFgJTGs+UBaKoGaVlGoW7LYoTEabmpXpOqgByS4VTVwcT8Dqrq +bbfu71tGHNdPpk7MPipZKirnEbQQyoG3wm2mGkS6+kf6C0gq65E9O1RjASdC80rnm8L K7wpuENKlW3Ph58/VXI3AEqtDMSRPA9UItpLRStAODQG7Bw4cpCKA/0ToT6pfG3tVy+f 74zrPC6fn+gERFVC8V1+JbAyBGF88b0KeWuTYh8Ys42JLq0gIcwT2FVzcYtef8jD0hxh 7Aaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mkZoK0/aAqvT+1zrAd5/4wcBd4tA7+DHKtF9ign+pSA=; b=hdPlpMe9XNcFgH3Hh+UydniNQR36DmHOz80a7rLEOZZUjsSfPfUlsIHkRIetoJuMfA QQzgd3eeiwbytBzU+ivjYNhN9c1X6YLaYKYljPyVfyvwm9FC1/cCdnh3apkNCZcI/z5x oP7PDlTu/BSwuojVucMODHT30aSmkrXmoSkWYp2lsF9qbaCg4GlRrJ6c+4BoXT6LgwkP VR/K4AY7v94b7pyftAO8UFmJO4HlVBmwEtsZ3Kd8otfl/ryUeAkACFCGdPsUidOBIPWr xhKrGhShOk41CvwkMqFLSojyIlMoOSvvMX210rK4jpdcFFSkzK5ugdilHeZJdXZZ2/qA 7Gfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FMLebj8I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id zy21-20020a17090734d500b0088e0c76c466si4330586ejb.356.2023.02.09.20.51.04; Thu, 09 Feb 2023 20:51:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FMLebj8I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230286AbjBJEs6 (ORCPT + 99 others); Thu, 9 Feb 2023 23:48:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230325AbjBJEst (ORCPT ); Thu, 9 Feb 2023 23:48:49 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F06A5B74E; Thu, 9 Feb 2023 20:48:48 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D5B00B82396; Fri, 10 Feb 2023 04:48:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20213C433EF; Fri, 10 Feb 2023 04:48:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676004525; bh=x39PRc/T046lvvssIPKrbvAhJnKd48hEXRslXo6G51Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FMLebj8IqIs5vo3DVpcyJ7/HYGRcBna7bSZLxkCSGshx/DP4CdpuHOVAaOReZtRS+ mvg6Lcq2EvaItJZPKIFui4VtCK8HVABM7HJGyxpj5ZGGmKpXW0kQyBXfY2fUYKtXOc b5aOsOV2S2N6G4fwtA249ibOtNcjB+m3qgzqcTtlLBnImql24nHqtawmTX0sBceEtc OB2CmTl4Auf+1ifxMouvM7y9Es+WBzZOujAgRbNQ1TSfqoSz/PizZds/CK1iJm0L85 Hw3gZtC98Ki9w3YCcHiUvF58EOttEltnfi8IHvB2yQjDSobfBf1fgqIaLvbwZDEOQl tZieONTUe/zXA== From: SeongJae Park To: SeongJae Park , Andrew Morton Cc: Jonathan Corbet , damon@lists.linux.dev, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] Docs/admin-guide/mm/damon/usage: add DAMON debugfs interface deprecation notice Date: Fri, 10 Feb 2023 04:48:36 +0000 Message-Id: <20230210044838.63723-2-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230210044838.63723-1-sj@kernel.org> References: <20230210044838.63723-1-sj@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757418291205166281?= X-GMAIL-MSGID: =?utf-8?q?1757418291205166281?= DAMON debugfs interface has announced to be deprecated after >v5.15 LTS kernel is released. And, v6.1.y has announced to be an LTS[1]. Though the announcement was there for a while, some people might not noticed that so far. Also, some users could depend on it and have problems at movng to the alternative (DAMON sysfs interface). For such cases, note DAMON debugfs interface as deprecated, and contacts to ask helps on the document. [1] https://git.kernel.org/pub/scm/docs/kernel/website.git/commit/?id=332e9121320bc7461b2d3a79665caf153e51732c Signed-off-by: SeongJae Park --- Documentation/admin-guide/mm/damon/usage.rst | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/Documentation/admin-guide/mm/damon/usage.rst b/Documentation/admin-guide/mm/damon/usage.rst index 9237d6a25897..9b823fec974d 100644 --- a/Documentation/admin-guide/mm/damon/usage.rst +++ b/Documentation/admin-guide/mm/damon/usage.rst @@ -25,10 +25,12 @@ DAMON provides below interfaces for different users. interface provides only simple :ref:`statistics ` for the monitoring results. For detailed monitoring results, DAMON provides a :ref:`tracepoint `. -- *debugfs interface.* +- *debugfs interface. (DEPRECATED!)* :ref:`This ` is almost identical to :ref:`sysfs interface - `. This will be removed after next LTS kernel is released, - so users should move to the :ref:`sysfs interface `. + `. This is deprecated, so users should move to the + :ref:`sysfs interface `. If you depend on this and cannot + move, please report your usecase to damon@lists.linux.dev and + linux-mm@kvack.org. - *Kernel Space Programming Interface.* :doc:`This ` is for kernel space programmers. Using this, users can utilize every feature of DAMON most flexibly and efficiently by @@ -487,13 +489,17 @@ the files as above. Above is only for an example. .. _debugfs_interface: -debugfs Interface -================= +debugfs Interface (DEPRECATED!) +=============================== .. note:: - DAMON debugfs interface will be removed after next LTS kernel is released, so - users should move to the :ref:`sysfs interface `. + THIS IS DEPRECATED! + + DAMON debugfs interface is deprecated, so users should move to the + :ref:`sysfs interface `. If you depend on this and cannot + move, please report your usecase to damon@lists.linux.dev and + linux-mm@kvack.org. DAMON exports eight files, ``attrs``, ``target_ids``, ``init_regions``, ``schemes``, ``monitor_on``, ``kdamond_pid``, ``mk_contexts`` and From patchwork Fri Feb 10 04:48:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 55217 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp755800wrn; Thu, 9 Feb 2023 20:52:31 -0800 (PST) X-Google-Smtp-Source: AK7set8mpQLy0m+SiPqDQ9m7E2zsNT4N7ZthTpCgMzk+F4RDIEdWOXnzRHpABeZPNgKS0sNWagbi X-Received: by 2002:a17:90a:ea82:b0:233:b1cf:541 with SMTP id h2-20020a17090aea8200b00233b1cf0541mr228765pjz.65.1676004751297; Thu, 09 Feb 2023 20:52:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676004751; cv=none; d=google.com; s=arc-20160816; b=ARvMI4uFE9vBUeAikGjbSUpFwDS6azdHY8htuzOHrBjsFhoPIxJO8Ipw4FFs6Dvx3D 7aI7LIaAkANypqWSnV3odZtT1JN+/YQrQ7xkR50C53aX4NNaXLuoZumrJ9t24weTaOtO rwWxGTWCBFhbj6kVpv7epZst3L/7Qp5gVirVGmAU2Mtko9qPRPZhvCn90pWqAeDuR6gf +DxjT1voKgCwAxYZIXy7HKQFDnuS7n5H4OpJV3UP52K08AfPNt1Qe3yp951jtRh6vy0q Kvtqsy3wHpt8iMhyllLnnUI2KkrcU2nx2VvWeQ1V7lVPT9hjrq7WalLBjwjKVJbwviHN UX7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=GMhQv0JeYHPs+Hm+FPEG1Rx/DU8HSBna4LuCCkQZS2A=; b=gjcfw53uwWR+YkD+PNHhRep8rk27rWQ8HHn7zS/fBuzj5jm/ClEx4PY60aR+isUjii SKjXKxhAvwmlSWg2O5ReZiBqwzYNMxs6sG+w++JljDVFtJfP8jcXRCoz62Jce7e6efMT pbeLqOjK9OvHxIRvpRF7NDgYEQP6xrRFHdRnxirpBnUJw5QcLOjp0D9JEG17QoAeq4tP p9UghIJDlXc3xNZ2z40bfME/jXeEFbvhxEXsrtEGGATK34VaMdGDuVxZznOAq4yMllup 7T88U6l0hYQZTcax3DpQLS78TxmoqTGaclmRLeVC08Am3+BGTr1RBGLROe05yKXEoxgA HYDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XdilebEY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p23-20020a170902b09700b00194d0ae0eedsi3188047plr.546.2023.02.09.20.52.18; Thu, 09 Feb 2023 20:52:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XdilebEY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231126AbjBJEsy (ORCPT + 99 others); Thu, 9 Feb 2023 23:48:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230286AbjBJEss (ORCPT ); Thu, 9 Feb 2023 23:48:48 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A5285B74C for ; Thu, 9 Feb 2023 20:48:47 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D8D7861C14 for ; Fri, 10 Feb 2023 04:48:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5971C433A0; Fri, 10 Feb 2023 04:48:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676004526; bh=3ZPhytsG6MoiFI71uMGAzjRAm4p3c/2mkgqWantxo+I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XdilebEYHnliIo6ccsozIn8z310XX+J4YeoCbW7rHQ02/iln2iXxE9EPvQfBjxLax t3ysfYwi4WsuohmRqftPzIgku530OlwXFpf3XyzBHQjyXWftPiGot3pG6gJwcCoJK3 NTluwuUy5cBGGi1P7UEcU1ZMFeY8ED+DIAgqZw4WjDJqwj+DJOuSP/4PUQmO8Uz265 5KTyBUZzr1t7Oe9UxIM5csHGF8Q8jf6WQe7xmnzaI9a1Se2LloVN9qnQ1LJckDykx6 x4HSp+SsZ6xYd8rw6ZiBjPcRKEaoRozmHkbJ8dttfY+EZtSAVlxs9CZAaveKCXb81/ UzFACfqLtzIRg== From: SeongJae Park To: SeongJae Park , Andrew Morton Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] mm/damon/Kconfig: add DAMON debugfs interface deprecation notice Date: Fri, 10 Feb 2023 04:48:37 +0000 Message-Id: <20230210044838.63723-3-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230210044838.63723-1-sj@kernel.org> References: <20230210044838.63723-1-sj@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757418357830162256?= X-GMAIL-MSGID: =?utf-8?q?1757418357830162256?= DAMON debugfs interface has announced to be deprecated after >v5.15 LTS kernel is released. And, v6.1.y has announced to be an LTS[1]. Though the announcement was there for a while, some people might not noticed that so far. Also, some users could depend on it and have problems at movng to the alternative (DAMON sysfs interface). For such cases, note DAMON debugfs interface as deprecated, and contacts to ask helps on the Kconfig. [1] https://git.kernel.org/pub/scm/docs/kernel/website.git/commit/?id=332e9121320bc7461b2d3a79665caf153e51732c Signed-off-by: SeongJae Park --- mm/damon/Kconfig | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mm/damon/Kconfig b/mm/damon/Kconfig index 7821fcb3f258..436c6b4cb5ec 100644 --- a/mm/damon/Kconfig +++ b/mm/damon/Kconfig @@ -60,7 +60,7 @@ config DAMON_SYSFS the interface for arbitrary data access monitoring. config DAMON_DBGFS - bool "DAMON debugfs interface" + bool "DAMON debugfs interface (DEPRECATED!)" depends on DAMON_VADDR && DAMON_PADDR && DEBUG_FS help This builds the debugfs interface for DAMON. The user space admins @@ -68,8 +68,9 @@ config DAMON_DBGFS If unsure, say N. - This will be removed after >5.15.y LTS kernel is released, so users - should move to the sysfs interface (DAMON_SYSFS). + This is deprecated, so users should move to the sysfs interface + (DAMON_SYSFS). If you depend on this and cannot move, please report + your usecase to damon@lists.linux.dev and linux-mm@kvack.org. config DAMON_DBGFS_KUNIT_TEST bool "Test for damon debugfs interface" if !KUNIT_ALL_TESTS From patchwork Fri Feb 10 04:48:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 55214 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp755535wrn; Thu, 9 Feb 2023 20:51:37 -0800 (PST) X-Google-Smtp-Source: AK7set/0VFZudtP44fGCTHFZMk8tLu9xOps0WTAO0iWVfPeO54PL9e+G6BJwnJAsm2c7E/CY9m7B X-Received: by 2002:a17:906:478e:b0:8aa:9abe:8edd with SMTP id cw14-20020a170906478e00b008aa9abe8eddmr16428493ejc.66.1676004697700; Thu, 09 Feb 2023 20:51:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676004697; cv=none; d=google.com; s=arc-20160816; b=VuW4Z0uBSvJfh1Jj9rgdf+Q6TGo1i++rZI+o7HVVPJXQ8uRVzqOUi6i2xPJ7N9m6K0 AxZqtji7VJ/8uLWhZdVmJESoFBw20nlHTq7EDLWOItMlUeh7DaFJT9QTlxWzi2QzP14g vOYOQh4xTjHyxNoC7UfevMPb1qy3pWfr6kvui9PM4hJk+askPrLkP444ltg5AIwp1zeV 1PWiZfh4NWH7NfT320fsnXDdhQNNRaqOMATvFEehm0EpS6lblDbToLu6DiVRaO3cOwgl rtWvLwJcU8hCv1/gddqDUH0PlwNZRQok/Ip6FQ8ru33Li5lH2ci5pUBgdQzOk5TxvQcs PmbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=PwwzsY/51csXNOOx4GzPgkxCySUu+mfViXO0wUCKyK0=; b=WlkqioiI4m8OvBz4FHkmk7r0VJ4BCMLSpB0+0e7Hj5v8kyauaik8h59AWHseLH/n81 OFDPoSUyLSfrEfj2nimAzK1qutKNZr0i0rhVsiH2XquW5BQHUCfGnfOFYmD8JGt50s1J K4GMPeDVBxQb5SxBME5TPvMMs5oHu5x2SFlDCrF8ErgKe6MJubGW798M5tZR53iKOLvU CvwqRSx1+Yx0NxMHZU1XBWZu5F7ru94EOupqD9/Ve3E1Dc/LL/vZkwtTqhYw/TwXaels J9IcRcbmM/COPYpvqzEQ6gIZhdMKJTog6GQmzH/9SdbncHDs9TO0BkiBtQunsR5GRnCJ 5mMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="osoBk/p5"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s12-20020a170906220c00b00889c115cf70si4089375ejs.190.2023.02.09.20.51.14; Thu, 09 Feb 2023 20:51:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="osoBk/p5"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231178AbjBJEtB (ORCPT + 99 others); Thu, 9 Feb 2023 23:49:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230239AbjBJEsu (ORCPT ); Thu, 9 Feb 2023 23:48:50 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9541A6D8E7 for ; Thu, 9 Feb 2023 20:48:49 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 34607B823BE for ; Fri, 10 Feb 2023 04:48:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 786BEC433A1; Fri, 10 Feb 2023 04:48:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676004527; bh=GHjXtEXAs/907P6A+4MUMIxpIxGv/uFwCu4RPtNwvv4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=osoBk/p5fti365hKvBevvfZpAfFjjBuRvv90yf+hbzGZGnr44zGzfMzevZBF1G5W+ 0cZp6p4OTOl29Rq8NHb+4yhgbo8Dduwr/YXYSUYSaJfAIuLSRgmDs6O0hUYP3PvxqA lnnI3TiTC1gQpj6NnQM4FpQwlGgEiexU4MJHePwMijo+PLyb1i04CdpxtINd6AHV+t iDshdB/9WNtDhnYuAiB7CBh1adRpmRDEgHAOFRS5ChWfCZGD0kOJAV2osSEbuacspk /OtFQ0ujR1NeVbbBb8i0JhTrOBz2jn7zCDH/hnK7mivL/KBsapzZBsQf3lecRBPt1G cR/odiYu7eU/g== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jonathan Corbet Subject: [PATCH v2 3/3] mm/damon/dbgfs: print DAMON debugfs interface deprecation message Date: Fri, 10 Feb 2023 04:48:38 +0000 Message-Id: <20230210044838.63723-4-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230210044838.63723-1-sj@kernel.org> References: <20230210044838.63723-1-sj@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757418301907965051?= X-GMAIL-MSGID: =?utf-8?q?1757418301907965051?= DAMON debugfs interface has announced to be deprecated after >v5.15 LTS kernel is released. And, v6.1.y has announced to be an LTS[1]. Though the announcement was there for a while, some people might not noticed that so far. Also, some users could depend on it and have problems at movng to the alternative (DAMON sysfs interface). For such cases, warn DAMON debugfs interface deprecation with contacts to ask helps when any DAMON debugfs interface file is opened. [1] https://git.kernel.org/pub/scm/docs/kernel/website.git/commit/?id=332e9121320bc7461b2d3a79665caf153e51732c Link: https://lkml.kernel.org/r/20230209192009.7885-4-sj@kernel.org Signed-off-by: SeongJae Park Cc: Jonathan Corbet Signed-off-by: Andrew Morton --- mm/damon/dbgfs.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c index b3f454a5c682..124f0f8c97b7 100644 --- a/mm/damon/dbgfs.c +++ b/mm/damon/dbgfs.c @@ -20,6 +20,14 @@ static int dbgfs_nr_ctxs; static struct dentry **dbgfs_dirs; static DEFINE_MUTEX(damon_dbgfs_lock); +static void damon_dbgfs_warn_deprecation(void) +{ + pr_warn_once("DAMON debugfs interface is deprecated, " + "so users should move to DAMON_SYSFS. If you cannot, " + "please report your usecase to damon@lists.linux.dev and " + "linux-mm@kvack.org.\n"); +} + /* * Returns non-empty string on success, negative error code otherwise. */ @@ -711,6 +719,8 @@ static ssize_t dbgfs_kdamond_pid_read(struct file *file, static int damon_dbgfs_open(struct inode *inode, struct file *file) { + damon_dbgfs_warn_deprecation(); + file->private_data = inode->i_private; return nonseekable_open(inode, file); @@ -1039,15 +1049,24 @@ static ssize_t dbgfs_monitor_on_write(struct file *file, return ret; } +static int damon_dbgfs_static_file_open(struct inode *inode, struct file *file) +{ + damon_dbgfs_warn_deprecation(); + return nonseekable_open(inode, file); +} + static const struct file_operations mk_contexts_fops = { + .open = damon_dbgfs_static_file_open, .write = dbgfs_mk_context_write, }; static const struct file_operations rm_contexts_fops = { + .open = damon_dbgfs_static_file_open, .write = dbgfs_rm_context_write, }; static const struct file_operations monitor_on_fops = { + .open = damon_dbgfs_static_file_open, .read = dbgfs_monitor_on_read, .write = dbgfs_monitor_on_write, };