From patchwork Thu Feb 9 19:20:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 55072 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp527654wrn; Thu, 9 Feb 2023 11:25:42 -0800 (PST) X-Google-Smtp-Source: AK7set8zJnX3LGjy+Gp2csEFYCrLyd0kDCfwDVstURojoxVSxC2CodWrB0xWi8JbDw1nZ9QRn71K X-Received: by 2002:a50:d4c8:0:b0:4a1:8579:d6ee with SMTP id e8-20020a50d4c8000000b004a18579d6eemr13038686edj.42.1675970741998; Thu, 09 Feb 2023 11:25:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675970741; cv=none; d=google.com; s=arc-20160816; b=shswX/+2MNT4q+ga9QESP4jdjLDznZ6y4VDQuLmTgPWfZldORUgQx/oPhotBP2H+MQ nSFAtnfagcu3oRaYwPovfMKht25o+i3i4rhc7ZTIEM0ApW/r9ZkrJMpNn/08aFV6/yu0 BuKqYmOQIFmYuN8P44PAW+BaR6t7VLimtpr2ewZwWI1J9SZSXUlt2u81CIawItrqBmKC 4PaLw8nOb7g2YPB8ncMyQyYlffwV+ktr3Ht43SocPSE9Cy7xN68y4tntSXxQIycjcDyk V32odiSTFotDUu7eT586uqADcaVwaZFMApxNK/jCEQtCHp+x+2UwqXIwnQmAg9qicErc N7Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mkZoK0/aAqvT+1zrAd5/4wcBd4tA7+DHKtF9ign+pSA=; b=uKej+TsqOAxnjfv1mVx86LqTNzsH4mgd/ab14uAbx8DavsemELFXlPMOn+fzKYo6w2 Vcc2C1QxdU+m0d41toTbL331w/61A6YBBNRC7Fq2LFxyZD5fzz0TB/Z/NRm3bozTGder 3M1Jkww8IxrUTP4kox0+DAeiuTy9bgmviZrUwxqLY+pGU5ppPzan+HpobovjyKpBTPku BFLO7p2oNhuoOQ0glfmSm9f2j/tLCvU2gQF9ix00XfXQK5XcXg+NPy/TABC0i64QjKKD Ug+AdHmlVFeriMTHrGR5myj/cxN01NnoZ2V05Hcn4wRRUj53sIB6pedQ8oGH6g0d5mL7 L5Nw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GzFX5MPf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ba17-20020a0564021ad100b0049ff06fc978si1503907edb.534.2023.02.09.11.25.18; Thu, 09 Feb 2023 11:25:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GzFX5MPf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230102AbjBITUZ (ORCPT + 99 others); Thu, 9 Feb 2023 14:20:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229772AbjBITUS (ORCPT ); Thu, 9 Feb 2023 14:20:18 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC3AB458A1; Thu, 9 Feb 2023 11:20:16 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 476CD61BA0; Thu, 9 Feb 2023 19:20:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27BDCC4339C; Thu, 9 Feb 2023 19:20:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675970415; bh=x39PRc/T046lvvssIPKrbvAhJnKd48hEXRslXo6G51Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GzFX5MPfuSPK29Lom5JhsbHaaPcgjVVf1YkoJfatDQvxT5JmnDvRrVYrsiJRGiXTK L2Pe4kmbM4k/370TpVO1iWj1l5UpsBTyojfgcZice2Ge5QrYw5xcSt9xvsFixlggAT 01IJkraGTY4i3MaiKeoiBoklVgJwQqvr8lALW54YozE9TnHdqgC77AbXHHlGtEUH5k ig1KK8mmIgy5hjL/Rpehj3X6amPuwwYe2gV1NClvixj/EL1PV6LanqN4qivaSBtGmy kUJp6CL33PK925drX8e4s92T8z+AfPtOpzjgRBJhQgT1lwJzPyb+0i9jP/jaKTJysf dSNNcCw/cXYbQ== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Jonathan Corbet , damon@lists.linux.dev, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] Docs/admin-guide/mm/damon/usage: add DAMON debugfs interface deprecation notice Date: Thu, 9 Feb 2023 19:20:07 +0000 Message-Id: <20230209192009.7885-2-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230209192009.7885-1-sj@kernel.org> References: <20230209192009.7885-1-sj@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757382696675407554?= X-GMAIL-MSGID: =?utf-8?q?1757382696675407554?= DAMON debugfs interface has announced to be deprecated after >v5.15 LTS kernel is released. And, v6.1.y has announced to be an LTS[1]. Though the announcement was there for a while, some people might not noticed that so far. Also, some users could depend on it and have problems at movng to the alternative (DAMON sysfs interface). For such cases, note DAMON debugfs interface as deprecated, and contacts to ask helps on the document. [1] https://git.kernel.org/pub/scm/docs/kernel/website.git/commit/?id=332e9121320bc7461b2d3a79665caf153e51732c Signed-off-by: SeongJae Park --- Documentation/admin-guide/mm/damon/usage.rst | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/Documentation/admin-guide/mm/damon/usage.rst b/Documentation/admin-guide/mm/damon/usage.rst index 9237d6a25897..9b823fec974d 100644 --- a/Documentation/admin-guide/mm/damon/usage.rst +++ b/Documentation/admin-guide/mm/damon/usage.rst @@ -25,10 +25,12 @@ DAMON provides below interfaces for different users. interface provides only simple :ref:`statistics ` for the monitoring results. For detailed monitoring results, DAMON provides a :ref:`tracepoint `. -- *debugfs interface.* +- *debugfs interface. (DEPRECATED!)* :ref:`This ` is almost identical to :ref:`sysfs interface - `. This will be removed after next LTS kernel is released, - so users should move to the :ref:`sysfs interface `. + `. This is deprecated, so users should move to the + :ref:`sysfs interface `. If you depend on this and cannot + move, please report your usecase to damon@lists.linux.dev and + linux-mm@kvack.org. - *Kernel Space Programming Interface.* :doc:`This ` is for kernel space programmers. Using this, users can utilize every feature of DAMON most flexibly and efficiently by @@ -487,13 +489,17 @@ the files as above. Above is only for an example. .. _debugfs_interface: -debugfs Interface -================= +debugfs Interface (DEPRECATED!) +=============================== .. note:: - DAMON debugfs interface will be removed after next LTS kernel is released, so - users should move to the :ref:`sysfs interface `. + THIS IS DEPRECATED! + + DAMON debugfs interface is deprecated, so users should move to the + :ref:`sysfs interface `. If you depend on this and cannot + move, please report your usecase to damon@lists.linux.dev and + linux-mm@kvack.org. DAMON exports eight files, ``attrs``, ``target_ids``, ``init_regions``, ``schemes``, ``monitor_on``, ``kdamond_pid``, ``mk_contexts`` and From patchwork Thu Feb 9 19:20:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 55071 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp527487wrn; Thu, 9 Feb 2023 11:25:18 -0800 (PST) X-Google-Smtp-Source: AK7set88mpIi4HTOyx5Vo6Bx10g2fUTkAyuJ2moTuYoBQNfi/8KSY4iUJMIbG7ZogX0ipdME9IIQ X-Received: by 2002:a50:d5d9:0:b0:4ab:1584:c0d6 with SMTP id g25-20020a50d5d9000000b004ab1584c0d6mr6903930edj.32.1675970718770; Thu, 09 Feb 2023 11:25:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675970718; cv=none; d=google.com; s=arc-20160816; b=H4nxyhJEkHUxn2qjJcZhC/1Wv49S5J7y56UG8+x0b/buFh5cvuNVGdK8KJ5Z0FKCId Nxb8iEfpV5ZJTIekLOtGzR3++NIuvmmnPvGiSlFpHeohOvXxZu2j2aFyuYriIEhEKwJJ +OJJ78ynA/1Khy9d5cXTCyt74XcehNopVkG1D7MflaMIYKA0Nv+EfJo09sO5NtIGxLlm qTncmIO0DVnnbiiZ0XsCitwOXpoJtL8JMOXTUMos1s3EZahlAR1R2rEwupxC+LOMuPkn tvLK49cyugLaYr58DjpkKcaXRuySOnl9Ttv+cNTzR7eHJPPjtqb3OHmfHI+XszIlxiYl 57wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=GMhQv0JeYHPs+Hm+FPEG1Rx/DU8HSBna4LuCCkQZS2A=; b=vqPQehQYPkpUqPKSpB+tl9nppmGxcHze7a33ckMVmegwuJh9n/WHSfKQ+OFL3whzJi Wc8wcNl/9O8SdJ2N+BmybA5yt1Qpr5AEz/hN5e3UMfbU/MYYVLz4JPUB7fQu1E0qKhNz A/yCdDWT/Li/DZVFJbplqeqZaA618/8Pp8qaflYPRi88HB91uwh2/v9+LU51nGmlK4op o37xhpgHj9yJxqlRXer3xtF78TQdSH3U1838Zb6VFe05yDae2SbvZ/FT2s7HDPbQlP/J FVx8lFOfNCwAGXb2RJjQ4hyJsEW0ZjukyfiKPdCRCzyta6jqyXUCu0yG6RgsgoF4WwJz e7gw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="rA9v/IlA"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g4-20020a056402114400b0048e82d753a3si2961229edw.227.2023.02.09.11.24.55; Thu, 09 Feb 2023 11:25:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="rA9v/IlA"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230087AbjBITUX (ORCPT + 99 others); Thu, 9 Feb 2023 14:20:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229836AbjBITUS (ORCPT ); Thu, 9 Feb 2023 14:20:18 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 438504740B for ; Thu, 9 Feb 2023 11:20:17 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D394D61B9A for ; Thu, 9 Feb 2023 19:20:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2561C433A0; Thu, 9 Feb 2023 19:20:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675970416; bh=3ZPhytsG6MoiFI71uMGAzjRAm4p3c/2mkgqWantxo+I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rA9v/IlAimkmQzJd9fC7BNDYoPRQfdmYdGr+BsMUvy6S1DlXT51Ze4eoQXL+sPJej saLINvtg1Ytlv865eJ5j2Tv8XVxFNX6a+4wtC9SaFulcqmopRSukl9hmpf11dKstlN +QYIu/tzbD+w+BSs7eqEOgDdxDn5MExI0Gzhea5qwmoaSOzQNpgt68WwOdoOD7/OH0 bEIifYbc7ua2i4DE53Awy0TLV7o64OPnHiwTruOuFRURpYproX4HVWe/wBmJTG5yM2 e7UvDENGm8vA0b/rWFcbw/96jTHVryPSdrKOSnhIl69NwvCEDoXV2m+URReTq6okbt dFDxxllM6tZRA== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] mm/damon/Kconfig: add DAMON debugfs interface deprecation notice Date: Thu, 9 Feb 2023 19:20:08 +0000 Message-Id: <20230209192009.7885-3-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230209192009.7885-1-sj@kernel.org> References: <20230209192009.7885-1-sj@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757382672871550536?= X-GMAIL-MSGID: =?utf-8?q?1757382672871550536?= DAMON debugfs interface has announced to be deprecated after >v5.15 LTS kernel is released. And, v6.1.y has announced to be an LTS[1]. Though the announcement was there for a while, some people might not noticed that so far. Also, some users could depend on it and have problems at movng to the alternative (DAMON sysfs interface). For such cases, note DAMON debugfs interface as deprecated, and contacts to ask helps on the Kconfig. [1] https://git.kernel.org/pub/scm/docs/kernel/website.git/commit/?id=332e9121320bc7461b2d3a79665caf153e51732c Signed-off-by: SeongJae Park --- mm/damon/Kconfig | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mm/damon/Kconfig b/mm/damon/Kconfig index 7821fcb3f258..436c6b4cb5ec 100644 --- a/mm/damon/Kconfig +++ b/mm/damon/Kconfig @@ -60,7 +60,7 @@ config DAMON_SYSFS the interface for arbitrary data access monitoring. config DAMON_DBGFS - bool "DAMON debugfs interface" + bool "DAMON debugfs interface (DEPRECATED!)" depends on DAMON_VADDR && DAMON_PADDR && DEBUG_FS help This builds the debugfs interface for DAMON. The user space admins @@ -68,8 +68,9 @@ config DAMON_DBGFS If unsure, say N. - This will be removed after >5.15.y LTS kernel is released, so users - should move to the sysfs interface (DAMON_SYSFS). + This is deprecated, so users should move to the sysfs interface + (DAMON_SYSFS). If you depend on this and cannot move, please report + your usecase to damon@lists.linux.dev and linux-mm@kvack.org. config DAMON_DBGFS_KUNIT_TEST bool "Test for damon debugfs interface" if !KUNIT_ALL_TESTS From patchwork Thu Feb 9 19:20:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 55070 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp527430wrn; Thu, 9 Feb 2023 11:25:10 -0800 (PST) X-Google-Smtp-Source: AK7set9RZf4T1EO6EJAb3rtplQiuoDwWZ263MX0O195mwbYZAKkCMqPiGf7ZhYEbXqjsIQyn4mJk X-Received: by 2002:a17:906:db0b:b0:8ae:80d5:7385 with SMTP id xj11-20020a170906db0b00b008ae80d57385mr9661093ejb.10.1675970710152; Thu, 09 Feb 2023 11:25:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675970710; cv=none; d=google.com; s=arc-20160816; b=m8UwvmzkV8PMErz7X3bht+LVqWK/amvs/iUo5zbOceZJ36okdwoFgEvAEK7nVNUayW U3y8HnKRhgR1hX/X9JxUmHaGYHitXB7YESjttuHKkl4m6t+fJo+oCsftGKhJB387r4Oy tlKLPnM1IR8+6/K3j6t3jqcVtwZ0QEOwlDR9ACp1HyhHdg+Z9gCXuzWwI/wK9v+HLesU BadwXAQNCWjn5lO4JNgCPeUXigTnKO2HDtCE+lJBplGfkj/9HW2eWbsxtniuc5DsjxeD fGvi6sKYYixMOgf3bcX4zwBzQRoV4ABQiCE8W7kZ2NRf1zT/wN2Jx37oAFDx1/I8KQ04 +Hcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=v/ZbcDDyGp1GCgR/7hYyVbx4tuFen8J1znyyD4wVL8g=; b=Nm1GfAe9KH4zOxEzX37bmQ7z65lO3yBQJwHtYVM71x+QBF5Sm6CgbRMOALOFWTlRom bhElngPhwgB82FEad+R16dol9vfqVl1NbZTE7dxZsIVirFKmhzZWipO+G6dc1Rgt/V/n xv7IA8Gk9xtRmpJ19psNlFVAEiWdJ37PRqRi+al+w8eiIBH0BIi2TsfIlKvywJYP047H O/2I/qC1rh7YnMul/Bbwrz08iYqYQqfg5px46PXoGSg/9SHmbfKYFEl1Qr082j1GbnwJ TU7uJ4lyF26PeMr+ZTwWXFo1mEvHpqtwHMM3racAUNCxp3N7ghinRBQrGvwRVw4FqFvp Lqbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YNwNncax; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fx33-20020a1709069ea100b008778ad3ca00si3495240ejc.234.2023.02.09.11.24.46; Thu, 09 Feb 2023 11:25:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YNwNncax; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230084AbjBITUV (ORCPT + 99 others); Thu, 9 Feb 2023 14:20:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbjBITUS (ORCPT ); Thu, 9 Feb 2023 14:20:18 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEF625356F for ; Thu, 9 Feb 2023 11:20:17 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6BCC361BB5 for ; Thu, 9 Feb 2023 19:20:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C11FC433A1; Thu, 9 Feb 2023 19:20:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675970416; bh=YKnuEvRI6qfPAJO2dUUkfnH+bQPuZPD2yzEq+Lx0+z4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YNwNncaxqJtNLK1jiU8L7oyV++uilfm1Jne4U3kLLB385NSqtdiYkJ9f+YuB4rOdK r8irMblAq+as8w9prFXzUhRqT+sN+Q8MUOX4T2Cct1ET47M1Wj8YGIxL9yvdIt+GQX tJrmah8kxg9jC8ep0z3I06JWRIl1Y652uHmKIWsjWEVZ6cbkf3A7U5L3N//AQDz4Xf FbHuAgyGYxo05IvYJnqmOh72HjluzjCiL/YsfqTdGsa9yqVhZU0WXMzbM5FtgWLRj/ 7SfnQPPzftZC0eIW4SR3pZgk8QhRJV6q5mTmj6nX2NU2shlUhkKAdA36QETg86+6oi wWowqMT+cl1zw== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] mm/damon/dbgfs: print DAMON debugfs interface deprecation message Date: Thu, 9 Feb 2023 19:20:09 +0000 Message-Id: <20230209192009.7885-4-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230209192009.7885-1-sj@kernel.org> References: <20230209192009.7885-1-sj@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757382663326578860?= X-GMAIL-MSGID: =?utf-8?q?1757382663326578860?= DAMON debugfs interface has announced to be deprecated after >v5.15 LTS kernel is released. And, v6.1.y has announced to be an LTS[1]. Though the announcement was there for a while, some people might not noticed that so far. Also, some users could depend on it and have problems at movng to the alternative (DAMON sysfs interface). For such cases, warn DAMON debugfs interface deprecation with contacts to ask helps when any DAMON debugfs interface file is opened. [1] https://git.kernel.org/pub/scm/docs/kernel/website.git/commit/?id=332e9121320bc7461b2d3a79665caf153e51732c Signed-off-by: SeongJae Park --- mm/damon/dbgfs.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c index b3f454a5c682..e551a20b35e3 100644 --- a/mm/damon/dbgfs.c +++ b/mm/damon/dbgfs.c @@ -20,6 +20,11 @@ static int dbgfs_nr_ctxs; static struct dentry **dbgfs_dirs; static DEFINE_MUTEX(damon_dbgfs_lock); +static void damon_dbgfs_warn_deprecation(void) +{ + pr_warn_once("DAMON debugfs interface is deprecated, so users should move to the sysfs interface (DAMON_SYSFS). If you depend on this and cannot move, please report your usecase to damon@lists.linux.dev and linux-mm@kvack.org.\n"); +} + /* * Returns non-empty string on success, negative error code otherwise. */ @@ -711,6 +716,8 @@ static ssize_t dbgfs_kdamond_pid_read(struct file *file, static int damon_dbgfs_open(struct inode *inode, struct file *file) { + damon_dbgfs_warn_deprecation(); + file->private_data = inode->i_private; return nonseekable_open(inode, file); @@ -1039,15 +1046,24 @@ static ssize_t dbgfs_monitor_on_write(struct file *file, return ret; } +static int damon_dbgfs_static_file_open(struct inode *inode, struct file *file) +{ + damon_dbgfs_warn_deprecation(); + return nonseekable_open(inode, file); +} + static const struct file_operations mk_contexts_fops = { + .open = damon_dbgfs_static_file_open, .write = dbgfs_mk_context_write, }; static const struct file_operations rm_contexts_fops = { + .open = damon_dbgfs_static_file_open, .write = dbgfs_rm_context_write, }; static const struct file_operations monitor_on_fops = { + .open = damon_dbgfs_static_file_open, .read = dbgfs_monitor_on_read, .write = dbgfs_monitor_on_write, };