From patchwork Thu Feb 9 16:24:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Brugger X-Patchwork-Id: 55048 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp439731wrn; Thu, 9 Feb 2023 08:39:25 -0800 (PST) X-Google-Smtp-Source: AK7set/jQPuc/mtgD0sfCLhC2BtMvY0Wb+tzrdy8nsjWr2JHo0ndjsHltIC64EMqwDY5u822xZqS X-Received: by 2002:a62:38c8:0:b0:5a8:19f6:fe31 with SMTP id f191-20020a6238c8000000b005a819f6fe31mr2365734pfa.1.1675960765041; Thu, 09 Feb 2023 08:39:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675960765; cv=none; d=google.com; s=arc-20160816; b=fo3eFpx2rXDiV1UzjWQvsgWP4i83IdA7QUk7k1/edigMqy1JsdWOdEyDjJ8pYIZRVp JMy0lEZu8swmEj6Qg8+DUMOyDK7FIULfcCiHXZPuI6Wb33wKUTfMJqSpqH+zP5BxrFPS kqHDZoDvVbWqHbNu+ddyfBUt7oiR+RKURz8Hl8uHDiA92nmj4UeVEm+KSDUN8bfEzkgG ZBPhnnIV9GFMpT+YA3tlrSkYFmmgZYkU4ohTAn5YbiKVVPJZdcW3Z3MRb1esndWTYvlr ak/jr38g4CeVyfblZ8tzVY+SCndKd6SqkIKUap3VN9X/fQBmEeQBom7KUWDt6bajeujZ kv5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=5nOJyxJwVyTDsDVXocGIO+17IABv/8jaO6RNufzijKY=; b=dr63D/4q7qOjRoEbolAUiRehmirCfZrMhn6N1nHyoY5CJmvskMAseNBKWyLYrjpTGF O2SMPS+D0Y6vAOoHq0nb74DgzQbU07U1nTHyC8LEtmsvVPQY2tipYQPqY38jFArByt8s LA6gZDlwZ/+pcmG/fSvh9qU/vT+JjBMx8Z81b0wMXHsJ/kxExW3v1KnPGUwx6uJs7LmH G09RcDdn5bmX4ZOjDZPSJ5hBLcM3AjpFodqh01Y2dBngugbIdha4isJYW+7xMrao2iea I6FH6iU6kXa6amotTrHQnAgpUVrBu6SPUDz8tuYd6ljAXsu0x+wPkoovwmXSDhDPvMcI 113w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Sny2gS7Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 66-20020a621445000000b00593e4d2bd75si2160241pfu.227.2023.02.09.08.39.12; Thu, 09 Feb 2023 08:39:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Sny2gS7Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229572AbjBIQYZ (ORCPT + 99 others); Thu, 9 Feb 2023 11:24:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229592AbjBIQYY (ORCPT ); Thu, 9 Feb 2023 11:24:24 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41AF622035 for ; Thu, 9 Feb 2023 08:24:23 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D397AB82212 for ; Thu, 9 Feb 2023 16:24:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA9E3C433EF; Thu, 9 Feb 2023 16:24:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675959858; bh=ylKCMMud2Zsh10OZZ6A3WtVHDEvxQmFf8psavqmf5og=; h=From:To:Cc:Subject:Date:From; b=Sny2gS7ZYNfyI4GtLmyH+FcNKMId23prYAZLOUStaE3eMwh+J2MfIfdo3ms3wZh+U QtI8VFiTLOemvDMhLt9s/XnHGvp7Npxj8OoJjy99++imPHPj6CK7f3S9S1MFB6tlzF Ae1itnhlSaJH/szbTGshwlx9uVtBMb3ccBGe0vS5WP+gMTIhjeG7kcAQ0OWRAB2kqG L4m1Do7Gxwbqps57FO1yDF6cpZ5YYkN0F7KUokdbBdlGVSH0JxzRnDUgh3ifo42NpR 6MwFXsNoyIZEQdctQcYa/09b6rNo6/GwegaB6zCviJPzuBeC2EhJLC4ArsMggEgDHc 0t4+FZWvCmP+g== From: matthias.bgg@kernel.org To: matthias.bgg@gmail.com, roger.lu@mediatek.com Cc: nfraprado@collabora.com, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, angelogioacchino.delregno@collabora.com Subject: [PATCH] soc: mediatek: mtk-svs: delete node name check Date: Thu, 9 Feb 2023 17:24:03 +0100 Message-Id: <20230209162403.21113-1-matthias.bgg@kernel.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757372235392669301?= X-GMAIL-MSGID: =?utf-8?q?1757372235392669301?= From: Matthias Brugger The function svs_add_device_link is called only internally from the SoC specific probe functions. We don't need to check if the node_name is null because that would mean that we have a buggy SoC probe function in the first place. Signed-off-by: Matthias Brugger Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Roger Lu --- drivers/soc/mediatek/mtk-svs.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c index 299f580847bdc..a7eb019b5157d 100644 --- a/drivers/soc/mediatek/mtk-svs.c +++ b/drivers/soc/mediatek/mtk-svs.c @@ -2027,11 +2027,6 @@ static struct device *svs_add_device_link(struct svs_platform *svsp, struct device *dev; struct device_link *sup_link; - if (!node_name) { - dev_err(svsp->dev, "node name cannot be null\n"); - return ERR_PTR(-EINVAL); - } - dev = svs_get_subsys_device(svsp, node_name); if (IS_ERR(dev)) return dev;