From patchwork Thu Feb 9 08:55:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guillaume Tucker X-Patchwork-Id: 54806 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp219716wrn; Thu, 9 Feb 2023 01:00:06 -0800 (PST) X-Google-Smtp-Source: AK7set8jjmYfXriD6ewMuen6Y7aZTMlE0Rcykwnr5vp+DZaHS4mftblBsn1CPGq+WpzyEJI/NXpX X-Received: by 2002:a17:907:8d13:b0:8af:2cf7:dd2b with SMTP id tc19-20020a1709078d1300b008af2cf7dd2bmr3433650ejc.13.1675933206367; Thu, 09 Feb 2023 01:00:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675933206; cv=none; d=google.com; s=arc-20160816; b=TXU2yED4QjEjsmTpSkPf6UqmwEb5cgw7a8sVf2KG6+9TR7v5KjEJQpzv1s0Q25lljH KVyPgjn+GUMsp6rCiuCTGWdvgzpvwE1sLMcRON3MbbX464ksVek0snaUQ5M7w9tVCplO 10w4dfGgzRL1bQVefQNz1QlfSNXEEymrVRqj6aYr/fWz8hffwVbWrx9NI5cqGGUFDTlF 60lvKNOufSVdd0VpWYQSfdqu680l+9fkGbAlg0V5o9vmoSKJor649jZatqsJQAEzcsVF ipo0xv1UHSCdhqymN26OOF45rbMIQ3E/axri898XZw8ZLxTgXtkBn9FsNHG1KpaeasEL ZQzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=pQVFj+y6HYijx/5YEemiZDGnwssIpFwMBJJ9brcquQU=; b=FTIiJs63+zP5amiacoCXo/TGuGOpGonJH8JPMiVrABhOSpinPiNl45OyVYT/OlN7jS Sje64FEYcHlQaxQLv4xSf2nkUCWs/389+qRFVWX/GS4LD7IxYq2renw3MhQbW8MJS6cd KmnD+l7UCr/RHQ5eSt4wHJ2zHePwHz6zYUcpcrMEqdhnlnoM0aQbeWWS64HJDCBCJ9lf mnGklmExslgPSmdY0uyoD5tMGCKGfButMKMw26dtDJJEX/NyrhYZpaD7i8LwRVgmTAbL w/ZqdGap8ZaJBx9W6Iy6Jk60Mu+yQ7pomQmRjoVIqXDNLFUluXXwukV2xEXzvnjbCn5g C6hw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=VB2WWYTp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cq10-20020a170906d50a00b0087a14964095si1649025ejc.812.2023.02.09.00.59.43; Thu, 09 Feb 2023 01:00:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=VB2WWYTp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229801AbjBIIy4 (ORCPT + 99 others); Thu, 9 Feb 2023 03:54:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229476AbjBIIyu (ORCPT ); Thu, 9 Feb 2023 03:54:50 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11BD853E5D; Thu, 9 Feb 2023 00:54:50 -0800 (PST) Received: from tincan.lan (unknown [IPv6:2001:861:4a40:8620:46d9:3185:bc09:aecb]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: gtucker) by madras.collabora.co.uk (Postfix) with ESMTPSA id 9349266020B9; Thu, 9 Feb 2023 08:54:48 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1675932888; bh=vbnRXiU+r4c7lvYMbX38+Jok/UNcPnjR5Ne1oApjqZU=; h=From:To:Cc:Subject:Date:From; b=VB2WWYTp77n8ycy6ogtmSPtYStA4SHrxRDYimXiBgm2u3/9b2202H5BFiAkaYL5pv B3xXlmNMdE+v+VEAIWCfckf9tJAf1xHxt/90wU2OgfqTs08OxBKzRLtMDXjvIee6Hb airsB87vt3axe4qUe6k03OdamDha3R023xjKdpL/kMnfD39hZwwAT66WSwiTcMOBQM Wr8gwgCTxGwqsAiLm/bGyLc1wZN/q5HONco9swpH8+Cew5urZEn5Mtx4MXz/303UDy Shx87ijZ87Al8vXDIySHyDV4AByv38cC/YLTcS/VsEgR5Ct9PTmz+OF/7YN/lnoZuF tgkS7RkGUMyKg== From: Guillaume Tucker To: Shuah Khan , Gautam , David Laight Cc: Guillaume Tucker , kernel@collabora.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kernelci@lists.linux.dev Subject: [PATCH v3] selftests: use printf instead of echo -ne Date: Thu, 9 Feb 2023 09:55:36 +0100 Message-Id: <20230209085536.1076662-1-guillaume.tucker@collabora.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757343337744126893?= X-GMAIL-MSGID: =?utf-8?q?1757343337744126893?= Rather than trying to guess which implementation of "echo" to run with support for "-ne" options, use "printf" instead of "echo -ne". It handles escape characters as a standard feature and it is widespread among modern shells. Reported-by: "kernelci.org bot" Suggested-by: David Laight Fixes: 3297a4df805d ("kselftests: Enable the echo command to print newlines in Makefile") Fixes: 79c16b1120fe ("selftests: find echo binary to use -ne options") Signed-off-by: Guillaume Tucker Reviewed-by: Guenter Roeck --- Notes: v2: use printf insead of $(which echo) v3: rebase on top of fix with $(which echo) tools/testing/selftests/Makefile | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index 9619d0f3b2ff..06578963f4f1 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -234,11 +234,10 @@ ifdef INSTALL_PATH @# While building kselftest-list.text skip also non-existent TARGET dirs: @# they could be the result of a build failure and should NOT be @# included in the generated runlist. - ECHO=`which echo`; \ for TARGET in $(TARGETS); do \ BUILD_TARGET=$$BUILD/$$TARGET; \ - [ ! -d $(INSTALL_PATH)/$$TARGET ] && $$ECHO "Skipping non-existent dir: $$TARGET" && continue; \ - $$ECHO -ne "Emit Tests for $$TARGET\n"; \ + [ ! -d $(INSTALL_PATH)/$$TARGET ] && printf "Skipping non-existent dir: $$TARGET\n" && continue; \ + printf "Emit Tests for $$TARGET\n"; \ $(MAKE) -s --no-print-directory OUTPUT=$$BUILD_TARGET COLLECTION=$$TARGET \ -C $$TARGET emit_tests >> $(TEST_LIST); \ done;