From patchwork Wed Feb 8 23:14:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 54635 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3741158wrn; Wed, 8 Feb 2023 15:14:37 -0800 (PST) X-Google-Smtp-Source: AK7set+wXs9Psb8t3oks06DOm70SrTwiw99/w5eYeaakaqf/7z5I418euLdlq2cjC3iaVWt2s7M9 X-Received: by 2002:a50:bb4e:0:b0:4aa:b40d:e0a3 with SMTP id y72-20020a50bb4e000000b004aab40de0a3mr9572155ede.34.1675898077193; Wed, 08 Feb 2023 15:14:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675898077; cv=none; d=google.com; s=arc-20160816; b=E+ZicZPXg0UXiqgPh8cb4Ui82R35wJZXbjiEOIgrg9Wl0KHOe9McYzObGAmJ+NKMIG moZRO4bRFHmDt5r5hoHjko0nkJlveXCPBES1OwBTtp31siw2xJg8DhBkVAQgY3Yh5p6z /+jBMnZ/3xY1KLj+CSfjf7GhKPCN8zjc89tzroybWQqCDgax5WBSk1qwi7lV8gAPV+Lv aDxZ3fDETsh5YnrAUpYPffUtlz4DjvPD70cJKjbaA5wDmWF1ufp6gpQDJ2TQrDPUhox+ HkFomqSPQB5DTjUfkt/e6es9Oy78q413vqlQcOSeRJocl6M+Z3v+k7pBdnjhACtUScx3 L3rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=ym57lUnHHdLU5DZ9bA/gfTaKfYr6BA19/xSTw2m9eNs=; b=KK9BXdaJ43+kshwsTGf07CFY6P1jgzvWiYgmTPFc11+MFBuWRMYhmL+mJgChUdlH6F 0Rs8a17JQMfshgvNFbvyYc+m/VNtDy0fbWk85+OyZS+qm7+P68a3pQEcgTWnw//aUn/s /6A2IKr/qnUaY/9P8qZG/eCX6J+ZcKHKVDeM52BIXAxP1FLO09kOXPRqtgMvlCqiVTMb utbOtTrgM9OefjWKxB+Ka1jq9etbfz8Q465I6CWh9wqRD2kVSV2ePqkkUISoJpnbg6/P ijHCiEcgCfacyQ0Emo5FtXwuvyizzSV87pfkLsJGzd95B+dDvOP1X/FAvntJXYOtrHbf oANg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=IhwFlMpu; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id e13-20020a50fb8d000000b004a5840f7641si58940edq.117.2023.02.08.15.14.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 15:14:37 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=IhwFlMpu; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D7B2B385828E for ; Wed, 8 Feb 2023 23:14:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D7B2B385828E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1675898074; bh=ym57lUnHHdLU5DZ9bA/gfTaKfYr6BA19/xSTw2m9eNs=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=IhwFlMpuAr4sEB7wVQMmBhm8BpQ7HB8qXogvXe/DAdKvD5RH/fI4e5JodPjVAlxbU 3GXI4igeb0JGwU5Wwj2cjlvEh3+J0qbmPuBuSEqSqkm43b2hACUyoT0MVt+Lq1yOGM bVTvwT2cNM2VWJOg9a5ewejImq5md2up563ZkNJk= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id AB8A83858C60 for ; Wed, 8 Feb 2023 23:14:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AB8A83858C60 Received: by mail-pg1-x533.google.com with SMTP id v3so433384pgh.4 for ; Wed, 08 Feb 2023 15:14:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ym57lUnHHdLU5DZ9bA/gfTaKfYr6BA19/xSTw2m9eNs=; b=XKp+QT8GLUNW+CWH07n79f/LigWU0N/FwrPpUImbkuE3wz6mPcI6U86Tk5CRSIu/vU 8lg7nOMUC8yMNSqjNhfEoQm+04/Lo9l+TvrF4P8o6Opg0CKpZ5RWetMGjwg6+QNCLr8G vsG6aq5wQTd2v2vqN0Atdww8tRJajxEfPNuHnJc9v9GN5gGHSBMT8KRlj9vDNzomBRAB 7Zf0unKPkI2MKEC1pqGZVi8jB5NsKAFcTLTHds9Fel+PcNbsWwgg0vFI9DHEOzANd3aT cjqeqZWA8v1JBrH/r8sLm/pcmrivrFQZ95w+IY+xxSie0PH1bo0+xu1sO9KxqlzfhiR6 2cVA== X-Gm-Message-State: AO0yUKU2+4WJPA8vFzM97w0BnIpcXsHaOfyS3Qi+cQ/Tz1vUiRS2FuSM rF+lU79ZV+boZwmKf4KSVyf+WY8ttVc= X-Received: by 2002:a62:19d0:0:b0:5a8:455a:694f with SMTP id 199-20020a6219d0000000b005a8455a694fmr3262396pfz.4.1675898065584; Wed, 08 Feb 2023 15:14:25 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:2c19:e063:cb3b:da4]) by smtp.gmail.com with ESMTPSA id b205-20020a621bd6000000b0058bc37f3d1csm11774985pfb.44.2023.02.08.15.14.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 15:14:25 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 186821142D73; Thu, 9 Feb 2023 09:44:23 +1030 (ACDT) Date: Thu, 9 Feb 2023 09:44:23 +1030 To: binutils@sourceware.org Subject: coff-sh.c keep_relocs, keep_contents and keep_syms Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3035.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757306501834558093?= X-GMAIL-MSGID: =?utf-8?q?1757306501834558093?= keep_relocs and keep_contents are unused nowadays except by xcofflink.c, and I can't see a reason why keep_syms needs to be set. The external syms are read and used by sh_relax_section and used by sh_relax_delete_bytes. There doesn't appear to be any way that freeing them will cause trouble. * coff-sh.c (sh_relax_section): Don't set keep_relocs, keep_contents or keep_syms. (sh_relax_delete_bytes): Don't set keep_contents. diff --git a/bfd/coff-sh.c b/bfd/coff-sh.c index cc6faac4e80..314b796ac8b 100644 --- a/bfd/coff-sh.c +++ b/bfd/coff-sh.c @@ -905,12 +905,7 @@ sh_relax_section (bfd *abfd, the linker is run. */ coff_section_data (abfd, sec)->relocs = internal_relocs; - coff_section_data (abfd, sec)->keep_relocs = true; - coff_section_data (abfd, sec)->contents = contents; - coff_section_data (abfd, sec)->keep_contents = true; - - obj_coff_keep_syms (abfd) = true; /* Replace the jsr with a bsr. */ @@ -1027,12 +1022,7 @@ sh_relax_section (bfd *abfd, if (swapped) { coff_section_data (abfd, sec)->relocs = internal_relocs; - coff_section_data (abfd, sec)->keep_relocs = true; - coff_section_data (abfd, sec)->contents = contents; - coff_section_data (abfd, sec)->keep_contents = true; - - obj_coff_keep_syms (abfd) = true; } } @@ -1435,8 +1425,6 @@ sh_relax_delete_bytes (bfd *abfd, if (val > addr && val < toaddr) bfd_put_32 (abfd, val - count, ocontents + irelscan->r_vaddr - o->vma); - - coff_section_data (abfd, o)->keep_contents = true; } } }