From patchwork Mon Oct 17 12:08:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 3411 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp1409760wrs; Mon, 17 Oct 2022 05:10:23 -0700 (PDT) X-Google-Smtp-Source: AMsMyM49j4JxNte6xmgz67WGDumrGPOAlTRjT8z+ytVNMgOuCa1q9A5swT5D5B1loSrRXF6IJdSA X-Received: by 2002:a17:907:788:b0:741:4d1a:595d with SMTP id xd8-20020a170907078800b007414d1a595dmr8245679ejb.737.1666008623541; Mon, 17 Oct 2022 05:10:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666008623; cv=none; d=google.com; s=arc-20160816; b=g9Ifn5a43OyzAA2jt+2BhX2BgEFFRxXCsvDN7Q2d0OtQFaxzUkVgUGcCZ0vB2vc1bM wROo6BuO5u4OBEnuJ/3DQkk831T7pOakyDvNMO8rbDvSjJDiciNp7EWOA1Zz65BPN0qj AtnSWyHJRgakD+AXYonOI0601kmQv2jcVOC3NXCSFJC6ydar3BcswlL8KQ9fzfKTFeA+ 6LT2yl5vCsx+0MY/ALiRHsNDFsewNBeOUSPmGLQ8ulz0MbrjYbRhiEEBxKVBqMqAo0D5 QbK2L9pCA2JCVLW26b8zI9xNgA5YV9agMu0XuqUoYt50HJCIoBCvSmyT+fGkxd9PIvjv 1NIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version:message-id:date :user-agent:references:in-reply-to:subject:to:from:ironport-sdr :dmarc-filter:delivered-to; bh=cfjxMj0Vv0KHtkZ3EQslPDhtykGq4jDAn2JFI+Pyxfg=; b=YjaEJancEQ22dBScBfvXhpRwwr0NvRjP9BVwizssYbdoQ9lSs1GEx+4HsBa9cTZiD2 4+TlS0DijxGb8iI20XD3/DYIN2XF83XQrYEmlpIUnEUHxZRRhz6RlnugmNLA9z5ec/4E jv2qjWa7YmrjObUtJQjqVeIp/G8O8+93QZYnzkA+i2PlpXCgH87iHQq/ret3Jr5jhDsw Qq1Aa9YOb9wDfuStkBsQrKDXt9kuOPXZAfM/E187GgMIDyeZQpTINZqPyleHrd/0Xf2e 8BVXE61QA6191oDp45315Rpx9ekO2zV+h4mi6DMls0qRBaQZVravt8VUnf3ZdQ2pHX5V 8nFA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id b9-20020aa7dc09000000b00456964d3369si7617910edu.230.2022.10.17.05.10.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Oct 2022 05:10:23 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 21740385AE4D for ; Mon, 17 Oct 2022 12:09:21 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 77004385735A for ; Mon, 17 Oct 2022 12:08:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 77004385735A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.95,191,1661846400"; d="scan'208,223";a="87684132" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 17 Oct 2022 04:08:55 -0800 IronPort-SDR: 5ADv9LJwu5NT2pSr3qv3jplWqNlG2B/RQTLNzFybFSunKqeGyzuCbdZZ7jkU7Xhblhs6Qt6EH2 IeX2L4205+1ZWl7ePVcWbBFj7d2rG/1IQcD1m+itufRno0nY2bgS8+ljqRZsoAcVqLp9Uc/+E1 9TcSz8gPdizJaA2RQsDXQEWUd2SRgsOIVW6ZwqfDEkaW72A6aszGqHKI2YR84IXAJDhq6IQPIn a5KpSfa2QQAfpKTUKxEmEMIBTqE+MTM1WZDh+jyEIElcSgHo4cpBwKTCSUzJXGm29j74459CT1 VSs= From: Thomas Schwinge To: Alexandre Oliva , Subject: Tag 'gcc/gimple-expr.cc:mark_addressable_2' as 'static' (was: [PR67891] drop is_gimple_reg test from set_parm_rtl) In-Reply-To: References: <20150810082355.GA31149@arm.com> <55C8BFC3.3030603@redhat.com> <55E72D4C.40705@arm.com> <55FC3171.7040509@arm.com> <56382653.4060605@redhat.com> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/27.1 (x86_64-pc-linux-gnu) Date: Mon, 17 Oct 2022 14:08:47 +0200 Message-ID: <871qr6ire8.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-15.mgc.mentorg.com (139.181.222.15) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746936658151715774?= X-GMAIL-MSGID: =?utf-8?q?1746936658151715774?= Hi! On 2015-11-03T02:29:41-0200, Alexandre Oliva wrote: > Thanks, here's the patch as just installed. > --- a/gcc/gimple-expr.c > +++ b/gcc/gimple-expr.c > +static void > +mark_addressable_1 (tree x) > +{ > + [...] > +} > + > +/* Adaptor for mark_addressable_1 for use in hash_set traversal. */ > + > +bool > +mark_addressable_2 (tree const &x, void * ATTRIBUTE_UNUSED = NULL) > +{ > + mark_addressable_1 (x); > + return false; > +} Found already a while ago, now pushed to master branch in commit aeb1e2bff95ae17717026905ef404699d91f5c61 "Tag 'gcc/gimple-expr.cc:mark_addressable_2' as 'static'", see attached. Grüße Thomas > +void > +flush_mark_addressable_queue () > +{ > + gcc_assert (!currently_expanding_to_rtl); > + if (mark_addressable_queue) > + { > + mark_addressable_queue->traverse (NULL); > + delete mark_addressable_queue; > + mark_addressable_queue = NULL; > + } > +} > --- a/gcc/gimple-expr.h > +++ b/gcc/gimple-expr.h > +extern void flush_mark_addressable_queue (void); ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 From aeb1e2bff95ae17717026905ef404699d91f5c61 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Wed, 15 Dec 2021 22:00:53 +0100 Subject: [PATCH] Tag 'gcc/gimple-expr.cc:mark_addressable_2' as 'static' Added in 2015 r229696 (commit 1b223a9f3489296c625bdb7cc764196d04fd9231) "defer mark_addressable calls during expand till the end of expand", it has never been used 'extern'ally. gcc/ * gimple-expr.cc (mark_addressable_2): Tag as 'static'. --- gcc/gimple-expr.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/gimple-expr.cc b/gcc/gimple-expr.cc index c9c7285efbc..4fbce9369c7 100644 --- a/gcc/gimple-expr.cc +++ b/gcc/gimple-expr.cc @@ -912,7 +912,7 @@ mark_addressable_1 (tree x) /* Adaptor for mark_addressable_1 for use in hash_set traversal. */ -bool +static bool mark_addressable_2 (tree const &x, void * ATTRIBUTE_UNUSED = NULL) { mark_addressable_1 (x); -- 2.35.1