From patchwork Wed Feb 8 11:29:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 54414 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3403957wrn; Wed, 8 Feb 2023 03:41:06 -0800 (PST) X-Google-Smtp-Source: AK7set9z3nfZLaalosfTBIvLtixMD+O0aI2J8gD5nKOfTsxEV964klq//smKMO1Z7UoFpqLSTk3C X-Received: by 2002:a05:6402:5205:b0:4aa:a248:a15c with SMTP id s5-20020a056402520500b004aaa248a15cmr8878998edd.1.1675856466491; Wed, 08 Feb 2023 03:41:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675856466; cv=none; d=google.com; s=arc-20160816; b=yJ/+gTqzZYcVmvfP+V8vmPWNS/iaPtBXzgFsYxxeAgWsBj+OBaKyFSya1zTfertHii hnkNDaX/EShxtP1cEevSmpi1rjdGOHu7mfiIj8Pk8j1/gimGx/SeI4RvnVK21z4DSit9 sEJOOGLT1q57t2rkBrutO/ok9a1fosQJtEpKI2/q6P+2/jCow2uufShobj6r+nqRHoEx 9Uq6SMjFagZmen+cZI2azBVXpoYZ29b2Mne0JLkuH1dnYRnVgGKyIcsMSHjIo1SsXerL proULFf47+I7AXrJWo3BpPUbEK8JTQi+26kTL38IGw6TbqyJDHJL3O3+e1q90G5PLmT4 N0WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=LMYWIP1KdS6fUCNtrtjRbmi57RR9qig/f6X3fseaB90=; b=lTOCsD1dvL9h0MuxV4Y2gftuz9RqdlMjC6JArchX8Pfg7kOIMenWqlpdOgqJJRu1Jz 9xDObAUsE+YMXgfyMGjlVNMpJrO7CwJ/DkY7YTwMvDBEz31tPEQYXrIvM/hRBRIKO035 EnqO3QLEcSTVxRBqbQxogf1FX5+kI1+Eg0qqbXtK9+5xx2AIHhYjtpJzNyrdYAZW2Uh1 VzkoAT84Q6fbAFONM416xt9+T4oYD4QbWUN8PVoYU5nABvJbizf59wDI7Fz/nZADb20Q 0/UyXRHo5MHhLWKXYU3G/0NbjhXYOpa0SMjXGSoxva3LBXBR9nwjLvDQzbzicsa8vpG2 BdFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=kRt+Z2N+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b5-20020a0564021f0500b0049ea0e7ae42si18804070edb.393.2023.02.08.03.40.43; Wed, 08 Feb 2023 03:41:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=kRt+Z2N+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231172AbjBHL3b (ORCPT + 99 others); Wed, 8 Feb 2023 06:29:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230305AbjBHL3a (ORCPT ); Wed, 8 Feb 2023 06:29:30 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D904458BB; Wed, 8 Feb 2023 03:29:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675855768; x=1707391768; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=YOp7/xwpRbM1HsVxkj/oLzcILyXmsT17xldYoQVlStc=; b=kRt+Z2N+rjZe0ARRu5Nejljik/nGcBgG9gY9/ckKcc1MqHwZj8AvJZ60 9rdbLwxPZlybM5U0tSb/b4zPVYM8qKh7s/XfBUnX5T1QzsUoQsuSkzDwO wJ0F91YOa5NFsHcprLcLYZegItvbxNv+nFlUXOA4fwy5IncrhF8OV+c8s VE355WGJNSdJo7p3TbjvZBiAypGrEyiyJJPP1tEvjg/Pdo4xpP5p4AC0/ 9V4kam4naacH0CTObwEFu3PG11S4huJzWfWucmBbX/DW5QdDcTbbfL06O YRpfW3vdXdLbn7YpLZIzASkzctMCzQPTrZHIQJT1NqdusazrL7lQ0DuWk w==; X-IronPort-AV: E=McAfee;i="6500,9779,10614"; a="394364469" X-IronPort-AV: E=Sophos;i="5.97,280,1669104000"; d="scan'208";a="394364469" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2023 03:29:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10614"; a="735909089" X-IronPort-AV: E=Sophos;i="5.97,280,1669104000"; d="scan'208";a="735909089" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 08 Feb 2023 03:29:21 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 3EE231A6; Wed, 8 Feb 2023 13:29:59 +0200 (EET) From: Andy Shevchenko To: Sakari Ailus , Laurent Pinchart , Alexander Stein , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Manivannan Sadhasivam , Mauro Carvalho Chehab , Andy Shevchenko Subject: [PATCH v1 1/1] media: i2c: imx290: Make use of get_unaligned_le24(), put_unaligned_le24() Date: Wed, 8 Feb 2023 13:29:57 +0200 Message-Id: <20230208112957.15563-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757262870504507596?= X-GMAIL-MSGID: =?utf-8?q?1757262870504507596?= Since we have a proper endianness converters for LE 24-bit data use them. While at it, format the code using switch-cases as it's done for the rest of the endianness handlers. Signed-off-by: Andy Shevchenko --- drivers/media/i2c/imx290.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c index 49d6c8bdec41..330098a0772d 100644 --- a/drivers/media/i2c/imx290.c +++ b/drivers/media/i2c/imx290.c @@ -16,6 +16,9 @@ #include #include #include + +#include + #include #include #include @@ -466,18 +469,20 @@ static int __always_unused imx290_read(struct imx290 *imx290, u32 addr, u32 *val return ret; } - *value = (data[2] << 16) | (data[1] << 8) | data[0]; + *value = get_unaligned_le24(data); return 0; } static int imx290_write(struct imx290 *imx290, u32 addr, u32 value, int *err) { - u8 data[3] = { value & 0xff, (value >> 8) & 0xff, value >> 16 }; + u8 data[3]; int ret; if (err && *err) return *err; + put_unaligned_le24(value, data); + ret = regmap_raw_write(imx290->regmap, addr & IMX290_REG_ADDR_MASK, data, (addr >> IMX290_REG_SIZE_SHIFT) & 3); if (ret < 0) {