From patchwork Wed Feb 8 04:00:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qi Zheng X-Patchwork-Id: 54172 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3246713wrn; Tue, 7 Feb 2023 20:25:58 -0800 (PST) X-Google-Smtp-Source: AK7set+8ULasOiEys7PxuSwr/WAWOjmlCjXBQ2lgVHlQqe7clIq7mR/aHN9DceoRU9ffz4WyzT1L X-Received: by 2002:a17:906:d28e:b0:878:7449:429f with SMTP id ay14-20020a170906d28e00b008787449429fmr5903832ejb.16.1675830357866; Tue, 07 Feb 2023 20:25:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675830357; cv=none; d=google.com; s=arc-20160816; b=a/TiRUB8M3sm0VWLmE9YoKceacmWrNppArru3XoKca5uUAaOm/B4AjwY0KJQgT9/De yYNYWd3LDChLIFqiKFFc2CHIIloALKGqRvAh344AcE/LkQUKCUxlF8UPMPrheFAoXQHa +Avo+woj8AB/WE5Brg4rRXo4kYodwvr97h6Inehn/uyBviqFgpVmi0ic994zSCgYxDut s7r83QAvyr4aSlv8+WlBlGGymd9naEGd9iDp2QSgjIwV6xizcWheQ5bng51E4NBh8Axv 8D9uo6/AmmE5wMXpfi/fvmhoxnpU/xmwWKCHwTJrVR/elFr/mrLxNqbQafhdfDmyG/eZ Cp9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=HrSasTHUWHyknm8t+OqzpF7esMFl5X5VPv7s+9gtrSQ=; b=I1gA/Xfb++ZZFrhlHwcRvS+9UGbDatNohOojl1eyRz7YKe9PoFVw4XYw5Ymw+sIS3O GxNztmyA6vEd236HfzCzD2jIrTsJe/xndWyt3379Yai92WtGhSBrGFk62OWV0qsQqnZ5 FG2mHHo/IP7tuuDXCyQGbuFZvsvw6rhD7IcVqh43XqdXL2ujnC/RxiYPu3Uyd/FQWtqO PTSLPrgMwNOvKdwYyO//nV5R/515MKTXbHnOqzZzHSjn9EPKSOWXdxbHDOBuwAUnz3Aa Bv3Wtrq/tnjQ6yGDiYx4PyT/nMvnjljY6SfpFTyIidl6u/YatZTSFBqUqmaGBPqUHmdg MiVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=yYLsC+a9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s7-20020a170906220700b008858aea48acsi22073988ejs.103.2023.02.07.20.25.34; Tue, 07 Feb 2023 20:25:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=yYLsC+a9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229894AbjBHEBP (ORCPT + 99 others); Tue, 7 Feb 2023 23:01:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229557AbjBHEBN (ORCPT ); Tue, 7 Feb 2023 23:01:13 -0500 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEB5423661 for ; Tue, 7 Feb 2023 20:00:46 -0800 (PST) Received: by mail-pl1-x631.google.com with SMTP id r8so17936784pls.2 for ; Tue, 07 Feb 2023 20:00:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=HrSasTHUWHyknm8t+OqzpF7esMFl5X5VPv7s+9gtrSQ=; b=yYLsC+a9foAgx0/qG8Tynxa2rhnjlf4m5wChT5u7ipx2Pv7z7GJg7Fhuaj+HXPgLmc IK93iXYHKD3TDgXWyIh/N1lLqhMwjwXdcVe4e6UQiRxWpB4HvvcU7F6z24IHrBr/jq1q sJRBVKkXc+Jx9FMfiMdVQcXgJ5kDOPZ6U7VNISWtNtFidCktQCxbHPnen/2hWNCpuZAJ Tn/qQOS1joFqlima6k1jSIKJF28c79UJSGv2ZXdNNIyM/xSTD2h88B4Mmoa19A/9s+sG i0z6m7moGYBvsxE6dNc2uVDxvDYKW50H+sc4Wl7V2t3On7dbKLK3og4TskrjE/FZM2rn Suzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HrSasTHUWHyknm8t+OqzpF7esMFl5X5VPv7s+9gtrSQ=; b=u7UElZ1ENpVNq87Y0QnPp5r9IixoLIBZVIbsgsL4orxRE6Va56hzcaPqaniV1JImid hdqH3x6+VeZ3R+2Q9tyh/1RBR9rvgfhjSBrzRw9dDMiBYof76bPQEGKeLfkrde3xhtsm tuVc+3e+qj4Riqn8uJ7FOWvhuUSdASNFi5mbXGfqfAUA4Hfdf2nLLQK5UsdY4KgE+C+H hMbLqU0dqzZLvEM0jwsXYSusGwn4caT42AQak2UVRkQr8c9ezW3dggxAJbqofJJ++Vmu rdiv1v7W1ibWJ+nJKtEZTXtzzlXqnVTsTlQ+xrA3YNjnBRomWla7M5dKaRnNHL+cFh+Y NM4Q== X-Gm-Message-State: AO0yUKU/6+h+/hrgpS8SBbMdyk+KlIH0pXJPGKr2HkeVk+OAc+SK1Dwf 2+FQOhp88BO21ysczSj8aRcsOQ== X-Received: by 2002:a17:902:d505:b0:198:e8c6:859a with SMTP id b5-20020a170902d50500b00198e8c6859amr5908845plg.0.1675828846121; Tue, 07 Feb 2023 20:00:46 -0800 (PST) Received: from C02DW0BEMD6R.bytedance.net ([139.177.225.226]) by smtp.gmail.com with ESMTPSA id p6-20020a170903248600b00198b0fd363bsm9753879plw.45.2023.02.07.20.00.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 20:00:45 -0800 (PST) From: Qi Zheng To: vireshk@kernel.org, nm@ti.com, sboyd@kernel.org, gregkh@linuxfoundation.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Qi Zheng Subject: [PATCH RESEND] PM/OPP: fix error checking in opp_migrate_dentry() Date: Wed, 8 Feb 2023 12:00:37 +0800 Message-Id: <20230208040037.60305-1-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757235492958074730?= X-GMAIL-MSGID: =?utf-8?q?1757235492958074730?= Since commit ff9fb72bc077 ("debugfs: return error values, not NULL") changed return value of debugfs_rename() in error cases from %NULL to %ERR_PTR(-ERROR), we should also check error values instead of NULL. Fixes: ff9fb72bc077 ("debugfs: return error values, not NULL") Signed-off-by: Qi Zheng --- Resend as a separate patch. drivers/opp/debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/opp/debugfs.c b/drivers/opp/debugfs.c index 96a30a032c5f..2c7fb683441e 100644 --- a/drivers/opp/debugfs.c +++ b/drivers/opp/debugfs.c @@ -235,7 +235,7 @@ static void opp_migrate_dentry(struct opp_device *opp_dev, dentry = debugfs_rename(rootdir, opp_dev->dentry, rootdir, opp_table->dentry_name); - if (!dentry) { + if (IS_ERR(dentry)) { dev_err(dev, "%s: Failed to rename link from: %s to %s\n", __func__, dev_name(opp_dev->dev), dev_name(dev)); return;