From patchwork Tue Feb 7 20:58:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 54077 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3073802wrn; Tue, 7 Feb 2023 13:01:24 -0800 (PST) X-Google-Smtp-Source: AK7set/YLbuRXoEJpbQ79JO4rUwT3jsnOepUgXanhe/TldJHmhdBgTvfkFMif79vxWTVa0+L/TEj X-Received: by 2002:a17:90a:1a43:b0:229:4731:994d with SMTP id 3-20020a17090a1a4300b002294731994dmr5507355pjl.4.1675803683887; Tue, 07 Feb 2023 13:01:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675803683; cv=none; d=google.com; s=arc-20160816; b=eZHEZDqcYK6AoId6dcGSM1DxXjjKSKl0QPFPfTRt5JrP8DXvkv2nRDqFrvbD8darLN CGJQAdxLfrONUsMkf1+KlB/8YNaK4rZMpsy8Yi06UmC+ZWBPjZvtfpL0UjKl264Kf2NK 2/YTdUWMOE/igiht6LQClPdWhos8lpULrPPmgoKSrcH379+0TgmuccI+4Kkx8Lfyxml9 2w9+iSpvadmN5OVImqmtO9vgJXv+9/cd8eYidTxxOQ3Y9sLm8oacux/3PKq+h7TqAyn7 9HY43XEDSHCYSY7WellXY7imGsv+KOXqwxRzcsIt1vseQp5a2OzBNam5ftdEFvElHMgS 4c3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=PoMfks5Pi2TAoCgRVsoQ1C6g7O43cRdI/G6Mr7ISRn4=; b=ApTUdDdkh2rgXQ0UX+hGhmJ+1r45EeUIOl12/HkRtleBl/c21rFLno0aCUYOwHiww4 +rRzfYIyYTL7hWan33pk5gohp18qZjOE5MphoJzA65zvjWzacUPbW4HLxOSwu6AF2zDq IoDwOiRptPOWQdTfBnVp90PEG0AaOS8dZZbj3M5o6iNtlmzDVwunef1NdPXG21KkueF6 dj1vJ+2pMb7IOIic/8a/2qu0iu84a18x8YD675ZHY/TJ/xej2SWHq9Uz1L5lrsOx1bgL d/0/eSBEQRMQCErZQ+0PxRiucxmGXgqxtKt7NyfDmKorf2WcB45UHcHtXTqgBDB8tuqr hVKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rqB6aQWQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x3-20020a17090ad68300b00229c7de0072si15106326pju.147.2023.02.07.13.01.10; Tue, 07 Feb 2023 13:01:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rqB6aQWQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229822AbjBGU6u (ORCPT + 99 others); Tue, 7 Feb 2023 15:58:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229648AbjBGU6q (ORCPT ); Tue, 7 Feb 2023 15:58:46 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D11C813DE7 for ; Tue, 7 Feb 2023 12:58:42 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id f23-20020a05600c491700b003dff4480a17so1422649wmp.1 for ; Tue, 07 Feb 2023 12:58:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PoMfks5Pi2TAoCgRVsoQ1C6g7O43cRdI/G6Mr7ISRn4=; b=rqB6aQWQXXK0ao4JHOkfgdGuPUpCbCE2deHTaQQffNIrwCaCjse2g8b0W9RZzk5DYF 4OPSf2Ny5DW3A5rqDgqk2VfPJSlS8NQ5iOs/s/md60pjpOqm3Wv5lGN+opgQAz055zbZ dEsY6iu27kXRwanAzT7WfUT1kp0AhEvXZB/9T7QR72HhHO0odF9VHXV3jWTr2Ydo98zf thLTDWrNHOWPciBFNe1eMzLrJ0NPqw7s1s08/STrDABCE/qdy79Vf0DdSl2pXVMpsjSh H8s8X8tfvknB180sxMePHNAkDigo0kbZ9Y3yFpxIgf2wGE/dSaNN4wC0cmVHbnViguta hcOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PoMfks5Pi2TAoCgRVsoQ1C6g7O43cRdI/G6Mr7ISRn4=; b=LoS/xnCPt62EM/TfVkb4tniRAG3QmnsLc2HuZohBFZkhR60y2Z6qfT0TRqAk4+H4QV 2XPIKjZ425qrO7LTAp5/m5Y0p4UNbAOOMG8yNHiaFlQwi1yWnH7F1EAmYM95OzZnXl/d BnW5gIE5mDe/nGQSLpiBX9WMmPRML10Kcmx1bGgX75yNaa/QMUAGgYwnf/eac+m03NwR 7kI1WKAXoOUzh+13KwGwdsMjQMJuEAgG/5aY65rFYhTCEYYkhvKBeZfSwDY4rXnw6zdm XBSpqE8FMaZHSz1qPq5N2kE7vSx2iABQyn5HAUOPI6mw2iVhtpyer+1zQQak+XcK7OzL AsoA== X-Gm-Message-State: AO0yUKUWX90VKXB00FQHxpIcz7o7jLYOCSgeO2wOnu6uOSb3Qh0lR/JI HTsKz/N4b14LA+6UGS8gfuKBPg== X-Received: by 2002:a05:600c:3d0e:b0:3df:efdd:9dc7 with SMTP id bh14-20020a05600c3d0e00b003dfefdd9dc7mr281774wmb.10.1675803521352; Tue, 07 Feb 2023 12:58:41 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h27-20020a05600c2cbb00b003db12112fcfsm16555649wmc.4.2023.02.07.12.58.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 12:58:41 -0800 (PST) From: Krzysztof Kozlowski To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 1/4] media: dt-bindings: samsung-fimc: drop simple-bus Date: Tue, 7 Feb 2023 21:58:31 +0100 Message-Id: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757203304475312293?= X-GMAIL-MSGID: =?utf-8?q?1757207523764707537?= The FIMC camera node wrapper is not a bus, so using simple-bus fallback compatible just to instantiate its children nodes was never correct. Drop the simple-bus compatible and expect driver to explicitly populate children devices. Signed-off-by: Krzysztof Kozlowski Acked-by: Rob Herring --- Changes since v1: 1. None --- Documentation/devicetree/bindings/media/samsung-fimc.txt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/media/samsung-fimc.txt b/Documentation/devicetree/bindings/media/samsung-fimc.txt index 20447529c985..f90267f1180e 100644 --- a/Documentation/devicetree/bindings/media/samsung-fimc.txt +++ b/Documentation/devicetree/bindings/media/samsung-fimc.txt @@ -15,7 +15,7 @@ Common 'camera' node Required properties: -- compatible: must be "samsung,fimc", "simple-bus" +- compatible: must be "samsung,fimc" - clocks: list of clock specifiers, corresponding to entries in the clock-names property; - clock-names : must contain "sclk_cam0", "sclk_cam1", "pxl_async0", @@ -156,8 +156,8 @@ Example: }; }; - camera { - compatible = "samsung,fimc", "simple-bus"; + camera@11800000 { + compatible = "samsung,fimc"; clocks = <&clock 132>, <&clock 133>, <&clock 351>, <&clock 352>; clock-names = "sclk_cam0", "sclk_cam1", "pxl_async0", @@ -166,6 +166,7 @@ Example: clock-output-names = "cam_a_clkout", "cam_b_clkout"; pinctrl-names = "default"; pinctrl-0 = <&cam_port_a_clk_active>; + ranges; #address-cells = <1>; #size-cells = <1>; From patchwork Tue Feb 7 20:58:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 54074 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3073617wrn; Tue, 7 Feb 2023 13:01:06 -0800 (PST) X-Google-Smtp-Source: AK7set8NnxYweEgEeb4cwFGZ8gyp2W9Rjw/EASn1TC9bX0ivHvl6uzJtxf0lrU984oJ4pK4nL+yL X-Received: by 2002:a05:6a20:9f93:b0:bc:44b5:b4fe with SMTP id mm19-20020a056a209f9300b000bc44b5b4femr5232051pzb.33.1675803665933; Tue, 07 Feb 2023 13:01:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675803665; cv=none; d=google.com; s=arc-20160816; b=z8TRDagJL7n8ZfsrOq40EZeftXtt0NR3i+c4YB7sfHydN1msKovthmSCZMjHos+JQf UhBYt3GGpoteJHAjmQdjOD6mtDu12CBRx98IkGfOQFtSYc9newmXstWPm7sSXaypo6bs uxVlKeLvfBezOICW6XrNuEfCJgsMavvfd3CzSDyc7xg3jQx4bhp9qeSiNFhn2YlexosV QbxAtG7Ai4Rk7VwmvLWYffCNHmgnOPYrqjtWtB4UkIpHLrUeCOrqTWr/32BzJCgfsQGU 9fO7pAhjFXcM41j+IKOvD0LX5BEBOHAeylGOcycJ9v7odND18Xfuit6b3cwFj1jtUKAk fOKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Ig92pyMbU2zuSYAVil0uen1pAtlV0COrB7Gvugo1C0s=; b=PlJAU7RodE2VMSxQDOm1H6SzbgcMd5TebXH21unNRXOmxP3qKylpB8xdHBC9283EHx qBZbKDqtFMORo1o35ru5tdp3OyT9GfIQFwYlki91iVdtGCCUFoL3zTKMiYvg1IBGjBcL 6oy7pjxav06jBvV0adOkm2tm7P73GSwA9MPTR1ESNxjjZZW2PEh2LUiiaSYiz9A9hNoI ZBHf6A8QnreNe6vN7+5xuG9UJRz/WFBXIJ0LOvTm0audvwjnVV2kjyeged2/1zCaioWv bc27kuLYHo77A0BGp9GVue0y09p56eCdmzFy5pLa2pRg0U49jFBxEn1TtbNvcQoAVCBg lHWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MUpe8RWh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l7-20020a633e07000000b004e05c115395si16311059pga.8.2023.02.07.13.00.52; Tue, 07 Feb 2023 13:01:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MUpe8RWh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229756AbjBGU6r (ORCPT + 99 others); Tue, 7 Feb 2023 15:58:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbjBGU6p (ORCPT ); Tue, 7 Feb 2023 15:58:45 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD9DC11647 for ; Tue, 7 Feb 2023 12:58:44 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id z13so4466835wmp.2 for ; Tue, 07 Feb 2023 12:58:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ig92pyMbU2zuSYAVil0uen1pAtlV0COrB7Gvugo1C0s=; b=MUpe8RWh84Giqhg4fNSII6pvgNJL95YzWbpB90rqFpF18Il8U42VPn4Dx5x0kgyUPc wRAuaVnM2hQol1S6jcQOVtJK39CV0S+mXCutMqL1BctyduPwifErwRNpngNmU0PnXziD jH4Z1+fruERiY/Cj4x7wVUJH2+rFCF7ITCyRmB0ZuZSNlaHzd6Hp82O5tZ/O7Ck9/7Ax rY+f96I3tng5z1waAUgjaqY4HzR/VJTqp0vubPfIkko6chBuPqF0RCnmqepdvazBC9u6 DHD5IoQ9i9sSTMZ4wrLQIxLBGMdVOKQt1UWMv5/av8D7LR+QZS4ApqUy4oxsZKGQdGiU u78w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ig92pyMbU2zuSYAVil0uen1pAtlV0COrB7Gvugo1C0s=; b=nx1OwxcokdsBS9d/ebSNtQD4n6vHM3yxhcMZtAU+feqyqXlBFiJHtmB8DVSTJ7bCx8 dnuzUlPdiKj1aERgXPewvGVkm6Mo5XUttm5btcrPGyPt+PiuksnBGmBx5q0n7wmzJ9wH PF1BGUJR8Jg/IhqxYBZgvI2PjaV+Ihjdgg7DYAYvjT5r5+L13UDQ7tFlsrZ1AXOJvf7i T3y9iQPO688BjZKRD6RM6bLO+nwsejNqHTScs/A2i4PQ99kTqK3B+6D3CJV9XL9cfOO1 Hwp3Yj8XJmcqODx8L8+5navwwOhF/CymrKDNIpn2PRjIvyvsveZpiraG6HrQSzDoxm8I cEiw== X-Gm-Message-State: AO0yUKWbYSikpnOsTPJUOWzIITpiJj3gXPPOeeWN03mWd3y+bG1q2T0w 0Hg7m4kVQtutN1TMdKYk5Tizbg== X-Received: by 2002:a05:600c:1708:b0:3de:e8c5:d826 with SMTP id c8-20020a05600c170800b003dee8c5d826mr4444405wmn.28.1675803523206; Tue, 07 Feb 2023 12:58:43 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h27-20020a05600c2cbb00b003db12112fcfsm16555649wmc.4.2023.02.07.12.58.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 12:58:42 -0800 (PST) From: Krzysztof Kozlowski To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 2/4] media: samsung: exynos4-is: drop unused pinctrl bits Date: Tue, 7 Feb 2023 21:58:32 +0100 Message-Id: <20230207205834.673163-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> References: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757207504328098134?= X-GMAIL-MSGID: =?utf-8?q?1757207504328098134?= Drop unused pinctrl header and pctrl member of struct fimc_is. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. New patch --- drivers/media/platform/samsung/exynos4-is/fimc-is.h | 3 --- drivers/media/platform/samsung/exynos4-is/media-dev.h | 1 - 2 files changed, 4 deletions(-) diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-is.h b/drivers/media/platform/samsung/exynos4-is/fimc-is.h index 06586e455b1d..c126b779aafc 100644 --- a/drivers/media/platform/samsung/exynos4-is/fimc-is.h +++ b/drivers/media/platform/samsung/exynos4-is/fimc-is.h @@ -14,7 +14,6 @@ #include #include #include -#include #include #include #include @@ -231,7 +230,6 @@ struct chain_config { /** * struct fimc_is - fimc-is data structure * @pdev: pointer to FIMC-IS platform device - * @pctrl: pointer to pinctrl structure for this device * @v4l2_dev: pointer to the top level v4l2_device * @fw: data structure describing the FIMC-IS firmware binary * @memory: memory region assigned for the FIMC-IS (firmware) @@ -262,7 +260,6 @@ struct chain_config { */ struct fimc_is { struct platform_device *pdev; - struct pinctrl *pctrl; struct v4l2_device *v4l2_dev; struct fimc_is_firmware fw; diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.h b/drivers/media/platform/samsung/exynos4-is/media-dev.h index 62ad5d7e035a..079105d88bab 100644 --- a/drivers/media/platform/samsung/exynos4-is/media-dev.h +++ b/drivers/media/platform/samsung/exynos4-is/media-dev.h @@ -11,7 +11,6 @@ #include #include #include -#include #include #include #include From patchwork Tue Feb 7 20:58:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 54072 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3073521wrn; Tue, 7 Feb 2023 13:00:57 -0800 (PST) X-Google-Smtp-Source: AK7set+NupxCHw0wV++smF/mpr2FbK08P6myBH20xmMU1vm0dKR/RX9XIJcVmKwIuRb1yydirjNP X-Received: by 2002:a05:6a20:12ce:b0:be:d368:5c63 with SMTP id v14-20020a056a2012ce00b000bed3685c63mr5740381pzg.38.1675803657247; Tue, 07 Feb 2023 13:00:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675803657; cv=none; d=google.com; s=arc-20160816; b=IkK8wTOZUVEKMqbUnaDmzWopcYYjfWyoaP6Coqa9Sir9Ss2WrYRbh0/J/QgCDViqNW qrQ3Ol3o0+OHfbS+IMlUStgQdKBrjyYTwU5EAmZ0zI7JNQzGkkpkg7wwtIYNmeVhsC0M n09guSZQjjjb63q7Cp9FIDdXJggBxR2L5+xoRBDX+/RFeuvnItRMk8KDSu3u4wVAHdCZ Dl4rM8NiU61JgnfSWEBHKriI7C+ndccuDG71JhXIx8bjJT7H82HSOyOv46ahgMOUgYPo qgvN8dbdPe7xkqezlCDjKxKQDhV6IFhfQAfElCbiVCo9CVzp3Fadt8Z8tKZQzbQ4jzHe BDwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dRrfTafHWOPP66W8TWUXdxmmbu6jMm7VMDj6nUG7ys4=; b=ss0VkBTwj6MMwAj4H2CFqZxsCitMPecAxpP3beza1Ha5L5U921Jw3UFNb6LIyJhmPa UAvlrcqEBAylfQ2k40PbifGa3yki47tzMU90eaV8lha2YKdBR9uuMmJnZdc5i5XA4p1r w4lVr+mhGRROAXk6eAW5ce0/rblqYWStiJmgh1FXjKKZSdVzvkm/q7NXy6vS54iFPN23 n1uAaWiRyKSthqt7FL1XOgVHtvtgOouZLLDYYHymjH6ocu+/r7tPXHssblBUhO6ogEfg c/mP2+oskA0bks6pIeM1F9z5bh4ZOHgraPVQXI50IHLihDiTa98MAzE/kbom3yFNEpjn 3Ucg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DqtTAyD+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s27-20020a63925b000000b004a5c9673b66si16441433pgn.323.2023.02.07.13.00.42; Tue, 07 Feb 2023 13:00:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DqtTAyD+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229781AbjBGU6x (ORCPT + 99 others); Tue, 7 Feb 2023 15:58:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229724AbjBGU6r (ORCPT ); Tue, 7 Feb 2023 15:58:47 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DBE71420A for ; Tue, 7 Feb 2023 12:58:45 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id az4-20020a05600c600400b003dff767a1f1so14864wmb.2 for ; Tue, 07 Feb 2023 12:58:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dRrfTafHWOPP66W8TWUXdxmmbu6jMm7VMDj6nUG7ys4=; b=DqtTAyD+/DfVIXIixTTLeibbPWfARnoKPtZ503G/plOAdpSOZov9AsNRpB3pUQJUCv 5FCNQSbkC0AV7x/c4JKBbGIsoJuPYgqyzs2xF/miMtoLpyWrGtikd+RQT0vvCwpOV1c/ LVTXvBnhyoXTiKlSEA51+3WcZhlTyji8x5IDX0Mn2tghG16exPAaIpGzWridsqZMAxkx VxKKiazE0E9AuPVSkwv+0S9b9bro79BmeeJuIJsR8uaXenubEjuo5LA+Zoz2D1YzSnPv MGCiAbPamcfmHPYxaGJLC6H7KwYpZsFvUAOhnYsAIRJaKV7/5/MSyTniqrwxKqarbPsk QrEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dRrfTafHWOPP66W8TWUXdxmmbu6jMm7VMDj6nUG7ys4=; b=hN7V3BZzWtgFT6QM3pdHscN4+RTz7cUpjpTwKjzR8cQ90bUaSKdvAWsZP8KqSptXXN vwgwK5lR7+XhJEghqzx/apKiG9O7WTjR4fTM/DoxnsFwIgWxV0EVtS0hCl4kbNQ3Swbs hvvpQzxT9V77Eh7pbc7esg3KgYZqWMAunkWcYk7kUoX/JQRlPcLOPNTziLDQQhodNo9/ kHrIxGo51vzy9DofWWNwpdhbGQy9CJ39vZxAfMMjTYpZW7dlzSFU8Cm3Jl+xiktF+KLs u0zrTogFGOC43PobTR+pLYLsZ/rT+IFYH/ST0KKhYRl29IWulX43PGoHSXSEGBtgZqY1 rwqw== X-Gm-Message-State: AO0yUKWNF8ZLfg4KH40z7U02bUvSwV3ZFM5TkeMR2lZKcoDfqXFYfjT2 Cgu1twtMdIamqN3ARiBSGBs9Ww== X-Received: by 2002:a05:600c:4383:b0:3dc:57e8:1d1c with SMTP id e3-20020a05600c438300b003dc57e81d1cmr5511078wmn.9.1675803524727; Tue, 07 Feb 2023 12:58:44 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h27-20020a05600c2cbb00b003db12112fcfsm16555649wmc.4.2023.02.07.12.58.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 12:58:44 -0800 (PST) From: Krzysztof Kozlowski To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 3/4] media: samsung: exynos4-is: do not require pinctrl Date: Tue, 7 Feb 2023 21:58:33 +0100 Message-Id: <20230207205834.673163-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> References: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757207496033536306?= X-GMAIL-MSGID: =?utf-8?q?1757207496033536306?= Driver does not handle pin configuration switching and several DTS provide empty pinctrl property, just to satisfy the driver's requirement for it. Drop requirement for pinctrl property as it is really optional. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. New patch --- drivers/media/platform/samsung/exynos4-is/media-dev.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.c b/drivers/media/platform/samsung/exynos4-is/media-dev.c index 98a60f01129d..22baa429ed5d 100644 --- a/drivers/media/platform/samsung/exynos4-is/media-dev.c +++ b/drivers/media/platform/samsung/exynos4-is/media-dev.c @@ -1470,10 +1470,8 @@ static int fimc_md_probe(struct platform_device *pdev) goto err_v4l2dev; pinctrl = devm_pinctrl_get(dev); - if (IS_ERR(pinctrl)) { - ret = dev_err_probe(dev, PTR_ERR(pinctrl), "Failed to get pinctrl\n"); - goto err_clk; - } + if (IS_ERR(pinctrl)) + dev_dbg(dev, "Failed to get pinctrl: %pe\n", pinctrl); platform_set_drvdata(pdev, fmd); From patchwork Tue Feb 7 20:58:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 54073 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3073539wrn; Tue, 7 Feb 2023 13:00:59 -0800 (PST) X-Google-Smtp-Source: AK7set96IjNRfYP5AjZmRmNizzkeZc6TpzC2XBxIrcQv0Cz83dQwrmRwSuq8KATTODXpDupxdKK6 X-Received: by 2002:a62:14c2:0:b0:58d:f20b:5f2e with SMTP id 185-20020a6214c2000000b0058df20b5f2emr4156515pfu.1.1675803659294; Tue, 07 Feb 2023 13:00:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675803659; cv=none; d=google.com; s=arc-20160816; b=TR0WkirjrXZ8gChLxdhNUfKAJZ1v6vFM8UFfCWMUxzkyubuYiSr2Y9T4yHJnqaCRT8 BPEDAYIDDkyF4wmFn0lb6n6vahQ/xHFM7BL7r5xBp4Ew66c0KLvrW1JV3jmnC6KOsgLg FRf6qvSqsICOY+z9QZc6Z/ZiRx92au5oGn5FrDbnLw4SX0VExNDBLjWVhFzohjk/qiYK 2XNDItOOI7k3Jb9Qj3OKmdGV/Z97QDpo9GUc8BM2GHguwlVV6Fzd62pFcJMyVxq+gDMN qnZ5O1suODKR3XA23I6DSyG2Gmdd9HeiN59DayOWGUAEFS4LutIjWdsZ0bM7ZP/vZArN +KSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZVDEkwpSNBnNA5bvC0eSecX/xh6oUxrJTLdGIKP8nY4=; b=K6+/4x3APfMK5JDlgvvR8NaPEoo4CdE38zuG9OtuNK/dReJpBFuf58zqny4sVFDzeY 2Zsghs+3kIpqfvcMsH7RzlH6vwhKdOGrRZ07ZdupYm4lFSAkT20dAYRYvAABkGHOQwe8 OqMfUqCtXbWDTVM8DBocntTOP72ayjuXBA8XYBT8C83td3hK7lrBKlzo1BxDr3F9Jnbv GOKcVi9N/SliVAAzjAublZV2P7E5mQsH5AlKHdQtPA5Co/jARjozcvITWRGF9BI8/XoS p87ANzCBOr4AMX7EkZ0BcuMvmzQMeQKhcyxYTmucToJ01/HhA0mRv8aqykSLrCMN1Q0W 7lCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uH2KAUVk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id br4-20020a056a00440400b005916a333bffsi15881529pfb.264.2023.02.07.13.00.45; Tue, 07 Feb 2023 13:00:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uH2KAUVk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229923AbjBGU65 (ORCPT + 99 others); Tue, 7 Feb 2023 15:58:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229727AbjBGU6t (ORCPT ); Tue, 7 Feb 2023 15:58:49 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C26513DE7 for ; Tue, 7 Feb 2023 12:58:48 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id z13so4466948wmp.2 for ; Tue, 07 Feb 2023 12:58:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZVDEkwpSNBnNA5bvC0eSecX/xh6oUxrJTLdGIKP8nY4=; b=uH2KAUVklw9v43h9yxNBufniyLS6TjEIIWPQXE6iftGk2v0fGkbNJAd8CeWQXDyGTO 3+jQagCE3g33wzfpDvz1FKzLwayfNTWXZNUcGSwHDCQsY+10LxPptS0u9tN4OmmlfFp4 htkSYBlpb35kapv9Bddhu7pUZi6razflGKlvnFtGXW45pT/knPZScLm0kaj7vZDkGSMR ZfG4xCoTvpdrG+4szCkJASSht4esYG0MqkaPVSJzHa0os1OC2MJRRiftDXTcvRO00kTg AY4PXW31vld/2p1G2SfdyAP7/xPUMTFv2mefqhx+SpSVz9eHHvVpvL2nyB0DjMCGYV6L +PKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZVDEkwpSNBnNA5bvC0eSecX/xh6oUxrJTLdGIKP8nY4=; b=Nc1qUggE333l7IVZ0GexbHd73x7mWmfJFBdQC28DbvnwWc+aTFUGUHCGQl832UhBoZ QiZvfEsP0jyIbXqbLFEaWe8BBIGdbY4iGOs2itmqltCHbwk+V+nyyuFF5ybi8zcY4Eln k1PXDSds7M2s0+FrH+VQ/rx/3yBxnhaADxqgsgIYON2y5gR5MZderl9XxIzO1Rt6c5l6 7T8SBBRcky28Kejw9NpXJTsMHvtAhwqF05z9K4wzCfKdIDHHNeqzuuZmg5O+VLYDwQFd t3Xd/OTFzV4/OWTgMHXin2NW0fahl5eAGmDIV8kXqoGPGrHZdcFg5EUBuVALOPKxgKau x0Kw== X-Gm-Message-State: AO0yUKWWKs9wnyjYZAAwnQG8l89C1j7u3PogcMr5uz8c1piypPyDd+TC RvtWGxkd/g1U9YbdWkLJ+1nZgw== X-Received: by 2002:a05:600c:1688:b0:3dc:4042:5c21 with SMTP id k8-20020a05600c168800b003dc40425c21mr4443353wmn.6.1675803527622; Tue, 07 Feb 2023 12:58:47 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h27-20020a05600c2cbb00b003db12112fcfsm16555649wmc.4.2023.02.07.12.58.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 12:58:47 -0800 (PST) From: Krzysztof Kozlowski To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 4/4] media: samsung: exynos4-is: drop simple-bus from compatibles Date: Tue, 7 Feb 2023 21:58:34 +0100 Message-Id: <20230207205834.673163-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> References: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757207498086512739?= X-GMAIL-MSGID: =?utf-8?q?1757207498086512739?= The FIMC camera node wrapper is not a bus, so using simple-bus fallback compatible just to instantiate its children nodes was never correct. Driver should explicitly populate all its children devices. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Do not depopulate on errors because it causes several errors. --- drivers/media/platform/samsung/exynos4-is/media-dev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.c b/drivers/media/platform/samsung/exynos4-is/media-dev.c index 22baa429ed5d..6839007edf1d 100644 --- a/drivers/media/platform/samsung/exynos4-is/media-dev.c +++ b/drivers/media/platform/samsung/exynos4-is/media-dev.c @@ -1440,6 +1440,10 @@ static int fimc_md_probe(struct platform_device *pdev) if (!fmd) return -ENOMEM; + ret = of_platform_populate(dev->of_node, NULL, NULL, dev); + if (ret < 0) + return -ENOMEM; + spin_lock_init(&fmd->slock); INIT_LIST_HEAD(&fmd->pipelines); fmd->pdev = pdev;