From patchwork Tue Feb 7 19:32:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 54063 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3044752wrn; Tue, 7 Feb 2023 11:52:53 -0800 (PST) X-Google-Smtp-Source: AK7set9BTss1+8PpYHHdQbDMUyAsMOPn1Nao318ka7N7jXc844jiQ02EeZaoxeNl8SklRnv1rqNm X-Received: by 2002:a50:9eca:0:b0:4aa:a5b3:15e6 with SMTP id a68-20020a509eca000000b004aaa5b315e6mr4654201edf.0.1675799573229; Tue, 07 Feb 2023 11:52:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675799573; cv=none; d=google.com; s=arc-20160816; b=SJ7uBhSZlgLm2y8nuDRpIbtTSUZgqJPNvHXGA/Nx9s4gmGOvQh8HKW2lWX0rkAg9d8 r3K3m6CQYeQ0sPfyJ7azfQyAzZQ10VI5tvpXMrqJNE9HKfPWxKfvMpVUzOpuCqpGegry GgIjibdDA2B2nhdm2XN41rNz/uuHiJb1a5InWU0beXlHUSlGkVcdTgISOTYaxvELtKAf 9Pdkx/A75k+m6H4peap746ZjUWLJqZ3NPpCX/u/hIvlAXL7nbe1++DTRa+Gz4k+TFIZ1 Z2SMRZf0o7sMi4SDM/EWaFAnN3TJWUxIBoid8DQFe9rqj9FItCj2fAeKltxJX81JUyB4 dEkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=aDwz8ebyu9Jo7GZkf4h4ogBfSjVLdYt8W82W2oxUCBw=; b=a0EQoxrz6UOZ7Y8g0LyolPuHg65gAy/9fAJwediY/A8fRp8qTCVBQtFRXpwTDMrGgC +s9m+SnIphqlCexLLM/VoVrwmJ8PHyWcLiKloWt0NrE6BUUjQr1BI8U4zGHIko6tvR8C t7z5Ay0y2FpaqH9P5PtfKbyrPK38ztPTPCeumRP1jdCac82bLIdBfELEN+uEPt0RrFRI NUcd8jZ5ikTAi8BqQRnSOL5FGiLOiBjRilHWXSoZLMdFwX6+ahZTm16DHpvmPHd5B+c6 GwlxSV5LqDWBYRI0tx1U3G0ElU/WQ8e2ujnwIEvOumAn3yJVn5TlDeKjpR2fmmO4cNWM PT4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=o1nMqJ1J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g18-20020a056402181200b004aad97b78b2si1242529edy.54.2023.02.07.11.52.30; Tue, 07 Feb 2023 11:52:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=o1nMqJ1J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231625AbjBGTdD (ORCPT + 99 others); Tue, 7 Feb 2023 14:33:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230510AbjBGTdB (ORCPT ); Tue, 7 Feb 2023 14:33:01 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25D1A3B65F for ; Tue, 7 Feb 2023 11:33:00 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id n28-20020a05600c3b9c00b003ddca7a2bcbso12312771wms.3 for ; Tue, 07 Feb 2023 11:33:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=aDwz8ebyu9Jo7GZkf4h4ogBfSjVLdYt8W82W2oxUCBw=; b=o1nMqJ1JV7BH6nSbGoYhVezSQWYdsIwIHO2oFzyFGogxcJLHmPwe9icRyVU0CPVRdH LdQqsnc/XihYDgSfu5KXBhnFDFmQir7OHeNwLDLeIU+MXVG43QgTJJz79R7ouJVp2EGY xNhhFAW/mVyxPwXlrUopmdxEV+2L1ze0sqg2pLkgT+CEuRRzfTZ34oo7qz4WQF69LkpY AOT/DavIzxwqnyX5RijMWO+3tmStjS/teYbwI4aow06M7dAROfuyl6Dwv5oIuFYM84XV LNhbk2fdCDUAemNW3cKZi8CB5yMAIlLViRFK6RSlCC2WpOE103o9kAMVpKoArOP94U8h gndw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aDwz8ebyu9Jo7GZkf4h4ogBfSjVLdYt8W82W2oxUCBw=; b=ab0DPoaqhmieGcxNTUiuCXt5DwyPcVJ2jl4gEcQ3d62xKWZyw3XVVsOKEuWLMD3iA0 ontCvNyESXa3pLj8vRQzn1c5qJA1RWaDOu4tVYf0Nv9phQQHXkYNtyjULqXqlye6gjg/ Zqjrk6VilG/S6WnCQkQmL6BdCffNraABlkOSzyhZuazMJR7h/wQNPdt45IyKzPjuq+Pa AOaGa/0cndL0bgB+Ji008cBsc0x901npDth4jTGZnR/8axnHsvkTX5RWxju3/SxC2t1s tKTChV9QDfhfnwafbi35jGX10sIEWuDs7mpKz6LbTINyJWRH7pii2dSCXHLTfEc3xT81 GGPA== X-Gm-Message-State: AO0yUKX9R/VPL16eTkI0I7pS639RyEstKyE314oxYsugs1j/nxJTvNYh IFZludYSnT1KEblw2fTK0A32M3qs1avEUO2d X-Received: by 2002:a05:600c:713:b0:3df:e4b4:de69 with SMTP id i19-20020a05600c071300b003dfe4b4de69mr4118923wmn.27.1675798378737; Tue, 07 Feb 2023 11:32:58 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id d17-20020adff851000000b002c3dd82a0e9sm9199448wrq.91.2023.02.07.11.32.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 11:32:58 -0800 (PST) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Alim Akhtar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/2] ARM: dts: exynos: drop simple-bus from FIMC in Exynos4 Date: Tue, 7 Feb 2023 20:32:53 +0100 Message-Id: <20230207193254.550236-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757203213056518558?= X-GMAIL-MSGID: =?utf-8?q?1757203213056518558?= The FIMC camera node wrapper is not a bus, so using simple-bus fallback compatible just to instantiate its children nodes was never correct. Dropping simple-bus node fixes warnings: exynos4210-smdkv310.dtb: camera: $nodename:0: 'camera' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$' The change is not backwards compatible and expects the FIMC driver to populate its children. Signed-off-by: Krzysztof Kozlowski --- Depends on: https://lore.kernel.org/linux-samsung-soc/20230207192914.549309-1-krzysztof.kozlowski@linaro.org/T/#t --- arch/arm/boot/dts/exynos4.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index 8dd6976ab0a7..434025331041 100644 --- a/arch/arm/boot/dts/exynos4.dtsi +++ b/arch/arm/boot/dts/exynos4.dtsi @@ -201,8 +201,8 @@ dsi_0: dsi@11c80000 { #size-cells = <0>; }; - camera: camera { - compatible = "samsung,fimc", "simple-bus"; + camera: camera@11800000 { + compatible = "samsung,fimc"; status = "disabled"; #address-cells = <1>; #size-cells = <1>; From patchwork Tue Feb 7 19:29:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 54065 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3045319wrn; Tue, 7 Feb 2023 11:54:20 -0800 (PST) X-Google-Smtp-Source: AK7set/3Ws9y1fEdOzdivm5pB60tK8MgRI8M76qeQPN0lydjX+7Ilzd2QgmjBIEvKZCem7iPz1v6 X-Received: by 2002:a17:906:604b:b0:88d:2a41:2a4b with SMTP id p11-20020a170906604b00b0088d2a412a4bmr4410269ejj.60.1675799660411; Tue, 07 Feb 2023 11:54:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675799660; cv=none; d=google.com; s=arc-20160816; b=laot7aJHbm46rOqk0FASURR4f2Uc61zTYIHYaUuaCQFVuaM8MLyHeX5MA+73GjMPfh vWJsLHmw/buazPyFP+jOr5IHIrGI9ANI6yNebx8duFtRWUq4YRbuVww8quBAC2boLNjO fsDQnykFdkxeylA5PsVkg6yviisUmgXdyTnAvPJ2VvUq1GkTsCmXwbjLAhw+AMfIBrgr fqzxIUCNbSlMexX9LNa7IcOyCt2HlQqDXuLo/reaJo9cXY0pUTGqjKXPaD+dxOiAYvAm HnUkiofcYCs2MHZauq0ZA72SGCcqNS0PfPKoXRZAet53vglDSCATklyMtIub5gW+3+ct 2Byg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8w0MpZ2V4rLYFppvKGuA9m6PNERjPDODLlDLq+kfjPs=; b=F25TrNLlGKYtG2lrdheA2KQ4pu4VpCeX5JTO/zt/0FwakS9sMpyogW8v5N4e9HPVcp vi7I/MXWbg2LLrFg1LKr5GsSXHHmhM5prxY4Dne9pu8vTV3ktMCd7kjx6s0k4+0q7V6X JUvP7jLkkbyhDU+NoHu8T3xGB/ATaY6R5sRCL566secVUKQk4bQ+bX18qW0dylZ61M0N 2yQFsDyWpo8fLAyYV/oepD7EVuzjWLJShuGgMN/b8BKZlDUTXNqLsZKY2uBbVeQPdQAY /PNe08fwIdrM8xIJqw1rQMZY6azeeIexbjodnzgsX7t6KilsuvwTeooiC4DEHPFNTrqw +WWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=woz3ID5u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ui28-20020a170907c91c00b008aabe6361f9si1081248ejc.499.2023.02.07.11.53.57; Tue, 07 Feb 2023 11:54:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=woz3ID5u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231522AbjBGTaC (ORCPT + 99 others); Tue, 7 Feb 2023 14:30:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231572AbjBGT3r (ORCPT ); Tue, 7 Feb 2023 14:29:47 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 772B83EFE0 for ; Tue, 7 Feb 2023 11:29:21 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id ba1so10575961wrb.5 for ; Tue, 07 Feb 2023 11:29:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8w0MpZ2V4rLYFppvKGuA9m6PNERjPDODLlDLq+kfjPs=; b=woz3ID5u3YeS4AXaGqdutfXO9eSzuXNOLyF41ssaOAEufE0kNsS7bUpAFGyGgpjxLe WZDFzfdrIX7h1KW9flxdSs4Br6vTZXw5mzKNcP2mhKfiOd0MqN3f/mTB3bkjcv5WH+6I UCLx77fWQkMqeXO0Mh6o37OsY7D9/M7trF9GFJ/HsylJ3PFJNGep88m4kQExYGnLTEoU nuDL779dgdLlpnLHsKz5Uk+yBrOLzZYLDdu4KT6OGflkYGuVISrSl4VaT7kZTZb+NZO0 MNHH6z25P9Zx4RAeLrqy9JleX+epp6urvAtQfTe4pTlESBDld2Ptql1h3BGU4flOKYgh Rcxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8w0MpZ2V4rLYFppvKGuA9m6PNERjPDODLlDLq+kfjPs=; b=j9ARrpgpyvB6ZdPd/G5xsvzCMdnmOs+/LKqj5GP/OpoZHyrCx/ewnjCkMWlI0oLmdp OvbPXFj6fo+8T9OASbb4AvkEmWV0xvMxDxg2SZVH/+zHd3QikzsEulD+xKfbsy4HFfea zNYCHsIs/Sv4sLZbKwuFIXbfKKu4k7qH6jZcQgcF5PSHoKziAftnLXHBGlvGawCyadpU tLj38qPBzt90NA2XcCh25u4BVhQC472ha5CS4pN+LHFPpkL0wXMU4SV/xuIi7SyeW8lu BXTaLX+anBH5Jy/7rTa2Eix2YdMyvRMR2GKSYa+MKvuBlTj3di2nbbj7UYA2gUnEwOaV Gh9w== X-Gm-Message-State: AO0yUKWohVWLizWbjuGjIhAWRy+K/pqIKG1Tt8EZtpFkhKHAkLSxlwLM 9YgbHMUT3Nzyhqhio7d5OXNF1aPQus3Ak/Oh X-Received: by 2002:a5d:4cc6:0:b0:242:800:9a7f with SMTP id c6-20020a5d4cc6000000b0024208009a7fmr3911742wrt.65.1675798159433; Tue, 07 Feb 2023 11:29:19 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id bd16-20020a05600c1f1000b003db0ee277b2sm19858623wmb.5.2023.02.07.11.29.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 11:29:19 -0800 (PST) From: Krzysztof Kozlowski To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/2] media: dt-bindings: samsung-fimc: drop simple-bus Date: Tue, 7 Feb 2023 20:29:14 +0100 Message-Id: <20230207192914.549309-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230207192914.549309-1-krzysztof.kozlowski@linaro.org> References: <20230207192914.549309-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757203304475312293?= X-GMAIL-MSGID: =?utf-8?q?1757203304475312293?= The FIMC camera node wrapper is not a bus, so using simple-bus fallback compatible just to instantiate its children nodes was never correct. Drop the simple-bus compatible and expect driver to explicitly populate children devices. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/media/samsung-fimc.txt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/media/samsung-fimc.txt b/Documentation/devicetree/bindings/media/samsung-fimc.txt index 20447529c985..f90267f1180e 100644 --- a/Documentation/devicetree/bindings/media/samsung-fimc.txt +++ b/Documentation/devicetree/bindings/media/samsung-fimc.txt @@ -15,7 +15,7 @@ Common 'camera' node Required properties: -- compatible: must be "samsung,fimc", "simple-bus" +- compatible: must be "samsung,fimc" - clocks: list of clock specifiers, corresponding to entries in the clock-names property; - clock-names : must contain "sclk_cam0", "sclk_cam1", "pxl_async0", @@ -156,8 +156,8 @@ Example: }; }; - camera { - compatible = "samsung,fimc", "simple-bus"; + camera@11800000 { + compatible = "samsung,fimc"; clocks = <&clock 132>, <&clock 133>, <&clock 351>, <&clock 352>; clock-names = "sclk_cam0", "sclk_cam1", "pxl_async0", @@ -166,6 +166,7 @@ Example: clock-output-names = "cam_a_clkout", "cam_b_clkout"; pinctrl-names = "default"; pinctrl-0 = <&cam_port_a_clk_active>; + ranges; #address-cells = <1>; #size-cells = <1>;