From patchwork Tue Feb 7 19:29:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 54062 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3044644wrn; Tue, 7 Feb 2023 11:52:33 -0800 (PST) X-Google-Smtp-Source: AK7set+nWGtEa3d4Jm1XTAqCQnQuKC7NrKYFdSoQKVVlukpe0ff6ZsiN6Mddvmpaxivs/ILrw2e2 X-Received: by 2002:a50:9ec9:0:b0:4aa:a76a:c428 with SMTP id a67-20020a509ec9000000b004aaa76ac428mr3187347edf.6.1675799552993; Tue, 07 Feb 2023 11:52:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675799552; cv=none; d=google.com; s=arc-20160816; b=uWYV1QiTbBO8w0EV3jDZ1Rd+0l85lNyNy58lqpwG5ocITO8AJI7Th6gf36KaqBCAzR dgVVd8Wuizk/OQEnWgW8zHT+pbsWzD1hFPRttNvFCagABHp6Evck++FIHq6LqBKVFNDR NxY+SbcUN+U1O5exmHXxOeyT/8X4N5shb7RI+tZjkjXsz0suXSOq9KhonvBlr1eC5xwQ oqS1wgI+ECMq3piFjRfDqRlsSCmo6dtpcFQFRvfTwJXRHPSRpnpFwLFWCP75NZCXRWEL TFMxE8u5gqQFh+vWgPUjDZ1HMxGBZGBPHzq4Nu7IM8dPqlnr8JcIX0T24573j9bBxM1C 0V1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=hO5H0Nap/rA7n7JTyZf5zLflpWg3VbovGW4CVXHbCK4=; b=lC5DXYvTO1MI3NUK1Nc8UMAiHYppqt5piL7a6glnYkuf/AS1NTFMdMpE2TIcKMXUVP SxbTpXBBYkxsarkrgFWlK3KmaKKt0U5Q2FZeMNvB7Ycj5kZlJqfjS+a++4LY3eG3cQf1 U1Ypmd6j6xOUFvv5ukC1iG/TH7CR78VumfeAB0e9zb2wfA4HA56CRGsvMSuw1Zgn9F+a oRe5VpFgJqlxlm+zDih+5Fx1ZR4ZEf6kIzbXxA+Qos8Vn4M8wz4zlV4tjP/lrfjU2OBn yrqkhg5FiCKXjTV2BjmLLo3COQISk7FlMHyxgaba7voll39/YRnDaUm7svXABhA9yBB9 1ckg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pi4BF1tb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ev19-20020a056402541300b0049e1913b734si17049970edb.200.2023.02.07.11.52.10; Tue, 07 Feb 2023 11:52:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pi4BF1tb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230072AbjBGT3s (ORCPT + 99 others); Tue, 7 Feb 2023 14:29:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231179AbjBGT3j (ORCPT ); Tue, 7 Feb 2023 14:29:39 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BC433EC76 for ; Tue, 7 Feb 2023 11:29:19 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id d14so14623878wrr.9 for ; Tue, 07 Feb 2023 11:29:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hO5H0Nap/rA7n7JTyZf5zLflpWg3VbovGW4CVXHbCK4=; b=pi4BF1tbHVMh6DjSFOMxLSqBN7I485NtNf0wtShJCIWnuaPJ1f+bgaEDoNbCtkr81P f398/d5NXSkauPmUCVmc+LrJEKlAtIQaqZ1NlWqxiFzloxtTDDy+JvF23rABn9SPckmX xdnzhKBvnzygCFIbPXg+gaaVni3QrF1kpeRhNvaHHYaXv5i+CHjin9TSk5kWBDmjjx1M rLYmEM5m6Ypk46Mpx/si2EX6QHrzjaYIPSVzwBQIyrD3mgKANQx6RgAmpTBy0y6d7W7m hWFRLQgH4iFYKmxYtYEnxBgzEkbSMB5SlQ3IEkb6BVzdp3ZCEuF29ttomF4LHFyP4kRu DWrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hO5H0Nap/rA7n7JTyZf5zLflpWg3VbovGW4CVXHbCK4=; b=d7D4hdRM9MxCsC7JqdoUSoD47L07CixGTP0uIbll+D7vGhubtiS+EN7s0fXaGcatZw H7XT4bQsGGBqRxJEy7Hy6lWvgYKlmcWUev5EnnBhiskzQVf46udzALAMk9B89Q3WoICX ZzxRLjau08gEXHKEFfNw74CiJG0YbIkX9N/nW9FDuyARA/+pqpQE8nV+lAgJWFoZ0sWl aoNjxThCKKYPS0arJcm8mKxMlEn4WGIigSJoOz3Qdkm9PiLq1UxNaLRXH+nD5Lvb/NZC evN9EPOlmO38wSr/ls9/0hyOCQ17oYtiyItfaZJ0SvSpHwwR/WvkrrUGOZH6I7ufLOpX ryDQ== X-Gm-Message-State: AO0yUKXnE5jsjUOFW/lEWFBRIBagl4oATtyvVrV1C634hCi6qkEeSE5C LkXu5psEb9x2kVkyMV95gi4h3iVPs1Os2YlL X-Received: by 2002:a5d:6941:0:b0:2bf:cfbd:44be with SMTP id r1-20020a5d6941000000b002bfcfbd44bemr3491040wrw.69.1675798157787; Tue, 07 Feb 2023 11:29:17 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id bd16-20020a05600c1f1000b003db0ee277b2sm19858623wmb.5.2023.02.07.11.29.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 11:29:17 -0800 (PST) From: Krzysztof Kozlowski To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/2] media: samsung: exynos4-is: drop simple-bus from compatibles Date: Tue, 7 Feb 2023 20:29:13 +0100 Message-Id: <20230207192914.549309-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757203191837367101?= X-GMAIL-MSGID: =?utf-8?q?1757203191837367101?= The FIMC camera node wrapper is not a bus, so using simple-bus fallback compatible just to instantiate its children nodes was never correct. Driver should explicitly populate all its children devices. Signed-off-by: Krzysztof Kozlowski --- drivers/media/platform/samsung/exynos4-is/media-dev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.c b/drivers/media/platform/samsung/exynos4-is/media-dev.c index 98a60f01129d..70c4ca7844d3 100644 --- a/drivers/media/platform/samsung/exynos4-is/media-dev.c +++ b/drivers/media/platform/samsung/exynos4-is/media-dev.c @@ -1440,6 +1440,10 @@ static int fimc_md_probe(struct platform_device *pdev) if (!fmd) return -ENOMEM; + ret = devm_of_platform_populate(dev); + if (ret < 0) + return -ENOMEM; + spin_lock_init(&fmd->slock); INIT_LIST_HEAD(&fmd->pipelines); fmd->pdev = pdev; From patchwork Tue Feb 7 19:32:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 54058 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3038985wrn; Tue, 7 Feb 2023 11:37:11 -0800 (PST) X-Google-Smtp-Source: AK7set9WcXwSew7a+Cab3H2yw3l39CHfF38ufrXIEgadRAkg2JBJAT/OmTRwp7jfDcQCbi8aG01c X-Received: by 2002:a17:906:700a:b0:88d:ba89:1831 with SMTP id n10-20020a170906700a00b0088dba891831mr258646ejj.2.1675798631526; Tue, 07 Feb 2023 11:37:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675798631; cv=none; d=google.com; s=arc-20160816; b=ATI0zdUJ5T3Vt47rrnsPqV7mZ6rUZXtMhPik5CQdzyS/0uIK8ROd+B8nzdS2JsRGKe ixScKDr46pnSxjxoFCs60WxflEMuokKHwrJrT4LMB20xZZCmr8iKmUPUAOVOSI0Rh8dU LoYm9KkjUeCsUESobIR6dKF4TkfsTHZAZoi8gbptyDzG26q7no7X5IeNYeIp5Bd9Zpx1 AI/lUTAhqnWDliQLTQUUh3SjuLUrvPW0YUSTvCflgYCjb+gobaX3ccpXQNnjdu7a27qk WtPGXXt6JaIbCo/MRF5VDsQ7Q0xIjgTFnTwrnE7ERANPe19peiJ0z+s0I/h5TP5Bb7AV FuKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fSuoB4IgL+0KHcN4gvN6QaVojWpwSFr2mY0I+k3bLs0=; b=IkIqoCDyji0wseESJOoS2lrFEDI5HQ632MHwaLU2Voo7q5cgv0AKtbjGVh0fTy011H ydgl/SnoYzyxassRs4migCuPbPLRhA0opOsdlOn3vMG11eG74o3/vb0KBoKlRVdqPLZx 9FOjkG4HePzJvoY1+sJ4tlXmRSbrtHwt5dnPPg2CYxLenLCTCsTQO1DvNgYpcO+88XOg 2IyFVGhb3PESduhVmUDWKYMmmrXRV9Dute1t9CaRGGmFeHFvRdvxpduOryC9Xr/FHb+9 wCkmzBw6oXe8FqkROth+bbZ89JoeZTILL1qsJgjZZkD0d0KSOFkEcoj3Rks0hzU7AIGK I89A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="v/JFcetm"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z23-20020a170906435700b00855da26bccasi16216217ejm.974.2023.02.07.11.36.47; Tue, 07 Feb 2023 11:37:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="v/JFcetm"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231658AbjBGTdG (ORCPT + 99 others); Tue, 7 Feb 2023 14:33:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231614AbjBGTdD (ORCPT ); Tue, 7 Feb 2023 14:33:03 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CD3A3B670 for ; Tue, 7 Feb 2023 11:33:01 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id m14so14610118wrg.13 for ; Tue, 07 Feb 2023 11:33:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fSuoB4IgL+0KHcN4gvN6QaVojWpwSFr2mY0I+k3bLs0=; b=v/JFcetmcjwGGYaS8wQ2wLEvWCsjn37OPr0kKYZWgI1T7qbTU/6sAUJANbV8PYOqSe OLKALAFb+3j7ommNQ3CWd7r+DGgvwVdodH7/q7cUFEzReRVW4WFFOM3kmEEvAJRi0dOm lSPjsnt4jntZqB/mmkYA/kv+JO/EypR7Ipk0vmPVmiagMdbnYp2p1o9mmmuiNU+MVzr3 mUTrHyXmdrJpGW8RypV7ulMhDqDgHbTweQ/1bEJ6OjFk46ATwDAEBQbjCwV8ZZ+s1wge ncwdckumvk3UWIEBMjgeFQnnmjwm8XgRh7cIH23oZ/2WhSmOuupBYEe25S/t6X5gy9z0 LhXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fSuoB4IgL+0KHcN4gvN6QaVojWpwSFr2mY0I+k3bLs0=; b=yoQDIJusSMX9TAJoVz0d+BhwUgZC+WKEngAVgVHRdKdSGLyl1RQeBR/HZ17eq2RZ9y 6cvSMKpEBzZlOjbx1xyTrk/n6denGRlI/Dm3z/nL86l4+EzsrHso3oF8TAU5qxmQjJzM kKa3n2uCt3netPrVp9xJeGRjbrmRPo9iZnsMZSXdYel+39LYWw0CwNuY2ZjbSTLYm4dw lfM+6d3XkPJ7NYl0rmbX3Q6rSWWafyzREa9iKSKXnoVFDTByVO3n4PQxIycoc8g4ryfC RMvM1OOi9OQxaCWACm7BqSTU4aThpULgYaoWmmbd4KqtD6ZLMw4z7CeD26g2sGqgzFcd fLQQ== X-Gm-Message-State: AO0yUKWjZHWOfSLD3FtYmGNUj66h2Jr7r2aT2wTaqzLkbhkKGtOzv723 o5IzquRtfnurcoYWX+OnudFWpA== X-Received: by 2002:adf:9dd2:0:b0:2c3:efb7:e9a2 with SMTP id q18-20020adf9dd2000000b002c3efb7e9a2mr112678wre.16.1675798379782; Tue, 07 Feb 2023 11:32:59 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id d17-20020adff851000000b002c3dd82a0e9sm9199448wrq.91.2023.02.07.11.32.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 11:32:59 -0800 (PST) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Alim Akhtar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/2] ARM: dts: s5pv210: drop simple-bus from FIMC Date: Tue, 7 Feb 2023 20:32:54 +0100 Message-Id: <20230207193254.550236-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230207193254.550236-1-krzysztof.kozlowski@linaro.org> References: <20230207193254.550236-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757202226011730710?= X-GMAIL-MSGID: =?utf-8?q?1757202226011730710?= The FIMC camera node wrapper is not a bus, so using simple-bus fallback compatible just to instantiate its children nodes was never correct. The change is not backwards compatible and expects the FIMC driver to populate its children. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/s5pv210.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi index 12e90a1cc6a1..5cf75cccd088 100644 --- a/arch/arm/boot/dts/s5pv210.dtsi +++ b/arch/arm/boot/dts/s5pv210.dtsi @@ -547,8 +547,8 @@ i2c1: i2c@fab00000 { status = "disabled"; }; - camera: camera { - compatible = "samsung,fimc", "simple-bus"; + camera: camera@fa600000 { + compatible = "samsung,fimc"; pinctrl-names = "default"; pinctrl-0 = <>; clocks = <&clocks SCLK_CAM0>, <&clocks SCLK_CAM1>;