From patchwork Thu Feb 2 07:03:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neal Liu X-Patchwork-Id: 51744 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp83798wrn; Wed, 1 Feb 2023 23:06:37 -0800 (PST) X-Google-Smtp-Source: AK7set/zG+QV9QxRxAvk4tAl2n4mZyTN/RSVAQyRvVTkHN07z0C5Ac7I/mpWwXRhycQ9Gj3jAxFj X-Received: by 2002:a17:907:c248:b0:878:7f6e:38a7 with SMTP id tj8-20020a170907c24800b008787f6e38a7mr4942450ejc.44.1675321597072; Wed, 01 Feb 2023 23:06:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675321597; cv=none; d=google.com; s=arc-20160816; b=OlHoOZe36GIULEIktVl5lZqEwH7wBuGm75fVkWCFFuZmWtwe+UtVQopHpELCY8iI2d CuQ4Gd3sveCyBQ/WF5SnQ7Fjk/tmu5mgBGwiGLX5bhU03aBB+YQwT7BkYqkn8WHeFKw3 OTfGA1pweX0VSMNET1/QWPPTZW91g8PIFcvTUEMXj8mgFl12mhfB6PRt/VDibdvA8eEo cwzcUv0EU7p3D2q7NuFqmgvXUTL9twJbXntMiU+vCYIGsDu3ATCwRBRtH+bAGxaykV7s CFVrd4Ct3Gv+1CHWVfO9WJREqbpBDzr1652kApclj9DGM35XMwSCLZkmfzLTmNhZSldR FtMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=gAbqcMHYqWD3lIlf7L9TaQNRHJgTRd2rmgLc770qFuc=; b=mPXtYWkkcLUo5UGStBPyiBtwZXj2vrdGepemzWP2917xl37QrSrwAPMzD9MRdIyPVR AxXLSGkOPhAE3lENyqbIrHlKsmvP3NcM4KAbD1FU/UUe5S4MA0dQfpmecvNAVKE9DBbo T7s3cKtA/rkUmpQ44hJ1LEORwnzx0OKYlS91X+f7R2kHCWq/I+2Oy7CEAsA+ViWk+9tp Hu2ntI8sOFVcXBmwxb1ueuhn861/AFeU7KcyJlTCA0Hj/lxiM2zK+8e8KMszeXUB/VPf rohemWnsMkIiYNRuxu9Allctg71WbYfxEjwYMbWF7riIH4eLTM2T9lJq22a7XEqQwqCl jqSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fs22-20020a170907601600b0087bdb523367si17753490ejc.222.2023.02.01.23.06.12; Wed, 01 Feb 2023 23:06:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231252AbjBBHFH (ORCPT + 99 others); Thu, 2 Feb 2023 02:05:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229940AbjBBHFG (ORCPT ); Thu, 2 Feb 2023 02:05:06 -0500 Received: from twspam01.aspeedtech.com (twspam01.aspeedtech.com [211.20.114.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0693B49014 for ; Wed, 1 Feb 2023 23:05:04 -0800 (PST) Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 3126q2Ri020440; Thu, 2 Feb 2023 14:52:02 +0800 (GMT-8) (envelope-from neal_liu@aspeedtech.com) Received: from localhost.localdomain (192.168.10.10) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 2 Feb 2023 15:03:48 +0800 From: Neal Liu To: Joel Stanley , Andrew Jeffery , Neal Liu , Herbert Xu , "David S . Miller" CC: , , , Subject: [PATCH v2 -next] crypto: aspeed: fix type warnings Date: Thu, 2 Feb 2023 15:03:45 +0800 Message-ID: <20230202070345.191514-1-neal_liu@aspeedtech.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [192.168.10.10] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 3126q2Ri020440 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756686666861152284?= X-GMAIL-MSGID: =?utf-8?q?1756702019061960885?= This patch fixes following warnings: 1. sparse: incorrect type in assignment (different base types) Fix: change to __le32 type. 2. sparse: cast removes address space '__iomem' of expression Fix: use readb to avoid dereferencing the memory. Signed-off-by: Neal Liu --- Change since v1: keep iomem marker to remain its purpose. drivers/crypto/aspeed/aspeed-acry.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/aspeed/aspeed-acry.c b/drivers/crypto/aspeed/aspeed-acry.c index 164c524015f0..f2429e699d14 100644 --- a/drivers/crypto/aspeed/aspeed-acry.c +++ b/drivers/crypto/aspeed/aspeed-acry.c @@ -252,7 +252,7 @@ static int aspeed_acry_rsa_ctx_copy(struct aspeed_acry_dev *acry_dev, void *buf, enum aspeed_rsa_key_mode mode) { const u8 *src = xbuf; - u32 *dw_buf = (u32 *)buf; + __le32 *dw_buf = (__le32 *)buf; int nbits, ndw; int i, j, idx; u32 data = 0; @@ -302,7 +302,7 @@ static int aspeed_acry_rsa_ctx_copy(struct aspeed_acry_dev *acry_dev, void *buf, static int aspeed_acry_rsa_transfer(struct aspeed_acry_dev *acry_dev) { struct akcipher_request *req = acry_dev->req; - u8 *sram_buffer = (u8 *)acry_dev->acry_sram; + u8 __iomem *sram_buffer = (u8 __iomem *)acry_dev->acry_sram; struct scatterlist *out_sg = req->dst; static u8 dram_buffer[ASPEED_ACRY_SRAM_MAX_LEN]; int leading_zero = 1; @@ -321,11 +321,11 @@ static int aspeed_acry_rsa_transfer(struct aspeed_acry_dev *acry_dev) for (j = ASPEED_ACRY_SRAM_MAX_LEN - 1; j >= 0; j--) { data_idx = acry_dev->data_byte_mapping[j]; - if (sram_buffer[data_idx] == 0 && leading_zero) { + if (readb(sram_buffer + data_idx) == 0 && leading_zero) { result_nbytes--; } else { leading_zero = 0; - dram_buffer[i] = sram_buffer[data_idx]; + dram_buffer[i] = readb(sram_buffer + data_idx); i++; } }