From patchwork Wed Feb 1 09:48:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Clifton X-Patchwork-Id: 51254 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp180174wrn; Wed, 1 Feb 2023 01:48:45 -0800 (PST) X-Google-Smtp-Source: AK7set9OYqMZGSbUhWQEtK5NNOU7HsVwQBNyyb3+FLZ1prLzPqRrMa0Pb8bglfTEertCrD8sfkcZ X-Received: by 2002:aa7:de13:0:b0:499:d0e3:7745 with SMTP id h19-20020aa7de13000000b00499d0e37745mr1350455edv.14.1675244925430; Wed, 01 Feb 2023 01:48:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675244925; cv=none; d=google.com; s=arc-20160816; b=HJb23y+mUqpfJ+8WxfRhspu8iPa/oEEwEm1SBVfEW77GQt89D26CR+06u6U8rk+Gsu 3Hzii3qyazW7jVCWl4N3CF5uUb2KtOYdUd71k6n+xRZx+sSQtKD8GiZs8QnGdNsixjN+ D8vh7JMRCvVPbc9HOcMCsgMuzorgGIlq2k1dzoNIyqGVR6usxbnALiMNZR6hu2uFIWc6 oPnQherVVn1F/fNMJ9uMqDGZxchAbrv+5qCgwH/YulJcNeuR9ZDTayg+TWHnaWqoELF7 FBT8s+8zDGPQufnAPwXKjM1f2FVGTQD7TmrPfialriQnK8hVZp2sO2kFzPj5qytkbqP6 lEvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:mime-version :message-id:date:subject:to:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=6elDABGApEk6TaxRl4QLm8QvpuHhXyqxRwjS/4mTmNg=; b=VjB9xVfXBzTOE/6cj9GwWSNspL3+cjOgBtaXuYb6Lf+VNo/0XdcuNRz2usTQxjCJwW sO3p/yhKyGL9Tk+Gbys60tXbN9h9xwhl+U7oCjo6rwTiaCqv/owAoxfdrvJCtbhupd9G ahff8cJ+na8Ifl3I4WVtBJEyNAnSR/LSNWrS1GLxhyWjHMy/cnP0Y6zuz7sz5sY8QoVc /VVw78Qf6xmwac2XwBcTs0GAiYuVgI6B4qRT9MjczfJubnUfrih3Lpy2MkApBwYJo0+7 zSH6GCqAxBjlc9tzNsOgBxGDk6eq1BiDUrsPAsp+n171I0ibe4YCKgNJtL8hdQpQbj+J oehQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b="Pos/aZv8"; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id u12-20020aa7d98c000000b004a3f330109bsi1478112eds.484.2023.02.01.01.48.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 01:48:45 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b="Pos/aZv8"; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 641F43858031 for ; Wed, 1 Feb 2023 09:48:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 641F43858031 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1675244921; bh=6elDABGApEk6TaxRl4QLm8QvpuHhXyqxRwjS/4mTmNg=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Pos/aZv81l6Pv6t3DgMpzq49Cizov7as9WIKg8W2gXUw1RITJl7qyiEP6tYlnZalL aBwFN2j5+mL0qDFvw8Ve0focXtBkanXj697N670wcQeG0KLNmZboKS2D0xPKeAVk8L zr3BEbxJDiquR5MK8kWHSTXT1sVWvmPZHMJQyUUg= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 94479385B504 for ; Wed, 1 Feb 2023 09:48:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 94479385B504 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-377-jofwEZFGMQmWAd46i5KkYA-1; Wed, 01 Feb 2023 04:48:30 -0500 X-MC-Unique: jofwEZFGMQmWAd46i5KkYA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D67DA85A5A3 for ; Wed, 1 Feb 2023 09:48:29 +0000 (UTC) Received: from prancer.redhat.com (unknown [10.33.36.170]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 89DF81121330 for ; Wed, 1 Feb 2023 09:48:29 +0000 (UTC) To: binutils@sourceware.org Subject: Fix sanitization warning message building gas. Date: Wed, 01 Feb 2023 09:48:28 +0000 Message-ID: <87lelhzpg3.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Nick Clifton via Binutils From: Nick Clifton Reply-To: Nick Clifton Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756621622478184783?= X-GMAIL-MSGID: =?utf-8?q?1756621622478184783?= Hi Guys, I am applying the patch below to fix a couple of compile time warnings when building the assembler with sanitization enabled: gas/dwarf2dbg.c: In function 'size_inc_line_addr': gas/dwarf2dbg.c:1644:18: error: comparison of integer expressions of different signedness: 'addressT' {aka 'long unsigned int'} and 'int' [-Werror=sign-compare] 1644 | if (addr_delta < 256 + MAX_SPECIAL_ADDR_DELTA) gas/dwarf2dbg.c: In function 'emit_inc_line_addr': gas/dwarf2dbg.c:1726:18: error: comparison of integer expressions of different signedness: 'addressT' {aka 'long unsigned int'} and 'int' [-Werror=sign-compare] 1726 | if (addr_delta < 256 + MAX_SPECIAL_ADDR_DELTA) Cheers Nick diff --git a/gas/dwarf2dbg.c b/gas/dwarf2dbg.c index b54050c6442..05f966256e4 100644 --- a/gas/dwarf2dbg.c +++ b/gas/dwarf2dbg.c @@ -1641,7 +1641,7 @@ size_inc_line_addr (int line_delta, addressT addr_delta) tmp += DWARF2_LINE_OPCODE_BASE; /* Avoid overflow when addr_delta is large. */ - if (addr_delta < 256 + MAX_SPECIAL_ADDR_DELTA) + if (addr_delta < 256U + MAX_SPECIAL_ADDR_DELTA) { /* Try using a special opcode. */ opcode = tmp + addr_delta * DWARF2_LINE_RANGE; @@ -1723,7 +1723,7 @@ emit_inc_line_addr (int line_delta, addressT addr_delta, char *p, int len) tmp += DWARF2_LINE_OPCODE_BASE; /* Avoid overflow when addr_delta is large. */ - if (addr_delta < 256 + MAX_SPECIAL_ADDR_DELTA) + if (addr_delta < 256U + MAX_SPECIAL_ADDR_DELTA) { /* Try using a special opcode. */ opcode = tmp + addr_delta * DWARF2_LINE_RANGE;