From patchwork Wed Feb 1 05:48:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 51164 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp100649wrn; Tue, 31 Jan 2023 21:51:13 -0800 (PST) X-Google-Smtp-Source: AK7set8/C39RGUKVYStbkoqBKkOjfemiQCsiJ9WhwxZJfDgC0ge0xHkCdOoN1N/BRoN2P2oB7Eud X-Received: by 2002:a62:1908:0:b0:582:ca4d:f6a7 with SMTP id 8-20020a621908000000b00582ca4df6a7mr13338459pfz.4.1675230673214; Tue, 31 Jan 2023 21:51:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675230673; cv=none; d=google.com; s=arc-20160816; b=GPC1wU4rdhYY4yrpRnsnBXHVjGWuWMj09PG1SIaqtLthF9bNSInn7xyp4s10DW0qVp W3syxzZpo9UFMLdZdHcQtKBEoIhkqCdRa6RBu5/H7vPcsIeU96eLftqzi5ho/l+OHhbE 8LdIG5x7Iktb5vSYrH8nyhflQCvM3cLpjkZxRj8bHB08UEa44YV1BpY0tey3xD7ctmKW bsNWWXg+KSb88e6b+rA2yoITGa47PyPLpA+/Iqw2fB9J2G05EZLsIkD8RczyVRFB5GTW 0Zm1OjOKfjPQ9Z3A4Y+TMyPZI/8Z8upLpZgkEBOgm072jY8myA2pRWkEcv5Qp2/mCre9 crlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=hsl33PszSOpzgnvgqkP5N89g+lpbOX6KfA0Skot7YpY=; b=DjNskO/yg86enEQPsMt8vHxY0WbVsDieNJGsh5ukc9lUr5u1Ill35pXmdcIkBf/B1C 0tPtXadYt2euX/OkPnnSHBsIzUEA1UwXqMeOuuadMmFftzyeBRykfAwkCtTbGr8pOJpW DbIIoWWiMY59N19y2iPgcJJxmyCKCg7C/bx5VWx0xgJICcKd/JHKV5xgIS7qzpNevWsE qfv053NqqqUV6JUoeBULDCM/TBltVK//rTKfdRkNf+TfQZU2w3bJgWTosrEKbA+hw9TL Wksy/LQeYeiDjnenQjaVCghYtzKMYn+2yfICrzsDKYYEIbbycmjsn+Q1qNRipdGTi5Fo SBxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=HAEliPKT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t3-20020a625f03000000b0057674a6a662si17595371pfb.138.2023.01.31.21.51.00; Tue, 31 Jan 2023 21:51:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=HAEliPKT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229827AbjBAFsn (ORCPT + 99 others); Wed, 1 Feb 2023 00:48:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231285AbjBAFsZ (ORCPT ); Wed, 1 Feb 2023 00:48:25 -0500 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19760EF83; Tue, 31 Jan 2023 21:48:20 -0800 (PST) Received: by mail-pj1-x1033.google.com with SMTP id nm12-20020a17090b19cc00b0022c2155cc0bso910672pjb.4; Tue, 31 Jan 2023 21:48:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hsl33PszSOpzgnvgqkP5N89g+lpbOX6KfA0Skot7YpY=; b=HAEliPKT9St4PwoNoXnNB1kdwddUuglLLnirU0BSkHaJG6z0f3fJtpAhkcp1jq+5Yd clmhtEsyePEV6cf3EaJtPFgotFUgOvREVROfLar+sPKKW3CNrO4sQFKMoFBRMMtvftbi FMFAG9glF0CaLfkPZM0OZFPvd2kEnEVERPO7UtduVsyqWAcFZzLUffXSrxPyo0W3E3Op NGngFC5R/eCNdalsGc5mXjMySQxZOEr5qXfN4f7V0Uwz7CPx3KUlCCOuxXGDt8OJWcmb 0T5wyDNYsX8XjUUjwVAsrG8woRVvMQDwvhHwbhtZzwPCoB+y1vd7LyUL9JOUPyLk5yVk HBbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hsl33PszSOpzgnvgqkP5N89g+lpbOX6KfA0Skot7YpY=; b=dI1w38Ha+DAiacGAfdk8sNiDcpbmOo9QlqzRq9ZgqzS2EogmhPi86Zcn/lyRbrVM7i MBZu8gbhUCD6deYqFETgJZ1TXqBxVNZsIHE82tZ29XkuP/liKKowV035XdXrcZp5y11M ai8WjPvrmInsA2q28mKeqIolgI13E6AenAh27jzY8iZOvtM/3DMgalrkgr+cbybE3ySA 2Y/UWi7yQkwD+bIXEWEBrhkgcvVtlzfPKUQo+SVmFWl7pWxIVmnVkUnCg8Ho3Gf61PU4 9HgchLjePm059hjL68+n5axZsDvtoEGgRooefrV30U4pZDRtPb0Q7wqUzy8WOu+BsDQV rCbw== X-Gm-Message-State: AO0yUKX3ONzNWUW+09lvurZ9kbVGmYJJuT0PoxNm8W+9IUNpWx+1SuB+ Lr5IwI6LsMMvdEGt7hvpCCg= X-Received: by 2002:a17:902:da89:b0:194:6f3b:3aa1 with SMTP id j9-20020a170902da8900b001946f3b3aa1mr18118338plx.55.1675230499431; Tue, 31 Jan 2023 21:48:19 -0800 (PST) Received: from dtor-ws.mtv.corp.google.com ([2620:15c:9d:2:ce3a:44de:62b3:7a4b]) by smtp.gmail.com with ESMTPSA id w2-20020a1709027b8200b00196025a34b9sm7461575pll.159.2023.01.31.21.48.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 21:48:18 -0800 (PST) From: Dmitry Torokhov To: Alessandro Zummo , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski Cc: Arnd Bergmann , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 1/3] rtc: moxart: switch to using gpiod API Date: Tue, 31 Jan 2023 21:48:13 -0800 Message-Id: <20230201054815.4112632-1-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.39.1.456.gfc5497dd1b-goog MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756606678490565061?= X-GMAIL-MSGID: =?utf-8?q?1756606678490565061?= Switch the driver from legacy gpio API that is deprecated to the newer gpiod API that respects line polarities described in ACPI/DT. This makes driver use standard property name for its gpios ("rtc-*-gpios" vs "gpios-rtc-*"), however there is a quirk in gpiolib to also recognize legacy names and keep compatibility with older DTSes: eaf1a29665cd ("gpiolib: of: add a quirk for legacy names in MOXA ART RTC"). Signed-off-by: Dmitry Torokhov --- drivers/rtc/rtc-moxart.c | 89 ++++++++++++++++------------------------ 1 file changed, 36 insertions(+), 53 deletions(-) diff --git a/drivers/rtc/rtc-moxart.c b/drivers/rtc/rtc-moxart.c index 6b24ac9e1cfa..2247dd39ee4b 100644 --- a/drivers/rtc/rtc-moxart.c +++ b/drivers/rtc/rtc-moxart.c @@ -10,14 +10,15 @@ * Moxa Technology Co., Ltd. */ +#include #include #include #include #include #include #include -#include -#include +#include +#include #define GPIO_RTC_RESERVED 0x0C #define GPIO_RTC_DATA_SET 0x10 @@ -55,7 +56,9 @@ struct moxart_rtc { struct rtc_device *rtc; spinlock_t rtc_lock; - int gpio_data, gpio_sclk, gpio_reset; + struct gpio_desc *gpio_data; + struct gpio_desc *gpio_sclk; + struct gpio_desc *gpio_reset; }; static int day_of_year[12] = { 0, 31, 59, 90, 120, 151, 181, @@ -67,10 +70,10 @@ static void moxart_rtc_write_byte(struct device *dev, u8 data) int i; for (i = 0; i < 8; i++, data >>= 1) { - gpio_set_value(moxart_rtc->gpio_sclk, 0); - gpio_set_value(moxart_rtc->gpio_data, ((data & 1) == 1)); + gpiod_set_value(moxart_rtc->gpio_sclk, 0); + gpiod_set_value(moxart_rtc->gpio_data, ((data & 1) == 1)); udelay(GPIO_RTC_DELAY_TIME); - gpio_set_value(moxart_rtc->gpio_sclk, 1); + gpiod_set_value(moxart_rtc->gpio_sclk, 1); udelay(GPIO_RTC_DELAY_TIME); } } @@ -82,11 +85,11 @@ static u8 moxart_rtc_read_byte(struct device *dev) u8 data = 0; for (i = 0; i < 8; i++) { - gpio_set_value(moxart_rtc->gpio_sclk, 0); + gpiod_set_value(moxart_rtc->gpio_sclk, 0); udelay(GPIO_RTC_DELAY_TIME); - gpio_set_value(moxart_rtc->gpio_sclk, 1); + gpiod_set_value(moxart_rtc->gpio_sclk, 1); udelay(GPIO_RTC_DELAY_TIME); - if (gpio_get_value(moxart_rtc->gpio_data)) + if (gpiod_get_value(moxart_rtc->gpio_data)) data |= (1 << i); udelay(GPIO_RTC_DELAY_TIME); } @@ -101,15 +104,15 @@ static u8 moxart_rtc_read_register(struct device *dev, u8 cmd) local_irq_save(flags); - gpio_direction_output(moxart_rtc->gpio_data, 0); - gpio_set_value(moxart_rtc->gpio_reset, 1); + gpiod_direction_output(moxart_rtc->gpio_data, 0); + gpiod_set_value(moxart_rtc->gpio_reset, 1); udelay(GPIO_RTC_DELAY_TIME); moxart_rtc_write_byte(dev, cmd); - gpio_direction_input(moxart_rtc->gpio_data); + gpiod_direction_input(moxart_rtc->gpio_data); udelay(GPIO_RTC_DELAY_TIME); data = moxart_rtc_read_byte(dev); - gpio_set_value(moxart_rtc->gpio_sclk, 0); - gpio_set_value(moxart_rtc->gpio_reset, 0); + gpiod_set_value(moxart_rtc->gpio_sclk, 0); + gpiod_set_value(moxart_rtc->gpio_reset, 0); udelay(GPIO_RTC_DELAY_TIME); local_irq_restore(flags); @@ -124,13 +127,13 @@ static void moxart_rtc_write_register(struct device *dev, u8 cmd, u8 data) local_irq_save(flags); - gpio_direction_output(moxart_rtc->gpio_data, 0); - gpio_set_value(moxart_rtc->gpio_reset, 1); + gpiod_direction_output(moxart_rtc->gpio_data, 0); + gpiod_set_value(moxart_rtc->gpio_reset, 1); udelay(GPIO_RTC_DELAY_TIME); moxart_rtc_write_byte(dev, cmd); moxart_rtc_write_byte(dev, data); - gpio_set_value(moxart_rtc->gpio_sclk, 0); - gpio_set_value(moxart_rtc->gpio_reset, 0); + gpiod_set_value(moxart_rtc->gpio_sclk, 0); + gpiod_set_value(moxart_rtc->gpio_reset, 0); udelay(GPIO_RTC_DELAY_TIME); local_irq_restore(flags); @@ -247,53 +250,33 @@ static int moxart_rtc_probe(struct platform_device *pdev) if (!moxart_rtc) return -ENOMEM; - moxart_rtc->gpio_data = of_get_named_gpio(pdev->dev.of_node, - "gpio-rtc-data", 0); - if (!gpio_is_valid(moxart_rtc->gpio_data)) { - dev_err(&pdev->dev, "invalid gpio (data): %d\n", - moxart_rtc->gpio_data); - return moxart_rtc->gpio_data; - } - - moxart_rtc->gpio_sclk = of_get_named_gpio(pdev->dev.of_node, - "gpio-rtc-sclk", 0); - if (!gpio_is_valid(moxart_rtc->gpio_sclk)) { - dev_err(&pdev->dev, "invalid gpio (sclk): %d\n", - moxart_rtc->gpio_sclk); - return moxart_rtc->gpio_sclk; - } - - moxart_rtc->gpio_reset = of_get_named_gpio(pdev->dev.of_node, - "gpio-rtc-reset", 0); - if (!gpio_is_valid(moxart_rtc->gpio_reset)) { - dev_err(&pdev->dev, "invalid gpio (reset): %d\n", - moxart_rtc->gpio_reset); - return moxart_rtc->gpio_reset; - } - - spin_lock_init(&moxart_rtc->rtc_lock); - platform_set_drvdata(pdev, moxart_rtc); - - ret = devm_gpio_request(&pdev->dev, moxart_rtc->gpio_data, "rtc_data"); + moxart_rtc->gpio_data = devm_gpiod_get(&pdev->dev, "rtc-data", + GPIOD_IN); + ret = PTR_ERR_OR_ZERO(moxart_rtc->gpio_data); if (ret) { - dev_err(&pdev->dev, "can't get rtc_data gpio\n"); + dev_err(&pdev->dev, "can't get rtc data gpio: %d\n", ret); return ret; } - ret = devm_gpio_request_one(&pdev->dev, moxart_rtc->gpio_sclk, - GPIOF_DIR_OUT, "rtc_sclk"); + moxart_rtc->gpio_sclk = devm_gpiod_get(&pdev->dev, "rtc-sclk", + GPIOD_ASIS); + ret = PTR_ERR_OR_ZERO(moxart_rtc->gpio_sclk); if (ret) { - dev_err(&pdev->dev, "can't get rtc_sclk gpio\n"); + dev_err(&pdev->dev, "can't get rtc sclk gpio: %d\n", ret); return ret; } - ret = devm_gpio_request_one(&pdev->dev, moxart_rtc->gpio_reset, - GPIOF_DIR_OUT, "rtc_reset"); + moxart_rtc->gpio_reset = devm_gpiod_get(&pdev->dev, "rtc-reset", + GPIOD_ASIS); + ret = PTR_ERR_OR_ZERO(moxart_rtc->gpio_reset); if (ret) { - dev_err(&pdev->dev, "can't get rtc_reset gpio\n"); + dev_err(&pdev->dev, "can't get rtc reset gpio: %d\n", ret); return ret; } + spin_lock_init(&moxart_rtc->rtc_lock); + platform_set_drvdata(pdev, moxart_rtc); + moxart_rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name, &moxart_rtc_ops, THIS_MODULE); From patchwork Wed Feb 1 05:48:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 51163 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp100560wrn; Tue, 31 Jan 2023 21:50:53 -0800 (PST) X-Google-Smtp-Source: AK7set8fTszyZU2W6OqF5BUrY1TOTGQdM97/J++EI+Kaj4Nj1IhS9hsTH0cdEVnvdBS7Yz6MRG9h X-Received: by 2002:a17:906:744:b0:888:9693:fb18 with SMTP id z4-20020a170906074400b008889693fb18mr365605ejb.37.1675230653194; Tue, 31 Jan 2023 21:50:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675230653; cv=none; d=google.com; s=arc-20160816; b=CVwah/m7MFABnbIY5gjOX2Ms07RnzTq/qErkQI3vtDrbfeeVcJt5iDhlH8msGjG3Cr J2mX0JqfQLDpDsgOT929cxXeagCHNeH0jv32Wwo0INfkwQjVwr3N2Wtvd+M1yrGm8Q9X cca+e55t/VJ8RmfjrQ/wdqrK+YfnRC0QZ7+zbulsZuKAv7r0JNYhLe4xG8qxZyI0FKHf On2aQQoqMnuo0961boR2NnkvtSPi1KgJu/hS+MVDYI+hIsbJzgOZ6aQGiecrjq0ztmO6 xpWYmXNYDb4iumLvOaVmc8W4nntiv7bueqQk6cST6bhJhVcWa9eIlrJwRVQqs0mgaRN9 uQWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2feaPTiFf6nFchWNFm62ii1folwFLguTnGsIZ0OJssw=; b=FEnJqFlR3BdKj4nrSNWLqpvav0HH37+Wh6qyZm7YIiiO+9eNcOreVmaXM+W0OVXdZa RgkcsL0n2UjG3tc/mjZFrGLdDE8eiHtlUSmrUeVMegG0o/1A2s20CyzLGUV8tdt9deiN sgvgcdJKjx3IWPvOPFc+tDQv2tTYAk6hzd98O5zzCcLJOLB6WUVk4pE9ksmTMbLke1Gq TKlbXFLjfwtFR9CBxjJ8nQA3KraH+TVA/g8SIqVnItQhLSy/1hqxfL8cYDWXB4YiyM1S 3cqYkvZdqjKplaq0I4qVHugbuv50wFwGQrKmdXTtakoQXnqdu1BHBuhSUM0LC0RV4JYS P1yQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=YMpzAQ8f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id vl7-20020a17090730c700b008889a6323absi8642268ejb.511.2023.01.31.21.50.28; Tue, 31 Jan 2023 21:50:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=YMpzAQ8f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231360AbjBAFsb (ORCPT + 99 others); Wed, 1 Feb 2023 00:48:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231329AbjBAFs1 (ORCPT ); Wed, 1 Feb 2023 00:48:27 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D0D3166E5; Tue, 31 Jan 2023 21:48:22 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id t12-20020a17090aae0c00b00229f4cff534so2638361pjq.1; Tue, 31 Jan 2023 21:48:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2feaPTiFf6nFchWNFm62ii1folwFLguTnGsIZ0OJssw=; b=YMpzAQ8fSIRxXawrqIgaOXYDEBG33SRSWpmrJnMmSK2OmQZgwHGwnRbudSsCj+yyxr 3rTv0zv0BkaTn18vomuhgoyWeFUmoeWGkQoBuUTf3erEAD98ucoD0r20wrTQSffGrGIW qaR+uoKXBbLnFh7MGh7cIhqvQkPtLpkhzHv0VqK9lBQMS01ESJ5UZv9v7xu/eWFgmHZJ rRrcPK4aZFTZbbQnoRXpPqVXPinXGowI1lPB3lxXcfDvE41gKH5hfQXejCqquluqsBEJ Xc8J4DtqgF76zAOle7igHctSN7wHKCEfBQoz86Onk68CZW/sO5F9AwF030MvmWVJWF/z 8XbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2feaPTiFf6nFchWNFm62ii1folwFLguTnGsIZ0OJssw=; b=Px9bGtvh2qfHWksl7RpSKEaTyngELDTyLtwhNQdVhslko3I48CYYcoYribQsYu3ZU3 FuRP+uXUhGktayKO/ipZjXySP9mt3Zzp58HEhTR7jsa/9Fq7fYuDO3U+ZNMyyOD3Xiah kvFhznMxlWLF+Cw1IdrbH48K7gjekIr19wJxJ4cjY38RI2bFGJZs9c4zw+MtVQK/xj59 JaI5mOcNUHRg4lpwH9oIusMRkL5C3ADJE0ilXccFJANGRMZbvyN2Xw9UbLcjxyw6Kfk7 YcJ09A8ttoYm7hVVROkmvBoLGmCLi1etCXEJuXLPvNJgbOlK8p5R3nP7P26/XCq44Eb1 xsNA== X-Gm-Message-State: AO0yUKVJZDIyjE+8r06wzyZozl9FtVu2FDO1G1CAzpVC2wNjPUPz8oqR bb86Kd7VxEhies9CQOWZ9Tk= X-Received: by 2002:a17:903:1111:b0:196:6ec4:52db with SMTP id n17-20020a170903111100b001966ec452dbmr1854428plh.51.1675230502394; Tue, 31 Jan 2023 21:48:22 -0800 (PST) Received: from dtor-ws.mtv.corp.google.com ([2620:15c:9d:2:ce3a:44de:62b3:7a4b]) by smtp.gmail.com with ESMTPSA id w2-20020a1709027b8200b00196025a34b9sm7461575pll.159.2023.01.31.21.48.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 21:48:21 -0800 (PST) From: Dmitry Torokhov To: Alessandro Zummo , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski Cc: Arnd Bergmann , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 2/3] dt-bindings: rtc: moxart: use proper names for gpio properties Date: Tue, 31 Jan 2023 21:48:14 -0800 Message-Id: <20230201054815.4112632-2-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.39.1.456.gfc5497dd1b-goog In-Reply-To: <20230201054815.4112632-1-dmitry.torokhov@gmail.com> References: <20230201054815.4112632-1-dmitry.torokhov@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756606657297869598?= X-GMAIL-MSGID: =?utf-8?q?1756606657297869598?= MOXA ART RTC driver has been switched to gpiod API and is now using properly named properties for its gpios (with gpiolib implementing a quirk to recognize legacy names). Change binding document to use proper names as well. Signed-off-by: Dmitry Torokhov --- .../devicetree/bindings/rtc/moxa,moxart-rtc.txt | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt b/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt index c9d3ac1477fe..1374df7bf9d6 100644 --- a/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt +++ b/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt @@ -3,15 +3,15 @@ MOXA ART real-time clock Required properties: - compatible : Should be "moxa,moxart-rtc" -- gpio-rtc-sclk : RTC sclk gpio, with zero flags -- gpio-rtc-data : RTC data gpio, with zero flags -- gpio-rtc-reset : RTC reset gpio, with zero flags +- rtc-sclk-gpios : RTC sclk gpio, with zero flags +- rtc-data-gpios : RTC data gpio, with zero flags +- rtc-reset-gpios : RTC reset gpio, with zero flags Example: rtc: rtc { compatible = "moxa,moxart-rtc"; - gpio-rtc-sclk = <&gpio 5 0>; - gpio-rtc-data = <&gpio 6 0>; - gpio-rtc-reset = <&gpio 7 0>; + rtc-sclk-gpios = <&gpio 5 0>; + rtc-data-gpios = <&gpio 6 0>; + rtc-reset-gpios = <&gpio 7 0>; }; From patchwork Wed Feb 1 05:48:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 51165 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp100751wrn; Tue, 31 Jan 2023 21:51:33 -0800 (PST) X-Google-Smtp-Source: AK7set/aTYexVE9wDdVhjvdWYFsNPmnIF+k+v8ynAb/KBRPQ95ybAhNdB+nzVszOhg9tSgYg6FT7 X-Received: by 2002:a17:902:d505:b0:196:844e:5f49 with SMTP id b5-20020a170902d50500b00196844e5f49mr2041592plg.65.1675230693602; Tue, 31 Jan 2023 21:51:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675230693; cv=none; d=google.com; s=arc-20160816; b=SNbkBkqcKHf2CfJkVohY4U/cE2d/nSTGFyz/byLuTxy3KYff1xT5/I22UWFA5pDVMT iZ5MoeKuur3VAEh3SUdUcr7Ym86kPnoxIdkoQNcEk5LMb+i4Jbqkww8xDPfv0+PicVaI c3oIdHaMW2J2NvTatf4F1lnhfLMnb1mPgYpi62scnfQB5iF1qQSwB9TSC63gfJeNW9FV iLzwkGnpT/x15ftiycug0K6vHZ0Ij3499VvfD/zQNTABMtVjRNgjQMXDfEJfnTqE/2GD V673yck/eMfRfZivofm/5g1W0tef4rkA4DiInw6evv8FJGoAeMZaYLstIL1qq8t0Q04v aimg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=PHMEwx5DpAADNj0aeVoFdx46vZBaLLK3nsLX9ugqjV0=; b=P+qEf1L1yvxCBA71fc5gXP3VZ9weTSvo5LCxRqyeYhpFuj7k69EJ01ii1NWLiOoAaL Xo3OgXx4BnUIP6polNqzb714b65rkcy4W0ZDcLF4UnfW9KKJutNdUnlUC4ZJfooDAPcy 8Ru+Zsqr93Ohp3ENZ+fctQN3GpadlwYhpdVFuqbL6m28qTBbJcRfuE8q+QhCegtDnPlP 8NEu/uxaxlccQ0ORJNk7kMGnV3UXhzPkNLG2pU+kn8OJl/mBRAqL7tFFhReHIUp6QyXp JkWrcRYE5TcJqxcjP4WHbl2/R6GaEwVow5o74SrBTUT/+zzwG1iKMrozB03JTq8BIKrn CMLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=hhIbgJ5z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bg6-20020a1709028e8600b001931fce6511si17770184plb.374.2023.01.31.21.51.21; Tue, 31 Jan 2023 21:51:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=hhIbgJ5z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231359AbjBAFtE (ORCPT + 99 others); Wed, 1 Feb 2023 00:49:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231282AbjBAFs1 (ORCPT ); Wed, 1 Feb 2023 00:48:27 -0500 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2AC61A4B6; Tue, 31 Jan 2023 21:48:25 -0800 (PST) Received: by mail-pj1-x1030.google.com with SMTP id e10-20020a17090a630a00b0022bedd66e6dso992453pjj.1; Tue, 31 Jan 2023 21:48:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PHMEwx5DpAADNj0aeVoFdx46vZBaLLK3nsLX9ugqjV0=; b=hhIbgJ5zhQunawb5Bl72W2gs9ckvnnog5fFrNBFVZU5xthmVvUioqOvfB9itiLJosf Ui8A9WDQD/wc7osP3mifVMwf9vHUSRUw56ZWGxkmPnoz6DtNWvFD9MpfLOBMWp2DA4nV YUNs6i1IWg7+Lk9DN7N3iPyRCG5hqN9msCf28DxD0fW2KQA5vD6b61UlaHwZ/ULDFwRo Fs6LIKbQ0T0rf9e78LGVpXFqXEjmVPm321XOFgTnW3CAnwcTzcj81HjV50dLtZEH+iZa rDbT66ZJZKri7ncs1G7jug5XIssUoAnMIMOjQ8/1wH0346UExHr1i/7Fbu3+Iwj5tkC2 wkhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PHMEwx5DpAADNj0aeVoFdx46vZBaLLK3nsLX9ugqjV0=; b=wmhgG+c5sDH5LGG7GFcsKpvYueLDcBGQCRQjYcFC8w3cHDqXS8SeUEDE6M1KWbegjc cLbkFLcWeiKEEYN3c4emJura6nNHM9h18kYOzAi9QpYag0VKLWli5+sPpxvuTkikVKJu Cj+9U/VqcCDqmihxPSDxI12DL352bVPu3hbYHtIBURlaVVlWQYNU51L8RVGGWCqNQ0qr mHldvZo6Tf15tLoY/GW640RA4JirxUjJfdkygwmTIC5i0n7aCGdcmD6CzZhtJ3q3w5B7 6SsayiB0ks9oEKHdZRJr2xaCJhQlfiklZcFeMHe7fPvWbAMhl2xboeAHFqQEq4dmukG0 4tew== X-Gm-Message-State: AO0yUKUCtGTPT1B3C+EFDiGcQ3vAoN78Io/PbcrFQnrDgLNOjN0YiHak w7Wha8CUyDK/tHnZRHmdxsKuNphQ4EQ= X-Received: by 2002:a17:902:d48b:b0:194:5c63:3638 with SMTP id c11-20020a170902d48b00b001945c633638mr1783199plg.61.1675230504356; Tue, 31 Jan 2023 21:48:24 -0800 (PST) Received: from dtor-ws.mtv.corp.google.com ([2620:15c:9d:2:ce3a:44de:62b3:7a4b]) by smtp.gmail.com with ESMTPSA id w2-20020a1709027b8200b00196025a34b9sm7461575pll.159.2023.01.31.21.48.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 21:48:23 -0800 (PST) From: Dmitry Torokhov To: Alessandro Zummo , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski Cc: Arnd Bergmann , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 3/3] ARM: dts: moxart: switch to proper names for RTC GPIOs Date: Tue, 31 Jan 2023 21:48:15 -0800 Message-Id: <20230201054815.4112632-3-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.39.1.456.gfc5497dd1b-goog In-Reply-To: <20230201054815.4112632-1-dmitry.torokhov@gmail.com> References: <20230201054815.4112632-1-dmitry.torokhov@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756606699923710781?= X-GMAIL-MSGID: =?utf-8?q?1756606699923710781?= Update DTS to use proper names for RTC GPIOs. While the driver/gpiolib will still recognize the old variants of names, there is no reason why we should not update DTS that is present in the kernel. Signed-off-by: Dmitry Torokhov --- arch/arm/boot/dts/moxart.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/moxart.dtsi b/arch/arm/boot/dts/moxart.dtsi index 11cbea5b94d2..622742956b2b 100644 --- a/arch/arm/boot/dts/moxart.dtsi +++ b/arch/arm/boot/dts/moxart.dtsi @@ -74,9 +74,9 @@ gpio: gpio@98700000 { rtc: rtc { compatible = "moxa,moxart-rtc"; - gpio-rtc-sclk = <&gpio 5 0>; - gpio-rtc-data = <&gpio 6 0>; - gpio-rtc-reset = <&gpio 7 0>; + rtc-sclk-gpios = <&gpio 5 0>; + rtc-data-gpios = <&gpio 6 0>; + rtc-reset-gpios = <&gpio 7 0>; }; dma: dma@90500000 {