From patchwork Tue Jan 31 13:25:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arthur Cohen X-Patchwork-Id: 50859 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2749816wrn; Tue, 31 Jan 2023 05:29:05 -0800 (PST) X-Google-Smtp-Source: AK7set++2bgIS8M6+y9/k5pCfCDKWCzz+PEYdvaWIZgHyTNCqVpowqdU+35SI1kol742IwYzGvpy X-Received: by 2002:a17:907:7da4:b0:886:843b:e695 with SMTP id oz36-20020a1709077da400b00886843be695mr12658465ejc.22.1675171745406; Tue, 31 Jan 2023 05:29:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675171745; cv=none; d=google.com; s=arc-20160816; b=AQx5C1JsO08husgiVc0RR9d9woh6P5y1fGFIGIEX0EUeRfvVB0F4Yi0CDznc2sKhf/ C9UBebUt4WWAvKyKJaFXrBG0atjSXkDJTyg6rISw43XM+0j714GxNjVJOcaavE1daHkE 66LNiVW8/gJ3IrnoMZ/NMJ5tWQQG9CQA3a1/SOQ0+SrthUmq86OW+W58YCtDnwtn9ofd nTqJ7PcbBZ3Pw9AJYwwsMYvR3YBjundw9rO6dLL7K0QL0Y9LmZfgWHr2xzCs9E34ylDM y8QhVJWyt1k6eNWEGgCWkNuA01zfv4ZwQsl7JGgSY1GvcXl9YgqzpWu5IiE/FRX5OjnM jFcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature :dmarc-filter:delivered-to; bh=z7QfhCHvezDniASZh3QJPKr3dM/lsB2SwGxc73bc92o=; b=SQWmpFoM2CrtSqUUaaqCHrbdVXDldDQti9pynHnX+wpb6n6nC+RkqWMDJTjvCZ2oUW JG+gdoV87vv3gMNG+N9wWObdXOZV4+1UaBI3TcZ1cg0H3Tlf1pT9rURT3uVoPrLemlQv zu7CsufrEjekL8jBYI31B0xYVtCwwIv6PCzmuRMBS6ZeH5by0YwEwI6X3NOn8UVXzmsH 0q59ZYnvMV4hEbdH9ASmcDmetDsW2t2BK+N8sJyDam4V8xMXB9BtJO4VOlsJn/7LV4Mq nuU23si6U2m4ZHUies0CNbvC0/z4XeV6qLWeST1NK6JdYOTGTaRLFKPGlFoFEuW5Pkyt cE1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@embecosm.com header.s=google header.b=GIt7QYAv; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id v24-20020a17090651d800b0087d9362c240si2816445ejk.509.2023.01.31.05.29.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 05:29:05 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@embecosm.com header.s=google header.b=GIt7QYAv; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AC91638AA275 for ; Tue, 31 Jan 2023 13:23:18 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id DA576395201E for ; Tue, 31 Jan 2023 13:22:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA576395201E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wr1-x429.google.com with SMTP id bk16so14170721wrb.11 for ; Tue, 31 Jan 2023 05:22:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=z7QfhCHvezDniASZh3QJPKr3dM/lsB2SwGxc73bc92o=; b=GIt7QYAvw1TG/pj/O8rpjX6KmYZcl1lrW2sV7uqunaXR0mB6pVUj3xmzmu1BcrDe+z wSqi+62o+T1Eva7MaMIKi36EAT4pOG7syEsjGHkCJrIPuXrGKnFA7m43kFGfvO0IIJkz Mo1WVipeRRDGcx9zIyDVZHLxRTvDyerpsGeaS+BxazO83x0PrmczOSuQaUrV0dyhzb3F LNkJXQywXnSOnof39OxGxOcxPURsxfsSmMyZV4vv8pAjc1KQ/GY5kho+Xc1jatzt9mcH Wzs8Sk3QmSDvNx4JsQIuxwnz9Wfk24pXmvKY+uQvVbmLDY7ms36HK//tEsxT2PLLdtx1 XpMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=z7QfhCHvezDniASZh3QJPKr3dM/lsB2SwGxc73bc92o=; b=X459ZiYECFnlbb5Mn8w/xV+6Vp2R7ddILlriuLHlqhUndKsjuemPEh6ZFzXX4IbcQ3 WAk/IB59C5HOQP1ag71LXBy/86Mp9ebphP/oZFr8p2xVJJQK1oct+hhODR+vvtmYsdfI C6YqSLKrzra9iH4u+WUpuPVvUFCDJv2zOu7KUbB6Zb5p/kESFQSbjonKaZR55+MCWX3W Y6QGgFEqg7zodCySQq/TFvhmsUeocdvwDmwM2Uy1ae4B0l4tJjwwcB1iXu4j5rxbzzzX 8h6mVZY2xkEiVej5jLP/sCjCgXgJavJjxK0QLGw+mtMP3UAzOyzp8Tjbx2leRomxo771 Gpyg== X-Gm-Message-State: AO0yUKVf/T3E82h5mjx9+wE8DcEJFEUJTzGTxMxTNaDQIsHHZvnoRkTj YSyEv9YvnblB0gvPKZvY/jrxIGBM0Cyt/oqwnw== X-Received: by 2002:a5d:604d:0:b0:2c1:2a2e:34eb with SMTP id j13-20020a5d604d000000b002c12a2e34ebmr2992205wrt.71.1675171317541; Tue, 31 Jan 2023 05:21:57 -0800 (PST) Received: from platypus.lan ([2001:861:5e4c:3bb0:6424:328a:1734:3249]) by smtp.gmail.com with ESMTPSA id n6-20020adff086000000b002bdbead763csm15177069wro.95.2023.01.31.05.21.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 05:21:57 -0800 (PST) From: Arthur Cohen To: gcc-patches@gcc.gnu.org Cc: gcc-rust@gcc.gnu.org, Philip Herron Subject: [COMMITTED] gccrs: Add extra debugging for method call expressions Date: Tue, 31 Jan 2023 14:25:42 +0100 Message-Id: <20230131132542.662372-1-arthur.cohen@embecosm.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Spam-Status: No, score=-15.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756544888346572100?= X-GMAIL-MSGID: =?utf-8?q?1756544888346572100?= From: Philip Herron gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-expr.cc (TypeCheckExpr::visit): Add more calls to `rust_debug` for development. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/rust/typecheck/rust-hir-type-check-expr.cc | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/gcc/rust/typecheck/rust-hir-type-check-expr.cc b/gcc/rust/typecheck/rust-hir-type-check-expr.cc index a0eb1a596f7..bea5eb8cb0b 100644 --- a/gcc/rust/typecheck/rust-hir-type-check-expr.cc +++ b/gcc/rust/typecheck/rust-hir-type-check-expr.cc @@ -1024,6 +1024,11 @@ TypeCheckExpr::visit (HIR::MethodCallExpr &expr) return; } + rust_debug_loc (expr.get_method_name ().get_locus (), + "resolved method to: {%u} {%s}", + candidate.candidate.ty->get_ref (), + candidate.candidate.ty->debug_str ().c_str ()); + // Get the adjusted self Adjuster adj (receiver_tyty); TyTy::BaseType *adjusted_self = adj.adjust_type (candidate.adjustments); @@ -1120,6 +1125,9 @@ TypeCheckExpr::visit (HIR::MethodCallExpr &expr) // apply any remaining generic arguments if (expr.get_method_name ().has_generic_args ()) { + rust_debug_loc (expr.get_method_name ().get_generic_args ().get_locus (), + "applying generic arguments to method_call: {%s}", + lookup->debug_str ().c_str ()); HIR::GenericArgs &args = expr.get_method_name ().get_generic_args (); lookup = SubstMapper::Resolve (lookup, expr.get_method_name ().get_locus (), @@ -1129,10 +1137,14 @@ TypeCheckExpr::visit (HIR::MethodCallExpr &expr) } else if (lookup->needs_generic_substitutions ()) { + rust_debug ("method needs inference: {%s}", + lookup->debug_str ().c_str ()); lookup = SubstMapper::InferSubst (lookup, expr.get_method_name ().get_locus ()); } + rust_debug ("type-checking method_call: {%s}", lookup->debug_str ().c_str ()); + TyTy::BaseType *function_ret_tyty = TyTy::TypeCheckMethodCallExpr::go (lookup, expr, adjusted_self, context); if (function_ret_tyty == nullptr