From patchwork Tue Jan 31 11:14:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miko Larsson X-Patchwork-Id: 50776 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2694479wrn; Tue, 31 Jan 2023 03:27:20 -0800 (PST) X-Google-Smtp-Source: AK7set9S3gt+8Kr1sZYZ1/fbr+RNsV2RIO/K2DA1k2J1R/Z8Z/X46xAvDIvapcHbQke/vVHrrxnW X-Received: by 2002:a17:90b:224e:b0:22b:fe1a:1e94 with SMTP id hk14-20020a17090b224e00b0022bfe1a1e94mr27066775pjb.23.1675164440305; Tue, 31 Jan 2023 03:27:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675164440; cv=none; d=google.com; s=arc-20160816; b=pvUBJ2dknbH9wRje3gf7GWb+lXxBxw4/zPWd3m/9Ib37MIbVwMXDuE6S8bX4hgdXDo FlSy+5tKbM54ZqpTpQvjCun70OQDpm0bRjkpq1RGsBjYU8shbrWCaz8xWNxI9t9w1pXN YgWhlwClFyrowFtz1kyWY1YEMDfgH72lFPCxvH5+ka+Wp+/azJRLjFtK4KjqiRtuUVLV N0cIjFGXQfv2LquwDsYEW97uUDJIfZIt/pWrkCpddKsTnedRCb5vMrp7Zb7IgjJQb++p QjDmZkDxisR8UfpDbmhEa0q3wMUAAJTdofQmc5YnFnUeXD+TbnE44xjJB5AQXTQSyihG Vu0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:date:cc:to:from:subject:message-id :dkim-signature; bh=rJ6oUhRQsdKJpSWApz0PU5q/d65KHu6fj0/NFeFyyPo=; b=ssrJWLbpdN/UUh/B/TV/t34/BwHlFkIU5+CJv4jfTy1g0gxyvrsXbMfOgllVWnKTys zegdY5BMKe04hlrN1HzWHA+WQdPCJ8e/iBgKkyg5evvBPVdmopddq/XIMGBEdKrcwAAm ddnE5i60BffB5xD+GMEV/gCanOX7Tlz6qkfHrYpsU8SKgpPEaUUgmxCMJw/Ed+IDowHG h75qyvEbsXk3QMoFPp7u7hqJYCTzZupMKSwv6F5R6aRJr3urWXW47J4gRvic2sQi8KKt h6CuXz5UV6LuEeEndBHstCDnDoWkgbeCau26iAEUGznDkdH9bj7dDQAYpfgHEJD38V7k KNiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Uo+JRdrd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h17-20020a633851000000b004a2d9640cd1si16809597pgn.168.2023.01.31.03.27.02; Tue, 31 Jan 2023 03:27:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Uo+JRdrd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231713AbjAaLPE (ORCPT + 99 others); Tue, 31 Jan 2023 06:15:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231388AbjAaLO7 (ORCPT ); Tue, 31 Jan 2023 06:14:59 -0500 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A70E4B4B2; Tue, 31 Jan 2023 03:14:57 -0800 (PST) Received: by mail-ed1-x532.google.com with SMTP id n6so11402325edo.9; Tue, 31 Jan 2023 03:14:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:date:cc:to:from :subject:message-id:from:to:cc:subject:date:message-id:reply-to; bh=rJ6oUhRQsdKJpSWApz0PU5q/d65KHu6fj0/NFeFyyPo=; b=Uo+JRdrdbMDcPUUK2QO20xye4voQrXk9zs9TSQWcFlFQz9+YY/R5M9nmeduY5/gLbT Z5zVJAR7PjeZQGpNzU9fxLJ/ZYRsZ0/pf05UwEw604xN5JQmlKS15M9hJJKJJsUeb539 F1QEr0n0Lgcap65LnTYpFrs7zUOCrd8cO9D24nFzRs9tdhFyvXsGbN4ZG82SUp0pRF5n w0F6x9XUm0gMlHKIVd7w0m1f6Y/qd2rGLFT1CwdpuyAXMqbFgXnDkmlNGyhcFQszBO6p 7+dG2TT3rUDkGSrg39RiJjvhdtQotdtE7/ZQMn8XdMxgegpPd7cN5YiRuDkvJNLuaVPc argA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:date:cc:to:from :subject:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rJ6oUhRQsdKJpSWApz0PU5q/d65KHu6fj0/NFeFyyPo=; b=k9FolhluWiLdTaS+saUO16EHz3hRNn+0Uoqxteip2UI/wMxI7TMkHpXwdTDazyE/44 ip+y6VKdDjq9vvb5N1itvk8Tw3oCmnyKXY3Nn9DItI7pa5Eg3tjUlmnUDekCEUPMX2bV uLwCco1L6hHiWfhsyWeLEHlznM+NTywjhwXCvoq4HJ1RGrS/pssT8rjmVK/hC+msyONd ySfY3nH2ZTzjXnmwvF3vWkzfm/r8cNfz5zi2L+E4/34/ZUCqH+ITWcFLyGoNQDGdL3tD eCIK1CiJNThcR0JWlJ4skmjWkdZ0mLycBsuO3EtIAREv4tC/k049vfJC6y7AMW8kdC0r PJbQ== X-Gm-Message-State: AFqh2kooyWyq8x+L+rQ0kjauS/2SNIjCKOc6rX/7GRizi+2h/sgZl9ON EJzNI3Ur1doTds3KyMbyh0g= X-Received: by 2002:a05:6402:3709:b0:49e:baf:f6e9 with SMTP id ek9-20020a056402370900b0049e0baff6e9mr63783738edb.9.1675163695979; Tue, 31 Jan 2023 03:14:55 -0800 (PST) Received: from touko.myxoz.lan (90-224-45-44-no2390.tbcn.telia.com. [90.224.45.44]) by smtp.gmail.com with ESMTPSA id by13-20020a0564021b0d00b004a277d55a6csm76199edb.1.2023.01.31.03.14.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 03:14:55 -0800 (PST) Message-ID: <7266fe67c835f90e5c257129014a63e79e849ef9.camel@gmail.com> Subject: [UNTESTED PATCH] net/usb: kalmia: Fix uninit-value in kalmia_send_init_packet From: Miko Larsson To: "David S. Miller" Cc: Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 31 Jan 2023 12:14:54 +0100 User-Agent: Evolution 3.46.3 (3.46.3-1.module_f37+15877+cf3308f9) MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756537227966917077?= X-GMAIL-MSGID: =?utf-8?q?1756537227966917077?= From ef617d8df22945b871ab989e25c07d7c60ae21f6 Mon Sep 17 00:00:00 2001 From: Miko Larsson Date: Tue, 31 Jan 2023 11:01:20 +0100 Subject: [UNTESTED PATCH] net/usb: kalmia: Fix uninit-value in kalmia_send_init_packet syzbot reports that act_len in kalmia_send_init_packet() is uninitialized. Attempt to fix this by initializing it to 0. Fixes: d40261236e8e ("net/usb: Add Samsung Kalmia driver for Samsung GT-B3730") Reported-by: syzbot+cd80c5ef5121bfe85b55@syzkaller.appspotmail.com Signed-off-by: Miko Larsson --- drivers/net/usb/kalmia.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/kalmia.c b/drivers/net/usb/kalmia.c index 9f2b70ef39aa..b158fb7bf66a 100644 --- a/drivers/net/usb/kalmia.c +++ b/drivers/net/usb/kalmia.c @@ -56,7 +56,7 @@ static int kalmia_send_init_packet(struct usbnet *dev, u8 *init_msg, u8 init_msg_len, u8 *buffer, u8 expected_len) { - int act_len; + int act_len = 0; int status; netdev_dbg(dev->net, "Sending init packet");