From patchwork Tue Jan 31 08:46:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 50739 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2637744wrn; Tue, 31 Jan 2023 00:55:17 -0800 (PST) X-Google-Smtp-Source: AK7set8PwRs2G4kF4+NaAwimEbYi7bnlB5KiI77zIOMnpyVOsxer4F6hS5CbRNcTtqSk7ItLA+Oe X-Received: by 2002:a17:902:d2c9:b0:198:68b1:624f with SMTP id n9-20020a170902d2c900b0019868b1624fmr3254928plc.66.1675155317337; Tue, 31 Jan 2023 00:55:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675155317; cv=none; d=google.com; s=arc-20160816; b=yaPBT4g6R83u+pwTXgAKL+M9vXMbFmEJVfZG+FX5m3mefVUnaxJYrigwV7I6cgl59p FeIIUY9c/mQACKBi6DxsTKL3m1E/JJNH2xhoMuAj7AcFwbHz286Dm7sl7ArkZUpH8S1I dhv2zpBwkt4qUeiiUUjRyRA/L9RJmijpGS3HKsDvUnfLh3sZ+yWi03EzjTCnBrPvi1RQ Gw9yCGwvJwDSzzJL1yFQr8OAPo4fs2QdbgHiHjbpsjiNsPHIjabK389T3SLlpNlOCfiV I02/kWY1DS+oEhMJ8EwfPNzS5WMZ3vFSG+mgiDnXx7EjSuQjS04MBuRmTiNcm95UpH06 WwFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=r2FQ9+Rae/K9OxUNBRw61ID6g4dYH2kxFL1tu4JkuN8=; b=Jua/NKsdGs4Sxp9i/ZK52prRhDmucPYWY7Y+U5rcLCH8tdEIK0ApixOtfNbbBLyYsR 8tpzwcJZwf/uoZug/9GYyUk+0TOFSfUn9TLSHIajNQ0TN3Zt4O/9p+bSfQ4J+nkqhFQJ 92P0jMw0XjSKt1ETL7TQ7XZhbRiNUhME4NfkRt5OEM5deBQSlfUVgYbt6UXBLHXMApUd 0vY/s+RXXQC0awjxq7Voy0Q1qG84cityTSF1fghZ90HqJ4hBqlIk/SDjmn/Q/Yp30jFK RGM3st3erUD1Jn0y2/8CkNyZhJHx1pXedxIGj3H/8Vd5K+s/YdK9xQQorWCKpdEtDxDO FCqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o17-20020a639211000000b004e7b4b984desi7629840pgd.279.2023.01.31.00.55.03; Tue, 31 Jan 2023 00:55:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231190AbjAaIxg (ORCPT + 99 others); Tue, 31 Jan 2023 03:53:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232114AbjAaIxF (ORCPT ); Tue, 31 Jan 2023 03:53:05 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C88AE4DBE4 for ; Tue, 31 Jan 2023 00:49:00 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMmHw-0003v4-Bl; Tue, 31 Jan 2023 09:46:48 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pMmHv-001eMI-T5; Tue, 31 Jan 2023 09:46:46 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pMmHr-002yZ2-0B; Tue, 31 Jan 2023 09:46:43 +0100 From: Oleksij Rempel To: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Abel Vesa , Michael Turquette , Stephen Boyd , Richard Cochran Cc: Oleksij Rempel , Abel Vesa , kernel@pengutronix.de, Fabio Estevam , NXP Linux Team , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 01/19] clk: imx: add clk-gpr-mux driver Date: Tue, 31 Jan 2023 09:46:24 +0100 Message-Id: <20230131084642.709385-2-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230131084642.709385-1-o.rempel@pengutronix.de> References: <20230131084642.709385-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756527662264519213?= X-GMAIL-MSGID: =?utf-8?q?1756527662264519213?= Almost(?) every i.MX variant has clk mux for ethernet (rgmii/rmii) reference clock located in the GPR1 register. So far this clk is configured in different ways: - mach-imx6q is doing mux configuration based on ptp vs enet_ref clk comparison. - mach-imx7d is setting mux to PAD for all boards - mach-imx6ul is setting mux to internal clock for all boards. Since we have imx7d and imx6ul board variants which do not work with configurations forced by kernel mach code, we need to implement this clk mux properly as part of the clk framework. Which is done by this patch. Signed-off-by: Oleksij Rempel Reviewed-by: Abel Vesa --- drivers/clk/imx/Makefile | 1 + drivers/clk/imx/clk-gpr-mux.c | 119 ++++++++++++++++++++++++++++++++++ drivers/clk/imx/clk.h | 5 ++ 3 files changed, 125 insertions(+) create mode 100644 drivers/clk/imx/clk-gpr-mux.c diff --git a/drivers/clk/imx/Makefile b/drivers/clk/imx/Makefile index e8aacb0ee6ac..a75d59f7cb8a 100644 --- a/drivers/clk/imx/Makefile +++ b/drivers/clk/imx/Makefile @@ -22,6 +22,7 @@ mxc-clk-objs += clk-pllv3.o mxc-clk-objs += clk-pllv4.o mxc-clk-objs += clk-pll14xx.o mxc-clk-objs += clk-sscg-pll.o +mxc-clk-objs += clk-gpr-mux.o obj-$(CONFIG_MXC_CLK) += mxc-clk.o obj-$(CONFIG_CLK_IMX8MM) += clk-imx8mm.o diff --git a/drivers/clk/imx/clk-gpr-mux.c b/drivers/clk/imx/clk-gpr-mux.c new file mode 100644 index 000000000000..47a3e3cdcc82 --- /dev/null +++ b/drivers/clk/imx/clk-gpr-mux.c @@ -0,0 +1,119 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + */ + +#define pr_fmt(fmt) "imx:clk-gpr-mux: " fmt + +#include + +#include +#include +#include +#include +#include +#include +#include + +#include "clk.h" + +struct imx_clk_gpr { + struct clk_hw hw; + struct regmap *regmap; + u32 mask; + u32 reg; + const u32 *mux_table; +}; + +static struct imx_clk_gpr *to_imx_clk_gpr(struct clk_hw *hw) +{ + return container_of(hw, struct imx_clk_gpr, hw); +} + +static u8 imx_clk_gpr_mux_get_parent(struct clk_hw *hw) +{ + struct imx_clk_gpr *priv = to_imx_clk_gpr(hw); + unsigned int val; + int ret; + + ret = regmap_read(priv->regmap, priv->reg, &val); + if (ret) + goto get_parent_err; + + val &= priv->mask; + + ret = clk_mux_val_to_index(hw, priv->mux_table, 0, val); + if (ret < 0) + goto get_parent_err; + + return ret; + +get_parent_err: + pr_err("failed to get parent (%pe)\n", ERR_PTR(ret)); + + /* return some realistic non negative value. Potentially we could + * give index to some dummy error parent. + */ + return 0; +} + +static int imx_clk_gpr_mux_set_parent(struct clk_hw *hw, u8 index) +{ + struct imx_clk_gpr *priv = to_imx_clk_gpr(hw); + unsigned int val = clk_mux_index_to_val(priv->mux_table, 0, index); + + return regmap_update_bits(priv->regmap, priv->reg, priv->mask, val); +} + +static int imx_clk_gpr_mux_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) +{ + return clk_mux_determine_rate_flags(hw, req, 0); +} + +const struct clk_ops imx_clk_gpr_mux_ops = { + .get_parent = imx_clk_gpr_mux_get_parent, + .set_parent = imx_clk_gpr_mux_set_parent, + .determine_rate = imx_clk_gpr_mux_determine_rate, +}; + +struct clk_hw *imx_clk_gpr_mux(const char *name, const char *compatible, + u32 reg, const char **parent_names, + u8 num_parents, const u32 *mux_table, u32 mask) +{ + struct clk_init_data init = { }; + struct imx_clk_gpr *priv; + struct regmap *regmap; + struct clk_hw *hw; + int ret; + + regmap = syscon_regmap_lookup_by_compatible(compatible); + if (IS_ERR(regmap)) { + pr_err("failed to find %s regmap\n", compatible); + return ERR_CAST(regmap); + } + + priv = kzalloc(sizeof(*priv), GFP_KERNEL); + if (!priv) + return ERR_PTR(-ENOMEM); + + init.name = name; + init.ops = &imx_clk_gpr_mux_ops; + init.parent_names = parent_names; + init.num_parents = num_parents; + init.flags = CLK_SET_RATE_GATE | CLK_SET_PARENT_GATE; + + priv->hw.init = &init; + priv->regmap = regmap; + priv->mux_table = mux_table; + priv->reg = reg; + priv->mask = mask; + + hw = &priv->hw; + ret = clk_hw_register(NULL, &priv->hw); + if (ret) { + kfree(priv); + hw = ERR_PTR(ret); + } + + return hw; +} diff --git a/drivers/clk/imx/clk.h b/drivers/clk/imx/clk.h index c4c73477e772..afc1ea0f5bcf 100644 --- a/drivers/clk/imx/clk.h +++ b/drivers/clk/imx/clk.h @@ -458,4 +458,9 @@ struct clk_hw *imx_clk_hw_divider_gate(const char *name, const char *parent_name unsigned long flags, void __iomem *reg, u8 shift, u8 width, u8 clk_divider_flags, const struct clk_div_table *table, spinlock_t *lock); + +struct clk_hw *imx_clk_gpr_mux(const char *name, const char *compatible, + u32 reg, const char **parent_names, + u8 num_parents, const u32 *mux_table, u32 mask); + #endif From patchwork Tue Jan 31 08:46:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 50723 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2637196wrn; Tue, 31 Jan 2023 00:53:30 -0800 (PST) X-Google-Smtp-Source: AK7set/mfpizAv3DcDyXcizCL31Z/U717oRsjRId5fJJ8knnBjg4T4F+TTyBiif35kb+xVhMRgI/ X-Received: by 2002:a17:903:1d1:b0:196:433e:236b with SMTP id e17-20020a17090301d100b00196433e236bmr24068175plh.54.1675155209830; Tue, 31 Jan 2023 00:53:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675155209; cv=none; d=google.com; s=arc-20160816; b=CMyLWKmKvnljnl1ly5vZPxKNXItLYczJZrl8Vl55qosxn4z33VnnKydihp5krejYLK IdhF/Yeeb15sYWq5e8qlBCwn3pDSQKTbSGSbFU1T5uQ9fjVcRbfFr2qmHk2OKxW4Jf4j CX/eSzHpEtq+Rzu8m4xS/kTC4FeEB/r+42VPIOW+rEM64JzQsXdRRw6g6AWrlSsQy/Xb tWkzbpvHjxIZX0aNSO/gObwpc7xXgMycZswa7kmC25rKpfQislWjZv4rNMawUA5anH/S R8EgQLDudWqSnFAYGVaJBbY3M388sH/894lc9l8mqgE9bT2e19sC2pxuUgjaX1yOMwFj y4Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=DyHxCwrFilwK52phSZkot9Egw54JczN0OUceMNvzT7M=; b=n3W9xgRAryinSn4bHn4ZR/s1j+4Eow7Jiz8cjOsW+1GcYx9v1NS6FinSdiK0z/iKHl 1awd+a9lGGIzulx0Mv2pxObHcr7uyQ0fDLq9+eXSZLee7Gfy62j7zF2SoQ5HS1KSo/Pp ZNjQNeyTyngsG6+DtHbpC6tKw4Hm5O/I2D7bPsrwk0TsmSwU1n8Nzq6aMcja09LLlsOY TSkwC4uqr9xhOoxMVH6UGEiEZR8QOYC7ketwDuf8kN0ZtjyfBYj6WQnY+jSk2eGE0szJ J2XrUzzlpF80yGSHCc6HRI+dqoztzkz8ckDXsKYiEF7CI6PFgwE/Rn8oQgcEjEagiy5F ZDOA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q13-20020a170902b10d00b001933989d4f8si14686080plr.344.2023.01.31.00.53.07; Tue, 31 Jan 2023 00:53:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230200AbjAaIv0 (ORCPT + 99 others); Tue, 31 Jan 2023 03:51:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230158AbjAaIvK (ORCPT ); Tue, 31 Jan 2023 03:51:10 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6139B4B897 for ; Tue, 31 Jan 2023 00:47:12 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMmHv-0003uM-LW; Tue, 31 Jan 2023 09:46:47 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pMmHv-001eMF-MT; Tue, 31 Jan 2023 09:46:46 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pMmHr-002yZB-0y; Tue, 31 Jan 2023 09:46:43 +0100 From: Oleksij Rempel To: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Abel Vesa , Michael Turquette , Stephen Boyd , Richard Cochran Cc: Oleksij Rempel , Abel Vesa , kernel@pengutronix.de, Fabio Estevam , NXP Linux Team , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 02/19] clk: imx6q: add ethernet refclock mux support Date: Tue, 31 Jan 2023 09:46:25 +0100 Message-Id: <20230131084642.709385-3-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230131084642.709385-1-o.rempel@pengutronix.de> References: <20230131084642.709385-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756527549273873735?= X-GMAIL-MSGID: =?utf-8?q?1756527549273873735?= Add ethernet refclock mux support and set it to internal clock by default. This configuration will not affect existing boards since machine code currently overwrites this default. The machine code will be fixed in a separate patch. Signed-off-by: Oleksij Rempel Reviewed-by: Abel Vesa --- drivers/clk/imx/clk-imx6q.c | 13 +++++++++++++ include/dt-bindings/clock/imx6qdl-clock.h | 4 +++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c index da71e064531e..bf4c1d9c9928 100644 --- a/drivers/clk/imx/clk-imx6q.c +++ b/drivers/clk/imx/clk-imx6q.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -115,6 +116,10 @@ static struct clk_div_table video_div_table[] = { { /* sentinel */ } }; +static const char * enet_ref_sels[] = { "enet_ref", "enet_ref_pad", }; +static const u32 enet_ref_sels_table[] = { IMX6Q_GPR1_ENET_CLK_SEL_ANATOP, IMX6Q_GPR1_ENET_CLK_SEL_PAD }; +static const u32 enet_ref_sels_table_mask = IMX6Q_GPR1_ENET_CLK_SEL_ANATOP; + static unsigned int share_count_esai; static unsigned int share_count_asrc; static unsigned int share_count_ssi1; @@ -908,6 +913,12 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node) if (clk_on_imx6q() && imx_get_soc_revision() == IMX_CHIP_REVISION_1_0) hws[IMX6QDL_CLK_GPT_3M] = hws[IMX6QDL_CLK_GPT_IPG_PER]; + hws[IMX6QDL_CLK_ENET_REF_PAD] = imx6q_obtain_fixed_clk_hw(ccm_node, "enet_ref_pad", 0); + + hws[IMX6QDL_CLK_ENET_REF_SEL] = imx_clk_gpr_mux("enet_ref_sel", "fsl,imx6q-iomuxc-gpr", + IOMUXC_GPR1, enet_ref_sels, ARRAY_SIZE(enet_ref_sels), + enet_ref_sels_table, enet_ref_sels_table_mask); + imx_check_clk_hws(hws, IMX6QDL_CLK_END); of_clk_add_hw_provider(np, of_clk_hw_onecell_get, clk_hw_data); @@ -974,6 +985,8 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node) hws[IMX6QDL_CLK_PLL3_USB_OTG]->clk); } + clk_set_parent(hws[IMX6QDL_CLK_ENET_REF_SEL]->clk, hws[IMX6QDL_CLK_ENET_REF]->clk); + imx_register_uart_clocks(); } CLK_OF_DECLARE(imx6q, "fsl,imx6q-ccm", imx6q_clocks_init); diff --git a/include/dt-bindings/clock/imx6qdl-clock.h b/include/dt-bindings/clock/imx6qdl-clock.h index e20c43cc36f6..e5b2a1ba02bc 100644 --- a/include/dt-bindings/clock/imx6qdl-clock.h +++ b/include/dt-bindings/clock/imx6qdl-clock.h @@ -273,6 +273,8 @@ #define IMX6QDL_CLK_MMDC_P0_IPG 263 #define IMX6QDL_CLK_DCIC1 264 #define IMX6QDL_CLK_DCIC2 265 -#define IMX6QDL_CLK_END 266 +#define IMX6QDL_CLK_ENET_REF_SEL 266 +#define IMX6QDL_CLK_ENET_REF_PAD 267 +#define IMX6QDL_CLK_END 268 #endif /* __DT_BINDINGS_CLOCK_IMX6QDL_H */ From patchwork Tue Jan 31 08:46:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 50729 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2637251wrn; Tue, 31 Jan 2023 00:53:41 -0800 (PST) X-Google-Smtp-Source: AK7set+nUtAV8QwdmFh7pSJX7prH0KdRC8utoZITqrcsMzCipetqnX0zn5NmlaD/ieMzlgg3V3xm X-Received: by 2002:a17:90a:e7cd:b0:228:d42c:d5d6 with SMTP id kb13-20020a17090ae7cd00b00228d42cd5d6mr12489977pjb.27.1675155221195; Tue, 31 Jan 2023 00:53:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675155221; cv=none; d=google.com; s=arc-20160816; b=XqaUKhgCkZKTTfQbaML/zkn3u9uh+9Ldh+XvTucHrlMBAFyjyfrubD6+mt9SlPGjzD 8o2KeEblx53naSiTlhLsu8YHmGyJAbEGoQScgaMgu8krnTKcyyME6gCTRgxhaFguCYPI FDJhhzunhh05V+1X207IhUr394C3RYTnYVORQ00C1h9cQFTwIpwBfsZ4+OrOF6eYaCRd +QXqFsHBA8sKpTZgmx3K+A1ZaYU7xVD5C9/tsdKh7e392J6DZ5254iUHUjo8Ednk2Q4s 67cUdBVKVq0CaVMgbntu0O6KSlEFGUmoZiL0lo6qp2X8kc3rxXXZ/qPmlL0bsAMEvb5u 2dGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=NKAM+52DP2e8x/TtHek9h1Bhf4AHTLQuWAxwKS2y76c=; b=OoAEHN0I3Oa9vyD4OiO0vJa8QVOVxLkOtYECvlLTEFG9HjXe53rphvVsAGx1DoiwRG a2EF4PYFY+p1xDckoXbYjUfq6cadchbNKOPueKUw7BaZQUlOtlAMb+JwlaH+yt8sSH5j 69sBAGV0UBKcW9FS8i32ooIv7F7Q80/8RzPYxSoVgKHA+S4o0zqhd7av9f+uZ1/VMb6I mccBJymqx62qhx7xSBNR3eqGjV4ngmi2kAoq5cXrw4vL7Cfqo1WZDyQ/c0Zxnj45bjjY SW6fhQfLIFX1rpoEYGsQFX0/D8OfjnHVCy80PtzHttfC9iUse5iKpbL2MJPJ3Fwia4Uu Ix7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s1-20020a17090a948100b00228f8ce4657si19395847pjo.5.2023.01.31.00.53.27; Tue, 31 Jan 2023 00:53:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232018AbjAaIvx (ORCPT + 99 others); Tue, 31 Jan 2023 03:51:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231640AbjAaIvV (ORCPT ); Tue, 31 Jan 2023 03:51:21 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E228A4FC25 for ; Tue, 31 Jan 2023 00:47:24 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMmHv-0003tF-9d; Tue, 31 Jan 2023 09:46:47 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pMmHv-001eLx-9n; Tue, 31 Jan 2023 09:46:46 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pMmHr-002yZK-1d; Tue, 31 Jan 2023 09:46:43 +0100 From: Oleksij Rempel To: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Abel Vesa , Michael Turquette , Stephen Boyd , Richard Cochran Cc: Oleksij Rempel , kernel@pengutronix.de, Fabio Estevam , NXP Linux Team , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 03/19] ARM: imx6q: skip ethernet refclock reconfiguration if enet_clk_ref is present Date: Tue, 31 Jan 2023 09:46:26 +0100 Message-Id: <20230131084642.709385-4-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230131084642.709385-1-o.rempel@pengutronix.de> References: <20230131084642.709385-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756527561374904015?= X-GMAIL-MSGID: =?utf-8?q?1756527561374904015?= Current mach-imx6q code has following logic: - if ptp clock of the ethernet controller node is attached to the SoC internal enet_ref clock, then we configure RMII reference clock pin as output by setting IOMUXC_GPR1 BIT(21). In this case - MAC (SoC) is the clock provider, PHY is the clock consumer. - if ptp clock of the ethernet controller node is not attached to the enet_ref clock, then we configure RMII reference clock pin as input by clearing IOMUXC_GPR1 BIT(21). In this case - PHY is the clock provider, MAC is the clock consumer. According to the Freescale MX6SDL ReferenceManual v4, IOMUXC_GPR1 BIT(21) (page 2033) this configuration bit is not related to the PTP (IEEE1588) clock: 21 ENET_CLK_SEL - choose enet reference clk mode: 0 - get enet tx reference clk from pad (external OSC for both external PHY and Internal Controller) 1 - get enet tx reference clk from internal clock from anatop (loopback through pad), this clock also sent out to external PHY. According to the Documentation/devicetree/bindings/net/fsl,fec.yaml: The "ptp"(option), for IEEE1588 timer clock that requires the clock. The "enet_clk_ref"(option), for MAC transmit/receiver reference clock like RGMII TXC clock or RMII reference clock. It depends on board design, the clock is required if RGMII TXC and RMII reference clock source from SOC internal PLL. The "enet_out"(option), output clock for external device, like supply clock for PHY. The clock is required if PHY clock source from SOC. We can see, that "enet_clk_ref" clock is the best fit for this purpose. Other properties like "ptp" is designed for IEEE1588 and "enet_out" do not have real functionality within imx related clock infrastructure. Since the "enet_clk_ref" is not used by the imx6qdl devicetrees, we can use it as indicator of potentially properly configured DT. At same time we can keep ptp clock based logic as the fallback for old DTs. Signed-off-by: Oleksij Rempel --- arch/arm/mach-imx/mach-imx6q.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c index c9d7c29d95e1..7f6200925752 100644 --- a/arch/arm/mach-imx/mach-imx6q.c +++ b/arch/arm/mach-imx/mach-imx6q.c @@ -79,7 +79,7 @@ static void __init imx6q_enet_phy_init(void) static void __init imx6q_1588_init(void) { struct device_node *np; - struct clk *ptp_clk; + struct clk *ptp_clk, *fec_enet_ref; struct clk *enet_ref; struct regmap *gpr; u32 clksel; @@ -90,6 +90,14 @@ static void __init imx6q_1588_init(void) return; } + /* + * If enet_clk_ref configured, we assume DT did it properly and . + * clk-imx6q.c will do needed configuration. + */ + fec_enet_ref = of_clk_get_by_name(np, "enet_clk_ref"); + if (!IS_ERR(fec_enet_ref)) + goto put_node; + ptp_clk = of_clk_get(np, 2); if (IS_ERR(ptp_clk)) { pr_warn("%s: failed to get ptp clock\n", __func__); From patchwork Tue Jan 31 08:46:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 50735 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2637352wrn; Tue, 31 Jan 2023 00:53:59 -0800 (PST) X-Google-Smtp-Source: AK7set+qTBO8XgX3wF5wtw7jEZDInN2T0teDShBgYmomfQAKDSBWAJraCnaGXfrsLRTzI1P7TeNB X-Received: by 2002:a05:6a00:190e:b0:593:b309:aa55 with SMTP id y14-20020a056a00190e00b00593b309aa55mr9484623pfi.28.1675155239518; Tue, 31 Jan 2023 00:53:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675155239; cv=none; d=google.com; s=arc-20160816; b=bpSW1giJPYGtPbFdVGwcGPbSBaEhQt8YnKlIg4yqZf/PqPJIJAQqUCxci0T9QsL/pF 2ZTc7b7uGz95koptAQTeo2m9B//6pgk05rdce8m+7iAZ2XwE+xcTCfw2GqIVCL5RDmNP Te3OKujdP/zs2YPQHwFeSD69y0dpE2A1/iVxPuAfZIITJrH5cYhutfmEm449ZNtCKX73 RQUOaPdkgFWVYT4TIM9yjgNupFrrsG63K9OMelwTP6hBwMmPFZtCWvqKEHJzfc6XybZP Nezn3K/7AOpdY/evlQAlwGHbrfS+8UEJKFsMMkfB6AVJHkVXgSen4YH2OiKLyAmuZjz2 Iyyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=hBrCgVGRusIcY7u2DnlVJKVaPNEdeQll6rowglQyKOU=; b=H3aph/liPrcjlwLSHDmcrbPJ6F9r/EvDtW6LusOawpGRp5BEQqorVaVXptj0div25H nHmuiHS3m0ONbJZGZ9AqBhImhlQD8k+tYAtRWrE0sTuOqh45JEb5+76sYR64Zli4vg0T ZSRrE1Rg0LFsek2GwUrz7bqnqrQwT2PwIpewMsc7UzrWaINbiCBsObUcpqw+yw5FM1kZ ZQvtVX2DzHjMnlqX4DT4Fo0lkXV8ibOBm0toB9gs4/WsfYV/KsPekK0eBAlZ7wJG4DF0 EgwwE5nLmdD6CuhsxUaeYRUNvqls16DWVNcdQ6gnc3TBjb8qMrPBijT/yuB4IfaH+nHz Zc1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m14-20020a62f20e000000b00593d279ca07si3881155pfh.189.2023.01.31.00.53.47; Tue, 31 Jan 2023 00:53:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230204AbjAaIwj (ORCPT + 99 others); Tue, 31 Jan 2023 03:52:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232024AbjAaIwB (ORCPT ); Tue, 31 Jan 2023 03:52:01 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4A68DBCD for ; Tue, 31 Jan 2023 00:47:57 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMmHu-0003rQ-Dj; Tue, 31 Jan 2023 09:46:46 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pMmHu-001eLc-Fj; Tue, 31 Jan 2023 09:46:45 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pMmHr-002yZT-2J; Tue, 31 Jan 2023 09:46:43 +0100 From: Oleksij Rempel To: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Abel Vesa , Michael Turquette , Stephen Boyd , Richard Cochran Cc: Oleksij Rempel , kernel@pengutronix.de, Fabio Estevam , NXP Linux Team , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 04/19] ARM: dts: imx6qdl: use enet_clk_ref instead of enet_out for the FEC node Date: Tue, 31 Jan 2023 09:46:27 +0100 Message-Id: <20230131084642.709385-5-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230131084642.709385-1-o.rempel@pengutronix.de> References: <20230131084642.709385-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756527580760202664?= X-GMAIL-MSGID: =?utf-8?q?1756527580760202664?= Old imx6q machine code makes RGMII/RMII clock direction decision based on configuration of "ptp" clock. "enet_out" is not used and make no real sense, since we can't configure it as output or use it as clock provider. Instead of "enet_out" use "enet_clk_ref" which is actual selector to choose between internal and external clock source: FEC MAC <---------- enet_clk_ref <--------- SoC PLL \ ^------<-> refclock PAD (bi directional) Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6qdl.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index ff1e0173b39b..71522263031a 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -1050,8 +1050,8 @@ fec: ethernet@2188000 { clocks = <&clks IMX6QDL_CLK_ENET>, <&clks IMX6QDL_CLK_ENET>, <&clks IMX6QDL_CLK_ENET_REF>, - <&clks IMX6QDL_CLK_ENET_REF>; - clock-names = "ipg", "ahb", "ptp", "enet_out"; + <&clks IMX6QDL_CLK_ENET_REF_SEL>; + clock-names = "ipg", "ahb", "ptp", "enet_clk_ref"; fsl,stop-mode = <&gpr 0x34 27>; status = "disabled"; }; From patchwork Tue Jan 31 08:46:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 50724 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2637199wrn; Tue, 31 Jan 2023 00:53:30 -0800 (PST) X-Google-Smtp-Source: AK7set8ywzc8c9h3C1WmgOgED2jTKpF2Zi/nP0s5xjYDlevSJMmZLhcFNGRMpB0k04Wh2ShcarAi X-Received: by 2002:a17:902:cec1:b0:196:88e0:ea10 with SMTP id d1-20020a170902cec100b0019688e0ea10mr5571569plg.60.1675155210199; Tue, 31 Jan 2023 00:53:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675155210; cv=none; d=google.com; s=arc-20160816; b=clxs22SDVEc3Oa+HWoMpkGZHpb4PzYHNRhdp+R09CPloVRmTUV7n+A0h+YWw5VkFCL /+pB3HvYpk1ZH054f8OH70JI8n82HmL4Xtey0BVmFG3T0u3JpEAGdBg5Q12X/+jKrggF 5C7ynyEwSn9dBAsDTlIqlFvGBi9V8FzxmhfdOGAilCE/LkXbIx5X2lVTjQFD8QfP5Kbh 4Mj+DEkvkdqPGN6zxhUoDPIlgZmOlngjhELsKluKC8Ly8ONkHaYKkLL0XxKy+ygHH/pv oENfxNjDEZ8hJTgmnBvbIzmVgkSebKHoJBTmJP1WWkw5//wVJ9Y8GB9HFTayPKkz93XL 0QNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=as2tSa4ZNRD7Nf3EtMX9qcU/Rl+Akfottb0BLeDHQdg=; b=OtbYKVHGSWubng5NyZbpgVl7N4UEun4/fOHCGRNXdHm/Ve3X5Gw5VXv2l36Z0BurVE KCc2LaxuLGhkJjERgQ3qG5ptwj5sF+pMruI1bK93YPnh3RaiFeVltB6Q6PSgwZbE5etH jnzWvoax2rAdc3JNTXNwN6MRpUeg+Tc04iAvkJiZCSn9hAI4ocDjMRICYEszAlUodhWt Y5P3doGpnVSINnXuNJI13t/THJUCyLOk4OB7JZhdZMdJjQHDpK/UhHIaF6eWABnA8CAe eoP5GuXmjWovF2NQFmxF3M553fmGpRXVkkGeLDsJc0qqe6eNZMHOYJ5iRPux5pGReWFd P1KA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t5-20020a170902e84500b001944ced796asi18177061plg.125.2023.01.31.00.53.09; Tue, 31 Jan 2023 00:53:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231964AbjAaIvu (ORCPT + 99 others); Tue, 31 Jan 2023 03:51:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231656AbjAaIvV (ORCPT ); Tue, 31 Jan 2023 03:51:21 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E25684FC26 for ; Tue, 31 Jan 2023 00:47:24 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMmHv-0003tY-C2; Tue, 31 Jan 2023 09:46:47 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pMmHv-001eLz-CB; Tue, 31 Jan 2023 09:46:46 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pMmHr-002yZc-2x; Tue, 31 Jan 2023 09:46:43 +0100 From: Oleksij Rempel To: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Abel Vesa , Michael Turquette , Stephen Boyd , Richard Cochran Cc: Oleksij Rempel , kernel@pengutronix.de, Fabio Estevam , NXP Linux Team , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 05/19] ARM: dts: imx6dl-lanmcu: configure ethernet reference clock parent Date: Tue, 31 Jan 2023 09:46:28 +0100 Message-Id: <20230131084642.709385-6-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230131084642.709385-1-o.rempel@pengutronix.de> References: <20230131084642.709385-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756527549285057089?= X-GMAIL-MSGID: =?utf-8?q?1756527549285057089?= On this board the PHY is the ref clock provider. So, configure ethernet reference clock as input. Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6dl-lanmcu.dts | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6dl-lanmcu.dts b/arch/arm/boot/dts/imx6dl-lanmcu.dts index 6b6e6fcdea9c..fa823988312d 100644 --- a/arch/arm/boot/dts/imx6dl-lanmcu.dts +++ b/arch/arm/boot/dts/imx6dl-lanmcu.dts @@ -21,6 +21,7 @@ clock_ksz8081: clock-ksz8081 { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <50000000>; + clock-output-names = "enet_ref_pad"; }; backlight: backlight { @@ -109,14 +110,17 @@ &can2 { status = "okay"; }; +&clks { + clocks = <&clock_ksz8081>; + clock-names = "enet_ref_pad"; + assigned-clocks = <&clks IMX6QDL_CLK_ENET_REF_SEL>; + assigned-clock-parents = <&clock_ksz8081>; +}; + &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; phy-mode = "rmii"; - clocks = <&clks IMX6QDL_CLK_ENET>, - <&clks IMX6QDL_CLK_ENET>, - <&clock_ksz8081>; - clock-names = "ipg", "ahb", "ptp"; phy-handle = <&rgmii_phy>; status = "okay"; From patchwork Tue Jan 31 08:46:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 50730 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2637253wrn; Tue, 31 Jan 2023 00:53:41 -0800 (PST) X-Google-Smtp-Source: AMrXdXvZqKRnSBxq32L8TY3556TCsMdNxcU8Pp4Y/81v4mH0uGD6BG/PdySKOaowLVTAn+RnD6TI X-Received: by 2002:a05:6a21:398d:b0:b9:19b0:d58a with SMTP id ad13-20020a056a21398d00b000b919b0d58amr50786701pzc.31.1675155221236; Tue, 31 Jan 2023 00:53:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675155221; cv=none; d=google.com; s=arc-20160816; b=WQnWF2rntyhiepQbEdroLIKxCLQvSdSoNsYyLGxK5CfG1uneaiG7cHVvEzJP5SlEFp gup0X80W1nEI43vhr2NGHWYm/USq4Tp117zTl717i6tyCrg3ZXLhZYX3gM0qMJIuoPtU BzNWzM8w9IzxnBlU8l8MXRO1CAtngamM9VC9jtIRdKmDuwaH360baxiAHhgUjy+ywwtc ANAHhrg3Ao1Uom0JQk7iTI8y1gavcWGcz9sHQ3jgD4QaC/lLx0eZU8U+NVUb3K39N4yb 7Si43hjXyMxQsMZ7BW75pSngGNj3pDc4vGuiCDthj2I/e8iQsr73hFRlCGVtveMLnd5a JO3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=pFWqpEiSrDC/WdKulq35sYQHtyoSXieW7pQQeoz6qFA=; b=m88BE1iSoIsq/290oiYnXc7CHREbHCncRMsfz2Pv4JW7ztNaGEOf8TlvvKq5PA2LV0 mQFP5Sd/akKC/1yhy0F+rxWmxzV3v2xTdE4B2s8Zx1XA/r+uvVatik4Mf15NMgtdUYPj lBgDB3lQGb/F00rn1tHD2MtJpiZrNY/kB6mh3oczLd97zoMrgBcdBp8BHNZPTaC54VKO xRHl8KdIky7wRKsUsZFXv9wUSov9SMIuYBr5VR+Ukd7B1qM1VQzQevtmkM+HI+2BSO4O GVwpyT9KXZItgKTnwpKo+yEhM74U4CkmllPciMYTKk6+4HTGPvIslepeJVrP7GRJmjzq 0HSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d7-20020a637347000000b004cc67cfc92bsi15177170pgn.97.2023.01.31.00.53.22; Tue, 31 Jan 2023 00:53:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231694AbjAaIvq (ORCPT + 99 others); Tue, 31 Jan 2023 03:51:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231630AbjAaIvV (ORCPT ); Tue, 31 Jan 2023 03:51:21 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDC614FC24 for ; Tue, 31 Jan 2023 00:47:24 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMmHu-0003rX-Uj; Tue, 31 Jan 2023 09:46:46 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pMmHu-001eLm-U4; Tue, 31 Jan 2023 09:46:46 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pMmHr-002yZl-3W; Tue, 31 Jan 2023 09:46:43 +0100 From: Oleksij Rempel To: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Abel Vesa , Michael Turquette , Stephen Boyd , Richard Cochran Cc: Oleksij Rempel , kernel@pengutronix.de, Fabio Estevam , NXP Linux Team , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 06/19] ARM: dts: imx6dl-alti6p: configure ethernet reference clock parent Date: Tue, 31 Jan 2023 09:46:29 +0100 Message-Id: <20230131084642.709385-7-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230131084642.709385-1-o.rempel@pengutronix.de> References: <20230131084642.709385-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756527561055410108?= X-GMAIL-MSGID: =?utf-8?q?1756527561055410108?= On this board the PHY is the ref clock provider. So, configure ethernet reference clock as input. Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6dl-alti6p.dts | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6dl-alti6p.dts b/arch/arm/boot/dts/imx6dl-alti6p.dts index e8325fd680d9..e6a4e2770640 100644 --- a/arch/arm/boot/dts/imx6dl-alti6p.dts +++ b/arch/arm/boot/dts/imx6dl-alti6p.dts @@ -22,6 +22,7 @@ clock_ksz8081: clock-ksz8081 { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <50000000>; + clock-output-names = "enet_ref_pad"; }; i2c2-mux { @@ -191,6 +192,13 @@ &can1 { status = "okay"; }; +&clks { + clocks = <&clock_ksz8081>; + clock-names = "enet_ref_pad"; + assigned-clocks = <&clks IMX6QDL_CLK_ENET_REF_SEL>; + assigned-clock-parents = <&clock_ksz8081>; +}; + &ecspi1 { cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>; pinctrl-names = "default"; @@ -208,10 +216,6 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; phy-mode = "rmii"; - clocks = <&clks IMX6QDL_CLK_ENET>, - <&clks IMX6QDL_CLK_ENET>, - <&clock_ksz8081>; - clock-names = "ipg", "ahb", "ptp"; status = "okay"; mdio { From patchwork Tue Jan 31 08:46:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 50732 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2637325wrn; Tue, 31 Jan 2023 00:53:53 -0800 (PST) X-Google-Smtp-Source: AK7set/J+MNQK63+rNaavMZLZbGMU8z81YDR5v6VrtFiTl/u10mV4aR8W6vQnNFH77kKrwkqNAqR X-Received: by 2002:a17:903:41c9:b0:194:997d:7735 with SMTP id u9-20020a17090341c900b00194997d7735mr13922607ple.48.1675155233369; Tue, 31 Jan 2023 00:53:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675155233; cv=none; d=google.com; s=arc-20160816; b=vtJkKYwvEYQ5CqTJZ1YLvLm3q9RQDYVHh9NDtUe2L5By3BHSCd0wsKJ3vpJga0yEpn DjsOZKMW+LsKyPyLXO9Jpo/ZQ9E25UxSIlEzWXjs/5TAesYs0XDXDwe0FTEXnWEKFol4 +GyxCNhOpiDZis6wIN4Xdb41gE+4C1iQoOStnbj1mkj67vloOgM0yF1efkFNPZoRz9ay U6V47ew9hsgDN8tmTJDq+uADKDpbojXZSjkzVrur4mW0TVsOznxpArBd7s9WblhSHSjS lkoUx8PDDbWv+7zzpt9eY13ng9lkPg9IG3jtCeemM8sKAoh7Globff0nZJ+hT8PukkJ3 SofQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=WMXgor3Mk0Pp4/8EPk6ADBxBq69qtpOZkRPMRbOHBSw=; b=hBOMRwzDKTMJDFs6Fwd2pBgAwi5uPcou7E2CTmlYLLoFUcYEr32GGKU1777KZJjU6k zCElt4OQiEaySAQPX/qsZJq9q59lxDWWr7NoAtdxx5MQaWzEkn19qoaKIFs2fACZwX/P m4kr2gAWteVjznz7OJEh08/pH3rQTOUuUJQ76KTImobZ3oA2c8/5/qkchBUFTBdZQbn1 Ikph4Ool9o0GoSuPM/OjU3EizCABWZSgs3+KFmb852Ltf/XUq9Ip6woSAZgkAGK25e5I bTeVzkaK78P4zlbt/QdSDQgpna+wRckQbhdRadS7qzBzd8ou7fgQxz7e+i2CUwSoUHMa 9Dgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q3-20020a170902e30300b001927e835ffasi14074018plc.119.2023.01.31.00.53.40; Tue, 31 Jan 2023 00:53:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232082AbjAaIwH (ORCPT + 99 others); Tue, 31 Jan 2023 03:52:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230204AbjAaIv0 (ORCPT ); Tue, 31 Jan 2023 03:51:26 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CAD055B6 for ; Tue, 31 Jan 2023 00:47:33 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMmHw-0003v5-Ac; Tue, 31 Jan 2023 09:46:48 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pMmHv-001eMJ-TB; Tue, 31 Jan 2023 09:46:46 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pMmHr-002yZu-47; Tue, 31 Jan 2023 09:46:43 +0100 From: Oleksij Rempel To: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Abel Vesa , Michael Turquette , Stephen Boyd , Richard Cochran Cc: Oleksij Rempel , kernel@pengutronix.de, Fabio Estevam , NXP Linux Team , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 07/19] ARM: dts: imx6dl-plybas: configure ethernet reference clock parent Date: Tue, 31 Jan 2023 09:46:30 +0100 Message-Id: <20230131084642.709385-8-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230131084642.709385-1-o.rempel@pengutronix.de> References: <20230131084642.709385-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756527574006442189?= X-GMAIL-MSGID: =?utf-8?q?1756527574006442189?= On this board the PHY is the ref clock provider. So, configure ethernet reference clock as input. Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6dl-plybas.dts | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6dl-plybas.dts b/arch/arm/boot/dts/imx6dl-plybas.dts index c52e6caf3996..e98046eea7a4 100644 --- a/arch/arm/boot/dts/imx6dl-plybas.dts +++ b/arch/arm/boot/dts/imx6dl-plybas.dts @@ -75,6 +75,7 @@ clk50m_phy: phy-clock { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <50000000>; + clock-output-names = "enet_ref_pad"; }; reg_5v0: regulator-5v0 { @@ -99,6 +100,13 @@ &can2 { status = "okay"; }; +&clks { + clocks = <&clk50m_phy>; + clock-names = "enet_ref_pad"; + assigned-clocks = <&clks IMX6QDL_CLK_ENET_REF_SEL>; + assigned-clock-parents = <&clk50m_phy>; +}; + &ecspi1 { cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>; pinctrl-names = "default"; @@ -116,10 +124,6 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; phy-mode = "rmii"; - clocks = <&clks IMX6QDL_CLK_ENET>, - <&clks IMX6QDL_CLK_ENET>, - <&clk50m_phy>; - clock-names = "ipg", "ahb", "ptp"; phy-handle = <&rgmii_phy>; status = "okay"; From patchwork Tue Jan 31 08:46:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 50737 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2637417wrn; Tue, 31 Jan 2023 00:54:15 -0800 (PST) X-Google-Smtp-Source: AK7set+OHWl+os3+owe+znUaoTfnARWdgDKnkw7D2iXKKuIcpa+TU3FUUOk/npCjDPUvC8MT+jJy X-Received: by 2002:a17:90b:4f46:b0:22c:1211:89c0 with SMTP id pj6-20020a17090b4f4600b0022c121189c0mr23002769pjb.30.1675155255278; Tue, 31 Jan 2023 00:54:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675155255; cv=none; d=google.com; s=arc-20160816; b=gSHyaPZj4moqBeLRD/W7f4HYienjcYyGGECeTl54uzfOuxI4xLDjFjhyW2DtVb8SxC 0fk/CohNwuGB7gBDR6jcGT+gxfbubsFxpFMM6liEhmxIpqX6qpb+OeSkswl9njnRiObo 5mTJMwKfOZWhxuUUCkhab6G9XJxkks1ZRo2BUEKL8Zes66mB4fPb3hL+01V8FGZYO9vZ RIWBSNfcuwPlGmB2D1CfsaXww4zRpu7Q9+VXR9//Wsqhiasi5y438Or80cxsayN0qYgN c5UPCvUj1b0p5iBxkr8IAZLpYCURBYdtLV8rNO4qH+xg0oUUaoWYjLlBbnYhgGlF6lJS Hduw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=grd+sam5Qxna5WdoiAfUEZmWfel/NkzbbQ/LAC29JbU=; b=HUX+9u4J16//AWpCBwkDbwl/yPvWBGqItaeqXA/zVAk6OY8Zkv8u4OQKA4p4BnIZKQ MAZPsUpWHiVkkRNspaVDZ7gx9FNDpFT54/QQysa+pKJpWSl5nmabsg7kpACVsIDXHXD3 7+a6vsfchnu/hEVdzPNVIREqJcFaQgKnp+Sk2Qe5Eqqkr2KPeLrKdFU8JORqhx87dBoS bc1e+eIWuaOnMvKdrAK5LRn9lAuTRSYxag7+PzSN1uY8dlYShXb4QSF7pVhiH4v+xmmj 9JclLrn0OO3KKwkFCh85Bh/AVp6VMSgPuMQ0p3wpSMNbxq8DrAQPfMFdqZT0zTRkbcd1 VTuA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b14-20020a17090a990e00b002299b3cd7acsi18702817pjp.83.2023.01.31.00.54.03; Tue, 31 Jan 2023 00:54:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229815AbjAaIwy (ORCPT + 99 others); Tue, 31 Jan 2023 03:52:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231909AbjAaIw1 (ORCPT ); Tue, 31 Jan 2023 03:52:27 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C4164C6C5 for ; Tue, 31 Jan 2023 00:48:17 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMmHu-0003rT-KQ; Tue, 31 Jan 2023 09:46:46 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pMmHu-001eLj-Q6; Tue, 31 Jan 2023 09:46:45 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pMmHr-002ya3-4i; Tue, 31 Jan 2023 09:46:43 +0100 From: Oleksij Rempel To: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Abel Vesa , Michael Turquette , Stephen Boyd , Richard Cochran Cc: Oleksij Rempel , kernel@pengutronix.de, Fabio Estevam , NXP Linux Team , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 08/19] ARM: dts: imx6dl-plym2m: configure ethernet reference clock parent Date: Tue, 31 Jan 2023 09:46:31 +0100 Message-Id: <20230131084642.709385-9-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230131084642.709385-1-o.rempel@pengutronix.de> References: <20230131084642.709385-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756527596619772017?= X-GMAIL-MSGID: =?utf-8?q?1756527596619772017?= On this board the PHY is the ref clock provider. So, configure ethernet reference clock as input. Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6dl-plym2m.dts | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6dl-plym2m.dts b/arch/arm/boot/dts/imx6dl-plym2m.dts index 522660c912a0..e3c10483f33b 100644 --- a/arch/arm/boot/dts/imx6dl-plym2m.dts +++ b/arch/arm/boot/dts/imx6dl-plym2m.dts @@ -84,6 +84,7 @@ clk50m_phy: phy-clock { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <50000000>; + clock-output-names = "enet_ref_pad"; }; reg_3v3: regulator-3v3 { @@ -173,6 +174,13 @@ &can1 { status = "okay"; }; +&clks { + clocks = <&clk50m_phy>; + clock-names = "enet_ref_pad"; + assigned-clocks = <&clks IMX6QDL_CLK_ENET_REF_SEL>; + assigned-clock-parents = <&clk50m_phy>; +}; + &ecspi1 { cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>; pinctrl-names = "default"; @@ -254,10 +262,6 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; phy-mode = "rmii"; - clocks = <&clks IMX6QDL_CLK_ENET>, - <&clks IMX6QDL_CLK_ENET>, - <&clk50m_phy>; - clock-names = "ipg", "ahb", "ptp"; phy-handle = <&rgmii_phy>; status = "okay"; From patchwork Tue Jan 31 08:46:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 50738 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2637494wrn; Tue, 31 Jan 2023 00:54:28 -0800 (PST) X-Google-Smtp-Source: AK7set8yDN705z7wK8dwiJS9+3VEiLmtZ4OhNcBJFNBijXFkH1fbsC5f4WGL63jEX5uT3ggOMdnb X-Received: by 2002:a05:6a00:23c6:b0:592:48ba:9f59 with SMTP id g6-20020a056a0023c600b0059248ba9f59mr22420753pfc.22.1675155268253; Tue, 31 Jan 2023 00:54:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675155268; cv=none; d=google.com; s=arc-20160816; b=MJwCShhz1yQP3LhBi6rIo4j2tIOjjFw03wgXHTYBRSf5kVIwCcKJ6GkW2JwItNUDJ7 /bSDJNS5FIuMgHEjpLfIs5yg8rslI9xQAZZ/P0BQ4YykmmdpJr8jLsvnQQKK+KT0VrzD 3NOyxSxwjntRCiWDSfd84TuDywhTxDxqkm496tbC0GP3vgj21vf02yKJnz/txfGtyFgo W6K0SMmvVH1+cFnL/ZqyID0bFzrr3PZDpfubSZ4lA4N5BDJTjzclei8OO4A35xqjsWOG TRTJNoGAiQIsq/XOf6I2oqt6vIatkit3fthu+HfnWnpQiJxoGA6+Pcios7WKYjx1bvLE xQNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=U725IPXBjHTRMUQLe9NlmSwRWDhEDTaLqSWnBKpqArw=; b=kf5tOacDMyKTfoJGa4bUZltdDux3703FSUD6rbBCSO2XcpnAsAxb0o7JCMVwV/HIjA QyZ/iWNVFNs+8TPdn6rfCjIveVSsSnsoA6nqdyH5zTp5PKXu1a3rJhmhmVDnugQNj5Dk 4sICiduHALn7W8jIdJcMf/YunWaeicgsH02m1TdpwUToiY7+ZKxuOJC30+Uv97dSJkhb Breq+grynW6MjwX52fMtclxaeATbKX5lqW3Icf3U0LYqxcOnEQEg1+UYY26apaxzoHrR tPqaRYLfPhkMfb3HJAX7E9rK9d5/VIlkJSGrwrJaweRv1C3OpmWNTLHLr0/lpnDbQ/6U H9HQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 190-20020a6218c7000000b005939ae441f7si9600534pfy.111.2023.01.31.00.54.16; Tue, 31 Jan 2023 00:54:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232108AbjAaIxF (ORCPT + 99 others); Tue, 31 Jan 2023 03:53:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231767AbjAaIwd (ORCPT ); Tue, 31 Jan 2023 03:52:33 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A7864C6DE for ; Tue, 31 Jan 2023 00:48:28 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMmHu-0003rR-Gm; Tue, 31 Jan 2023 09:46:46 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pMmHu-001eLf-L4; Tue, 31 Jan 2023 09:46:45 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pMmHr-002yaC-5I; Tue, 31 Jan 2023 09:46:43 +0100 From: Oleksij Rempel To: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Abel Vesa , Michael Turquette , Stephen Boyd , Richard Cochran Cc: Oleksij Rempel , kernel@pengutronix.de, Fabio Estevam , NXP Linux Team , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 09/19] ARM: dts: imx6dl-prtmvt: configure ethernet reference clock parent Date: Tue, 31 Jan 2023 09:46:32 +0100 Message-Id: <20230131084642.709385-10-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230131084642.709385-1-o.rempel@pengutronix.de> References: <20230131084642.709385-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756527610638470737?= X-GMAIL-MSGID: =?utf-8?q?1756527610638470737?= On this board the PHY is the ref clock provider. So, configure ethernet reference clock as input. Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6dl-prtmvt.dts | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/imx6dl-prtmvt.dts b/arch/arm/boot/dts/imx6dl-prtmvt.dts index 1f8cddd83ccb..5f4fa796ca18 100644 --- a/arch/arm/boot/dts/imx6dl-prtmvt.dts +++ b/arch/arm/boot/dts/imx6dl-prtmvt.dts @@ -193,6 +193,7 @@ clk50m_phy: phy-clock { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <50000000>; + clock-output-names = "enet_ref_pad"; }; reg_1v8: regulator-1v8 { @@ -293,8 +294,10 @@ &can2 { }; &clks { - assigned-clocks = <&clks IMX6QDL_CLK_LDB_DI0_SEL>; - assigned-clock-parents = <&clks IMX6QDL_CLK_PLL5_VIDEO_DIV>; + clocks = <&clk50m_phy>; + clock-names = "enet_ref_pad"; + assigned-clocks = <&clks IMX6QDL_CLK_LDB_DI0_SEL>, <&clks IMX6QDL_CLK_ENET_REF_SEL>; + assigned-clock-parents = <&clks IMX6QDL_CLK_PLL5_VIDEO_DIV>, <&clk50m_phy>; }; &ecspi1 { @@ -314,10 +317,6 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; phy-mode = "rmii"; - clocks = <&clks IMX6QDL_CLK_ENET>, - <&clks IMX6QDL_CLK_ENET>, - <&clk50m_phy>; - clock-names = "ipg", "ahb", "ptp"; phy-handle = <&rmii_phy>; status = "okay"; From patchwork Tue Jan 31 08:46:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 50722 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2637046wrn; Tue, 31 Jan 2023 00:53:06 -0800 (PST) X-Google-Smtp-Source: AMrXdXuJuC3JajLgzyrVUmKkYcAb8+aWP4GynWwNH/5kACm/x3sSKC21LeyY4zBNtoL4lW9C1dhi X-Received: by 2002:a62:ea13:0:b0:58d:9ad4:adaa with SMTP id t19-20020a62ea13000000b0058d9ad4adaamr49798825pfh.17.1675155186342; Tue, 31 Jan 2023 00:53:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675155186; cv=none; d=google.com; s=arc-20160816; b=sVFGDQG6Xwsyu70bulj6g5LSqffK9VNeQ3mCUSyFdz40xO0WOl5EKZ84REogazoDAp ZmK0cpXhTWKMNx4kduh8qLIWKr0SIvH3Il7nt2TuKTlH8PbVYJ5Uol3LdOc+9FXwYfH/ uUVgSMlnUy1FXVEQnxuXy9O+D9JDL10eZoi+0+YWD/5omy3PzZ43hT2x3iVHQGUnkRKo OxYJRA+o+3drvhEV8uXcRZSlI4XklNooiKamIGTqo4qvFRPnUIAr6apYhWr6rAfpMAnD Qcdt6Ac8H7HqbY5Ct9hniDtpiH9tpq1QfV4v5zt63xMKk+bHoWt4VQYtrWrO/Ov+uK5s /soQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=7aMY2Rtu75NPXwlr0NtKVooiGaC4CYsO13kYBEqj5G8=; b=OGybpcExqRC/nwTZqapQwH+2GFhFJ8I3GI1eNzAsYrmTW4ewz+HXn6i3LUFZgSt6t5 lU7+BuUrF7N9eJ8VbO8VR5PURtY1r6qydypHohWvNj8y62I57R30oQ3w2n4t7yNwoghS SDXyEtJrFn9idnwYmQYckDVtU3kqxTFv7wGrtSZ5xEFvY2N0e/iZwCI3O0qxx561nj4q n2/nOxF4hPUixd5qVFcaBoHXaZBE8F3KkOvYUiJvNVLU4cs3LPRzFss/+KEGIURNTtfN DMu3LI65+LRSr7strQm35LyO4xGjX1FaejdwC/mVaNybtnJvzV0zHDGFwilTxIvqWHeZ WciA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p23-20020a056a000a1700b00593b3c92c60si7797045pfh.177.2023.01.31.00.52.54; Tue, 31 Jan 2023 00:53:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231804AbjAaIvc (ORCPT + 99 others); Tue, 31 Jan 2023 03:51:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230433AbjAaIvN (ORCPT ); Tue, 31 Jan 2023 03:51:13 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 488464FAE4 for ; Tue, 31 Jan 2023 00:47:18 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMmHu-0003rh-TD; Tue, 31 Jan 2023 09:46:46 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pMmHu-001eLo-VO; Tue, 31 Jan 2023 09:46:46 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pMmHr-002yaL-5q; Tue, 31 Jan 2023 09:46:43 +0100 From: Oleksij Rempel To: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Abel Vesa , Michael Turquette , Stephen Boyd , Richard Cochran Cc: Oleksij Rempel , kernel@pengutronix.de, Fabio Estevam , NXP Linux Team , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 10/19] ARM: dts: imx6dl-victgo: configure ethernet reference clock parent Date: Tue, 31 Jan 2023 09:46:33 +0100 Message-Id: <20230131084642.709385-11-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230131084642.709385-1-o.rempel@pengutronix.de> References: <20230131084642.709385-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756527524695304072?= X-GMAIL-MSGID: =?utf-8?q?1756527524695304072?= On this board the PHY is the ref clock provider. So, configure ethernet reference clock as input. Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6dl-victgo.dts | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6dl-victgo.dts b/arch/arm/boot/dts/imx6dl-victgo.dts index 72df1dba83be..23274be08e61 100644 --- a/arch/arm/boot/dts/imx6dl-victgo.dts +++ b/arch/arm/boot/dts/imx6dl-victgo.dts @@ -54,6 +54,7 @@ clk50m_phy: phy-clock { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <50000000>; + clock-output-names = "enet_ref_pad"; }; rotary-encoder { @@ -134,6 +135,13 @@ vdiv_hitch_pos: voltage-divider-hitch-pos { }; }; +&clks { + clocks = <&clk50m_phy>; + clock-names = "enet_ref_pad"; + assigned-clocks = <&clks IMX6QDL_CLK_ENET_REF_SEL>; + assigned-clock-parents = <&clk50m_phy>; +}; + &ecspi2 { cs-gpios = <&gpio5 12 GPIO_ACTIVE_LOW>; pinctrl-names = "default"; @@ -182,10 +190,6 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; phy-mode = "rmii"; - clocks = <&clks IMX6QDL_CLK_ENET>, - <&clks IMX6QDL_CLK_ENET>, - <&clk50m_phy>; - clock-names = "ipg", "ahb", "ptp"; phy-handle = <&rmii_phy>; status = "okay"; From patchwork Tue Jan 31 08:46:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 50725 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2637208wrn; Tue, 31 Jan 2023 00:53:31 -0800 (PST) X-Google-Smtp-Source: AK7set8ad8uhhekjWCY0Q1EdjikM9kluGAKnq6o7TAQxZJCV6SepShsW5Jh4fkTemVRlu+13ApLR X-Received: by 2002:a17:90a:e7ca:b0:22c:1bd6:77d8 with SMTP id kb10-20020a17090ae7ca00b0022c1bd677d8mr21050693pjb.11.1675155211550; Tue, 31 Jan 2023 00:53:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675155211; cv=none; d=google.com; s=arc-20160816; b=SM0dSgz6deiZx7lfxa3Xrl6r12Rt9jBO0CnAU251KPHBuZNxCIJwMW9WTQCybQhx6I mJd3QidsplLonRT0XdbYWzrMxOIk/Uw0seqdnjYGiH8I0Yb1/k2I+/Uv9xYl9qJ+fqhL CWENTjsraObxz+TIIx3NMBP//IYdI8ipNQfCKaQW1aj9wZUtBN3WvMTtwy6jfrHjEVVa K527jIA7retz+fkRHFxPp+4+y1r+rwZGX68oc3SML7z1XZNOMQEicMZQCOvNd63bZk2s 9nMt7e8CBzVBk21O5AJSw8yWzOu+PJUL1CDC5DHPY0RYduxcgIIhdZzPeRngRShBjk7/ /QCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=mPNwXsX/GoA7be1rGkNuf9WDExESx3gYnmj7pY3U4YE=; b=YmximnGZuifCXQayZ0SEHPFXyuHGDSECZgCKBFMHxkakvq38h5PA2oATCPF392QZa8 WuogqQeRWH6u8xKQJQev4ijMxBrQL1/AW8Z22OGxcvo1ZJnOocZwhz9o3JuDMTRZ4OKj d4tOk36wdxdA+rWvV3164fy8zjzyZTt4j0rqvb9aNXq2PRgaDYq02QNGn5F+4JYY4JML n1yKPJWf7JPH6kVWLFkpAlxAPEPVNd6uZWkAUx+wSgQlnX3qgT8B6QTG8dFL0RLj+IQ5 FDUezvRbkXHRLU/bbOs5scln3khClBUxCpcz0Or2APirguAHY6wK6em3uk+HnhDBCDCL Oy4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z10-20020a17090ad78a00b0022bb6a9677csi6105319pju.35.2023.01.31.00.53.07; Tue, 31 Jan 2023 00:53:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231776AbjAaIv3 (ORCPT + 99 others); Tue, 31 Jan 2023 03:51:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230296AbjAaIvL (ORCPT ); Tue, 31 Jan 2023 03:51:11 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D0E64FAF1 for ; Tue, 31 Jan 2023 00:47:17 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMmHu-0003rL-8E; Tue, 31 Jan 2023 09:46:46 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pMmHt-001eLV-TZ; Tue, 31 Jan 2023 09:46:45 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pMmHr-002yaU-6P; Tue, 31 Jan 2023 09:46:43 +0100 From: Oleksij Rempel To: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Abel Vesa , Michael Turquette , Stephen Boyd , Richard Cochran Cc: Oleksij Rempel , kernel@pengutronix.de, Fabio Estevam , NXP Linux Team , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 11/19] ARM: dts: imx6q-prtwd2: configure ethernet reference clock parent Date: Tue, 31 Jan 2023 09:46:34 +0100 Message-Id: <20230131084642.709385-12-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230131084642.709385-1-o.rempel@pengutronix.de> References: <20230131084642.709385-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756527551216429451?= X-GMAIL-MSGID: =?utf-8?q?1756527551216429451?= On this board the PHY is the ref clock provider. So, configure ethernet reference clock as input. Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6q-prtwd2.dts | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/imx6q-prtwd2.dts b/arch/arm/boot/dts/imx6q-prtwd2.dts index 349959d38020..54a57a4548e2 100644 --- a/arch/arm/boot/dts/imx6q-prtwd2.dts +++ b/arch/arm/boot/dts/imx6q-prtwd2.dts @@ -22,6 +22,13 @@ memory@80000000 { reg = <0x80000000 0x20000000>; }; + clk50m_phy: phy-clock { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <50000000>; + clock-output-names = "enet_ref_pad"; + }; + usdhc2_wifi_pwrseq: usdhc2_wifi_pwrseq { compatible = "mmc-pwrseq-simple"; pinctrl-names = "default"; @@ -49,13 +56,17 @@ &can1 { status = "okay"; }; +&clks { + clocks = <&clk50m_phy>; + clock-names = "enet_ref_pad"; + assigned-clocks = <&clks IMX6QDL_CLK_ENET_REF_SEL>; + assigned-clock-parents = <&clk50m_phy>; +}; + &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; phy-mode = "rmii"; - clocks = <&clks IMX6QDL_CLK_ENET>, - <&clks IMX6QDL_CLK_ENET>; - clock-names = "ipg", "ahb"; status = "okay"; fixed-link { From patchwork Tue Jan 31 08:46:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 50736 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2637406wrn; Tue, 31 Jan 2023 00:54:10 -0800 (PST) X-Google-Smtp-Source: AMrXdXv3fWCpk4td6yC86DnqhjmBNyZ42gC8E+wemhyiPkXBMddztr/zkn+FX5F36+GgnaAYnvha X-Received: by 2002:a05:6a20:d80e:b0:b8:8098:7ee5 with SMTP id iv14-20020a056a20d80e00b000b880987ee5mr54245267pzb.60.1675155250470; Tue, 31 Jan 2023 00:54:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675155250; cv=none; d=google.com; s=arc-20160816; b=DUAjyenqPMKk6Opj+sGXYiaQKoQxnZzQIMu7005r8+IwrAH2Y/r9aRH0HHkqeA0qfc 0qLO9sVtuEK82fzb6h0tCHcaZMZtoqs3iZkuXfNTG8YHEufwgHrWi6LDoQHQj4VZpgFV TtXmyXF4Kc2wMLWbZjsWVVKXthwYJ4OvPczj1iapLntUG1ku8wRoPJKLYuECo/MJGrCM lP45+PGj+ZAN+yZpXeR3PAmbukp103T4ytiCTiuzqVvg9HtzlWzqYXOJjwzABn/vvFtJ STjsoIZ6iP4DGgenLuo5jNSpwRQo0jZOymCmWsnqvOFNgPtie/oSOEfI/5jIcjeTLK// 9+eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ud55DqyNR1gqbbnvAWxlT0yHWFQVsEg6fA69rQs/30w=; b=IrR+aByYcSS/a+TYhlgFV/irvURo4ugxoaDYIBBoVrZ50nES6ybQ/7uJNjvEyIrB+q 8q3UNsHoHyFO+qVWAo0vRMSmJ75Ja84alHH0Gb1YCYgsW2ndI+yXS7nWy3EXMPaXOIn2 YnfPj08ShdDwm0QytK3/nVSGx3tfmYMSz+w/Ny3lXedCNl+Fl3YTfcKOWfq8JJsnja3o oe57Q1/fv96TKf3qJAoxckvOvb1ezT9b7EefnM14mUvxF2n8K81M33wQ4Ua8Y3VbClde 9D4Bwgx4ZRuBpAZY/7wHIMq8oJ4Q4AbiHcB4cdfjS0HhR7H9sQEnWSF6Ham7GqzTIqhJ bPXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y2-20020aa78f22000000b0059242a657d9si15961002pfr.140.2023.01.31.00.53.58; Tue, 31 Jan 2023 00:54:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232088AbjAaIwn (ORCPT + 99 others); Tue, 31 Jan 2023 03:52:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230315AbjAaIwB (ORCPT ); Tue, 31 Jan 2023 03:52:01 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49FF214EA3 for ; Tue, 31 Jan 2023 00:47:58 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMmHu-0003rK-8B; Tue, 31 Jan 2023 09:46:46 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pMmHt-001eLS-Kg; Tue, 31 Jan 2023 09:46:44 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pMmHr-002yad-6x; Tue, 31 Jan 2023 09:46:43 +0100 From: Oleksij Rempel To: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Abel Vesa , Michael Turquette , Stephen Boyd , Richard Cochran Cc: Oleksij Rempel , kernel@pengutronix.de, Fabio Estevam , NXP Linux Team , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 12/19] ARM: dts: imx6qdl-skov-cpu: configure ethernet reference clock parent Date: Tue, 31 Jan 2023 09:46:35 +0100 Message-Id: <20230131084642.709385-13-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230131084642.709385-1-o.rempel@pengutronix.de> References: <20230131084642.709385-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756527592006502289?= X-GMAIL-MSGID: =?utf-8?q?1756527592006502289?= On this board the PHY is the ref clock provider. So, configure ethernet reference clock as input. Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi b/arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi index 3def1b621c8e..2731faede1cb 100644 --- a/arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi +++ b/arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi @@ -105,6 +105,7 @@ clk50m_phy: phy-clock { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <50000000>; + clock-output-names = "enet_ref_pad"; }; reg_3v3: regulator-3v3 { @@ -232,13 +233,16 @@ adc: adc@0 { }; }; +&clks { + clocks = <&clk50m_phy>; + clock-names = "enet_ref_pad"; + assigned-clocks = <&clks IMX6QDL_CLK_ENET_REF_SEL>; + assigned-clock-parents = <&clk50m_phy>; +}; + &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; - clocks = <&clks IMX6QDL_CLK_ENET>, - <&clks IMX6QDL_CLK_ENET>, - <&clk50m_phy>; - clock-names = "ipg", "ahb", "ptp"; phy-mode = "rmii"; phy-supply = <®_3v3>; status = "okay"; From patchwork Tue Jan 31 08:46:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 50740 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2638057wrn; Tue, 31 Jan 2023 00:56:12 -0800 (PST) X-Google-Smtp-Source: AK7set+fUOtB5Ph9pgMlc1vJEum8UzlSFj5QVrL3zb5IwSfnvpLqlgtpquiEt+d9zLk1CI/eegST X-Received: by 2002:a17:90b:4a45:b0:229:2d61:e419 with SMTP id lb5-20020a17090b4a4500b002292d61e419mr12956986pjb.14.1675155372676; Tue, 31 Jan 2023 00:56:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675155372; cv=none; d=google.com; s=arc-20160816; b=HVEZ7ouO48VZZgSbu2inTigcaKAePSuDO7dIgKeTMFMGoLCzqe0BSSadAkWXliS/fU vQnJWIdvhS5GjmUWXU/Q8PYwLSLy5dMCkMQEeFIOs4/835ji/JZBbUBPq+wlvDTnCN7H 6+MTELHK0UDUz9iVkf7kRpyIsrBwQ2cLXh37h/kKhXGxEjfR4jbystIAsVnkFY+l/+8a r3AkC8HskFNXd35Rt0lUa3s+3NZcWNyuvFvru5Oselx42tV0RZr9ocskp4DqRdnaTF4R 2WWLVitwaFQnlcGffnF19LfOhXUipOxva9/IzWhfBSCCQt14pKC1YJf8hmO9fUOKykYl vo6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Fgv32QB8dX9inGxzOWqMcNyiOpfLF6NMITiRrMUl3Gw=; b=Rk1E2Q3Lmm81hu3H/wUoQiHt3yTwsf52REgpLmaDumCHzVLIG97Tb16UaOd/472CG9 f+t+PuDWqrD0n3yVUfHQe8DK0X2TMwMbCwiQE0M5sewxkemq4jrNkYUHjvblK+jC61dz 17PjX2uVw8rw9Hzi4gPErEbdQSxD09J1kcCoaZcb7uo45jKFdvDvL1m1pSOj46RiPa54 LmY9Btmb8+trmq93VlMMnITnBCrk9jQSncYW3yW5X/x4pt9fGe579DPR9l7TWsoef25+ piqLsJvvXy2/wDfBT6HRiJ6x0tl+2GEN3GpQjPc+5eIo3qiLBMXC5FVCll8moDtIy5zs kb1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id go23-20020a17090b03d700b00229189b6fd9si19857712pjb.85.2023.01.31.00.56.00; Tue, 31 Jan 2023 00:56:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232177AbjAaIyP (ORCPT + 99 others); Tue, 31 Jan 2023 03:54:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232068AbjAaIxe (ORCPT ); Tue, 31 Jan 2023 03:53:34 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C69F4DE32 for ; Tue, 31 Jan 2023 00:49:23 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMmHw-0003vr-C3; Tue, 31 Jan 2023 09:46:48 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pMmHw-001eMR-3C; Tue, 31 Jan 2023 09:46:47 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pMmHr-002yam-7W; Tue, 31 Jan 2023 09:46:43 +0100 From: Oleksij Rempel To: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Abel Vesa , Michael Turquette , Stephen Boyd , Richard Cochran Cc: Oleksij Rempel , kernel@pengutronix.de, Fabio Estevam , NXP Linux Team , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 13/19] ARM: dts: imx6dl-eckelmann-ci4x10: configure ethernet reference clock parent Date: Tue, 31 Jan 2023 09:46:36 +0100 Message-Id: <20230131084642.709385-14-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230131084642.709385-1-o.rempel@pengutronix.de> References: <20230131084642.709385-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756527720114617676?= X-GMAIL-MSGID: =?utf-8?q?1756527720114617676?= On this board the PHY is the ref clock provider. So, configure ethernet reference clock as input. Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6dl-eckelmann-ci4x10.dts | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/imx6dl-eckelmann-ci4x10.dts b/arch/arm/boot/dts/imx6dl-eckelmann-ci4x10.dts index 864dc5018451..33825b5a8f26 100644 --- a/arch/arm/boot/dts/imx6dl-eckelmann-ci4x10.dts +++ b/arch/arm/boot/dts/imx6dl-eckelmann-ci4x10.dts @@ -28,6 +28,7 @@ rmii_clk: clock-rmii { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <50000000>; + clock-output-names = "enet_ref_pad"; }; reg_usb_h1_vbus: regulator-usb-h1-vbus { @@ -64,6 +65,13 @@ &can2 { status = "okay"; }; +&clks { + clocks = <&rmii_clk>; + clock-names = "enet_ref_pad"; + assigned-clocks = <&clks IMX6QDL_CLK_ENET_REF_SEL>; + assigned-clock-parents = <&rmii_clk>; +}; + &ecspi2 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_ecspi2>; @@ -297,11 +305,6 @@ &fec { phy-mode = "rmii"; phy-reset-gpios = <&gpio1 18 GPIO_ACTIVE_LOW>; phy-handle = <&phy>; - clocks = <&clks IMX6QDL_CLK_ENET>, - <&clks IMX6QDL_CLK_ENET>, - <&rmii_clk>, - <&clks IMX6QDL_CLK_ENET_REF>; - clock-names = "ipg", "ahb", "ptp", "enet_out"; status = "okay"; mdio { From patchwork Tue Jan 31 08:46:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 50727 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2637210wrn; Tue, 31 Jan 2023 00:53:32 -0800 (PST) X-Google-Smtp-Source: AK7set+wIISGbvE3NPuCH68HZCsYq0aJrFhA8Ld8p+WjoxRSa2ZZvoQFZUYaWGILf+g/XDrmQotA X-Received: by 2002:a05:6a20:8f06:b0:bc:d738:592e with SMTP id b6-20020a056a208f0600b000bcd738592emr12346885pzk.14.1675155211772; Tue, 31 Jan 2023 00:53:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675155211; cv=none; d=google.com; s=arc-20160816; b=lJ1N0oQbpEpYiuGwoRABpKMQ0yJYn6Y8o1vK/ckKCRk2Fl2yg7KMSHWTIZNv0VhzDf HGtkHbMIGlIin3qu5MjBKzs+hfDfI3EbNrPXzK+obNK6jwkUVZMkA0S2nwUEu3Cr+h4u 0khDRxCw+s9QGC1tvDP+tkNRhENAbSzoaGQ+ToKMueXd8+h7KT9DivOMVRmAmxRdRPfh qgrrxmRSab028qTN36QY4XFhPodoissiMzC0hhN645Zaq5XU/fj7lQfv1IpxwWI5RQQE QGP8n228PyF190vr+3wP9/aF6ZB2aKYZpVm7hya977IZ1S3s7XC6NYF07FXBpq/mFvwC xnjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=0ETXJukCaMQQAvc2taoFMHcAzuNDp7yPijIvmFr05I0=; b=KT5aqnTE0uHj8RZx3wr0ip9J3ORy8fQJTac7PxJvocD0Pyw49vUn4NiSGB+7RVtWwC ad92BKiZccZWfmj/jLP0OlkGaUCQTO+dnAx/u+3yEM9An+8l/wVMr0cRSoqyk2yRuB2r Z1jzJSZWGB6fO9mBlXofH98veNkXDLkDsfyNVQSHxBGwol1TXiCASbNY0Yj8m9hAU89I nV71fzHmwjrIFIXu6DxDpZYZM6KHU7U7dctUFm5xvKe9KkqP2x9AOWGE2RmbL0rQ88+7 iIsjUjj3a7sGu4BJwc2jZpWq3sHbUTj3ADL8odSVfYCCPYSNV9gmkRLINSGzrlmmS7Lt SzOQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j71-20020a638b4a000000b004dfb11310dbsi12424151pge.164.2023.01.31.00.53.05; Tue, 31 Jan 2023 00:53:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231516AbjAaIvl (ORCPT + 99 others); Tue, 31 Jan 2023 03:51:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231138AbjAaIvR (ORCPT ); Tue, 31 Jan 2023 03:51:17 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93A834FC0A for ; Tue, 31 Jan 2023 00:47:20 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMmHv-0003u1-Oi; Tue, 31 Jan 2023 09:46:47 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pMmHv-001eM4-FY; Tue, 31 Jan 2023 09:46:46 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pMmHr-002yav-84; Tue, 31 Jan 2023 09:46:43 +0100 From: Oleksij Rempel To: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Abel Vesa , Michael Turquette , Stephen Boyd , Richard Cochran Cc: Oleksij Rempel , Abel Vesa , kernel@pengutronix.de, Fabio Estevam , NXP Linux Team , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 14/19] clk: imx: add imx_obtain_fixed_of_clock() Date: Tue, 31 Jan 2023 09:46:37 +0100 Message-Id: <20230131084642.709385-15-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230131084642.709385-1-o.rempel@pengutronix.de> References: <20230131084642.709385-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756527550868846466?= X-GMAIL-MSGID: =?utf-8?q?1756527550868846466?= Add imx_obtain_fixed_of_clock() to optionally add clock not configured in the devicetree. Signed-off-by: Oleksij Rempel Reviewed-by: Abel Vesa --- drivers/clk/imx/clk.c | 14 ++++++++++++++ drivers/clk/imx/clk.h | 3 +++ 2 files changed, 17 insertions(+) diff --git a/drivers/clk/imx/clk.c b/drivers/clk/imx/clk.c index 4f7db3c9e144..19cde59a20cb 100644 --- a/drivers/clk/imx/clk.c +++ b/drivers/clk/imx/clk.c @@ -110,6 +110,20 @@ struct clk_hw *imx_obtain_fixed_clock_hw( return __clk_get_hw(clk); } +struct clk_hw *imx_obtain_fixed_of_clock(struct device_node *np, + const char *name, unsigned long rate) +{ + struct clk *clk = of_clk_get_by_name(np, name); + struct clk_hw *hw; + + if (IS_ERR(clk)) + hw = imx_obtain_fixed_clock_hw(name, rate); + else + hw = __clk_get_hw(clk); + + return hw; +} + struct clk_hw *imx_get_clk_hw_by_name(struct device_node *np, const char *name) { struct clk *clk; diff --git a/drivers/clk/imx/clk.h b/drivers/clk/imx/clk.h index afc1ea0f5bcf..3d94722bbf99 100644 --- a/drivers/clk/imx/clk.h +++ b/drivers/clk/imx/clk.h @@ -288,6 +288,9 @@ struct clk * imx_obtain_fixed_clock( struct clk_hw *imx_obtain_fixed_clock_hw( const char *name, unsigned long rate); +struct clk_hw *imx_obtain_fixed_of_clock(struct device_node *np, + const char *name, unsigned long rate); + struct clk_hw *imx_get_clk_hw_by_name(struct device_node *np, const char *name); struct clk_hw *imx_clk_hw_gate_exclusive(const char *name, const char *parent, From patchwork Tue Jan 31 08:46:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 50731 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2637275wrn; Tue, 31 Jan 2023 00:53:45 -0800 (PST) X-Google-Smtp-Source: AK7set+c5RGoPoEMWLBhoA1BBU3o/lBX0Hb7JwsEyA+7kcxOEsgUozxu4+IYIMeJzWsw/+C59ooZ X-Received: by 2002:a05:6a20:549b:b0:be:22c5:92df with SMTP id i27-20020a056a20549b00b000be22c592dfmr6813985pzk.16.1675155225329; Tue, 31 Jan 2023 00:53:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675155225; cv=none; d=google.com; s=arc-20160816; b=IgocO0vkB0GYSBL0wkNnHzbQc1lmbFpX0Rub+LBe8aCvOu0wQTb0JIL2nDUSf7ywwv zBLc2PPqmtaOiq1xhDAyZnfOaCTkcUqomists01ZqrtJ/Q32inqs7k5CX9lC3MNFhQck ST7302urxICUtaG9DXIRgM1gecsWaEbGDR4Y3ZBd94ds9S/IVvBuwo4STcLx09MoJZVM Mwxbs5+T+KSO3WQVlksqUbReO/mSzwxKa3jRgGtH3nZFg93CO04QNcQvfgTuA+vIvWs7 I5rZ8v420LOO4DS4qK5leivO6G+iGzLaOlJmRLsLFh+a5Bez5/gwTh7wFmV4mVzhAs8E WW9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=i/+NWcS7feSNTDT5GLihZYxExgUUut2hcnI5I3OTXDA=; b=KgiNwUoHizh4Rcy5FurBt778sIpJCICSD9xpLJnMIXYVUXuDCWGyrDef/QE5tJRag2 x2pl1Y5Tif2G24CSypARghIKbJ4naCBCieAHJBDx9IIlRV+itMR/KiRLp6sheVc1xAnq JJbSCvTD4dVR8PchAVQIuQ+C+ZFSkQvoQql3xQBlDg5upWs3sSkOmQjUmxERJXheCEW4 NHryhseXer0jkhN/SP0OEWZE2lEWA0lj4KNwM1GlxwDVwP2Wv5fHLqCTadbZ947sGa0s 1bnxCFEZHJed8GmnSNWC7wwGDja9vdgBEeDkuJe4Y958fgGZphsuIgLc0sTJLe7wmZRS NdUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x26-20020a056a00189a00b00593c77bf6e0si6393297pfh.100.2023.01.31.00.53.31; Tue, 31 Jan 2023 00:53:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232063AbjAaIwB (ORCPT + 99 others); Tue, 31 Jan 2023 03:52:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230138AbjAaIvZ (ORCPT ); Tue, 31 Jan 2023 03:51:25 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D88F5266 for ; Tue, 31 Jan 2023 00:47:31 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMmHv-0003u0-DP; Tue, 31 Jan 2023 09:46:47 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pMmHv-001eM6-G2; Tue, 31 Jan 2023 09:46:46 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pMmHr-002yb4-8d; Tue, 31 Jan 2023 09:46:43 +0100 From: Oleksij Rempel To: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Abel Vesa , Michael Turquette , Stephen Boyd , Richard Cochran Cc: Oleksij Rempel , Abel Vesa , kernel@pengutronix.de, Fabio Estevam , NXP Linux Team , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 15/19] clk: imx6ul: fix enet1 gate configuration Date: Tue, 31 Jan 2023 09:46:38 +0100 Message-Id: <20230131084642.709385-16-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230131084642.709385-1-o.rempel@pengutronix.de> References: <20230131084642.709385-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756527565699991110?= X-GMAIL-MSGID: =?utf-8?q?1756527565699991110?= According to the "i.MX 6UltraLite Applications Processor Reference Manual, Rev. 2, 03/2017", BIT(13) is ENET1_125M_EN which is not controlling root of PLL6. It is controlling ENET1 separately. So, instead of this picture (implementation before this patch): fec1 <- enet_ref (divider) <---------------------------, |- pll6_enet (gate) fec2 <- enet2_ref_125m (gate) <- enet2_ref (divider) <-´ we should have this one (after this patch): fec1 <- enet1_ref_125m (gate) <- enet1_ref (divider) <-, |- pll6_enet fec2 <- enet2_ref_125m (gate) <- enet2_ref (divider) <-´ With this fix, the RMII reference clock will be turned off, after setting network interface down on each separate interface (ip l s dev eth0 down). Which was not working before, on system with both FECs enabled. Signed-off-by: Oleksij Rempel Reviewed-by: Abel Vesa --- drivers/clk/imx/clk-imx6ul.c | 7 ++++--- include/dt-bindings/clock/imx6ul-clock.h | 3 ++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c index 67a7a77ca540..c3c465c1b0e7 100644 --- a/drivers/clk/imx/clk-imx6ul.c +++ b/drivers/clk/imx/clk-imx6ul.c @@ -176,7 +176,7 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node) hws[IMX6UL_CLK_PLL3_USB_OTG] = imx_clk_hw_gate("pll3_usb_otg", "pll3_bypass", base + 0x10, 13); hws[IMX6UL_CLK_PLL4_AUDIO] = imx_clk_hw_gate("pll4_audio", "pll4_bypass", base + 0x70, 13); hws[IMX6UL_CLK_PLL5_VIDEO] = imx_clk_hw_gate("pll5_video", "pll5_bypass", base + 0xa0, 13); - hws[IMX6UL_CLK_PLL6_ENET] = imx_clk_hw_gate("pll6_enet", "pll6_bypass", base + 0xe0, 13); + hws[IMX6UL_CLK_PLL6_ENET] = imx_clk_hw_fixed_factor("pll6_enet", "pll6_bypass", 1, 1); hws[IMX6UL_CLK_PLL7_USB_HOST] = imx_clk_hw_gate("pll7_usb_host", "pll7_bypass", base + 0x20, 13); /* @@ -205,12 +205,13 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node) hws[IMX6UL_CLK_PLL3_PFD2] = imx_clk_hw_pfd("pll3_pfd2_508m", "pll3_usb_otg", base + 0xf0, 2); hws[IMX6UL_CLK_PLL3_PFD3] = imx_clk_hw_pfd("pll3_pfd3_454m", "pll3_usb_otg", base + 0xf0, 3); - hws[IMX6UL_CLK_ENET_REF] = clk_hw_register_divider_table(NULL, "enet_ref", "pll6_enet", 0, + hws[IMX6UL_CLK_ENET_REF] = clk_hw_register_divider_table(NULL, "enet1_ref", "pll6_enet", 0, base + 0xe0, 0, 2, 0, clk_enet_ref_table, &imx_ccm_lock); hws[IMX6UL_CLK_ENET2_REF] = clk_hw_register_divider_table(NULL, "enet2_ref", "pll6_enet", 0, base + 0xe0, 2, 2, 0, clk_enet_ref_table, &imx_ccm_lock); - hws[IMX6UL_CLK_ENET2_REF_125M] = imx_clk_hw_gate("enet_ref_125m", "enet2_ref", base + 0xe0, 20); + hws[IMX6UL_CLK_ENET1_REF_125M] = imx_clk_hw_gate("enet1_ref_125m", "enet1_ref", base + 0xe0, 13); + hws[IMX6UL_CLK_ENET2_REF_125M] = imx_clk_hw_gate("enet2_ref_125m", "enet2_ref", base + 0xe0, 20); hws[IMX6UL_CLK_ENET_PTP_REF] = imx_clk_hw_fixed_factor("enet_ptp_ref", "pll6_enet", 1, 20); hws[IMX6UL_CLK_ENET_PTP] = imx_clk_hw_gate("enet_ptp", "enet_ptp_ref", base + 0xe0, 21); diff --git a/include/dt-bindings/clock/imx6ul-clock.h b/include/dt-bindings/clock/imx6ul-clock.h index 79094338e6f1..b44920f1edb0 100644 --- a/include/dt-bindings/clock/imx6ul-clock.h +++ b/include/dt-bindings/clock/imx6ul-clock.h @@ -256,7 +256,8 @@ #define IMX6UL_CLK_GPIO4 247 #define IMX6UL_CLK_GPIO5 248 #define IMX6UL_CLK_MMDC_P1_IPG 249 +#define IMX6UL_CLK_ENET1_REF_125M 250 -#define IMX6UL_CLK_END 250 +#define IMX6UL_CLK_END 251 #endif /* __DT_BINDINGS_CLOCK_IMX6UL_H */ From patchwork Tue Jan 31 08:46:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 50733 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2637330wrn; Tue, 31 Jan 2023 00:53:54 -0800 (PST) X-Google-Smtp-Source: AK7set/fStJDuhPIHs6A5W+UVgZEbVeRcozStdNh/izaRmfn2m7sgz2eyIiMTc48+VhZIGLgGAkg X-Received: by 2002:a17:902:e804:b0:198:9683:9f0a with SMTP id u4-20020a170902e80400b0019896839f0amr3125483plg.30.1675155234672; Tue, 31 Jan 2023 00:53:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675155234; cv=none; d=google.com; s=arc-20160816; b=Tf25y/JY8vzVrIKJW2KJ9n8eUGNpjBmzwc349gM/W6/Adj+7FvTziitvc/CysQJZnd bxkUpVxv2ihx8GonBxCfsspuhZkEVit8dDEE7G6YIIxtvaFp57EAFGbyBt/zylOwTsAS aWaMq5Ij/31jVhIcTdQb9/++KksRtPMSYdUx+r4kxQV/U0JZp/BKxc2Qj5EOSzC3la18 JDxW2l6T6lv6BE8f3XcpJamLfRVA6p3BIAcQqkwBT81xKj6dcBFR0znMFI7KgTXbMnqh 03/5i3DV5EmtPQfN/Yl8reEBGIoH0wlmpBM9xgdhq2Jnd8in1z5o3Fmn7zOYP8tRJpnW XInQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=wwAXbnx4YbVV/C/64R4iyWYG61u9jrw+Os6QRyeJYwQ=; b=Ca26R2S+pt4P1/5m668XeXENxhnQOX0caiX5rtgHryNR4gFJX2lS03G2ycmK8Cmu17 ZDYM9UE1Kej3+w8PXvlJHwKjPvjYzOdT4FTV51aIAX8RBrlQG3+QjYvHtPMrq/Qs9E56 jrf7Pg32RX8Mk+/u4eAC/5ioNWpNEDRvx5nC+fG9eNNLGtOq4KyZZIvR6KrGyKLy7Jqo +Su7o98wBXd8ELAwBa0R4M5gBwKqkIP73t9NTOVo+4TtRIIPOd0FlFrCQjAEzQqMxvZ5 TKb02ujbo7Wy9N2uYdsz0gqzTfquYCyCnWdXyWem6fUBzEB26Y5PceA02vCcg09ekAOU vGYA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h8-20020a170902f54800b00189847745f1si17684745plf.395.2023.01.31.00.53.38; Tue, 31 Jan 2023 00:53:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232065AbjAaIwD (ORCPT + 99 others); Tue, 31 Jan 2023 03:52:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230112AbjAaIvZ (ORCPT ); Tue, 31 Jan 2023 03:51:25 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2EEC30D4 for ; Tue, 31 Jan 2023 00:47:29 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMmHu-0003rP-C1; Tue, 31 Jan 2023 09:46:46 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pMmHu-001eLb-FG; Tue, 31 Jan 2023 09:46:45 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pMmHr-002ybD-9E; Tue, 31 Jan 2023 09:46:43 +0100 From: Oleksij Rempel To: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Abel Vesa , Michael Turquette , Stephen Boyd , Richard Cochran Cc: Oleksij Rempel , Lee Jones , Abel Vesa , kernel@pengutronix.de, Fabio Estevam , NXP Linux Team , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 16/19] clk: imx6ul: add ethernet refclock mux support Date: Tue, 31 Jan 2023 09:46:39 +0100 Message-Id: <20230131084642.709385-17-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230131084642.709385-1-o.rempel@pengutronix.de> References: <20230131084642.709385-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756527575401002135?= X-GMAIL-MSGID: =?utf-8?q?1756527575401002135?= Add ethernet refclock mux support and set it to internal clock by default. This configuration will not affect existing boards. clock tree before this patch: fec1 <- enet1_ref_125m (gate) <- enet1_ref (divider) <-, |- pll6_enet fec2 <- enet2_ref_125m (gate) <- enet2_ref (divider) <-´ after this patch: fec1 <- enet1_ref_sel(mux) <- enet1_ref_125m (gate) <- ... `--<> enet1_ref_pad |- pll6_enet fec2 <- enet2_ref_sel(mux) <- enet2_ref_125m (gate) <- ... `--<> enet2_ref_pad Signed-off-by: Oleksij Rempel Acked-by: Lee Jones Reviewed-by: Abel Vesa --- drivers/clk/imx/clk-imx6ul.c | 26 +++++++++++++++++++++ include/dt-bindings/clock/imx6ul-clock.h | 6 ++++- include/linux/mfd/syscon/imx6q-iomuxc-gpr.h | 6 +++-- 3 files changed, 35 insertions(+), 3 deletions(-) diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c index c3c465c1b0e7..2836adb817b7 100644 --- a/drivers/clk/imx/clk-imx6ul.c +++ b/drivers/clk/imx/clk-imx6ul.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include @@ -94,6 +95,17 @@ static const struct clk_div_table video_div_table[] = { { } }; +static const char * enet1_ref_sels[] = { "enet1_ref_125m", "enet1_ref_pad", }; +static const u32 enet1_ref_sels_table[] = { IMX6UL_GPR1_ENET1_TX_CLK_DIR, + IMX6UL_GPR1_ENET1_CLK_SEL }; +static const u32 enet1_ref_sels_table_mask = IMX6UL_GPR1_ENET1_TX_CLK_DIR | + IMX6UL_GPR1_ENET1_CLK_SEL; +static const char * enet2_ref_sels[] = { "enet2_ref_125m", "enet2_ref_pad", }; +static const u32 enet2_ref_sels_table[] = { IMX6UL_GPR1_ENET2_TX_CLK_DIR, + IMX6UL_GPR1_ENET2_CLK_SEL }; +static const u32 enet2_ref_sels_table_mask = IMX6UL_GPR1_ENET2_TX_CLK_DIR | + IMX6UL_GPR1_ENET2_CLK_SEL; + static u32 share_count_asrc; static u32 share_count_audio; static u32 share_count_sai1; @@ -472,6 +484,17 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node) /* mask handshake of mmdc */ imx_mmdc_mask_handshake(base, 0); + hws[IMX6UL_CLK_ENET1_REF_PAD] = imx_obtain_fixed_of_clock(ccm_node, "enet1_ref_pad", 0); + + hws[IMX6UL_CLK_ENET1_REF_SEL] = imx_clk_gpr_mux("enet1_ref_sel", "fsl,imx6ul-iomuxc-gpr", + IOMUXC_GPR1, enet1_ref_sels, ARRAY_SIZE(enet1_ref_sels), + enet1_ref_sels_table, enet1_ref_sels_table_mask); + hws[IMX6UL_CLK_ENET2_REF_PAD] = imx_obtain_fixed_of_clock(ccm_node, "enet2_ref_pad", 0); + + hws[IMX6UL_CLK_ENET2_REF_SEL] = imx_clk_gpr_mux("enet2_ref_sel", "fsl,imx6ul-iomuxc-gpr", + IOMUXC_GPR1, enet2_ref_sels, ARRAY_SIZE(enet2_ref_sels), + enet2_ref_sels_table, enet2_ref_sels_table_mask); + imx_check_clk_hws(hws, IMX6UL_CLK_END); of_clk_add_hw_provider(np, of_clk_hw_onecell_get, clk_hw_data); @@ -516,6 +539,9 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node) clk_set_parent(hws[IMX6ULL_CLK_EPDC_PRE_SEL]->clk, hws[IMX6UL_CLK_PLL3_PFD2]->clk); clk_set_parent(hws[IMX6UL_CLK_ENFC_SEL]->clk, hws[IMX6UL_CLK_PLL2_PFD2]->clk); + + clk_set_parent(hws[IMX6UL_CLK_ENET1_REF_SEL]->clk, hws[IMX6UL_CLK_ENET_REF]->clk); + clk_set_parent(hws[IMX6UL_CLK_ENET2_REF_SEL]->clk, hws[IMX6UL_CLK_ENET2_REF]->clk); } CLK_OF_DECLARE(imx6ul, "fsl,imx6ul-ccm", imx6ul_clocks_init); diff --git a/include/dt-bindings/clock/imx6ul-clock.h b/include/dt-bindings/clock/imx6ul-clock.h index b44920f1edb0..66239ebc0e23 100644 --- a/include/dt-bindings/clock/imx6ul-clock.h +++ b/include/dt-bindings/clock/imx6ul-clock.h @@ -257,7 +257,11 @@ #define IMX6UL_CLK_GPIO5 248 #define IMX6UL_CLK_MMDC_P1_IPG 249 #define IMX6UL_CLK_ENET1_REF_125M 250 +#define IMX6UL_CLK_ENET1_REF_SEL 251 +#define IMX6UL_CLK_ENET1_REF_PAD 252 +#define IMX6UL_CLK_ENET2_REF_SEL 253 +#define IMX6UL_CLK_ENET2_REF_PAD 254 -#define IMX6UL_CLK_END 251 +#define IMX6UL_CLK_END 255 #endif /* __DT_BINDINGS_CLOCK_IMX6UL_H */ diff --git a/include/linux/mfd/syscon/imx6q-iomuxc-gpr.h b/include/linux/mfd/syscon/imx6q-iomuxc-gpr.h index d4b5e527a7a3..09c6b3184bb0 100644 --- a/include/linux/mfd/syscon/imx6q-iomuxc-gpr.h +++ b/include/linux/mfd/syscon/imx6q-iomuxc-gpr.h @@ -451,8 +451,10 @@ #define IMX6SX_GPR12_PCIE_RX_EQ_2 (0x2 << 0) /* For imx6ul iomux gpr register field define */ -#define IMX6UL_GPR1_ENET1_CLK_DIR (0x1 << 17) -#define IMX6UL_GPR1_ENET2_CLK_DIR (0x1 << 18) +#define IMX6UL_GPR1_ENET2_TX_CLK_DIR BIT(18) +#define IMX6UL_GPR1_ENET1_TX_CLK_DIR BIT(17) +#define IMX6UL_GPR1_ENET2_CLK_SEL BIT(14) +#define IMX6UL_GPR1_ENET1_CLK_SEL BIT(13) #define IMX6UL_GPR1_ENET1_CLK_OUTPUT (0x1 << 17) #define IMX6UL_GPR1_ENET2_CLK_OUTPUT (0x1 << 18) #define IMX6UL_GPR1_ENET_CLK_DIR (0x3 << 17) From patchwork Tue Jan 31 08:46:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 50726 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2637209wrn; Tue, 31 Jan 2023 00:53:31 -0800 (PST) X-Google-Smtp-Source: AK7set9/y2GO9Ks5VkpxGG4ADhrywHTA88/lgZ0GNYrGKaMQGu68CFZEHZLEEkxOLwohWp3aRVev X-Received: by 2002:a05:6a20:938c:b0:bc:f336:98ed with SMTP id x12-20020a056a20938c00b000bcf33698edmr9493410pzh.45.1675155211585; Tue, 31 Jan 2023 00:53:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675155211; cv=none; d=google.com; s=arc-20160816; b=jBQ6nBwwIUfsAjAXhoLJXYlfZLd3peQ2cK2cTIUpHC+ubbS4m4tapEliVpELROYDdy lZE+VA6CErGVcOBDdhW7XLVy2hxFZKqJc7ufsOZ65FszYwEhNp8rAPShduyyRKURiBlh HbUVl7sCdAQ8UbfIScMSlPqeWRXH11WDq2xYZ+kQ9TikaNWxW4b1NUw5rr6CGz1+t5O2 dQu0uGkEoSDBTXNhB0me+vsQrEJNfEzcJ56Fmc9xzPTGNPO1mIy4yLYBtcuBPtexKq9a iaiD+D56Dvq9RHkXYt1tIxTqR3Fq3gz6QSVVWiy9/CncoyYI+TX1dAxcJlNWACvZgUKl kIMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=zP016fjXz0E4mF4XXbsINe06b2le10ECIVcBi2FHn7Y=; b=slfUO7kMIav0wyKulhPzWdyvrhg7Mgh9qjfJa3aEMpseruvZp4KwDiHawHp2kSsZ/L IeVfyIiDvT0PAfzwnHAaaVRUNCXZj9OaAUhtdKxJaI6ygcU8Hvo85EKqAajswMI8wlpq R1xuIbkYz+nRENZ+toUP1EgdD0/pxTKbNmPW5LaRJ2cMDH9Ui7AAvDvWEUQ7ZFQvL51L TytKEkFN4O4f6CckfSzndFyd1el34c6dnYgpj1ApbKV9STLpI7EF6u1bQvt15A80SRdk wtZyBJhcRpMErvxEVBbjlX+6KIqeRtk4eJD8K1OrJEI7wD7rNV8hePK7U4GcVQgntBKY PxgA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m8-20020a637108000000b004db564bb960si14963129pgc.610.2023.01.31.00.53.08; Tue, 31 Jan 2023 00:53:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231260AbjAaIvi (ORCPT + 99 others); Tue, 31 Jan 2023 03:51:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230455AbjAaIvQ (ORCPT ); Tue, 31 Jan 2023 03:51:16 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 395DF4FAE6 for ; Tue, 31 Jan 2023 00:47:19 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMmHw-0003vs-Es; Tue, 31 Jan 2023 09:46:48 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pMmHw-001eMQ-36; Tue, 31 Jan 2023 09:46:47 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pMmHr-002ybM-9p; Tue, 31 Jan 2023 09:46:43 +0100 From: Oleksij Rempel To: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Abel Vesa , Michael Turquette , Stephen Boyd , Richard Cochran Cc: Oleksij Rempel , kernel@pengutronix.de, Fabio Estevam , NXP Linux Team , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 17/19] ARM: dts: imx6ul: set enet_clk_ref to CLK_ENETx_REF_SEL Date: Tue, 31 Jan 2023 09:46:40 +0100 Message-Id: <20230131084642.709385-18-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230131084642.709385-1-o.rempel@pengutronix.de> References: <20230131084642.709385-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756527550927295950?= X-GMAIL-MSGID: =?utf-8?q?1756527550927295950?= IMX6UL_CLK_ENETx_REF is behind of CLK_ENETx_REF_SEL: FEC MAC <---------- CLK_ENETx_REF_SEL <--------- CLK_ENETx_REF \ ^------<-> CLK_ENETx_REF_PAD We should point to the clock selector instead. So, we will be able to use external clock source from CLK_ENETx_REF_PAD as well. At same time, remove enet_out clk. It is using always the same clock as enet_clk_ref and do not help to solve any challenges of this HW. Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6ul.dtsi | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi index 2b5996395701..fa9afedb6549 100644 --- a/arch/arm/boot/dts/imx6ul.dtsi +++ b/arch/arm/boot/dts/imx6ul.dtsi @@ -532,10 +532,9 @@ fec2: ethernet@20b4000 { clocks = <&clks IMX6UL_CLK_ENET>, <&clks IMX6UL_CLK_ENET_AHB>, <&clks IMX6UL_CLK_ENET_PTP>, - <&clks IMX6UL_CLK_ENET2_REF_125M>, - <&clks IMX6UL_CLK_ENET2_REF_125M>; + <&clks IMX6UL_CLK_ENET2_REF_SEL>; clock-names = "ipg", "ahb", "ptp", - "enet_clk_ref", "enet_out"; + "enet_clk_ref"; fsl,num-tx-queues = <1>; fsl,num-rx-queues = <1>; fsl,stop-mode = <&gpr 0x10 4>; @@ -880,10 +879,9 @@ fec1: ethernet@2188000 { clocks = <&clks IMX6UL_CLK_ENET>, <&clks IMX6UL_CLK_ENET_AHB>, <&clks IMX6UL_CLK_ENET_PTP>, - <&clks IMX6UL_CLK_ENET_REF>, - <&clks IMX6UL_CLK_ENET_REF>; + <&clks IMX6UL_CLK_ENET1_REF_SEL>; clock-names = "ipg", "ahb", "ptp", - "enet_clk_ref", "enet_out"; + "enet_clk_ref"; fsl,num-tx-queues = <1>; fsl,num-rx-queues = <1>; fsl,stop-mode = <&gpr 0x10 3>; From patchwork Tue Jan 31 08:46:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 50728 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2637212wrn; Tue, 31 Jan 2023 00:53:32 -0800 (PST) X-Google-Smtp-Source: AK7set/dCxTjdGYryo3vEZ5cCL+qa3clwnVfqM3fBRn5ynN72pbKgbqvdKzShQ9tbdSzYAXZMgK2 X-Received: by 2002:a05:6a00:1516:b0:593:af5d:7c2f with SMTP id q22-20020a056a00151600b00593af5d7c2fmr10354625pfu.11.1675155212069; Tue, 31 Jan 2023 00:53:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675155212; cv=none; d=google.com; s=arc-20160816; b=tjvEIrpU1K0ZsY+vV7VtYpND1pHwKpZY3/lbx363fKZ9Lbznh9PnAa7Fupq4QpIYAo w8bogZlHXJUe5tiuZYQbk+c/q+HdHlcc7g5nvSCja9yveidrIpOgPnfqtRl+evTGltVo aY9mY8oTOp+TJWY5i/H5xXpXQfV4YcuR8S6wepiAtukdd49FIl2QxdW32Etz8H+8gFCY C/L/uCdLDicQZ3WfVNn4N5jKQfbjJ4MERjazVKLUAwSi0zsq4Yn1PLlmnYbF0+s7N2Q/ p23rTOd+PVP8Fa19t6BSrz825szDrcqHpgz02jIqsYQy8NZlytjE8B0umDPyfURPnHit bPlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=wCqmKtCW5CIm6g0ejG4ulpk+/E/aeiiISJz82a0Pqr4=; b=MUwyl5qbNfuQPELDg1q2dfZzY4cgjrUdAsiPk7Hd+1fp4oGhE/zignP4urzuAZx3+q G9+ZCCBOg6Dy8RvEIXLqwkKgtErvnVmwErL4suzZHsTm5JSzBhBIlw0HzXKeGsxQB7v7 PcLKcrvQgW7NMJCd85BMMJXQlVaanTB6s3bT7Yl+lJLHWHe6BYKvWDrbdg2u/4yoZu/t NuUFdXE6a+n3tZYVcbB+F89YGKY2f0jLVUyfzcn+5uTtFoYq5S4PPravinxy2dabpf5W RpCOBROhUhpBgztdQ1P/fOfBwwOpnakgan3kkU8VsIsy6/qScosZ3dB0StMR+112LWh6 APJQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i11-20020aa78b4b000000b00582b674de4dsi14807506pfd.337.2023.01.31.00.53.19; Tue, 31 Jan 2023 00:53:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231688AbjAaIvn (ORCPT + 99 others); Tue, 31 Jan 2023 03:51:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231705AbjAaIvT (ORCPT ); Tue, 31 Jan 2023 03:51:19 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E06F44FC1A for ; Tue, 31 Jan 2023 00:47:22 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMmHv-0003sD-5O; Tue, 31 Jan 2023 09:46:47 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pMmHv-001eLt-57; Tue, 31 Jan 2023 09:46:46 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pMmHr-002ybV-AO; Tue, 31 Jan 2023 09:46:43 +0100 From: Oleksij Rempel To: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Abel Vesa , Michael Turquette , Stephen Boyd , Richard Cochran Cc: Oleksij Rempel , kernel@pengutronix.de, Fabio Estevam , NXP Linux Team , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 18/19] ARM: mach-imx: imx6ul: remove not optional ethernet refclock overwrite Date: Tue, 31 Jan 2023 09:46:41 +0100 Message-Id: <20230131084642.709385-19-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230131084642.709385-1-o.rempel@pengutronix.de> References: <20230131084642.709385-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756527551669576731?= X-GMAIL-MSGID: =?utf-8?q?1756527551669576731?= Ethernet refclock direction is board specific and should be configurable by devicetree. In fact there are board not working with this defaults, which will be fixed by separate patch. Signed-off-by: Oleksij Rempel --- arch/arm/mach-imx/mach-imx6ul.c | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/arch/arm/mach-imx/mach-imx6ul.c b/arch/arm/mach-imx/mach-imx6ul.c index 35e81201cb5d..9208a2d6a9da 100644 --- a/arch/arm/mach-imx/mach-imx6ul.c +++ b/arch/arm/mach-imx/mach-imx6ul.c @@ -4,8 +4,6 @@ */ #include #include -#include -#include #include #include #include @@ -16,30 +14,12 @@ #include "cpuidle.h" #include "hardware.h" -static void __init imx6ul_enet_clk_init(void) -{ - struct regmap *gpr; - - gpr = syscon_regmap_lookup_by_compatible("fsl,imx6ul-iomuxc-gpr"); - if (!IS_ERR(gpr)) - regmap_update_bits(gpr, IOMUXC_GPR1, IMX6UL_GPR1_ENET_CLK_DIR, - IMX6UL_GPR1_ENET_CLK_OUTPUT); - else - pr_err("failed to find fsl,imx6ul-iomux-gpr regmap\n"); -} - -static inline void imx6ul_enet_init(void) -{ - imx6ul_enet_clk_init(); -} - static void __init imx6ul_init_machine(void) { imx_print_silicon_rev(cpu_is_imx6ull() ? "i.MX6ULL" : "i.MX6UL", imx_get_soc_revision()); of_platform_default_populate(NULL, NULL, NULL); - imx6ul_enet_init(); imx_anatop_init(); imx6ul_pm_init(); } From patchwork Tue Jan 31 08:46:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 50734 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2637349wrn; Tue, 31 Jan 2023 00:53:59 -0800 (PST) X-Google-Smtp-Source: AK7set88286bot1jsHaLjHHBYXxXMtAnl7R4UO4a2pas7Q7dTSkhhqikzeqxWn/yMyookqqWWymV X-Received: by 2002:a05:6a20:1601:b0:bc:3cac:9a20 with SMTP id l1-20020a056a20160100b000bc3cac9a20mr19783667pzj.24.1675155239238; Tue, 31 Jan 2023 00:53:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675155239; cv=none; d=google.com; s=arc-20160816; b=LU58xsN8ERUYgn7dYbfnFuJJUGBZVFD1O8pLsdVDoM3W0W1YdH0/cfBYe93L/THWwS mFpDszqi+LFi1ElmsiIvCve7yLMi4PtT71hKRaHs/OOZ+C7DeVpAp4XMcnimk9Sua16p 8sjOoIjUlXqwtocQ1kQ9L403OFUCUZ5QYpxBfHAaiyHHIYv6Bz1H5mqsTP+p//P8WCZ6 ufRU/TOmN42aBBq55y92LvicZ8ZRVdy9i625jOQ4W4KFGcWQ4jxktLOF1ee0tNBr1PYv 7Z829hHRG909S8IWo9zgJwx6rvrsWsMBh8kFD3ooNLYnRsX8Bd21GG6dDG5DaZHlB2E1 9erw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=it5AInT7xMyQfXCTT7H+RISAS/crixmTMWy83LgKUXY=; b=B1ibhmIyEQMNdi8l11Z1v9yBopvV6lT7snGOvkIdYNg8wHE1N3VYp/y24O4NbMdDhg NLxVTJx8kzxtvv1DCEJb00iqfFWJ8cByo5mbvZkPwOVNCJ59Nj0GURzhr51bCYaTpHnc ILnLQV7v/lwN63uxVgtsNIcNWNuXil1PtSF5i52pIU6tIbaM+Nwaq8q/SOyst///eKmS Pjv2uI8yDa2BiQJHRRpKRjDuwo/CWffwz2bmsoGnpq8nM3JUxCDzU2LkhAk6g/OSd88X 7vHbxavv5pQZ0w56MsPxSyIOE8IvjtKW+F7t9n2Ec1PCCsZJa8bD1lYEpUAh+fb+7wZH hBQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p11-20020a63950b000000b0046e9da9ac40si12100787pgd.556.2023.01.31.00.53.47; Tue, 31 Jan 2023 00:53:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230272AbjAaIwc (ORCPT + 99 others); Tue, 31 Jan 2023 03:52:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232060AbjAaIwA (ORCPT ); Tue, 31 Jan 2023 03:52:00 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AD9F113E6 for ; Tue, 31 Jan 2023 00:47:56 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMmHu-0003rM-8C; Tue, 31 Jan 2023 09:46:46 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pMmHu-001eLX-2U; Tue, 31 Jan 2023 09:46:45 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pMmHr-002ybe-Av; Tue, 31 Jan 2023 09:46:43 +0100 From: Oleksij Rempel To: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Abel Vesa , Michael Turquette , Stephen Boyd , Richard Cochran Cc: Oleksij Rempel , kernel@pengutronix.de, Fabio Estevam , NXP Linux Team , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 19/19] ARM: dts: imx6ul-prti6g: configure ethernet reference clock parent Date: Tue, 31 Jan 2023 09:46:42 +0100 Message-Id: <20230131084642.709385-20-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230131084642.709385-1-o.rempel@pengutronix.de> References: <20230131084642.709385-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756527580192528127?= X-GMAIL-MSGID: =?utf-8?q?1756527580192528127?= On this board the PHY is the ref clock provider. So, configure ethernet reference clock as input. Without this patch we have relatively high amount of dropped packets. Signed-off-by: Oleksij Rempel --- arch/arm/boot/dts/imx6ul-prti6g.dts | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/imx6ul-prti6g.dts b/arch/arm/boot/dts/imx6ul-prti6g.dts index c18390f238e1..b7c96fbe7a91 100644 --- a/arch/arm/boot/dts/imx6ul-prti6g.dts +++ b/arch/arm/boot/dts/imx6ul-prti6g.dts @@ -26,6 +26,7 @@ clock_ksz8081_out: clock-ksz8081-out { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <50000000>; + clock-output-names = "enet1_ref_pad"; }; leds { @@ -60,6 +61,13 @@ &can2 { status = "okay"; }; +&clks { + clocks = <&ckil>, <&osc>, <&ipp_di0>, <&ipp_di1>, <&clock_ksz8081_out>; + clock-names = "ckil", "osc", "ipp_di0", "ipp_di1", "enet1_ref_pad"; + assigned-clocks = <&clks IMX6UL_CLK_ENET1_REF_SEL>; + assigned-clock-parents = <&clock_ksz8081_out>; +}; + &ecspi1 { cs-gpios = <&gpio4 26 GPIO_ACTIVE_LOW>; pinctrl-names = "default"; @@ -85,12 +93,6 @@ &fec1 { pinctrl-0 = <&pinctrl_eth1>; phy-mode = "rmii"; phy-handle = <&rmii_phy>; - clocks = <&clks IMX6UL_CLK_ENET>, - <&clks IMX6UL_CLK_ENET_AHB>, - <&clks IMX6UL_CLK_ENET_PTP>, - <&clock_ksz8081_out>; - clock-names = "ipg", "ahb", "ptp", - "enet_clk_ref"; status = "okay"; mdio {