From patchwork Mon Jan 30 13:04:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 50275 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2171537wrn; Mon, 30 Jan 2023 05:14:21 -0800 (PST) X-Google-Smtp-Source: AK7set+rqAuNcD3kAhKVsbAWjHWOB7mfMiPQ2saLlz4BMuYzfs27Hoio0vVjpOR3FMkCnd6xTi1w X-Received: by 2002:a17:90a:358:b0:22c:77e8:235 with SMTP id 24-20020a17090a035800b0022c77e80235mr7541983pjf.21.1675084460607; Mon, 30 Jan 2023 05:14:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675084460; cv=none; d=google.com; s=arc-20160816; b=KNLdlIJuWaAGpw7ZPoPZ5nMuosD0SdP5TboOit3uTmWfpBkAhXNqQ7E7IQDV2tk/CI UzXhYACe551AIScUQNEYiwIVdu/3NWIr3yIMznFS+qbWKhCjSe/z3TjkPMKqYw3xGqll hHF2PAD8fni+HWCFGAanOzke+L7zs8Bb/O+gbURFvVsCOBKfRNEqK9edUlq96z5MLrG2 I7cXKtKTbDsGFfEtlSOwE4KD4MUxJwOKIihzg7kYs9wgWN330fmZS8SKgYV+I+Z5mmSX wgDBHbEJdB6mlmPPhQyf9INog13lBcAhrKvB9Aag1JDCy2Ou9gGW2a9ExR7FYNA9Rrcw dpgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=qeAwgv5Vwrj+ZUHYj+u/v2cRx3SLtK/jWanZZUzZ5X8=; b=rdkJkckQz2nx21fsu+9HHdRSNll6kuFgHaD8qW/thQ1yITRSKm6IL/BSPjFcwJ+rqM 0gqtjMt36AZ/GIyIrekeYt8IJxBZxT2EWi+wP9yRUQSly1iXrPcUNFEREmuOkjY0RDXU J6WQx5YlLvtRnhT7oKPJfeYlovyAD1rX8F08fAVZE2F8loc0Wc8V0pxXPnFOtgG6MaV3 amqiZQsbf9/kMfIzxgLuhsPM+1snX1YD0R5TUwzYfmtG8A0Dhp6L4voyZMPh1+3eU5Be yhGCy5NMu6egHi10JyZ+DKsigOQtLYlwWYB9QQi3/h3bBBlsCYchoElhfemU/Sd+8A5A 4nbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="ss/YBlVw"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u186-20020a6379c3000000b004791e50c5ecsi2564753pgc.87.2023.01.30.05.14.08; Mon, 30 Jan 2023 05:14:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="ss/YBlVw"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236602AbjA3NFD (ORCPT + 99 others); Mon, 30 Jan 2023 08:05:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236100AbjA3NE7 (ORCPT ); Mon, 30 Jan 2023 08:04:59 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A3166589 for ; Mon, 30 Jan 2023 05:04:58 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0096360B21 for ; Mon, 30 Jan 2023 13:04:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4544C433D2; Mon, 30 Jan 2023 13:04:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675083897; bh=mmPMPIPmQMBoM9TxOjnSVNcnUXCZeV3N+dzz5BQ8urI=; h=From:To:Cc:Subject:Date:From; b=ss/YBlVwPSRzs68eTT278PeUuCwFSeUvVRaBWbMkEovzKNJSh9hA8CXy0R6NarH4Z xexXO/NA2ryynCT0d4dIwEuN7c4CpOdsoIO+1eQOLLf5CmOvl7+HnvPU9ptQ+juVdi ryJMEEBmez8NHlPbyyuS9HPNdkNxoF9upX6d2f5wy36c+qsz54eeVmX2Pe9kXdYQpV VhusaCAykFEHQoknQx12e2NJGBbTpInzV2tUVlAIzotJgduSqEa8yREdu2+Js9QqIR w2RiclDurtDUfsS4lTn7GI4VoWMrO4lRdg6oc6wBVxBVDKjLkFBMGg39mVuY++WFVK q0CfgpeOYMeoQ== From: Arnd Bergmann To: Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] soc: sunxi: select CONFIG_PM Date: Mon, 30 Jan 2023 14:04:47 +0100 Message-Id: <20230130130453.379749-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756453363664311339?= X-GMAIL-MSGID: =?utf-8?q?1756453363664311339?= From: Arnd Bergmann Selecting CONFIG_PM_GENERIC_DOMAINS without CONFIG_PM leads to a build failure: WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS Depends on [n]: PM [=n] Selected by [y]: - SUN20I_PPU [=y] && (ARCH_SUNXI [=n] || COMPILE_TEST [=y]) drivers/base/power/domain_governor.c: In function 'default_suspend_ok': drivers/base/power/domain_governor.c:85:24: error: 'struct dev_pm_info' has no member named 'ignore_children' 85 | if (!dev->power.ignore_children) | ^ drivers/base/power/domain.c: In function 'genpd_queue_power_off_work': drivers/base/power/domain.c:657:20: error: 'pm_wq' undeclared (first use in this function) 657 | queue_work(pm_wq, &genpd->power_off_work); | ^~~~~ Unfortunately platforms are inconsistent between using 'select PM' and 'depends on PM' here. CONFIG_PM is a user-visible symbol, so in principle we should be using 'depends on', but on the other hand using 'select' here is more common among drivers/soc. Go with the majority for now, as this has a smaller risk of introducing circular dependencies. We may need to clean this up for consistency later. Fixes: 0e30ca5ab0a8 ("soc: sunxi: Add Allwinner D1 PPU driver") Signed-off-by: Arnd Bergmann Acked-by: Jernej Skrabec --- drivers/soc/sunxi/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/sunxi/Kconfig b/drivers/soc/sunxi/Kconfig index 29e9ba2d520d..02d0b338feb3 100644 --- a/drivers/soc/sunxi/Kconfig +++ b/drivers/soc/sunxi/Kconfig @@ -23,6 +23,7 @@ config SUNXI_SRAM config SUN20I_PPU bool "Allwinner D1 PPU power domain driver" depends on ARCH_SUNXI || COMPILE_TEST + select PM select PM_GENERIC_DOMAINS help Say y to enable the PPU power domain driver. This saves power