From patchwork Mon Jan 30 08:34:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 50184 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2069601wrn; Mon, 30 Jan 2023 00:35:25 -0800 (PST) X-Google-Smtp-Source: AMrXdXuepFDG9czF46wm2kQ34H23dENTeBjSkmEavavrdN37WlXIM48b6DBtSH/lync9jMJTMQfn X-Received: by 2002:a05:6402:1ccc:b0:49c:fdd2:a47d with SMTP id ds12-20020a0564021ccc00b0049cfdd2a47dmr62722710edb.37.1675067725434; Mon, 30 Jan 2023 00:35:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675067725; cv=none; d=google.com; s=arc-20160816; b=DxWN+xAa9bb2qgaL2JuIRjtBod42BXE92NQ0bLN89awwOval1dkMr+z0VoUkK5lfBp wVNh7UfAXLZlzg3Peijy0lObFrxrjQ42jTcmCAsnOW0coTqko+s1kvC8RhQBas01/SLj SagOaSbdxnXpOeGUQZfI/gvm9wiHuYRWfcfVUJVJFhAWl0mAsaWHUL3eXYTMreCO+SL8 QIYKylHDPAujAOyHfDwVtmW02b/oUJ3OIjbA4SwdaFo1lR/ChbzBieOZ7eqRfs83k1WI Oiaf1DWqez1uOwfLMCOBqxB935D7WYPGLe6+Evzj8SxUMRhzSYHYv9XtUWGt+Ew/QiFy IKZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:message-id :mime-version:subject:to:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=Ijt22FfYJZwb7CzGq6fsR/HcKjcUZ41TeiHGp1WDai4=; b=0/oCaGSJxqNuWZP5B/fLng+zm/aNgfEFbpVavUlrC7wZ7CBthGKXE0mK/b0Sua1PO9 tmjLD9FyOelnLAnBFiHicRryuV4QIgYDphU+16kgXdYZ0lKtEkIdVim83djijRFhoguc 8a9TJnBCzOkycVykUSGM3dOPIghHnEdLUedY+yOB97usQtESvmxsf+Vpvf51liy1pL0T G/POP+s1W7CvAICEgweS6PFGgEQhVk3qDAAguSVL7+gpO7Ixe+ts41kgvPgnJx/433SN rVW3HsG4MxXQJWVp8QjfIbSMzw3rOrLCpz7eKy2xOb4V7ktA4euZAoJ6PH5Ml9uykwIR 9iTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=pEHT3YfN; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id vf24-20020a170907239800b008785c366471si12407077ejb.510.2023.01.30.00.35.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 00:35:25 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=pEHT3YfN; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5A11C3858404 for ; Mon, 30 Jan 2023 08:35:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5A11C3858404 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1675067724; bh=Ijt22FfYJZwb7CzGq6fsR/HcKjcUZ41TeiHGp1WDai4=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=pEHT3YfNcAXcQwfoVt5seZXmaQITA3RlvjtpHnBD9dLM+0osQDDWzI9ymZttNnLys eqXjfrBLdSOonksieWSxeH/v9vrPcgFAm8bRgaDkvoBf5q2QTyiNapNXFd9OI567/E j/hmUkz5Vele1ACFSFQ9jLZjChJBPG68NMJ0nV5k= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id ADCCF3858D1E for ; Mon, 30 Jan 2023 08:34:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ADCCF3858D1E Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 910AB1F86B for ; Mon, 30 Jan 2023 08:34:39 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 74B0E13A06 for ; Mon, 30 Jan 2023 08:34:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id pypxGx+B12OuUAAAMHmgww (envelope-from ) for ; Mon, 30 Jan 2023 08:34:39 +0000 Date: Mon, 30 Jan 2023 09:34:39 +0100 (CET) To: gcc-patches@gcc.gnu.org Subject: [PATCH] ipa/108511 - relax assert for undefined local statics MIME-Version: 1.0 Message-Id: <20230130083439.74B0E13A06@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756435815304220355?= X-GMAIL-MSGID: =?utf-8?q?1756435815304220355?= Since we no longer promote undefined local statics extern the assert in possibly_call_in_translation_unit_p triggers. The following relaxes it according to Honzas advice. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR ipa/108511 * cgraph.cc (possibly_call_in_translation_unit_p): Relax assert. --- gcc/cgraph.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/cgraph.cc b/gcc/cgraph.cc index b810237c919..06bc980fa52 100644 --- a/gcc/cgraph.cc +++ b/gcc/cgraph.cc @@ -4183,7 +4183,7 @@ cgraph_edge::possibly_call_in_translation_unit_p (void) node = node->previous_sharing_asm_name; if (node->previous_sharing_asm_name) node = symtab_node::get_for_asmname (DECL_ASSEMBLER_NAME (callee->decl)); - gcc_assert (TREE_PUBLIC (node->decl)); + gcc_assert (TREE_PUBLIC (node->decl) || DECL_EXTERNAL (node->decl)); return node->get_availability () >= AVAIL_INTERPOSABLE; }