From patchwork Sun Jan 29 04:06:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tong Tiangen X-Patchwork-Id: 49939 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1603874wrn; Sat, 28 Jan 2023 20:13:37 -0800 (PST) X-Google-Smtp-Source: AK7set+itkOZivSKVVAZqxGvM3s8HieIUh3WqlYc9bFOnoMy5w2r+pQM9ke/6cl79tlZHkJ86LP5 X-Received: by 2002:a05:6a20:a5a8:b0:ac:21c3:2fb7 with SMTP id bc40-20020a056a20a5a800b000ac21c32fb7mr5108406pzb.6.1674965616857; Sat, 28 Jan 2023 20:13:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674965616; cv=none; d=google.com; s=arc-20160816; b=vfxW4+rWxude6ekLvBHian4iB6HKENtXJ+17pcXeqpExRtp5ulWS3Zv2yd1w9UvS/m YSTqtA+CZHH+SMosL2qEW4uv1opd1aHhIGRV1I91JuBKQyL7diFrBLrXn6tFyn+sQ+wS BzqOQUXLMHPRfRb1JhXgErpvY2B9QSImbM+8rw/d2Z6K/qPKzahwIbJamF12zZaXVwKC ZIkOyfw1IPJkWNvExPYw30tHPFtKLJGu+fUvwUXXmkVT4wtl9d55UNxSYghRAX9wv0zi MluO/BfV6VAoYrVoP1eHrxumSHv9biwJdiKeXvHf5Hc4QVNP1uUWG9O9uinhwNQtHgMg z+QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=v3LUQEGcp2AJAVpi/XguHPJq5//d4cUzfSNrHXFgHFk=; b=wRwP2H9FQwQRZq2rXFtao+pa4o8EOH8SjK1EtuiCeatup3B2OCAk1Mb2bOAJPUry5L pVQTXDOBAaFw75zBVQ+613dqukRH/Fx6s/eKJsE9hmuEzqZGlYQp3Ne9fbKiq1gM8oFY jacX44SKLEtJW9qCHAULRtYOuH9FwIDcWILH5tqpqFIdHGA3s9I7X+9ixFVR0yrFPBkI G53Bzd6wN7xhu/vVZsUMFj5Nna2exlwzVDQV4xopwvCXnYEpXXp9MdJoegve3AQYqfqW gyXOsYqv+tzdySz3yVnUdmwNPeqCsRtQFHem8HZFM06AepaAnvItKGzdoqKPWjeuPQ/N D/Pg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z10-20020a63b04a000000b0046f583c8c4asi8899745pgo.315.2023.01.28.20.13.19; Sat, 28 Jan 2023 20:13:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230168AbjA2EHA (ORCPT + 99 others); Sat, 28 Jan 2023 23:07:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjA2EG5 (ORCPT ); Sat, 28 Jan 2023 23:06:57 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B96311CF5C for ; Sat, 28 Jan 2023 20:06:55 -0800 (PST) Received: from kwepemm600017.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4P4Hl13WRHzRnvL; Sun, 29 Jan 2023 12:04:45 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by kwepemm600017.china.huawei.com (7.193.23.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Sun, 29 Jan 2023 12:06:53 +0800 From: Tong Tiangen To: Andrew Morton , "Aneesh Kumar K . V" CC: , , Tong Tiangen , , Guohanjun Subject: [PATCH -next] memory tier: release the new_memtier in find_create_memory_tier() Date: Sun, 29 Jan 2023 04:06:51 +0000 Message-ID: <20230129040651.1329208-1-tongtiangen@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600017.china.huawei.com (7.193.23.234) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756328746455811440?= X-GMAIL-MSGID: =?utf-8?q?1756328746455811440?= In find_create_memory_tier(), if failed to register device, then we should release new_memtier from the tier list and put device instead of memtier. Fixes: 9832fb87834e ("mm/demotion: expose memory tier details via sysfs") Signed-off-by: Tong Tiangen --- mm/memory-tiers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c index c734658c6242..e593e56e530b 100644 --- a/mm/memory-tiers.c +++ b/mm/memory-tiers.c @@ -211,8 +211,8 @@ static struct memory_tier *find_create_memory_tier(struct memory_dev_type *memty ret = device_register(&new_memtier->dev); if (ret) { - list_del(&memtier->list); - put_device(&memtier->dev); + list_del(&new_memtier->list); + put_device(&new_memtier->dev); return ERR_PTR(ret); } memtier = new_memtier;