From patchwork Sun Jan 29 02:44:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kefeng Wang X-Patchwork-Id: 49930 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1583536wrn; Sat, 28 Jan 2023 18:44:56 -0800 (PST) X-Google-Smtp-Source: AMrXdXs2W+hd2Bq4h5dSJPMHJwNws8OYqX5dC3mm15D9DnKxt2z/eW9O2I/0jHfUDtGxOPUus3fG X-Received: by 2002:a17:906:5da8:b0:7b2:c227:126d with SMTP id n8-20020a1709065da800b007b2c227126dmr51443341ejv.20.1674960296233; Sat, 28 Jan 2023 18:44:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674960296; cv=none; d=google.com; s=arc-20160816; b=M5SOK+kl+ng2QTfXmwPTe33y5/ZJJpCfCWgau8J32nKKqaijXa6FTsMflEEdFKiA1S oM0cS93e97cURsys1pXP4Lpc41tEzD9nCfrZDgof+52REnEI/faj6a49Z8JjdH+QnZGr BHhlryh47EVSZ2uTxIX/cjSE0MLKIS/2tTYv+NUX7kseRqmhdE2fCh8rPV8bMXiZfx9a W+AX9snIEQX2ETMViQ2nmjHbWCfZv8NhHxr1OipJuUb3N7MUUyPvPnzIJYHY0L/M9qKU JRBymSb9tKyqRR8n8c0ULJdNbmFVueIOHY4MUdBaX0EkcpIuqI/Pa0NcD3sWyROEiVed /tAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=MhYxgd9UVPLlGEUu3KDODF507KFrOAhtfFwG2YfLqsQ=; b=wSVr3tO0A4mOghYdA40bqu6SrN92cHdcMJNvGGcXFG+O1l+rmu1jvCx9QN3qAWczDr tfPI1SHUFtZRLfSpRx0onZoJ4NBAnTNSfFg6//WpNyVa80WO7TcJVAKb4YzcKBcLlJVZ /1zuPtzFbUgSSIBaEObFkS3Ry98WAJjNSxyJfzarrOw6Ee+G1NwZvvJvvtXBcDZ9Guj3 M99HKtoESZiIzZA2EIZCJoPFAbxVE1u51Wikwu+Hxw+dKfstpnk9nqhOinWOQDlZv57n t5D06d0irkTui+hbYdo3oqrnHzyIsdAmUAOJcamQxTU7yRe0FK27rl1F96W497yvMeBF kgoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ec12-20020a170906b6cc00b007aeaacd5592si9510178ejb.124.2023.01.28.18.44.32; Sat, 28 Jan 2023 18:44:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233919AbjA2CWY (ORCPT + 99 others); Sat, 28 Jan 2023 21:22:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231126AbjA2CWX (ORCPT ); Sat, 28 Jan 2023 21:22:23 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC0D976B0 for ; Sat, 28 Jan 2023 18:22:21 -0800 (PST) Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4P4FR31FQ4zJrKm; Sun, 29 Jan 2023 10:20:47 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Sun, 29 Jan 2023 10:22:19 +0800 From: Kefeng Wang To: Andrew Morton CC: Tejun Heo , Jens Axboe , Jan Kara , Shakeel Butt , Naoya Horiguchi , , , Kefeng Wang , Ma Wupeng Subject: [PATCH] mm: memcg: fix NULL pointer in mem_cgroup_track_foreign_dirty() Date: Sun, 29 Jan 2023 10:44:51 +0800 Message-ID: <20230129024451.121590-1-wangkefeng.wang@huawei.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756323167487303390?= X-GMAIL-MSGID: =?utf-8?q?1756323167487303390?= As commit 18365225f044 ("hwpoison, memcg: forcibly uncharge LRU pages"), hwpoison will forcibly uncharg a LRU hwpoisoned page, the folio_memcg could be NULl, then, mem_cgroup_track_foreign_dirty_slowpath() could occurs a NULL pointer dereference, let's do not record the foreign writebacks for folio memcg is null in mem_cgroup_track_foreign() to fix it. Reported-by: Ma Wupeng Fixes: 97b27821b485 ("writeback, memcg: Implement foreign dirty flushing") Signed-off-by: Kefeng Wang Acked-by: Michal Hocko --- include/linux/memcontrol.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index eb6e5b18e1ad..35478695cabf 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -1688,10 +1688,13 @@ void mem_cgroup_track_foreign_dirty_slowpath(struct folio *folio, static inline void mem_cgroup_track_foreign_dirty(struct folio *folio, struct bdi_writeback *wb) { + struct mem_cgroup *memcg; + if (mem_cgroup_disabled()) return; - if (unlikely(&folio_memcg(folio)->css != wb->memcg_css)) + memcg = folio_memcg(folio); + if (unlikely(memcg && &memcg->css != wb->memcg_css)) mem_cgroup_track_foreign_dirty_slowpath(folio, wb); }