From patchwork Sat Jan 28 09:39:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiapeng Chong X-Patchwork-Id: 49833 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1268195wrn; Sat, 28 Jan 2023 01:48:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXvVv86emJ8f7CBBpHT/sQxtTdGpxfZduiAjv8W+GArFEFH8kunWY4dIOEVA1KgV4PNX0UOf X-Received: by 2002:a17:906:40d7:b0:84d:16d0:717 with SMTP id a23-20020a17090640d700b0084d16d00717mr46187192ejk.65.1674899301710; Sat, 28 Jan 2023 01:48:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674899301; cv=none; d=google.com; s=arc-20160816; b=tNvsZm8uXXHD6N5RIJcORp7Mof/HamNqdvdCVOFNUl6LTAq64q1DldSPok7efxbTKf 6unyBzWvKICeZWpZ+uJNS7msB+ChNlevRpVbi6MU77dpDtodj53y99LnmAzXRVcabLWv a5rKkzkxv2TJhhrRA1Igw4dQoRqkFle8DEo3GlkiZnqvw4tDKWIfE+u9w+LY8CZujtw8 ryGfT0m10XaJUwIGi2HJQJrUTtgfXJ6DIDivZf4SKU47WnzobRUm9ECSCvIwB11z52w5 DGKvxfmrW4QVk3EjerjzKtYaG1CTpkap02fZl3tGxTdNZ4RNyuwj4BiYpgvcCCGL0c7P 5VAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=VV+BIhYhRgmpn1R9/+NTY9Bl0wOT//YwwL6n5Ovy3ic=; b=WKaxxIh3/PgIDYnLfo2LPF7YLYMRt5U/yu5BKErq5uwIv0qqmZPKBufEHgrmIJc+WF EPbPtZmAusg/BxyWhIt1eFxStGtCaUK7PDKguhmUUqz7TH3D6aESliQzWLKos08iXbSc NMI6kIKUtWS0yPiIMm05riDrYdXbWoowA8W7eWlak4MkbIwT38qeMtguNPAhFLe7HBvb eHwVh3DQxsnuWepqu9pEVoetGqBQ6dKQ8WsRzFB0KuoVSvPFnedWIaupiyousoELjXiS Ig9pxrjWkYUJk7ZKGAloMECgODAvzz309w/gU7VuSfzrmiA6rqzLxawJ81R4q5rI32TY qO5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id eu16-20020a170907299000b0087783403e16si6497641ejc.489.2023.01.28.01.47.58; Sat, 28 Jan 2023 01:48:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233622AbjA1Jjo (ORCPT + 99 others); Sat, 28 Jan 2023 04:39:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231454AbjA1Jjn (ORCPT ); Sat, 28 Jan 2023 04:39:43 -0500 Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 608D82D69; Sat, 28 Jan 2023 01:39:41 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0VaHEO08_1674898762; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VaHEO08_1674898762) by smtp.aliyun-inc.com; Sat, 28 Jan 2023 17:39:38 +0800 From: Jiapeng Chong To: bcain@quicinc.com Cc: linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] trap: Fix warning comparing pointer to 0 Date: Sat, 28 Jan 2023 17:39:20 +0800 Message-Id: <20230128093920.2729-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756259210176173067?= X-GMAIL-MSGID: =?utf-8?q?1756259210176173067?= Avoid pointer type value compared with 0 to make code clear. ./arch/hexagon/kernel/traps.c:138:6-7: WARNING comparing pointer to 0. Reported-by: Abaci Robot Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3860 Signed-off-by: Jiapeng Chong Acked-by: Brian Cain --- arch/hexagon/kernel/traps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/hexagon/kernel/traps.c b/arch/hexagon/kernel/traps.c index 6447763ce5a9..fdbbf78b4ce0 100644 --- a/arch/hexagon/kernel/traps.c +++ b/arch/hexagon/kernel/traps.c @@ -135,7 +135,7 @@ static void do_show_stack(struct task_struct *task, unsigned long *fp, } /* Attempt to continue past exception. */ - if (0 == newfp) { + if (!newfp) { struct pt_regs *regs = (struct pt_regs *) (((void *)fp) + 8);